Anil created KAFKA-13870:
Summary: support both Suppressed untilTimeLimit and maxBytes
without using emitEarlyWhenFull()
Key: KAFKA-13870
URL: https://issues.apache.org/jira/browse/KAFKA-13870
Project: Kafka
showuon merged PR #12119:
URL: https://github.com/apache/kafka/pull/12119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon merged PR #12116:
URL: https://github.com/apache/kafka/pull/12116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stan-confluent commented on PR #12120:
URL: https://github.com/apache/kafka/pull/12120#issuecomment-1116870373
@confluentinc/quality-eng @omkreddy @lbradstreet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
stan-confluent opened a new pull request, #12120:
URL: https://github.com/apache/kafka/pull/12120
This is a super simple test that verifies zk and kafka can start up.
The purpose is mostly to verify any changes to ducktape, ducker-ak or
underlying test infrastructure, but it is also
[
https://issues.apache.org/jira/browse/KAFKA-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-13869:
Labels: kip-500 (was: )
> Update quota callback metadata in KRaft
>
RivenSun2 commented on PR #12010:
URL: https://github.com/apache/kafka/pull/12010#issuecomment-1116786841
Hi @mimaison Thank you for your review.
I just resubmitted the changes, please help to check again.
Thanks.
--
This is an automated message from the Apache Git Service.
To
gitlw commented on PR #12029:
URL: https://github.com/apache/kafka/pull/12029#issuecomment-1116769708
@junrao when you get a chance, can you please take another look? Thanks a
lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dengziming commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1116766320
Hello @hachikuji @divijvaidya @akhileshchg, another bug when reviewing and
fixing #12106, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the
dengziming commented on PR #12108:
URL: https://github.com/apache/kafka/pull/12108#issuecomment-1116766115
Hello @hachikuji @divijvaidya @akhileshchg, This is a finding when reviewing
and fixing #12106, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the
RivenSun2 commented on PR #12010:
URL: https://github.com/apache/kafka/pull/12010#issuecomment-1116763525
> Can a `STRING` configuration be null? I wonder if this validator can
actually trigger
Adding `NonNullValidator` here may only constrain code writing. For example,
when we
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r864331037
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -601,11 +607,16 @@ private void maybeOverrideClientId(Map
configs) {
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r864331037
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -601,11 +607,16 @@ private void maybeOverrideClientId(Map
configs) {
dengziming commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r864330362
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends
Jason Gustafson created KAFKA-13869:
---
Summary: Update quota callback metadata in KRaft
Key: KAFKA-13869
URL: https://issues.apache.org/jira/browse/KAFKA-13869
Project: Kafka
Issue Type:
junrao commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r864255901
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/BuiltInPartitioner.java:
##
@@ -0,0 +1,296 @@
+/*
+ * Licensed to the Apache Software Foundation
dengziming commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r864312925
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -490,7 +490,12 @@ class PlaintextAdminIntegrationTest extends
joel-hamill commented on PR #12119:
URL: https://github.com/apache/kafka/pull/12119#issuecomment-1116711647
cc @guozhangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
joel-hamill opened a new pull request, #12119:
URL: https://github.com/apache/kafka/pull/12119
This PR clarifies how to specify multiple log directories on the broker.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests
joel-hamill commented on code in PR #11874:
URL: https://github.com/apache/kafka/pull/11874#discussion_r864281925
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -216,8 +216,10 @@
private static final String
guozhangwang closed pull request #11896: KAFKA-13785: [6/N][Emit final] emit
final for TimeWindowedKStreamImpl
URL: https://github.com/apache/kafka/pull/11896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mimaison closed pull request #9794: Add a job to build on ARM64 at Amazon
Graviton2 nodes
URL: https://github.com/apache/kafka/pull/9794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mimaison commented on PR #9794:
URL: https://github.com/apache/kafka/pull/9794#issuecomment-1116656158
This has been fixed by https://github.com/apache/kafka/pull/9992, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mimaison closed pull request #11476: KAFKA-13407: Always start controller when
broker wins election
URL: https://github.com/apache/kafka/pull/11476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mimaison commented on PR #11476:
URL: https://github.com/apache/kafka/pull/11476#issuecomment-1116654945
This has been fixed in https://github.com/apache/kafka/pull/11563, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mimaison commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r864110167
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1139,7 +1139,7 @@ object KafkaConfig {
.define(MetadataMaxRetentionMillisProp, LONG,
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-13868:
---
Description:
The ASF has updated its privacy policy and all websites must be compliant.
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-13868:
---
Component/s: website
> Website updates to satisfy Apache privacy policies
>
Mickael Maison created KAFKA-13868:
--
Summary: Website updates to satisfy Apache privacy policies
Key: KAFKA-13868
URL: https://issues.apache.org/jira/browse/KAFKA-13868
Project: Kafka
Issue
mimaison commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r864068803
##
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530937#comment-17530937
]
François Rosière edited comment on KAFKA-13864 at 5/3/22 6:46 PM:
--
ahuang98 commented on PR #12116:
URL: https://github.com/apache/kafka/pull/12116#issuecomment-1116416744
Nice catch! Yeah, I think I accidentally ported it over twice. If you're
going to remove the `*` import, perhaps remove the corresponding
`suppressions.xml` change as well
```
[
https://issues.apache.org/jira/browse/KAFKA-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13813:
Summary: left/outer joins can wait indefinitely for emitted record with
spurious record
guozhangwang merged PR #12100:
URL: https://github.com/apache/kafka/pull/12100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hachikuji commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r863942404
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1364,7 +1364,8 @@ Boolean isBrokerUnfenced(int brokerId) {
akhileshchg commented on PR #12106:
URL: https://github.com/apache/kafka/pull/12106#issuecomment-1116278345
> The code looks good but as I said earlier, we are missing tests that
assert that `validateOnly` flag is working as expected. The tests added in this
PR are simply validating
nicolasguyomar opened a new pull request, #12118:
URL: https://github.com/apache/kafka/pull/12118
Proposal to catch valid 404 exceptions, triggered by any HTTP request to a
non existent path on the Connect REST API, higher in the code, not to log an
ERROR log on line 61 which can be seen
showuon commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r86375
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java:
##
@@ -148,18 +148,18 @@ public class
C0urante commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863740301
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java:
##
@@ -148,18 +148,18 @@ public class
divijvaidya commented on PR #12106:
URL: https://github.com/apache/kafka/pull/12106#issuecomment-1116036542
The code looks good but as I said earlier, we are missing tests that assert
that `validateOnly` flag is working as expected. The tests added in this PR are
simply validating whether
cadonna commented on PR #12114:
URL: https://github.com/apache/kafka/pull/12114#issuecomment-1115964688
Cherry-picked to 3.2
Opened PR https://github.com/apache/kafka/pull/12117 for 3.1 since I ran
into merge conflicts.
--
This is an automated message from the Apache Git Service.
To
cadonna commented on PR #12117:
URL: https://github.com/apache/kafka/pull/12117#issuecomment-1115963952
Call for review: @tombentley
While cherry-picking https://github.com/apache/kafka/pull/12114 I ran into
merge conflicts, so I decided to open a separate PR which seemed easier
cadonna opened a new pull request, #12117:
URL: https://github.com/apache/kafka/pull/12117
Adds a note to the upgrade notes to use slf4j-log4j version
1.7.35+ [1] or slf4j-reload4j to avoid possible compatibility issues
originating from the logging framework [2].
[1]
cadonna merged PR #12114:
URL: https://github.com/apache/kafka/pull/12114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531103#comment-17531103
]
Martin commented on KAFKA-10582:
I got the same issue and don't understand why this happens. I am using
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13718:
--
Labels: newbie newbie++ (was: newbee)
> kafka-topics describe topic with default config will show
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13718:
--
Labels: newbee (was: )
> kafka-topics describe topic with default config will show `segment.bytes`
dengziming commented on PR #12116:
URL: https://github.com/apache/kafka/pull/12116#issuecomment-1115780309
Hello, @ahuang98 I think those tests just belong to
`ApiVersionsResponseTest`, maybe you accidentally copied them to
`MetadataVersionTest` when working on #12072?
--
This is an
dengziming opened a new pull request, #12116:
URL: https://github.com/apache/kafka/pull/12116
*More detailed description of your change*
Removed some tests in `MetadataVersionTest` which are totally identical to
those in `ApiVersionsResponseTest`.
I think we removed `ApiVersionTest`
showuon commented on PR #11889:
URL: https://github.com/apache/kafka/pull/11889#issuecomment-1115770434
> I think the problem here is just to make sure we should provide both
listeners for the combined node, is this right?
Correct. Thanks for your help! :)
--
This is an automated
showuon commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863399174
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java:
##
@@ -148,18 +148,18 @@ public class
51 matches
Mail list logo
