dengziming commented on PR #12112:
URL: https://github.com/apache/kafka/pull/12112#issuecomment-1119266873
@showuon I have updated it, though @divijvaidya provided a good suggestion,
we still have a more generic solution for this kind of flakiness. [see details
here](https://github.com/apac
dengziming commented on code in PR #12112:
URL: https://github.com/apache/kafka/pull/12112#discussion_r866494535
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -586,11 +586,14 @@ class TopicCommandIntegrationTest extends
KafkaServerTestH
vamossagar12 commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r866489041
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTes
vamossagar12 commented on PR #12104:
URL: https://github.com/apache/kafka/pull/12104#issuecomment-1119258638
> Details
@guozhangwang , Thanks for pointing it out. I will take a look at this and
make another commit which should re-trigger the build.
--
This is an automated message f
ahuang98 closed pull request #12123: KAFKA-13830 Introduce metadata.version for
KRaft
URL: https://github.com/apache/kafka/pull/12123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
showuon commented on PR #12112:
URL: https://github.com/apache/kafka/pull/12112#issuecomment-1119226457
@dengziming , it's fine, we can improve the tests anyway. I agree your fix
is better. Let's address @divijvaidya 's comment. Thanks.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming resolved KAFKA-13854.
Resolution: Fixed
> Refactor ApiVersion to MetadataVersion
> -
Artem Livshits created KAFKA-13880:
--
Summary: DefaultStreamPartitioner may get "stuck" to one partition
for unkeyed messages
Key: KAFKA-13880
URL: https://issues.apache.org/jira/browse/KAFKA-13880
Pr
artemlivshits commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r866402725
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1403,25 +1452,54 @@ public boolean isDone() {
}
/**
- * A cal
YiDing-Duke commented on code in PR #9874:
URL: https://github.com/apache/kafka/pull/9874#discussion_r866399744
##
clients/src/test/java/org/apache/kafka/common/security/authenticator/SaslAuthenticatorFailureDelayTest.java:
##
@@ -228,12 +213,8 @@ private NioEchoServer createEch
rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866395929
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String
junrao commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r866393904
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1403,25 +1452,54 @@ public boolean isDone() {
}
/**
- * A callback c
[
https://issues.apache.org/jira/browse/KAFKA-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reassigned KAFKA-13879:
-
Assignee: Chern Yih Cheah
> Exponential backoff for reconnect does not work
> -
junrao commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866389159
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String,
artemlivshits commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r866386035
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1403,25 +1452,54 @@ public boolean isDone() {
}
/**
- * A cal
guozhangwang closed pull request #11917: KAFKA-13785: [8/N][emit final]
time-ordered session store
URL: https://github.com/apache/kafka/pull/11917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
guozhangwang merged PR #12127:
URL: https://github.com/apache/kafka/pull/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on code in PR #12128:
URL: https://github.com/apache/kafka/pull/12128#discussion_r866368735
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -0,0 +1,373 @@
+/*
+ * Licensed to the Apache Software Foundat
guozhangwang merged PR #12128:
URL: https://github.com/apache/kafka/pull/12128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866371951
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String
junrao commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866357178
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String,
frosiere commented on PR #12125:
URL: https://github.com/apache/kafka/pull/12125#issuecomment-1119022631
Tests and checks are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532518#comment-17532518
]
François Rosière commented on KAFKA-13864:
--
Thanks for the PR. I added some com
frosiere commented on code in PR #12125:
URL: https://github.com/apache/kafka/pull/12125#discussion_r866287593
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -663,12 +663,38 @@ public KafkaConsumer(Properties properties,
public KafkaCon
cadonna opened a new pull request, #12128:
URL: https://github.com/apache/kafka/pull/12128
This PR adds the default implementation of the state updater.
The implementation only implements adding active tasks to the
state updater.
### Committer Checklist (excluded from commit mess
[
https://issues.apache.org/jira/browse/KAFKA-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532480#comment-17532480
]
Guozhang Wang commented on KAFKA-13877:
---
Thanks [~lkokhreidze]!
> Flaky
> RackAw
rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866208728
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String
rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866206202
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String
Chern Yih Cheah created KAFKA-13879:
---
Summary: Exponential backoff for reconnect does not work
Key: KAFKA-13879
URL: https://issues.apache.org/jira/browse/KAFKA-13879
Project: Kafka
Issue T
junrao commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866200194
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String,
rittikaadhikari commented on PR #12005:
URL: https://github.com/apache/kafka/pull/12005#issuecomment-1118915061
@junrao: Thank you for the comments. Whenever you get a chance, this PR is
ready for review again!
--
This is an automated message from the Apache Git Service.
To respond to the
junrao commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r866194199
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/BuiltInPartitioner.java:
##
@@ -0,0 +1,297 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
[
https://issues.apache.org/jira/browse/KAFKA-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Levani Kokhreidze reassigned KAFKA-13877:
-
Assignee: Levani Kokhreidze
> Flaky
> RackAwarenessIntegrationTest.shouldDistr
[
https://issues.apache.org/jira/browse/KAFKA-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532474#comment-17532474
]
Levani Kokhreidze commented on KAFKA-13877:
---
I will take this on.
> Flaky
>
junrao commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r866191785
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStreamPartitioner.java:
##
@@ -25,12 +23,15 @@
private final Cluster cluster;
pri
junrao commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r866187547
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1403,25 +1452,54 @@ public boolean isDone() {
}
/**
- * A callback c
guozhangwang commented on PR #12104:
URL: https://github.com/apache/kafka/pull/12104#issuecomment-1118887691
Thanks @vamossagar12 , the failed tests still contains
`testDescribeUnderMinIsrPartitionsMixed(String).quorum=zk](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12104/4/te
[
https://issues.apache.org/jira/browse/KAFKA-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532427#comment-17532427
]
Matthias J. Sax commented on KAFKA-8769:
Just a "random" comment, based on some o
[
https://issues.apache.org/jira/browse/KAFKA-13878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-13878:
Component/s: KafkaConnect
> Connect deadlock in WorkerConnector on desired state change
>
Greg Harris created KAFKA-13878:
---
Summary: Connect deadlock in WorkerConnector on desired state
change
Key: KAFKA-13878
URL: https://issues.apache.org/jira/browse/KAFKA-13878
Project: Kafka
Is
[
https://issues.apache.org/jira/browse/KAFKA-13877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13877:
--
Labels: newbie (was: )
> Flaky
> RackAwarenessIntegrationTest.shouldDistributeStandbyReplica
Guozhang Wang created KAFKA-13877:
-
Summary: Flaky
RackAwarenessIntegrationTest.shouldDistributeStandbyReplicasOverMultipleClientTags
Key: KAFKA-13877
URL: https://issues.apache.org/jira/browse/KAFKA-13877
junrao commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r866131407
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStreamPartitioner.java:
##
@@ -25,12 +23,15 @@
private final Cluster cluster;
pri
guozhangwang commented on PR #12127:
URL: https://github.com/apache/kafka/pull/12127#issuecomment-1118838068
cc @lihaosky @mjsax @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
guozhangwang commented on PR #11917:
URL: https://github.com/apache/kafka/pull/11917#issuecomment-1118837108
The copy PR is here: https://github.com/apache/kafka/pull/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
guozhangwang commented on PR #12037:
URL: https://github.com/apache/kafka/pull/12037#issuecomment-1118836834
https://github.com/apache/kafka/pull/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
guozhangwang opened a new pull request, #12127:
URL: https://github.com/apache/kafka/pull/12127
This is a copy PR of #11917. The major diffs are:
1) Avoid extra byte array allocation for fixed upper/lower range
serialization.
2) Rename some class names to be more consistent.
guozhangwang commented on code in PR #11917:
URL: https://github.com/apache/kafka/pull/11917#discussion_r865488275
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSessionSegmentedBytesStore.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Ap
rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866120522
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String
junrao commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r865419210
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
mumrah commented on PR #12050:
URL: https://github.com/apache/kafka/pull/12050#issuecomment-1118712139
@dengziming @cmccabe I've updated this PR with the changes from #12072. I've
also modified the bootstrap mechanism to use a file with the KRaft snapshot
format rather than a property in me
[
https://issues.apache.org/jira/browse/KAFKA-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Bates updated KAFKA-13876:
Description:
I am starting a mirrormaker connect cluster using ./bin/connect-mirror-maker.
[
https://issues.apache.org/jira/browse/KAFKA-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Bates updated KAFKA-13876:
Description:
I am starting a mirrormaker connect cluster using ./bin/connect-mirror-maker.
[
https://issues.apache.org/jira/browse/KAFKA-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Bates updated KAFKA-13876:
Description:
I am starting a mirrormaker connect cluster using ./bin/connect-mirror-maker.
[
https://issues.apache.org/jira/browse/KAFKA-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Bates updated KAFKA-13876:
Description:
I am starting a mirrormaker connect cluster using ./bin/connect-mirror-maker.
Christian Bates created KAFKA-13876:
---
Summary: Mirrormaker-2 consumer settings not working
Key: KAFKA-13876
URL: https://issues.apache.org/jira/browse/KAFKA-13876
Project: Kafka
Issue Type:
dengziming commented on code in PR #12108:
URL: https://github.com/apache/kafka/pull/12108#discussion_r865580075
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1751,13 +1777,32 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInt
[
https://issues.apache.org/jira/browse/KAFKA-13871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yingquan he reassigned KAFKA-13871:
---
Assignee: (was: yingquan he)
> The documentation for the configuration item QUORUM_FETC
pan3793 opened a new pull request, #12126:
URL: https://github.com/apache/kafka/pull/12126
See details on KAFKA-8713 and KIP-581
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lqjacklee updated KAFKA-13864:
--
Attachment: (was: interceptor_constructor_client.patch)
> Change the visibility of a KafkaProducer
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532216#comment-17532216
]
lqjacklee commented on KAFKA-13864:
---
[~frosiere] [~cadonna] please help review the c
lqjack opened a new pull request, #12125:
URL: https://github.com/apache/kafka/pull/12125
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
konL opened a new pull request, #12124:
URL: https://github.com/apache/kafka/pull/12124
I used deep learning to discover that the method 'isDone' changed in
4af50bb8600c37ee2e3597fba9a54a29cef94afa.
The code snippet before and after the change is as follows.
```
public boolean isDon
[
https://issues.apache.org/jira/browse/KAFKA-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532122#comment-17532122
]
Jack Vanlightly commented on KAFKA-13872:
-
I presume you would need to perform a
dengziming commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1118264999
@cmccabe, Yeah, it's unnecessary to change `ReplicationControlManager`,
however, there is still a difference, in KRaft mode, the null config value is
treated as removing configs, so cr
[
https://issues.apache.org/jira/browse/KAFKA-13872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532092#comment-17532092
]
Francois Visconte commented on KAFKA-13872:
---
I was expecting the partition to
66 matches
Mail list logo
