divijvaidya commented on PR #12087:
URL: https://github.com/apache/kafka/pull/12087#issuecomment-1125752112
Thank you for reviewing this @showuon and @dengziming. Really appreciate it
:)
It should be ready to be merged.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536490#comment-17536490
]
flavio livide commented on KAFKA-6020:
--
An interesting extension of this feature wou
milindmantri commented on PR #12152:
URL: https://github.com/apache/kafka/pull/12152#issuecomment-1125774388
cc: @bbejeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
tombentley opened a new pull request, #12156:
URL: https://github.com/apache/kafka/pull/12156
Updates release versions in files that are used for upgrade test with the
3.1.1 release version.
(Also fixes a mistaken kafka-3.1.0 → kafka-3.2.0 in the Dockerfile)
--
This is an automated
tombentley commented on PR #12156:
URL: https://github.com/apache/kafka/pull/12156#issuecomment-1125788629
@dajac, @mimaison or @cadonna PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna commented on code in PR #12156:
URL: https://github.com/apache/kafka/pull/12156#discussion_r872131819
##
tests/docker/Dockerfile:
##
@@ -84,8 +84,8 @@ RUN curl -s "$KAFKA_MIRROR/kafka-streams-2.6.2-test.jar" -o
/opt/kafka-2.6.2/lib
RUN curl -s "$KAFKA_MIRROR/kafka-stre
tombentley commented on PR #12156:
URL: https://github.com/apache/kafka/pull/12156#issuecomment-1125794064
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
dengziming opened a new pull request, #12157:
URL: https://github.com/apache/kafka/pull/12157
*More detailed description of your change*
The behavior between co-resident mode and discrete mode is different, so we
should support co-resident mode too. I also find a bug in co-resident, see
tombentley merged PR #12156:
URL: https://github.com/apache/kafka/pull/12156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536512#comment-17536512
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on code in PR #410:
divijvaidya commented on PR #12153:
URL: https://github.com/apache/kafka/pull/12153#issuecomment-1125823580
@hachikuji one of the flaky failing tests in this PR is `Build / JDK 11 and
Scala 2.13 / testListenerConnectionRateLimitWhenActualRateAboveLimit() –
kafka.network.ConnectionQuotasTest
divijvaidya commented on code in PR #12153:
URL: https://github.com/apache/kafka/pull/12153#discussion_r872165577
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -894,7 +894,7 @@ object KafkaConfig {
"record batch size accepted by the broker is defined via
mes
[
https://issues.apache.org/jira/browse/KAFKA-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536522#comment-17536522
]
dengziming commented on KAFKA-9837:
---
[~soarez] Thank you for your proposals, I think th
[
https://issues.apache.org/jira/browse/KAFKA-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Sorokoumov reassigned KAFKA-12549:
---
Assignee: Alex Sorokoumov
> Allow state stores to opt-in transactional support
> --
bozhao12 opened a new pull request, #12158:
URL: https://github.com/apache/kafka/pull/12158
Following variables in kafkaController are used for metric statistics：
```
offlinePartitionCount
preferredReplicaImbalanceCount
globalTopicCount
globalPartitionCount
bozhao12 closed pull request #12022: MINOR:Remove repeated variable reset in
KafkaController.scala
URL: https://github.com/apache/kafka/pull/12022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536544#comment-17536544
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on code in PR #410:
Tom Bentley created KAFKA-13897:
---
Summary: Add 3.1.1 to system tests and streams upgrade tests
Key: KAFKA-13897
URL: https://issues.apache.org/jira/browse/KAFKA-13897
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536573#comment-17536573
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536574#comment-17536574
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536583#comment-17536583
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536584#comment-17536584
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536616#comment-17536616
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on code in PR #410:
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r872417278
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r872423670
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
joel-hamill commented on code in PR #12153:
URL: https://github.com/apache/kafka/pull/12153#discussion_r872429806
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -894,7 +894,7 @@ object KafkaConfig {
"record batch size accepted by the broker is defined via
mes
joel-hamill commented on code in PR #12153:
URL: https://github.com/apache/kafka/pull/12153#discussion_r872430394
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -894,7 +894,7 @@ object KafkaConfig {
"record batch size accepted by the broker is defined via
mes
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536685#comment-17536685
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on PR #410:
URL: htt
Ge commented on PR #12122:
URL: https://github.com/apache/kafka/pull/12122#issuecomment-1126143043
Green CI run with system tests -
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4897/.
--
This is an automated message from the Apache Git Service.
To respond to the m
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r872493845
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -927,6 +984,29 @@ private void appendRaftEvent(String name, Runnable
runnable) {
Tom Bentley created KAFKA-13898:
---
Summary: metrics.recording.level is underdocumented
Key: KAFKA-13898
URL: https://issues.apache.org/jira/browse/KAFKA-13898
Project: Kafka
Issue Type: Improvem
fvaleri opened a new pull request, #12159:
URL: https://github.com/apache/kafka/pull/12159
When there is an authentication error after the initial TCP connection,
the selector never becomes READY, and these tests wait forever waiting for
this state.
This is actually what happened t
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536718#comment-17536718
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL: ht
[
https://issues.apache.org/jira/browse/KAFKA-5074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536721#comment-17536721
]
Paul Dubuc commented on KAFKA-5074:
---
I see that this ticket is still open and unresolve
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536742#comment-17536742
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL: ht
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536746#comment-17536746
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536747#comment-17536747
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on code in PR #410:
Jason Gustafson created KAFKA-13899:
---
Summary: Inconsistent error codes returned from AlterConfig APIs
Key: KAFKA-13899
URL: https://issues.apache.org/jira/browse/KAFKA-13899
Project: Kafka
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872593270
##
streams/src/main/java/org/apache/kafka/streams/kstream/EmitStrategy.java:
##
@@ -19,15 +19,52 @@
import org.apache.kafka.streams.kstream.internals.UnlimitedWind
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872593623
##
streams/src/main/java/org/apache/kafka/streams/kstream/EmitStrategy.java:
##
@@ -19,15 +19,52 @@
import org.apache.kafka.streams.kstream.internals.UnlimitedWind
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r872596541
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -53,7 +55,7 @@ public class ClusterConfig {
ClusterConfig(Type type, int brokers, int controllers, Strin
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872596894
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractKStreamTimeWindowAggregateProcessor.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/KAFKA-13889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grant updated KAFKA-13889:
-
Summary: Update AclsDelta to handle ACCESS_CONTROL_ENTRY_RECORD quickly
followed by REMOVE_ACCES
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872600795
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractKStreamTimeWindowAggregateProcessor.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872601055
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractKStreamTimeWindowAggregateProcessor.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872602138
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractKStreamTimeWindowAggregateProcessor.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872603611
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractKStreamTimeWindowAggregateProcessor.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872604769
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractKStreamTimeWindowAggregateProcessor.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872607460
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractKStreamTimeWindowAggregateProcessor.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/KAFKA-13889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grant updated KAFKA-13889:
-
Summary: Fix AclsDelta to handle ACCESS_CONTROL_ENTRY_RECORD quickly
followed by REMOVE_ACCESS_C
[
https://issues.apache.org/jira/browse/KAFKA-13871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yingquan he closed KAFKA-13871.
---
> The documentation for the configuration item QUORUM_FETCH_TIMEOUT of the
> RaftConfig class is incorr
andymg3 opened a new pull request, #12160:
URL: https://github.com/apache/kafka/pull/12160
### JIRA
https://issues.apache.org/jira/browse/KAFKA-13889
### Description
- Fixes `AclsDelta` to handle `ACCESS_CONTROL_ENTRY_RECORD` quickly followed
by `REMOVE_ACCESS_CONTROL_ENTRY_RECO
jnh5y opened a new pull request, #12161:
URL: https://github.com/apache/kafka/pull/12161
This PR adds the ability to pause and resume KafkaStreams instances as well
as named/modular topologies.
Added an integration test to show how pausing and resuming works.
### Committer Chec
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872636671
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java:
##
@@ -467,13 +459,35 @@ private boolean rightWindowIsNotEmp
hachikuji opened a new pull request, #12162:
URL: https://github.com/apache/kafka/pull/12162
In the AlterConfigs/IncrementalAlterConfigs zk handler, we return
`INVALID_REQUEST` and `INVALID_CONFIG` inconsistently. The problem is in
`LogConfig.validate`. We may either return `ConfigException
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872646217
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java:
##
@@ -248,80 +182,43 @@ public void process(final Record record) {
Francesco Nigro created KAFKA-13900:
---
Summary: Support Java 9 direct ByteBuffer Checksum methods
Key: KAFKA-13900
URL: https://issues.apache.org/jira/browse/KAFKA-13900
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Nigro updated KAFKA-13900:
Description:
Java 9 has added a new Checksum method that can makes uses of ByteBuffer(s)
[
https://issues.apache.org/jira/browse/KAFKA-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Nigro updated KAFKA-13900:
Description:
Java 9 has added a new Checksum method that can makes uses of ByteBuffer(s)
[
https://issues.apache.org/jira/browse/KAFKA-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Nigro updated KAFKA-13900:
Description:
Java 9 has added a new Checksum method that can makes uses of ByteBuffer(s)
Ben Augarten created KAFKA-13901:
Summary: Exactly once producer cannot start due to
TimeoutException: Timeout expired after 30ms awaiting InitProducerId
Key: KAFKA-13901
URL: https://issues.apache.org/jira/br
[
https://issues.apache.org/jira/browse/KAFKA-13901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Augarten updated KAFKA-13901:
-
Description:
I'm currently running into this problem running org.apache.kafka:kafka and
org.apa
franz1981 commented on PR #12163:
URL: https://github.com/apache/kafka/pull/12163#issuecomment-1126318782
I've put it in draft mode in order to better format it according to the
community's rule, but feel free to review it: content-wise should be done.
Some numbers, for JDK 11:
```
guozhangwang commented on PR #12041:
URL: https://github.com/apache/kafka/pull/12041#issuecomment-1126350779
AH yes, that's clear.
My concern was that it's assuming the defined properties should be all
retrieved in the constructor (since the `logUnused` is called at the end of
it).
junrao commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r872705006
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String,
wcarlson5 commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r872731431
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##
@@ -463,7 +463,10 @@ public void restore(final Map tasks) {
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r872766397
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##
@@ -463,7 +463,10 @@ public void restore(final Map tasks) {
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r872767805
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -897,7 +897,8 @@ private void initializeAndRestorePhase() {
}
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r872767805
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -897,7 +897,8 @@ private void initializeAndRestorePhase() {
}
ijuma commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r872795794
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -40,10 +55,32 @@ public static void update(Checksum checksum, ByteBuffer
buffer, int length)
ijuma commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r872799071
##
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##
@@ -40,10 +55,32 @@ public static void update(Checksum checksum, ByteBuffer
buffer, int length)
David Arthur created KAFKA-13902:
Summary: Support online metadata.version upgrades for KIP-704 in
KRaft
Key: KAFKA-13902
URL: https://issues.apache.org/jira/browse/KAFKA-13902
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13902:
-
Component/s: controller
> Support online metadata.version upgrades for KIP-704 in KRaft
> -
David Arthur created KAFKA-13903:
Summary: Add queue size metric to QuorumController
Key: KAFKA-13903
URL: https://issues.apache.org/jira/browse/KAFKA-13903
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-13902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13902:
-
Labels: kip-500 (was: )
> Support online metadata.version upgrades for KIP-704 in KRaft
>
[
https://issues.apache.org/jira/browse/KAFKA-13903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13903:
-
Labels: kip-500 (was: )
> Add queue size metric to QuorumController
> -
[
https://issues.apache.org/jira/browse/KAFKA-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lim Qing Wei reassigned KAFKA-13817:
Assignee: Lim Qing Wei
> Schedule nextTimeToEmit to system time every time instead of jus
[
https://issues.apache.org/jira/browse/KAFKA-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reopened KAFKA-13502:
I accidentally resolved this issue.
> Support configuring BROKER_LOGG
[
https://issues.apache.org/jira/browse/KAFKA-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536895#comment-17536895
]
Lim Qing Wei commented on KAFKA-13817:
--
Hi [~lihaosky] , I am new to contributing t
xjin-Confluent opened a new pull request, #12164:
URL: https://github.com/apache/kafka/pull/12164
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536926#comment-17536926
]
Matthias J. Sax commented on KAFKA-13817:
-
> as it will eventually self-correct
guozhangwang commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r872898659
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTest
[
https://issues.apache.org/jira/browse/KAFKA-13746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-13746.
---
Resolution: Fixed
> Flaky
> kafka.admin.TopicCommandIntegrationTest.testDescribeUnderMinIsr
guozhangwang commented on PR #12035:
URL: https://github.com/apache/kafka/pull/12035#issuecomment-1126589067
Thanks @sayantanu-dey I will review asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872900375
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractKStreamTimeWindowAggregateProcessor.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872900761
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java:
##
@@ -50,22 +46,32 @@
private final SlidingWindows win
guozhangwang merged PR #12104:
URL: https://github.com/apache/kafka/pull/12104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872901603
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java:
##
@@ -467,13 +459,33 @@ private boolean rightWindowIsNotEmp
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872901962
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java:
##
@@ -103,59 +89,12 @@ public void enableSendingOldValues() {
mjsax merged PR #12122:
URL: https://github.com/apache/kafka/pull/12122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cmccabe merged PR #12155:
URL: https://github.com/apache/kafka/pull/12155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872905269
##
streams/src/test/java/org/apache/kafka/streams/integration/SlidingWindowedKStreamIntegrationTest.java:
##
@@ -0,0 +1,482 @@
+/*
+ * Licensed to the Apache Softwa
hachikuji commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r872906546
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2033,25 +2039,40 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872912257
##
streams/src/test/java/org/apache/kafka/streams/integration/SlidingWindowedKStreamIntegrationTest.java:
##
@@ -0,0 +1,482 @@
+/*
+ * Licensed to the Apache Softwa
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872912604
##
streams/src/test/java/org/apache/kafka/streams/integration/SlidingWindowedKStreamIntegrationTest.java:
##
@@ -0,0 +1,482 @@
+/*
+ * Licensed to the Apache Softwa
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872912670
##
streams/src/test/java/org/apache/kafka/streams/integration/SlidingWindowedKStreamIntegrationTest.java:
##
@@ -0,0 +1,482 @@
+/*
+ * Licensed to the Apache Softwa
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872913253
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java:
##
@@ -0,0 +1,1238 @@
+/*
+ * Licensed to the Ap
guozhangwang commented on code in PR #12135:
URL: https://github.com/apache/kafka/pull/12135#discussion_r872914073
##
streams/src/test/java/org/apache/kafka/streams/integration/SlidingWindowedKStreamIntegrationTest.java:
##
@@ -0,0 +1,482 @@
+/*
+ * Licensed to the Apache Softwa
guozhangwang closed pull request #12037: KAFKA-13785: [7/N][Emit final] emit
final for sliding window
URL: https://github.com/apache/kafka/pull/12037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guozhangwang commented on PR #12135:
URL: https://github.com/apache/kafka/pull/12135#issuecomment-1126616157
Merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
1 - 100 of 108 matches
Mail list logo
