showuon commented on PR #11845:
URL: https://github.com/apache/kafka/pull/11845#issuecomment-1141609896
@hachikuji @dajac , please take a look. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544098#comment-17544098
]
Luke Chen commented on KAFKA-13718:
---
[~hachikuji] , thanks for the comment. Yes, I can
hachikuji commented on code in PR #12086:
URL: https://github.com/apache/kafka/pull/12086#discussion_r885117228
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -139,7 +139,7 @@ public class TopicConfig {
public static final String CLEANUP_POL
hachikuji commented on code in PR #12086:
URL: https://github.com/apache/kafka/pull/12086#discussion_r885117228
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -139,7 +139,7 @@ public class TopicConfig {
public static final String CLEANUP_POL
hachikuji commented on code in PR #12086:
URL: https://github.com/apache/kafka/pull/12086#discussion_r885117228
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -139,7 +139,7 @@ public class TopicConfig {
public static final String CLEANUP_POL
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544086#comment-17544086
]
Jason Gustafson commented on KAFKA-13718:
-
[~showuon] I think the reason `segmen
hachikuji commented on code in PR #12120:
URL: https://github.com/apache/kafka/pull/12120#discussion_r885104060
##
tests/kafkatest/tests/core/mini_test.py:
##
@@ -0,0 +1,18 @@
+from ducktape.tests.test import Test
+from ducktape.mark.resource import cluster
+
+from kafkatest.ser
hachikuji commented on PR #12133:
URL: https://github.com/apache/kafka/pull/12133#issuecomment-1141526730
Closing this since the code intentionally avoids the early return. I was
going to suggest adding a comment, but this already seems clear:
```
// time-constant comparison that alway
hachikuji closed pull request #12133: improvement the compare logic
URL: https://github.com/apache/kafka/pull/12133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
hachikuji merged PR #12203:
URL: https://github.com/apache/kafka/pull/12203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
[
https://issues.apache.org/jira/browse/KAFKA-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13946.
-
Resolution: Fixed
> setMetadataDirectory() method in builder for ControllerNode has no p
hachikuji merged PR #12225:
URL: https://github.com/apache/kafka/pull/12225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
hachikuji commented on code in PR #12227:
URL: https://github.com/apache/kafka/pull/12227#discussion_r885101221
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -195,29 +193,17 @@ public RecordAccumulator(LogContext logContext,
hachikuji commented on code in PR #12206:
URL: https://github.com/apache/kafka/pull/12206#discussion_r885096122
##
core/src/test/scala/unit/kafka/server/DescribeQuorumRequestTest.scala:
##
@@ -54,30 +56,44 @@ class DescribeQuorumRequestTest(cluster: ClusterInstance) {
@Clus
hachikuji commented on code in PR #12223:
URL: https://github.com/apache/kafka/pull/12223#discussion_r885058478
##
core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala:
##
@@ -38,6 +37,7 @@ import scala.jdk.CollectionConverters._
* Tests Admi
hachikuji commented on code in PR #12223:
URL: https://github.com/apache/kafka/pull/12223#discussion_r885058478
##
core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala:
##
@@ -38,6 +37,7 @@ import scala.jdk.CollectionConverters._
* Tests Admi
hachikuji commented on PR #11687:
URL: https://github.com/apache/kafka/pull/11687#issuecomment-1141445344
@Kvicii Thanks for the patch. I checked this out and
`ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions` still
fails 5-10% of the time when run locally. The new fai
hachikuji merged PR #12185:
URL: https://github.com/apache/kafka/pull/12185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
divijvaidya commented on PR #12197:
URL: https://github.com/apache/kafka/pull/12197#issuecomment-1141344082
> Thanks @divijvaidya for the PR!
>
> Should we also update this instance
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/log/AbstractIndex.scala#L110
?
mimaison commented on PR #12197:
URL: https://github.com/apache/kafka/pull/12197#issuecomment-1141333932
Thanks @divijvaidya for the PR!
Should we also update this instance
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/log/AbstractIndex.scala#L110
?
--
This
hachikuji merged PR #1:
URL: https://github.com/apache/kafka/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
mimaison commented on PR #12194:
URL: https://github.com/apache/kafka/pull/12194#issuecomment-1141312130
Thanks for the PR!
Do we need all of `[SocketServer listenerType=ZK_BROKER, nodeId=0,
listener=PLAINTEXT]` ? I guess the only thing currently missing is the listener
name.
--
T
dajac commented on code in PR #12181:
URL: https://github.com/apache/kafka/pull/12181#discussion_r884847649
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -498,6 +498,23 @@ public UsableBroker next() {
}
}
+/**
+
[
https://issues.apache.org/jira/browse/KAFKA-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov reassigned KAFKA-13947:
-
Assignee: Christo Lolov
> Format strings appropriately for their argument types
> -
[
https://issues.apache.org/jira/browse/KAFKA-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543926#comment-17543926
]
Christo Lolov commented on KAFKA-13947:
---
Heya, I volunteer to pick this up!
> For
C0urante commented on PR #11778:
URL: https://github.com/apache/kafka/pull/11778#issuecomment-1141101927
@tombentley If you do not have time to take a look, is there anyone you can
recommend in your place?
--
This is an automated message from the Apache Git Service.
To respond to the mess
C0urante commented on PR #11776:
URL: https://github.com/apache/kafka/pull/11776#issuecomment-1141101742
@showuon If you do not have time to take a look, is there anyone you can
recommend in your place?
--
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/KAFKA-13948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov reassigned KAFKA-13948:
-
Assignee: Christo Lolov
> Don't catch and re-throw exception unnecessarily
> --
[
https://issues.apache.org/jira/browse/KAFKA-13948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543924#comment-17543924
]
Christo Lolov commented on KAFKA-13948:
---
Hello, I would like to pick this issue up
showuon commented on PR #12136:
URL: https://github.com/apache/kafka/pull/12136#issuecomment-1141052283
@junrao , thanks for the comment. I've updated the PR. The failed test:
`testCleanShutdownAfterFailedStartupDueToCorruptLogs` is indeed related. But
the test is not the correct expectatio
dengziming commented on code in PR #12223:
URL: https://github.com/apache/kafka/pull/12223#discussion_r884673070
##
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##
@@ -59,6 +60,7 @@
@RunWith(Parameterized.class)
dajac opened a new pull request, #12227:
URL: https://github.com/apache/kafka/pull/12227
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade not
[
https://issues.apache.org/jira/browse/KAFKA-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-13947:
-
Affects Version/s: (was: 3.2.0)
> Format strings appropriately for their argument types
> --
Divij Vaidya created KAFKA-13948:
Summary: Don't catch and re-throw exception unnecessarily
Key: KAFKA-13948
URL: https://issues.apache.org/jira/browse/KAFKA-13948
Project: Kafka
Issue Type:
Divij Vaidya created KAFKA-13947:
Summary: Format strings appropriately for their argument types
Key: KAFKA-13947
URL: https://issues.apache.org/jira/browse/KAFKA-13947
Project: Kafka
Issue T
Nayana-ibm commented on PR #11929:
URL: https://github.com/apache/kafka/pull/11929#issuecomment-1140880728
@mimaison If there are build failures or platform specific issues on s390x ,
we can look into/debug those.
--
This is an automated message from the Apache Git Service.
To respond to
dajac commented on code in PR #12185:
URL: https://github.com/apache/kafka/pull/12185#discussion_r884533015
##
core/src/test/scala/unit/kafka/network/RequestChannelTest.scala:
##
@@ -191,84 +194,66 @@ class RequestChannelTest {
assertTrue(isValidJson(RequestConvertToJson.r
clolov commented on code in PR #12223:
URL: https://github.com/apache/kafka/pull/12223#discussion_r884541134
##
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##
@@ -59,6 +60,7 @@
@RunWith(Parameterized.class)
+@Ta
divijvaidya commented on PR #12224:
URL: https://github.com/apache/kafka/pull/12224#issuecomment-1140825549
cc: @jsancio perhaps you would be interested to look into this one since you
reviewed https://github.com/apache/kafka/pull/10909
--
This is an automated message from the Apache Git
dajac commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r884492699
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor l
40 matches
Mail list logo
