[GitHub] [kafka] C0urante commented on pull request #11779: KAFKA-10000: Zombie fencing (KIP-618)

C0urante commented on PR #11779: URL: https://github.com/apache/kafka/pull/11779#issuecomment-1148257156 Thanks Tom, some great catches. Going to rebase tomorrow or Thursday which should address the one or two outstanding comments; everything else should be addressed now and ready for anoth

[GitHub] [kafka] C0urante commented on a diff in pull request #11779: KAFKA-10000: Zombie fencing (KIP-618)

C0urante commented on code in PR #11779: URL: https://github.com/apache/kafka/pull/11779#discussion_r890817727 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -2082,6 +2343,117 @@ private void resetActiveTopics(Collecti

[GitHub] [kafka] C0urante commented on a diff in pull request #11779: KAFKA-10000: Zombie fencing (KIP-618)

C0urante commented on code in PR #11779: URL: https://github.com/apache/kafka/pull/11779#discussion_r890817572 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -2082,6 +2343,117 @@ private void resetActiveTopics(Collecti

[GitHub] [kafka] C0urante commented on a diff in pull request #11779: KAFKA-10000: Zombie fencing (KIP-618)

C0urante commented on code in PR #11779: URL: https://github.com/apache/kafka/pull/11779#discussion_r890817431 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1745,6 +1958,23 @@ private boolean checkRebalanceNeeded(Cal

[GitHub] [kafka] C0urante commented on a diff in pull request #11779: KAFKA-10000: Zombie fencing (KIP-618)

C0urante commented on code in PR #11779: URL: https://github.com/apache/kafka/pull/11779#discussion_r890817292 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -582,6 +588,59 @@ public boolean startTask( } } +/** + * Us

[GitHub] [kafka] C0urante commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

C0urante commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r890754969 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dengziming commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

dengziming commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890725858 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -394,31 +432,49 @@ public void replay(UnregisterBrokerRecord record) { }

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12235: KAFKA-13945: add bytes/records consumed and produced metrics

ableegoldman commented on code in PR #12235: URL: https://github.com/apache/kafka/pull/12235#discussion_r890725391 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetricsTest.java: ## @@ -114,6 +116,63 @@ public void shouldGetProcessAtS

[GitHub] [kafka] ableegoldman closed pull request #12257: [DO NOT MERGE] test branch for debugging #12235 (KAFKA-13945)

ableegoldman closed pull request #12257: [DO NOT MERGE] test branch for debugging #12235 (KAFKA-13945) URL: https://github.com/apache/kafka/pull/12257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ableegoldman commented on pull request #12257: [DO NOT MERGE] test branch for debugging #12235 (KAFKA-13945)

ableegoldman commented on PR #12257: URL: https://github.com/apache/kafka/pull/12257#issuecomment-1148140886 WHEW finally managed to find the bug... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] C0urante commented on a diff in pull request #11778: KAFKA-10000: Use transactional producer for config topic (KIP-618)

C0urante commented on code in PR #11778: URL: https://github.com/apache/kafka/pull/11778#discussion_r890724606 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -309,16 +342,71 @@ public void start() { @Override publi

[GitHub] [kafka] ableegoldman commented on pull request #12256: [DO NOT MERGE] test branch for debugging #12235 (KAFKA-13945)

ableegoldman commented on PR #12256: URL: https://github.com/apache/kafka/pull/12256#issuecomment-1148140766 WHEW managed to find the bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] ableegoldman closed pull request #12256: [DO NOT MERGE] test branch for debugging #12235 (KAFKA-13945)

ableegoldman closed pull request #12256: [DO NOT MERGE] test branch for debugging #12235 (KAFKA-13945) URL: https://github.com/apache/kafka/pull/12256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-13908) RuntimeException will be thrown in BrokerServer.startup, not the cause of exception

[ https://issues.apache.org/jira/browse/KAFKA-13908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550747#comment-17550747 ] Luke Chen commented on KAFKA-13908: --- [~rjoerger] , thanks for picking it up. For the t

[GitHub] [kafka] hachikuji commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

hachikuji commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r890689748 ## clients/src/main/java/org/apache/kafka/common/requests/DescribeQuorumResponse.java: ## @@ -93,4 +94,25 @@ public static DescribeQuorumResponseData singletonRespons

[GitHub] [kafka] mumrah commented on a diff in pull request #12250: KAFKA-13935 Fix static usages of IBP in KRaft mode

mumrah commented on code in PR #12250: URL: https://github.com/apache/kafka/pull/12250#discussion_r890686480 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1790,38 +1790,13 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami //

[jira] [Commented] (KAFKA-13598) idempotence producer is not enabled by default if not set explicitly

[ https://issues.apache.org/jira/browse/KAFKA-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550736#comment-17550736 ] Derek Troy-West commented on KAFKA-13598: - Thanks Luke, I raised [https://github

[GitHub] [kafka] d-t-w opened a new pull request, #12260: MINOR: add note on IDEMPOTENT_WRITE ACL to 3.2.0 notable changes

d-t-w opened a new pull request, #12260: URL: https://github.com/apache/kafka/pull/12260 Update 3.2.0 notable changes documentation to include a subsection on requiring IDEMPOTENT_WRITE permission when producing messages with default/idempotent configuration and broker version lower than 2.

[jira] [Resolved] (KAFKA-13592) Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions

[ https://issues.apache.org/jira/browse/KAFKA-13592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13592. - Resolution: Fixed > Fix flaky test > ControllerIntegrationTest.testTopicIdUpgradeAfterR

[GitHub] [kafka] hachikuji merged pull request #11687: KAFKA-13592:Fix flaky test ControllerIntegrationTest.testTopicIdUpgradeAfterReassigningPartitions

hachikuji merged PR #11687: URL: https://github.com/apache/kafka/pull/11687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] junrao commented on a diff in pull request #12250: KAFKA-13935 Fix static usages of IBP in KRaft mode

junrao commented on code in PR #12250: URL: https://github.com/apache/kafka/pull/12250#discussion_r890589316 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1790,38 +1790,13 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami //

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r890648753 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,445 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] hachikuji commented on a diff in pull request #12258: MINOR: Convert `ReassignPartitionsIntegrationTest` to KRaft

hachikuji commented on code in PR #12258: URL: https://github.com/apache/kafka/pull/12258#discussion_r890622191 ## core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala: ## @@ -582,7 +598,7 @@ class ReassignPartitionsIntegrationTest extends QuorumT

[GitHub] [kafka] mumrah commented on a diff in pull request #12258: MINOR: Convert `ReassignPartitionsIntegrationTest` to KRaft

mumrah commented on code in PR #12258: URL: https://github.com/apache/kafka/pull/12258#discussion_r890611619 ## core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala: ## @@ -582,7 +598,7 @@ class ReassignPartitionsIntegrationTest extends QuorumTest

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890595884 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -485,12 +541,36 @@ Iterator usableBrokers() { id -> brokerRegistrati

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890548627 ## metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java: ## @@ -152,13 +156,22 @@ public boolean fenced() { return fenced; } -pub

[GitHub] [kafka] guozhangwang opened a new pull request, #12259: HOTFIX: only try to clear discover-coordinator future upon commit

guozhangwang opened a new pull request, #12259: URL: https://github.com/apache/kafka/pull/12259 This is a cherrypick commit of 3.1. Another way of fixing [KAFKA-13563](https://issues.apache.org/jira/browse/KAFKA-13563) other than https://github.com/apache/kafka/pull/11631. Instead o

[GitHub] [kafka] hachikuji opened a new pull request, #12258: MINOR: Convert `ReassignPartitionsIntegrationTest` to KRaft

hachikuji opened a new pull request, #12258: URL: https://github.com/apache/kafka/pull/12258 Updates relevant tests in `ReassignPartitionsIntegrationTest` for KRaft. We skip the JBOD and AlterPartition upgrade tests. ### Committer Checklist (excluded from commit message) -

[jira] [Updated] (KAFKA-13214) Consumer should not reset group state after disconnect

[ https://issues.apache.org/jira/browse/KAFKA-13214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13214: -- Labels: new-consumer-threading-should-fix (was: ) > Consumer should not reset group state aft

[jira] [Updated] (KAFKA-12983) onJoinPrepare is not always invoked before joining the group

[ https://issues.apache.org/jira/browse/KAFKA-12983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12983: -- Labels: new-consumer-threading-should-fix (was: ) > onJoinPrepare is not always invoked befor

[GitHub] [kafka] jsancio commented on pull request #12236: MINOR: Use right enum value for broker registration change

jsancio commented on PR #12236: URL: https://github.com/apache/kafka/pull/12236#issuecomment-1147912524 We need to make sure that we handle these changes depending on which commit gets merged first: https://github.com/apache/kafka/pull/12240/commits/db8224767457c79e8af31af0b4ddbd9988

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890549624 ## metadata/src/main/resources/common/metadata/BrokerRegistrationChangeRecord.json: ## @@ -17,14 +17,16 @@ "apiKey": 17, "type": "metadata", "name": "BrokerRegi

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890548627 ## metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java: ## @@ -152,13 +156,22 @@ public boolean fenced() { return fenced; } -pub

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890540775 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -682,25 +683,35 @@ private ApiError createTopic(CreatableTopic topic,

[GitHub] [kafka] jsancio commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

jsancio commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r890538379 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -132,15 +143,27 @@ ClusterControlManager build() { replicaPlacer

[jira] [Commented] (KAFKA-13908) RuntimeException will be thrown in BrokerServer.startup, not the cause of exception

[ https://issues.apache.org/jira/browse/KAFKA-13908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550630#comment-17550630 ] Richard Joerger commented on KAFKA-13908: - Hey [~showuon], I'm taking a look at

[GitHub] [kafka] mumrah commented on pull request #12245: KAFKA-13410; Add a --release-version flag for storage-tool

mumrah commented on PR #12245: URL: https://github.com/apache/kafka/pull/12245#issuecomment-1147824840 @dengziming you're right, we should add an equivalent flag to the features tool. It's definitely a better user experience to use a release version string rather than the internal feature l

[GitHub] [kafka] Stonepreheim commented on pull request #8575: KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null

Stonepreheim commented on PR #8575: URL: https://github.com/apache/kafka/pull/8575#issuecomment-1147824661 We have run into the same issue and believe the underlying problem is with the struct get method. While searching for a potential workaround we fixed the issue by changing this line h

[GitHub] [kafka] hachikuji merged pull request #12253: MINOR: A fewer method javadoc and typo fix

hachikuji merged PR #12253: URL: https://github.com/apache/kafka/pull/12253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] hachikuji commented on a diff in pull request #12249: MINOR; Test last committed record offset for Controllers

hachikuji commented on code in PR #12249: URL: https://github.com/apache/kafka/pull/12249#discussion_r890468231 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerMetricsTest.java: ## @@ -40,9 +40,11 @@ public void testKafkaControllerMetricNames() {

[GitHub] [kafka] hachikuji commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

hachikuji commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r890446439 ## core/src/test/scala/unit/kafka/server/DescribeQuorumRequestTest.scala: ## @@ -54,30 +54,44 @@ class DescribeQuorumRequestTest(cluster: ClusterInstance) { @Clus

[GitHub] [kafka] hachikuji commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

hachikuji commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r890415293 ## clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] niket-goel commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

niket-goel commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r890414480 ## clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] hachikuji merged pull request #12223: MINOR: Correctly mark some tests as integration tests

hachikuji merged PR #12223: URL: https://github.com/apache/kafka/pull/12223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] guozhangwang commented on pull request #12244: HOTFIX: only try to clear discover-coordinator future upon commit

guozhangwang commented on PR #12244: URL: https://github.com/apache/kafka/pull/12244#issuecomment-1147734294 Cherry-picking to 3.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] guozhangwang merged pull request #12244: HOTFIX: only try to clear discover-coordinator future upon commit

guozhangwang merged PR #12244: URL: https://github.com/apache/kafka/pull/12244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12244: HOTFIX: only try to clear discover-coordinator future upon commit

guozhangwang commented on code in PR #12244: URL: https://github.com/apache/kafka/pull/12244#discussion_r890401527 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -514,10 +514,62 @@ public void testCoordinatorNotAvailable

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] fvaleri commented on a diff in pull request #12159: KAFKA-13933: Fix stuck SSL tests in case of authentication failure

fvaleri commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r890306188 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -603,23 +603,18 @@ private void verifyChannelExpiry(KafkaChannel channel) throws Excep

[GitHub] [kafka] ijuma commented on a diff in pull request #11579: KAFKA-13518: Update gson dependency

ijuma commented on code in PR #11579: URL: https://github.com/apache/kafka/pull/11579#discussion_r890134554 ## gradle/spotbugs-exclude.xml: ## @@ -28,8 +28,19 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read - + +

[GitHub] [kafka] ijuma commented on a diff in pull request #11579: KAFKA-13518: Update gson dependency

ijuma commented on code in PR #11579: URL: https://github.com/apache/kafka/pull/11579#discussion_r890134361 ## gradle/spotbugs-exclude.xml: ## @@ -28,8 +28,19 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read

[GitHub] [kafka] ijuma commented on a diff in pull request #11579: KAFKA-13518: Update gson dependency

ijuma commented on code in PR #11579: URL: https://github.com/apache/kafka/pull/11579#discussion_r890132880 ## gradle/spotbugs-exclude.xml: ## @@ -105,6 +127,19 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read +

[GitHub] [kafka] ijuma commented on a diff in pull request #11579: KAFKA-13518: Update gson dependency

ijuma commented on code in PR #11579: URL: https://github.com/apache/kafka/pull/11579#discussion_r890133230 ## gradle/spotbugs-exclude.xml: ## @@ -43,6 +54,17 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read EQ_COMPARETO_USE_OBJEC

[jira] [Created] (KAFKA-13961) GKE kafka-consumer-groups returns incorrect hosts

Mikhail Filatov created KAFKA-13961: --- Summary: GKE kafka-consumer-groups returns incorrect hosts Key: KAFKA-13961 URL: https://issues.apache.org/jira/browse/KAFKA-13961 Project: Kafka Issue

[jira] [Commented] (KAFKA-13948) Don't catch and re-throw exception unnecessarily

[ https://issues.apache.org/jira/browse/KAFKA-13948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550424#comment-17550424 ] deepak chaurasia commented on KAFKA-13948: -- hi [~christo_lolov] are you working

[GitHub] [kafka] tombentley commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

tombentley commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r890059412 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTransactionContext.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] tombentley commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

tombentley commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r890058546 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] tombentley commented on a diff in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

tombentley commented on code in PR #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r890057763 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -0,0 +1,525 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] tombentley commented on a diff in pull request #11779: KAFKA-10000: Zombie fencing (KIP-618)

tombentley commented on code in PR #11779: URL: https://github.com/apache/kafka/pull/11779#discussion_r889992019 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -582,6 +588,59 @@ public boolean startTask( } } +/** + *

[GitHub] [kafka] dengziming commented on a diff in pull request #12245: KAFKA-13410; Add a --release-version flag for storage-tool

dengziming commented on code in PR #12245: URL: https://github.com/apache/kafka/pull/12245#discussion_r890020215 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -189,16 +190,33 @@ Found problem: @Test def testDefaultMetadataVersion(): Unit = { -v

[GitHub] [kafka] dajac commented on pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

dajac commented on PR #12240: URL: https://github.com/apache/kafka/pull/12240#issuecomment-1147170400 @jsancio Thanks for your review. I have addressed or replied to your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] dajac commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

dajac commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r889877186 ## metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java: ## @@ -152,13 +156,22 @@ public boolean fenced() { return fenced; } -publi

[GitHub] [kafka] dajac commented on a diff in pull request #12240: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 1)

dajac commented on code in PR #12240: URL: https://github.com/apache/kafka/pull/12240#discussion_r889876056 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -682,25 +683,35 @@ private ApiError createTopic(CreatableTopic topic,