[GitHub] [kafka] ableegoldman merged pull request #12288: HOTFIX: null check for ProducerRecord when computing sizeInBytes

2022-06-13 Thread GitBox
ableegoldman merged PR #12288: URL: https://github.com/apache/kafka/pull/12288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] ableegoldman commented on pull request #12288: HOTFIX: null check for ProducerRecord when computing sizeInBytes

2022-06-13 Thread GitBox
ableegoldman commented on PR #12288: URL: https://github.com/apache/kafka/pull/12288#issuecomment-1154724371 Failing tests are unrelated: `testIncrementalAlterConfigs() – kafka.server.KRaftClusterTest` `testFailureToFenceEpoch(String).quorum=kraft – kafka.api.TransactionsTest` Me

[GitHub] [kafka] C0urante commented on a diff in pull request #12281: KAFKA-13971: Fix atomicity violations caused by improper usage of ConcurrentHashMap - part2

2022-06-13 Thread GitBox
C0urante commented on code in PR #12281: URL: https://github.com/apache/kafka/pull/12281#discussion_r896319034 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -222,14 +222,10 @@ protected PluginClassLoader newPluginCl

[GitHub] [kafka] hachikuji commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 2)

2022-06-13 Thread GitBox
hachikuji commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r896305171 ## core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala: ## @@ -846,6 +862,135 @@ class ControllerIntegrationTest extends QuorumTestHarness {

[GitHub] [kafka] C0urante commented on pull request #12291: KAFKA-13987: Isolate REST request timeout changes in Connect integration tests

2022-06-13 Thread GitBox
C0urante commented on PR #12291: URL: https://github.com/apache/kafka/pull/12291#issuecomment-1154607749 @cadonna this is a follow-up from the earlier work in https://github.com/apache/kafka/pull/12191. It's not urgent but it should help reduce some flakiness; if you have time would you min

[GitHub] [kafka] C0urante opened a new pull request, #12291: KAFKA-13987: Isolate REST request timeout changes in Connect integration tests

2022-06-13 Thread GitBox
C0urante opened a new pull request, #12291: URL: https://github.com/apache/kafka/pull/12291 This causes the artificial reductions in the Connect REST request timeout to be more isolated. Specifically, they now only take place in the tests that need them (instead of any tests that happen to

[jira] [Created] (KAFKA-13987) BlockingConnectorTest causing flakiness in other tests

2022-06-13 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-13987: - Summary: BlockingConnectorTest causing flakiness in other tests Key: KAFKA-13987 URL: https://issues.apache.org/jira/browse/KAFKA-13987 Project: Kafka Issu

[GitHub] [kafka] C0urante opened a new pull request, #12290: MINOR: Stop leaking threads in BlockingConnectorTest

2022-06-13 Thread GitBox
C0urante opened a new pull request, #12290: URL: https://github.com/apache/kafka/pull/12290 These tests currently create threads that block forever until the JVM is shut down. This change unblocks those threads once their respective test cases are finished. This is valuable not only

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841, Part 2)

2022-06-13 Thread GitBox
artemlivshits commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r896208216 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1569,24 +1628,47 @@ class Partition(val topicPartition: TopicPartition, ): Boolean = { alterPa

[GitHub] [kafka] hachikuji commented on pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-13 Thread GitBox
hachikuji commented on PR #12206: URL: https://github.com/apache/kafka/pull/12206#issuecomment-1154541770 @niket-goel It looks like we are running into https://issues.apache.org/jira/browse/KAFKA-13940, which is causing the new integration test to be flaky. I think our options are either to

[jira] [Updated] (KAFKA-13984) Fix TopicBasedRemoteLogMetadataManager#initializeResources should exit immediately when partition size of __remote_log_metadata is not same as configured

2022-06-13 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13984: --- Summary: Fix TopicBasedRemoteLogMetadataManager#initializeResources should exit immediately when partition s

[GitHub] [kafka] C0urante commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-13 Thread GitBox
C0urante commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r896236376 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -16,56 +16,322 @@ */ package org.apache.kafka.connect.stora

[GitHub] [kafka] C0urante commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-13 Thread GitBox
C0urante commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r896234648 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1327,30 +1334,39 @@ public WorkerTask doBuild(Task task, conn

[GitHub] [kafka] C0urante commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-13 Thread GitBox
C0urante commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r896234734 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -16,56 +16,322 @@ */ package org.apache.kafka.connect.stora

[jira] [Assigned] (KAFKA-13986) DescribeQuorum does not return the observers (brokers) for the Metadata log

2022-06-13 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel reassigned KAFKA-13986: -- Assignee: Niket Goel > DescribeQuorum does not return the observers (brokers) for the Metadat

[GitHub] [kafka] niket-goel commented on pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-13 Thread GitBox
niket-goel commented on PR #12206: URL: https://github.com/apache/kafka/pull/12206#issuecomment-1154525501 Thanks @hachikuji . I have created https://issues.apache.org/jira/browse/KAFKA-13986 for the observer count issue and will raise a PR once this one is merged -- This is an automated

[jira] [Commented] (KAFKA-13986) DescribeQuorum does not return the observers (brokers) for the Metadata log

2022-06-13 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553818#comment-17553818 ] Niket Goel commented on KAFKA-13986: The fix should be something on the lines of: {c

[jira] [Commented] (KAFKA-10121) Streams Task Assignment optimization design

2022-06-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553814#comment-17553814 ] A. Sophie Blee-Goldman commented on KAFKA-10121: Bumping this up to 'Cri

[jira] [Updated] (KAFKA-10121) Streams Task Assignment optimization design

2022-06-13 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10121: --- Priority: Critical (was: Minor) > Streams Task Assignment optimization desi

[jira] [Commented] (KAFKA-12639) AbstractCoordinator ignores backoff timeout when joining the consumer group

2022-06-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553811#comment-17553811 ] Guozhang Wang commented on KAFKA-12639: --- This is a separate issue, as `joinGroupIf

[jira] [Commented] (KAFKA-13957) Flaky Test StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStores

2022-06-13 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553810#comment-17553810 ] Matthew de Detrich commented on KAFKA-13957: I have fixed the test at https:

[GitHub] [kafka] mdedetrich opened a new pull request, #12289: KAFKA-13957: Fix flaky shouldQuerySpecificActivePartitionStores test

2022-06-13 Thread GitBox
mdedetrich opened a new pull request, #12289: URL: https://github.com/apache/kafka/pull/12289 Previously the tests would fail even on retryable errors. This change adds a retryUntil similar to the current until method however it will retry the test if it throws an exception that passes a pr

[GitHub] [kafka] hachikuji commented on pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-13 Thread GitBox
hachikuji commented on PR #12206: URL: https://github.com/apache/kafka/pull/12206#issuecomment-1154495677 @dajac I think this is the reason there are no observers: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/raft/RaftManager.scala#L188. We should just use `config.no

[GitHub] [kafka] ableegoldman opened a new pull request, #12288: HOTFIX: null check for ProducerRecord when computing sizeInBytes

2022-06-13 Thread GitBox
ableegoldman opened a new pull request, #12288: URL: https://github.com/apache/kafka/pull/12288 Minor followup to #12235 that adds a null check on the record key in the new ClientUtils#producerRecordSizeInBytes utility method, as there are valid cases in which we might be sending records w

[jira] [Commented] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2022-06-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553806#comment-17553806 ] Guozhang Wang commented on KAFKA-10575: --- I took another look at this ticket while

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12235: KAFKA-13945: add bytes/records consumed and produced metrics

2022-06-13 Thread GitBox
ableegoldman commented on code in PR #12235: URL: https://github.com/apache/kafka/pull/12235#discussion_r896155831 ## streams/src/test/java/org/apache/kafka/test/MockRecordCollector.java: ## @@ -46,13 +47,15 @@ public void send(final String topic, f

[jira] [Created] (KAFKA-13986) DescribeQuorum does not return the observers (brokers) for the Metadata log

2022-06-13 Thread Niket Goel (Jira)
Niket Goel created KAFKA-13986: -- Summary: DescribeQuorum does not return the observers (brokers) for the Metadata log Key: KAFKA-13986 URL: https://issues.apache.org/jira/browse/KAFKA-13986 Project: Kafk

[jira] [Updated] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2022-06-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10575: -- Labels: (was: new-streams-runtime-should-fix) > StateRestoreListener#onRestoreEnd should alw

[jira] [Updated] (KAFKA-10199) Separate state restoration into separate threads

2022-06-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10199: -- Labels: (was: new-streams-runtime-should-fix) > Separate state restoration into separate thr

[jira] [Updated] (KAFKA-10199) Separate state restoration into separate threads

2022-06-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10199: -- Labels: new-streams-runtime-should-fix (was: ) > Separate state restoration into separate thr

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12287: KAFKA-13846: Use the new addMetricsIfAbsent API

2022-06-13 Thread GitBox
guozhangwang commented on code in PR #12287: URL: https://github.com/apache/kafka/pull/12287#discussion_r896037230 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java: ## @@ -502,9 +502,8 @@ public void addStoreLevelMutableMetri

[GitHub] [kafka] guozhangwang commented on pull request #12287: KAFKA-13846: Use the new addMetricsIfAbsent API

2022-06-13 Thread GitBox
guozhangwang commented on PR #12287: URL: https://github.com/apache/kafka/pull/12287#issuecomment-1154265926 cc @vamossagar12 @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] guozhangwang opened a new pull request, #12287: KAFKA-13846: Use the new addMetricsIfAbsent API

2022-06-13 Thread GitBox
guozhangwang opened a new pull request, #12287: URL: https://github.com/apache/kafka/pull/12287 Use the newly added function to replace the old `addMetric` function that may throw illegal argument exceptions. Although in some cases concurrency should not be possible they do not neces

[GitHub] [kafka] mumrah merged pull request #12250: KAFKA-13935 Fix static usages of IBP in KRaft mode

2022-06-13 Thread GitBox
mumrah merged PR #12250: URL: https://github.com/apache/kafka/pull/12250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] hachikuji commented on a diff in pull request #12250: KAFKA-13935 Fix static usages of IBP in KRaft mode

2022-06-13 Thread GitBox
hachikuji commented on code in PR #12250: URL: https://github.com/apache/kafka/pull/12250#discussion_r895992684 ## core/src/test/scala/unit/kafka/server/KafkaRaftServerTest.scala: ## @@ -215,4 +223,47 @@ class KafkaRaftServerTest { () => KafkaRaftServer.initializeLogDirs(

[GitHub] [kafka] niket-goel commented on pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-13 Thread GitBox
niket-goel commented on PR #12206: URL: https://github.com/apache/kafka/pull/12206#issuecomment-1154209076 Thanks for the in-depth review @dajac @hachikuji and @dengziming. I have updated the PR with the final NITs from @dajac fixed. Are we good to merge with 1 LGTM or do we need 1 more?

[GitHub] [kafka] guozhangwang merged pull request #12121: KAFKA-13846: Adding overloaded metricOrElseCreate method

2022-06-13 Thread GitBox
guozhangwang merged PR #12121: URL: https://github.com/apache/kafka/pull/12121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12121: KAFKA-13846: Adding overloaded metricOrElseCreate method

2022-06-13 Thread GitBox
guozhangwang commented on code in PR #12121: URL: https://github.com/apache/kafka/pull/12121#discussion_r895970308 ## clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java: ## @@ -509,7 +509,10 @@ public void addMetric(MetricName metricName, MetricConfig config, Me

[jira] [Commented] (KAFKA-8713) [Connect] JsonConverter NULL Values are replaced by default values even in NULLABLE fields

2022-06-13 Thread Cheng Pan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553724#comment-17553724 ] Cheng Pan commented on KAFKA-8713: -- Thanks [~rotem-ad], I'm sorry I haven't worked in th

[jira] [Updated] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-06-13 Thread Jacopo Riciputi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Riciputi updated KAFKA-13985: Description: Applying a SMT that filters out messages it can brings to enter in this path:

[jira] [Updated] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-06-13 Thread Jacopo Riciputi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Riciputi updated KAFKA-13985: Description: Applying a SMT that filters out messages it can brings to enter in this path:

[jira] [Updated] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-06-13 Thread Jacopo Riciputi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Riciputi updated KAFKA-13985: Description: Applying a SMT that filters out messages it can brings to enter in this path:

[GitHub] [kafka] tombentley commented on a diff in pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-06-13 Thread GitBox
tombentley commented on code in PR #11781: URL: https://github.com/apache/kafka/pull/11781#discussion_r895874082 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1327,30 +1334,39 @@ public WorkerTask doBuild(Task task, co

[GitHub] [kafka] hachikuji commented on pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-06-13 Thread GitBox
hachikuji commented on PR #12274: URL: https://github.com/apache/kafka/pull/12274#issuecomment-1154107684 @dengziming The difference is that advancing the high watermark would then be the trigger for fulfilling the Fetch. If the observer does not have the latest high watermark, then it mean

[GitHub] [kafka] mimaison merged pull request #12283: MINOR: Shutdown jmx reporter using internal utility method

2022-06-13 Thread GitBox
mimaison merged PR #12283: URL: https://github.com/apache/kafka/pull/12283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] ijuma commented on pull request #11261: KAFKA-13228: ApiVersionRequest is not properly handled in KRaft co-resident mode

2022-06-13 Thread GitBox
ijuma commented on PR #11261: URL: https://github.com/apache/kafka/pull/11261#issuecomment-1154058710 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[jira] [Updated] (KAFKA-13979) Kafka resets committed offset after rebalance

2022-06-13 Thread Fathima Khazana Abdul Haiyum (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fathima Khazana Abdul Haiyum updated KAFKA-13979: - Description: We have 3 nodes in our MSK cluster which run Apache

[GitHub] [kafka] divijvaidya commented on pull request #12283: MINOR: Shutdown jmx reporter using internal utility method

2022-06-13 Thread GitBox
divijvaidya commented on PR #12283: URL: https://github.com/apache/kafka/pull/12283#issuecomment-1154035937 @mimaison perhaps you could review this quick code change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mimaison commented on pull request #12285: KAFKA-7342 Part 1: Straightforward JUnit4 to JUnit5 migrations

2022-06-13 Thread GitBox
mimaison commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1154027464 Thanks for the PR! Since this PR only touches Streams, I'll let committers focused on Streams review it. -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Reopened] (KAFKA-13414) Replace Powermock/EasyMock by Mockito in connect.storage package

2022-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reopened KAFKA-13414: My PR only updated some of the classes under connect.storage. The following files still need

[jira] [Commented] (KAFKA-13414) Replace Powermock/EasyMock by Mockito in connect.storage package

2022-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553626#comment-17553626 ] Mickael Maison commented on KAFKA-13414: Feel free to grab the ticket if it's so

[jira] [Resolved] (KAFKA-13436) Omitted BrokerTopicMetrics metrics in the documentation

2022-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-13436. Fix Version/s: 3.3.0 Resolution: Fixed > Omitted BrokerTopicMetrics metrics in the

[GitHub] [kafka] mimaison merged pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

2022-06-13 Thread GitBox
mimaison merged PR #11473: URL: https://github.com/apache/kafka/pull/11473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] dajac commented on a diff in pull request #12206: KAFKA-13888: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-06-13 Thread GitBox
dajac commented on code in PR #12206: URL: https://github.com/apache/kafka/pull/12206#discussion_r895790891 ## clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] dengziming commented on a diff in pull request #12265: KAFKA-13968: Fix 3 major bugs of KRaft snapshot generating

2022-06-13 Thread GitBox
dengziming commented on code in PR #12265: URL: https://github.com/apache/kafka/pull/12265#discussion_r895799683 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -244,6 +248,9 @@ class BrokerMetadataListener( _publisher = Some(publisher)

[jira] [Commented] (KAFKA-13983) Support special character in Resource name in ACLs operation by sanitizing

2022-06-13 Thread Matias Cascallares (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553613#comment-17553613 ] Matias Cascallares commented on KAFKA-13983: Would it be possible to add a m

[GitHub] [kafka] mimaison merged pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-06-13 Thread GitBox
mimaison merged PR #11780: URL: https://github.com/apache/kafka/pull/11780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] dengziming commented on pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-06-13 Thread GitBox
dengziming commented on PR #12274: URL: https://github.com/apache/kafka/pull/12274#issuecomment-1153977501 > I think we should increase the `MetadataMaxIdleIntervalMs` to something like 800ms or 1000ms @showuon Neither changing `MetadataMaxIdleIntervalMs` nor changing `KafkaRaftClien

[GitHub] [kafka] dengziming commented on pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-06-13 Thread GitBox
dengziming commented on PR #12274: URL: https://github.com/apache/kafka/pull/12274#issuecomment-1153971776 > only letting observers fetch up to the high watermark @hachikuji Not sure did I understand correctly, the problem is that observer HW is always less than leader HW because the

[GitHub] [kafka] dengziming commented on pull request #11261: KAFKA-13228: ApiVersionRequest is not properly handled in KRaft co-resident mode

2022-06-13 Thread GitBox
dengziming commented on PR #11261: URL: https://github.com/apache/kafka/pull/11261#issuecomment-1153951329 > Was this fixed some other way? No, there are too many conflicts, I split this PR into 2 PRs, #12157 and #11784. -- This is an automated message from the Apache Git Service.

[jira] [Updated] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-06-13 Thread Jacopo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo updated KAFKA-13985: --- Description: Applying a SMT that filter message it can laverage to enter in this if:   >From WorkerSourceT

[jira] [Updated] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-06-13 Thread Jacopo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo updated KAFKA-13985: --- Description: Applying a SMT that filter message it can laverage to enter in this if:   >From WorkerSourceT

[jira] [Updated] (KAFKA-13984) Fix TopicBasedRemoteLogMetadataManager#initializeResources should exit immediately when partition numbers of __remote_log_metadata is inconsistent with configuration fil

2022-06-13 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13984: --- Summary: Fix TopicBasedRemoteLogMetadataManager#initializeResources should exit immediately when partition n

[jira] [Updated] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-06-13 Thread Jacopo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo updated KAFKA-13985: --- Description: Applying a SMT that filter message it can laverage to enter in this if:   >From WorkerSourceT

[jira] [Created] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-06-13 Thread Jacopo (Jira)
Jacopo created KAFKA-13985: -- Summary: MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record Key: KAFKA-13985 URL: https://issues.apache.org/jira/browse/KAFKA-13985 Project: Kafka

[GitHub] [kafka] bozhao12 opened a new pull request, #12286: KAFKA-13984: Fix TopicBasedRemoteLogMetadataManager#initializeResourc…

2022-06-13 Thread GitBox
bozhao12 opened a new pull request, #12286: URL: https://github.com/apache/kafka/pull/12286 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Commented] (KAFKA-13957) Flaky Test StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStores

2022-06-13 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553562#comment-17553562 ] Matthew de Detrich commented on KAFKA-13957: I am working on this issue, I m

[jira] [Assigned] (KAFKA-13957) Flaky Test StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStores

2022-06-13 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich reassigned KAFKA-13957: -- Assignee: Matthew de Detrich > Flaky Test StoreQueryIntegrationTest.shouldQue

[jira] [Updated] (KAFKA-13984) Fix TopicBasedRemoteLogMetadataManager#initializeResources should return immediately when the result of isPartitionsCountSameAsConfigured method is false

2022-06-13 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13984: --- Description: When  executing {*}TopicBasedRemoteLogMetadataManager.initializeResources(){*}, if the result

[jira] [Updated] (KAFKA-13984) Fix TopicBasedRemoteLogMetadataManager#initializeResources should return immediately when the result of isPartitionsCountSameAsConfigured method is false

2022-06-13 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13984: --- Description: When  executing {*}TopicBasedRemoteLogMetadataManager.initializeResources(){*}, if the result

[jira] [Created] (KAFKA-13984) Fix TopicBasedRemoteLogMetadataManager#initializeResources should return immediately when the result of isPartitionsCountSameAsConfigured method is false

2022-06-13 Thread zhaobo (Jira)
zhaobo created KAFKA-13984: -- Summary: Fix TopicBasedRemoteLogMetadataManager#initializeResources should return immediately when the result of isPartitionsCountSameAsConfigured method is false Key: KAFKA-13984 URL: https

[GitHub] [kafka] cadonna commented on a diff in pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for Streams…

2022-06-13 Thread GitBox
cadonna commented on code in PR #10881: URL: https://github.com/apache/kafka/pull/10881#discussion_r895663246 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNodeTest.java: ## @@ -23,43 +23,32 @@ import org.apache.kafka.streams.kstream.inter

[jira] [Commented] (KAFKA-8713) [Connect] JsonConverter NULL Values are replaced by default values even in NULLABLE fields

2022-06-13 Thread Rotem Adhoh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553550#comment-17553550 ] Rotem Adhoh commented on KAFKA-8713: [~pan3793] This exact same bug exists in Conflue

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r895651419 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] liuzhuang2017 commented on pull request #12272: MINOR: Update the README file in examples.

2022-06-13 Thread GitBox
liuzhuang2017 commented on PR #12272: URL: https://github.com/apache/kafka/pull/12272#issuecomment-1153833490 @[guozhangwang](https://github.com/guozhangwang), Sorry to bother you, can you help me review this pr? Thank you. -- This is an automated message from the Apache Git Service. To r

[jira] [Updated] (KAFKA-13983) Support special character in Resource name in ACLs operation by sanitizing

2022-06-13 Thread Aman Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Singh updated KAFKA-13983: --- Description: Currently, resource names in ACLS can contain any special characters, but resource nam

[jira] [Updated] (KAFKA-13983) Support special character in Resource name in ACLs operation by sanitizing

2022-06-13 Thread Aman Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Singh updated KAFKA-13983: --- Issue Type: Bug (was: Improvement) > Support special character in Resource name in ACLs operation b

[jira] [Updated] (KAFKA-13983) Support special character in Resource name in ACLs operation by sanitizing

2022-06-13 Thread Aman Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Singh updated KAFKA-13983: --- Description: Currently, resource names in ACLS can contain any special characters, but resource nam

[jira] [Created] (KAFKA-13983) Support special character in Resource name in ACLs operation by sanitizing

2022-06-13 Thread Aman Singh (Jira)
Aman Singh created KAFKA-13983: -- Summary: Support special character in Resource name in ACLs operation by sanitizing Key: KAFKA-13983 URL: https://issues.apache.org/jira/browse/KAFKA-13983 Project: Kafk

[jira] [Updated] (KAFKA-13967) Guarantees for producer callbacks on transaction commit should be documented

2022-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13967: --- Fix Version/s: 3.3.0 > Guarantees for producer callbacks on transaction commit should be doc

[jira] [Updated] (KAFKA-13967) Guarantees for producer callbacks on transaction commit should be documented

2022-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13967: --- Fix Version/s: 3.3 > Guarantees for producer callbacks on transaction commit should be docum

[GitHub] [kafka] tombentley commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

2022-06-13 Thread GitBox
tombentley commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r895546403 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -34,35 +35,56 @@ */ public abstract class SampledStat implements MeasurableS

[jira] [Updated] (KAFKA-13967) Guarantees for producer callbacks on transaction commit should be documented

2022-06-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13967: --- Fix Version/s: (was: 3.3) > Guarantees for producer callbacks on transaction commit shou

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r895578928 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r895564024 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r89390 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] cadonna commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

2022-06-13 Thread GitBox
cadonna commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r895542975 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Updated] (KAFKA-13982) Replace EasyMock and PowerMock with Mockito for WorkerConfigTransformerTest

2022-06-13 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-13982: -- Labels: connect (was: ) > Replace EasyMock and PowerMock with Mockito for WorkerConfigTransfo

[jira] [Updated] (KAFKA-13982) Replace EasyMock and PowerMock with Mockito for WorkerConfigTransformerTest

2022-06-13 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-13982: -- Description: I believe the file connect/runtime/src/test/java/org/apache/kafka/connect/runtime

[jira] [Assigned] (KAFKA-13982) Replace EasyMock and PowerMock with Mockito for WorkerConfigTransformerTest

2022-06-13 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-13982: - Assignee: Christo Lolov > Replace EasyMock and PowerMock with Mockito for WorkerConfigT

[jira] [Created] (KAFKA-13982) Replace EasyMock and PowerMock with Mockito for WorkerConfigTransformerTest

2022-06-13 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-13982: - Summary: Replace EasyMock and PowerMock with Mockito for WorkerConfigTransformerTest Key: KAFKA-13982 URL: https://issues.apache.org/jira/browse/KAFKA-13982 Project

[GitHub] [kafka] clolov commented on pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for Streams…

2022-06-13 Thread GitBox
clolov commented on PR #10881: URL: https://github.com/apache/kafka/pull/10881#issuecomment-1153680218 Hello @ijuma, @ableegoldman, @wycc! I have been working on trying to upgrade Kafka Streams from JUnit 4 to JUnit 5 and I was wondering what is the state of this pull request and all th

[jira] [Commented] (KAFKA-13414) Replace Powermock/EasyMock by Mockito in connect.storage package

2022-06-13 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553474#comment-17553474 ] Christo Lolov commented on KAFKA-13414: --- Hello [~mimaison]! I have resolved this i

[jira] [Resolved] (KAFKA-13414) Replace Powermock/EasyMock by Mockito in connect.storage package

2022-06-13 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-13414. --- Resolution: Fixed > Replace Powermock/EasyMock by Mockito in connect.storage package > -

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-7342 Part 1: Straightforward JUnit4 to JUnit5 migrations

2022-06-13 Thread GitBox
clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1153573803 Okay, I will work on 1 and 3, thank you for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Assigned] (KAFKA-7342) Migrate streams modules to JUnit 5

2022-06-13 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-7342: Assignee: Christo Lolov (was: Chia-Ping Tsai) > Migrate streams modules to JUnit 5 >