cadonna commented on PR #12325:
URL: https://github.com/apache/kafka/pull/12325#issuecomment-1162733434
Good call!
The mockito docs say:
> When using the inline mock maker, it is possible to mock static method
invocations within the current thread and a user-defined scope. This
dajac commented on code in PR #12329:
URL: https://github.com/apache/kafka/pull/12329#discussion_r903337001
##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -163,7 +162,7 @@ class DefaultAlterPartitionManager(
if (enqueued) {
maybePropagateIsrCh
dajac commented on PR #12329:
URL: https://github.com/apache/kafka/pull/12329#issuecomment-1162742639
@showuon Could you update the title to be inline with the Jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kobihikri commented on PR #12300:
URL: https://github.com/apache/kafka/pull/12300#issuecomment-1162747785
NP, I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
kobihikri closed pull request #12300: Update zookeeper version to 3.8.0
URL: https://github.com/apache/kafka/pull/12300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
cadonna commented on PR #12323:
URL: https://github.com/apache/kafka/pull/12323#issuecomment-1162753980
Good call!
The mockito docs say:
> When using the inline mock maker, it is possible to mock static method
invocations within the current thread and a user-defined scope. Th
cadonna commented on PR #12322:
URL: https://github.com/apache/kafka/pull/12322#issuecomment-1162770981
Good call!
The mockito docs say:
> When using the inline mock maker, it is possible to mock static method
invocations within the current thread and a user-defined scope. This
showuon commented on code in PR #12329:
URL: https://github.com/apache/kafka/pull/12329#discussion_r903406708
##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -163,7 +162,7 @@ class DefaultAlterPartitionManager(
if (enqueued) {
maybePropagateIsr
ashwinpankaj opened a new pull request, #12330:
URL: https://github.com/apache/kafka/pull/12330
https://cwiki.apache.org/confluence/display/KAFKA/KIP-850%3A+REST+API+for+filtering+Connector+plugins+by+type
### Committer Checklist (excluded from commit message)
- [ ] Verify design a
showuon commented on PR #12329:
URL: https://github.com/apache/kafka/pull/12329#issuecomment-1162782518
@dajac , thanks for your review! (I was going to ping you, though :)
I've addressed most of your comments. About adding tests in
`AlterPartitionManagerTest`, I thought about it, but I c
[
https://issues.apache.org/jira/browse/KAFKA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13930.
---
Resolution: Done
> Add 3.2.0 to broker/client and streams upgrade/compatibility tests
>
[
https://issues.apache.org/jira/browse/KAFKA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna closed KAFKA-13930.
-
> Add 3.2.0 to broker/client and streams upgrade/compatibility tests
> -
[
https://issues.apache.org/jira/browse/KAFKA-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass reopened KAFKA-6945:
> Add support to allow users to acquire delegation tokens for other users
> ---
[
https://issues.apache.org/jira/browse/KAFKA-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-6945:
---
Affects Version/s: 3.3.0
> Add support to allow users to acquire delegation tokens fo
divijvaidya commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r903557818
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -809,6 +810,13 @@ private void maybeCloseOldestConnection(long
currentTimeNanos) {
[
https://issues.apache.org/jira/browse/KAFKA-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557366#comment-17557366
]
Martin Pelak commented on KAFKA-7575:
-
Hi guys, [try this
patch|https://issues.apach
divijvaidya commented on code in PR #12224:
URL: https://github.com/apache/kafka/pull/12224#discussion_r903622295
##
metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java:
##
@@ -226,16 +227,19 @@ synchronized long tryAppend(int nodeId, int epoch,
List ba
divijvaidya commented on code in PR #12224:
URL: https://github.com/apache/kafka/pull/12224#discussion_r903622487
##
metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java:
##
@@ -723,9 +727,35 @@ public long scheduleAtomicAppend(int epoch,
List batch) {
@O
[
https://issues.apache.org/jira/browse/KAFKA-13950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-13950:
-
Fix Version/s: 3.3.0
3.3
> Resource leak at multiple places in the code
> ---
divijvaidya commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r903664991
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java:
##
@@ -326,7 +326,7 @@ static String formatRequestBody(S
vamossagar12 commented on PR #12309:
URL: https://github.com/apache/kafka/pull/12309#issuecomment-1163022795
Thanks @C0urante . How to get this PR merged though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
divijvaidya commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r90345
##
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java:
##
@@ -308,7 +308,7 @@ protected Record readNext(long baseOffset, long
baseTimestam
divijvaidya commented on code in PR #12229:
URL: https://github.com/apache/kafka/pull/12229#discussion_r903675795
##
clients/src/main/java/org/apache/kafka/common/protocol/types/CompactArrayOf.java:
##
@@ -119,7 +119,7 @@ public Object[] validate(Object item) {
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1163033464
@ijuma I have addressed your comments. This is ready for your review
(pending test run).
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
divijvaidya commented on code in PR #12230:
URL: https://github.com/apache/kafka/pull/12230#discussion_r903680274
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -463,8 +463,7 @@ public static T newParameterizedInstance(String
className, Object... para
MPeli opened a new pull request, #12331:
URL: https://github.com/apache/kafka/pull/12331
Hi,
I have come across [this
comment](https://issues.apache.org/jira/browse/KAFKA-2170?focusedCommentId=17477226&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1
dajac commented on code in PR #12328:
URL: https://github.com/apache/kafka/pull/12328#discussion_r903713010
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1125,13 +1125,11 @@ private Errors validateAlterPartitionData(
re
divijvaidya commented on code in PR #12230:
URL: https://github.com/apache/kafka/pull/12230#discussion_r903718578
##
clients/src/test/java/org/apache/kafka/common/KafkaFutureTest.java:
##
@@ -637,7 +637,12 @@ public void testLeakCompletableFuture() throws
NoSuchMethodException,
dajac commented on PR #12329:
URL: https://github.com/apache/kafka/pull/12329#issuecomment-1163096128
@showuon I think that we could write a test in `AlterPartitionManagerTest `
that does the following:
* submit an change for foo-0
* add a callback to the future which submit another ch
divijvaidya commented on code in PR #12281:
URL: https://github.com/apache/kafka/pull/12281#discussion_r903755896
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java:
##
@@ -222,14 +222,10 @@ protected PluginClassLoader newPlugi
fxbing opened a new pull request, #12333:
URL: https://github.com/apache/kafka/pull/12333
While setting `Defaults.LogMessageTimestampType` to `"LogAppendTime"`, this
error will throwed by
`LogCleanerManagerTest.testLogsUnderCleanupIneligibleForCompaction()`.
``` java
org.apache.kafka.
divijvaidya commented on code in PR #12331:
URL: https://github.com/apache/kafka/pull/12331#discussion_r903841247
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -461,14 +461,15 @@ private static FileChannel openChannel(File file,
divijvaidya commented on code in PR #12333:
URL: https://github.com/apache/kafka/pull/12333#discussion_r903878743
##
core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala:
##
@@ -341,12 +341,13 @@ class LogCleanerManagerTest extends Logging {
*/
@Test
def tes
[
https://issues.apache.org/jira/browse/KAFKA-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557525#comment-17557525
]
Matthew de Detrich commented on KAFKA-14014:
So interestingly I worked on an
[
https://issues.apache.org/jira/browse/KAFKA-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557525#comment-17557525
]
Matthew de Detrich edited comment on KAFKA-14014 at 6/22/22 3:29 PM:
-
vamossagar12 commented on code in PR #12321:
URL: https://github.com/apache/kafka/pull/12321#discussion_r904003072
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -241,6 +242,7 @@ protected AbstractWorkerSourceTask(Connector
vamossagar12 commented on PR #12321:
URL: https://github.com/apache/kafka/pull/12321#issuecomment-1163357345
> LGTM! (With some non-blocker suggestions)
>
> I wonder if there are some higher-level fixes we might also adopt that
would make NPEs from method references harder to write. S
[
https://issues.apache.org/jira/browse/KAFKA-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557564#comment-17557564
]
Matthew de Detrich commented on KAFKA-14014:
Okay so I just noticed the link
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557572#comment-17557572
]
Guozhang Wang commented on KAFKA-13840:
---
[~showuon] I read through the discussions
hachikuji commented on code in PR #12328:
URL: https://github.com/apache/kafka/pull/12328#discussion_r904038432
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1125,13 +1125,11 @@ private Errors validateAlterPartitionData(
[
https://issues.apache.org/jira/browse/KAFKA-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557576#comment-17557576
]
Guozhang Wang commented on KAFKA-12478:
---
Thanks [~hudeqi], I will take a look at t
mnegodaev commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1163436844
> I've marked this as needing a KIP, though I'm not yet sure whether that is
the case. These SMTs are technically part of the API, since they appear in STM
configurations, which are con
MPeli commented on code in PR #12331:
URL: https://github.com/apache/kafka/pull/12331#discussion_r904097378
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -461,14 +461,15 @@ private static FileChannel openChannel(File file,
C0urante commented on PR #12291:
URL: https://github.com/apache/kafka/pull/12291#issuecomment-1163466722
👍 sounds good, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
MPeli commented on code in PR #12331:
URL: https://github.com/apache/kafka/pull/12331#discussion_r904097378
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -461,14 +461,15 @@ private static FileChannel openChannel(File file,
hachikuji merged PR #12328:
URL: https://github.com/apache/kafka/pull/12328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
kirktrue commented on PR #12039:
URL: https://github.com/apache/kafka/pull/12039#issuecomment-1163610295
@dajac / @cadonna / @jsancio - any suggestions on a reviewer for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
scanterog commented on PR #8656:
URL: https://github.com/apache/kafka/pull/8656#issuecomment-1163643352
@Justinwins I worked around the issue by using mm2 as a connector on a
kafka-connect cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557759#comment-17557759
]
Luke Chen commented on KAFKA-13840:
---
Thanks [~guozhang] ! Make sense.
> KafkaConsumer
[
https://issues.apache.org/jira/browse/KAFKA-13715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13715:
--
Fix Version/s: (was: 3.3.0)
> Add "generation" field into consumer protocol
>
showuon commented on PR #12332:
URL: https://github.com/apache/kafka/pull/12332#issuecomment-1163839671
@vilmos , thanks for the PR. But I think the link to `powered-by` is a
correct link because it talks about how other users in our world-wide community
are getting value out of Kafka. What
fxbing commented on code in PR #12333:
URL: https://github.com/apache/kafka/pull/12333#discussion_r904456689
##
core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala:
##
@@ -341,12 +341,13 @@ class LogCleanerManagerTest extends Logging {
*/
@Test
def testLogs
showuon commented on PR #12329:
URL: https://github.com/apache/kafka/pull/12329#issuecomment-1163880185
@dajac , thanks for your suggestion. I've added a test:
`AlterPartitionManagerTest#testRetryOnPartitionLevelError`. Thanks.
--
This is an automated message from the Apache Git Service.
C0urante commented on code in PR #12320:
URL: https://github.com/apache/kafka/pull/12320#discussion_r904481428
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Justinwins commented on PR #8656:
URL: https://github.com/apache/kafka/pull/8656#issuecomment-1163893820
thank all. I work around by patching for now ,and will keep still observing
for more time
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-14014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557842#comment-17557842
]
Matthew de Detrich commented on KAFKA-14014:
So I ran the tests overnight wi
vilmos commented on PR #12332:
URL: https://github.com/apache/kafka/pull/12332#issuecomment-1164001862
@showuon: I wasn't paying enough attention of the context of this sentence.
The the text of the link is a bit _misleading_ if you click _before_ you read
the whole sentence but yes, the `p
57 matches
Mail list logo
