showuon commented on PR #12326:
URL: https://github.com/apache/kafka/pull/12326#issuecomment-1166175055
This PR: https://github.com/apache/kafka/pull/12334 already addressed this
issue, and not only `no-op` record type, there are also other types handler
missing. FYI
--
This is an
[
https://issues.apache.org/jira/browse/KAFKA-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justinwins reassigned KAFKA-13856:
--
Assignee: Justinwins
> MirrorCheckpointTask meets ConcurrentModificationException
>
Chris Egerton created KAFKA-14021:
-
Summary: MirrorMaker 2 should implement KIP-618 APIs
Key: KAFKA-14021
URL: https://issues.apache.org/jira/browse/KAFKA-14021
Project: Kafka
Issue Type:
guozhangwang commented on code in PR #12204:
URL: https://github.com/apache/kafka/pull/12204#discussion_r906425650
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java:
##
@@ -148,55 +173,184 @@ public void process(final Record
hachikuji commented on code in PR #12345:
URL: https://github.com/apache/kafka/pull/12345#discussion_r906510006
##
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala:
##
@@ -18,42 +18,41 @@
package kafka.server
import scala.collection.Seq
-
-import
ahuang98 opened a new pull request, #12345:
URL: https://github.com/apache/kafka/pull/12345
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
C0urante commented on code in PR #12320:
URL: https://github.com/apache/kafka/pull/12320#discussion_r906416230
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation
John Roesler created KAFKA-14020:
Summary: Performance regression in Producer
Key: KAFKA-14020
URL: https://issues.apache.org/jira/browse/KAFKA-14020
Project: Kafka
Issue Type: Bug
vvcephei commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165842337
Hey @jolshan , let me share those details with you offline. I would like to
publish the benchmarks at some point, but now is not the time.
--
This is an automated message from the
guozhangwang commented on code in PR #12337:
URL: https://github.com/apache/kafka/pull/12337#discussion_r906313287
##
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java:
##
@@ -34,7 +34,7 @@ public class ListConsumerGroupOffsetsResult {
vvcephei commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165841554
Thanks, all. If we can simply set the default back to the old behavior, then
I agree it's nicer than reverting.
Also, of course, I have no intention of hitting "merge" unless we
artemlivshits commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165838742
I'm out of office till the end of the week, I can take a look next week.
Instead of revert, can we consider setting
jolshan commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165828269
Can we also share more details about the benchmark that was run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
YiDing-Duke commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165811246
@artemlivshits can you review this revert when get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ijuma commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165807769
@vvcephei @guozhangwang Please hold off reverting this until we have had a
chance to review.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jolshan commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165801074
I'm a little confused by the results here.
> Results:
Commit:
https://github.com/apache/kafka/commit/e3202b9ef4c63aab2e5ab049978704282792
(the parent of the problematic
guozhangwang commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165789457
Thanks @vvcephei , I agree it's better to first revert and then re-introduce
the feature after we got the root cause of the perf regression.
--
This is an automated message from
guozhangwang commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165789978
Made a pass on just my PR regarding the streams partitioner, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
guozhangwang commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r906262638
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -603,6 +629,67 @@ public void
guozhangwang opened a new pull request, #12344:
URL: https://github.com/apache/kafka/pull/12344
1. For most tests we would need an auto-ticking mock timer to work with
draining-with-timeout functions.
2. For tests that check for never checkpoint we need no auto-ticking timer
to control
jonathan-albrecht-ibm opened a new pull request, #12343:
URL: https://github.com/apache/kafka/pull/12343
The IBM Semeru JDK use the OpenJDK security providers instead of the IBM
security providers so test for the OpenJDK classes first where possible
and test for Semeru in the
vvcephei commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165770584
Also cc @guozhangwang , @ableegoldman , @bbejeck : I had to partially revert
some of your changes that had been based on top of the problematic commit. I'm
not sure whether you'll want
vvcephei commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165768336
Pinging @artemlivshits and @junrao for reviews of this revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vvcephei commented on PR #12342:
URL: https://github.com/apache/kafka/pull/12342#issuecomment-1165767443
There is already a new conflict, which seems to support the argument to
revert as soon as possible. I'll rebase and update this PR.
--
This is an automated message from the Apache Git
vvcephei opened a new pull request, #12342:
URL: https://github.com/apache/kafka/pull/12342
Benchmarking indicates that #12049 was responsible for a 10% performance
regression in the Producer. We are not sure why, but reverting the commit shows
a return to nominal performance, so there is
dajac commented on PR #12308:
URL: https://github.com/apache/kafka/pull/12308#issuecomment-1165757819
@Stephan14 I will review it next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Chia-Ping Tsai created KAFKA-14019:
--
Summary: removeMembersFromConsumerGroup can't delete all members
when there is no members already
Key: KAFKA-14019
URL: https://issues.apache.org/jira/browse/KAFKA-14019
guozhangwang merged PR #12312:
URL: https://github.com/apache/kafka/pull/12312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on code in PR #12312:
URL: https://github.com/apache/kafka/pull/12312#discussion_r906222088
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -86,7 +88,7 @@ public Collection getUpdatingStandbyTasks() {
tang7526 commented on PR #12139:
URL: https://github.com/apache/kafka/pull/12139#issuecomment-1165646326
@chia7712 Could you help to review this PR? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on code in PR #12339:
URL: https://github.com/apache/kafka/pull/12339#discussion_r906090123
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3742,7 +3743,8 @@ private List getMembersFromGroup(String
groupId, String
chia7712 closed pull request #12339: MINOR: set UNKNOWN_MEMBER_ID explicitly
when deleting group instance id
URL: https://github.com/apache/kafka/pull/12339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dajac commented on code in PR #12339:
URL: https://github.com/apache/kafka/pull/12339#discussion_r906064565
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3742,7 +3743,8 @@ private List getMembersFromGroup(String
groupId, String reason)
cadonna commented on code in PR #12289:
URL: https://github.com/apache/kafka/pull/12289#discussion_r906002582
##
streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java:
##
@@ -210,39 +213,33 @@ public void
showuon commented on code in PR #12329:
URL: https://github.com/apache/kafka/pull/12329#discussion_r905995359
##
core/src/test/scala/unit/kafka/server/AlterPartitionManagerTest.scala:
##
@@ -178,6 +178,46 @@ class AlterPartitionManagerTest {
showuon commented on PR #12329:
URL: https://github.com/apache/kafka/pull/12329#issuecomment-1165506731
@dajac , thanks for the comments. I've updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on code in PR #12329:
URL: https://github.com/apache/kafka/pull/12329#discussion_r905995359
##
core/src/test/scala/unit/kafka/server/AlterPartitionManagerTest.scala:
##
@@ -178,6 +178,46 @@ class AlterPartitionManagerTest {
cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r905991389
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -603,6 +629,67 @@ public void
elkkhan commented on code in PR #12320:
URL: https://github.com/apache/kafka/pull/12320#discussion_r905988489
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation
kobihikri commented on PR #6329:
URL: https://github.com/apache/kafka/pull/6329#issuecomment-1165494929
Hi,
Yes, it seems like the same issue.
This fix was never adopted / promoted by the community, unfortunately.
A PR I’ve made in the past for resolving the issue wasn’t
andreapicaro commented on PR #6329:
URL: https://github.com/apache/kafka/pull/6329#issuecomment-1165434718
Hello,
I understand this is a very old topic, but, just to understand,
I'm testing Kafka 3.2.0 on Windows and is crashing due to log retention not
being able to rename old index
cadonna merged PR #12341:
URL: https://github.com/apache/kafka/pull/12341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12341:
URL: https://github.com/apache/kafka/pull/12341#issuecomment-1165429277
Since the change was limited to a unit test and all unit test passed for ARM
and PowerPC I going to merge this PR before the other builds terminate to fix
broken trunk.
--
This is an
dajac merged PR #12335:
URL: https://github.com/apache/kafka/pull/12335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #12337:
URL: https://github.com/apache/kafka/pull/12337#discussion_r905896743
##
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java:
##
@@ -34,7 +34,7 @@ public class ListConsumerGroupOffsetsResult {
cadonna opened a new pull request, #12341:
URL: https://github.com/apache/kafka/pull/12341
The mocks were not setup correctly in StreamTask#shouldCheckpointState
which caused a null pointer exception during test execution.
### Committer Checklist (excluded from commit message)
-
gddsop opened a new pull request, #12340:
URL: https://github.com/apache/kafka/pull/12340
Hi, my first PR.
Our partner changed the encryption algorithm of the p12 certificate from
SHA1 to SHA256 for some reason. As a result, Kafka reported a connection error
due to the wrong
gdd sop created KAFKA-14018:
---
Summary: Kafka SSL can't support p12 certificate using sha256 on
jdk8
Key: KAFKA-14018
URL: https://issues.apache.org/jira/browse/KAFKA-14018
Project: Kafka
Issue
dengziming commented on code in PR #12315:
URL: https://github.com/apache/kafka/pull/12315#discussion_r905758022
##
core/src/main/scala/kafka/tools/MetadataShellTool.scala:
##
@@ -0,0 +1,199 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/KAFKA-13936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558339#comment-17558339
]
Prashanth Joseph Babu commented on KAFKA-13936:
---
[~mjsax] I looked into the doc section
50 matches
Mail list logo
