[GitHub] [kafka] cmccabe merged pull request #12447: KAFKA-14124: improve quorum controller fault handling

2022-08-04 Thread GitBox
cmccabe merged PR #12447: URL: https://github.com/apache/kafka/pull/12447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] premkamal23 closed pull request #12481: Kafka 14115

2022-08-04 Thread GitBox
premkamal23 closed pull request #12481: Kafka 14115 URL: https://github.com/apache/kafka/pull/12481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] premkamal23 commented on pull request #12481: Kafka 14115

2022-08-04 Thread GitBox
premkamal23 commented on PR #12481: URL: https://github.com/apache/kafka/pull/12481#issuecomment-1206068753 Fix has been merged : https://github.com/apache/kafka/pull/12483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-14133) Remaining EasyMock to Mockito tests

2022-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575558#comment-17575558 ] Christo Lolov commented on KAFKA-14133: --- I provided an answer in

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575556#comment-17575556 ] Christo Lolov commented on KAFKA-14132: --- The ticket itself isn't looking for an owner as Divij and

[GitHub] [kafka] ashwinpankaj commented on a diff in pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so that fresh new producerBatch is created

2022-08-04 Thread GitBox
ashwinpankaj commented on code in PR #12462: URL: https://github.com/apache/kafka/pull/12462#discussion_r938422637 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -394,13 +397,15 @@ private RecordAppendResult tryAppend(long

[jira] [Updated] (KAFKA-14144) AlterPartition is not idempotent when requests time out

2022-08-04 Thread David Mao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao updated KAFKA-14144: -- Affects Version/s: 3.3.0 > AlterPartition is not idempotent when requests time out >

[jira] [Created] (KAFKA-14144) AlterPartition is not idempotent when requests time out

2022-08-04 Thread David Mao (Jira)
David Mao created KAFKA-14144: - Summary: AlterPartition is not idempotent when requests time out Key: KAFKA-14144 URL: https://issues.apache.org/jira/browse/KAFKA-14144 Project: Kafka Issue

[GitHub] [kafka] AlanConfluent commented on a diff in pull request #12458: MINOR: Adds KRaft versions of most streams system tests

2022-08-04 Thread GitBox
AlanConfluent commented on code in PR #12458: URL: https://github.com/apache/kafka/pull/12458#discussion_r938317255 ## tests/kafkatest/tests/streams/streams_broker_bounce_test.py: ## @@ -205,11 +212,17 @@ def collect_results(self, sleep_time_secs): return data

[GitHub] [kafka] AlanConfluent commented on pull request #12458: MINOR: Adds KRaft versions of most streams system tests

2022-08-04 Thread GitBox
AlanConfluent commented on PR #12458: URL: https://github.com/apache/kafka/pull/12458#issuecomment-1205864412 > Thanks @AlanConfluent ! A few meta questions: > > 1. Seems the `streams_cooperative_rebalance_upgrade_test.py` is not included in this PR? I didn't update any of the

[GitHub] [kafka] AlanConfluent commented on pull request #12458: MINOR: Adds KRaft versions of most streams system tests

2022-08-04 Thread GitBox
AlanConfluent commented on PR #12458: URL: https://github.com/apache/kafka/pull/12458#issuecomment-1205861035 > > In addition to addressing the review comments, can you post a link to the system test results with this change? It would be good to verify the impact before merging. > >

[jira] [Resolved] (KAFKA-14136) AlterConfigs in KRaft does not generate records for unchanged values

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14136. -- Resolution: Fixed > AlterConfigs in KRaft does not generate records for unchanged values >

[jira] [Updated] (KAFKA-14111) Dynamic config update fails for "password" configs in KRaft

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14111: - Fix Version/s: 3.2.2 > Dynamic config update fails for "password" configs in KRaft >

[jira] [Commented] (KAFKA-14115) Password configs are logged in plaintext in KRaft

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575446#comment-17575446 ] David Arthur commented on KAFKA-14115: -- Fixed as part of KAFKA-14136 > Password configs are logged

[jira] [Resolved] (KAFKA-14115) Password configs are logged in plaintext in KRaft

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14115. -- Assignee: David Arthur (was: Prem Kamal) Resolution: Fixed > Password configs are

[jira] [Commented] (KAFKA-14133) Remaining EasyMock to Mockito tests

2022-08-04 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575435#comment-17575435 ] Matthew de Detrich commented on KAFKA-14133: [~divijvaidya] [~christo_lolov] As per the

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-08-04 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575434#comment-17575434 ] Matthew de Detrich commented on KAFKA-14132: [~divijvaidya] [~christo_lolov] As per the

[jira] [Updated] (KAFKA-14115) Password configs are logged in plaintext in KRaft

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14115: - Component/s: kraft > Password configs are logged in plaintext in KRaft >

[jira] [Updated] (KAFKA-14136) AlterConfigs in KRaft does not generate records for unchanged values

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14136: - Component/s: kraft > AlterConfigs in KRaft does not generate records for unchanged values >

[jira] [Updated] (KAFKA-14136) AlterConfigs in KRaft does not generate records for unchanged values

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14136: - Fix Version/s: 3.2.2 > AlterConfigs in KRaft does not generate records for unchanged values >

[jira] [Updated] (KAFKA-14115) Password configs are logged in plaintext in KRaft

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14115: - Fix Version/s: 3.2.2 > Password configs are logged in plaintext in KRaft >

[GitHub] [kafka] mumrah merged pull request #12483: KAFKA-14136 Generate ConfigRecord even if the value is unchanged

2022-08-04 Thread GitBox
mumrah merged PR #12483: URL: https://github.com/apache/kafka/pull/12483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (KAFKA-14131) KafkaBasedLog#readToLogEnd() may accciedently falls into infinite loop

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575390#comment-17575390 ] Sagar Rao edited comment on KAFKA-14131 at 8/4/22 6:20 PM: --- [~Justinwins] i

[GitHub] [kafka] jsancio commented on a diff in pull request #12457: KAFKA-14104: Add CRC validation when iterating over Metadata Log Records

2022-08-04 Thread GitBox
jsancio commented on code in PR #12457: URL: https://github.com/apache/kafka/pull/12457#discussion_r938103850 ## raft/src/main/java/org/apache/kafka/raft/internals/RecordsIterator.java: ## @@ -179,7 +184,12 @@ private Optional> nextBatch() { return Optional.empty();

[jira] [Commented] (KAFKA-14131) KafkaBasedLog#readToLogEnd() may accciedently falls into infinite loop

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575390#comment-17575390 ] Sagar Rao commented on KAFKA-14131: --- [~Justinwins] i created a PR here =>

[GitHub] [kafka] vamossagar12 opened a new pull request, #12485: KAFKA-14131: Adding InterruptException when reading to end of Offseto…

2022-08-04 Thread GitBox
vamossagar12 opened a new pull request, #12485: URL: https://github.com/apache/kafka/pull/12485 When a herder starts ,its KafkaOffsetBackingStore will readToLogEnd() by DistributedHerder.herderExecutor of name "Distrubuted-connect-" thread , e.g . Distrubuted-connect-28-1 , which

[jira] [Assigned] (KAFKA-13888) KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

2022-08-04 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel reassigned KAFKA-13888: -- Assignee: Niket Goel (was: lqjacklee) > KIP-836: Addition of Information in

[jira] [Resolved] (KAFKA-13313) In KRaft mode, CreateTopic should return the topic configs in the response

2022-08-04 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-13313. -- Resolution: Duplicate > In KRaft mode, CreateTopic should return the topic configs in the

[jira] [Updated] (KAFKA-14114) KIP-859: Add Metadata Log Processing Error Related Metrics

2022-08-04 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel updated KAFKA-14114: --- Fix Version/s: 3.3.0 (was: 3.3) > KIP-859: Add Metadata Log Processing Error

[jira] [Updated] (KAFKA-14104) Perform CRC validation on KRaft Batch Records and Snapshots

2022-08-04 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel updated KAFKA-14104: --- Fix Version/s: 3.3.0 (was: 3.3) > Perform CRC validation on KRaft Batch

[jira] [Commented] (KAFKA-14118) Generate and persist storage uuiid

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575366#comment-17575366 ] Sagar Rao commented on KAFKA-14118: --- [~jsancio] i assigned this to myself, but I figured this is part

[jira] [Assigned] (KAFKA-14118) Generate and persist storage uuiid

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14118: - Assignee: (was: Sagar Rao) > Generate and persist storage uuiid >

[GitHub] [kafka] divijvaidya commented on pull request #12472: KAFKA-14134: Replace EasyMock with Mockito for WorkerConnectorTest

2022-08-04 Thread GitBox
divijvaidya commented on PR #12472: URL: https://github.com/apache/kafka/pull/12472#issuecomment-1205526845 Looks good from my side! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ashmeet13 commented on pull request #12414: KAFKA-14073 Logging the reason for Snapshot

2022-08-04 Thread GitBox
ashmeet13 commented on PR #12414: URL: https://github.com/apache/kafka/pull/12414#issuecomment-1205525598 Thanks @jsancio, this is helpful. I'll go ahead and make these changes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

2022-08-04 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575364#comment-17575364 ] Jose Armando Garcia Sancio commented on KAFKA-12473: Discussed this KIP and issue

[jira] [Updated] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

2022-08-04 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12473: --- Fix Version/s: 3.4.0 (was: 3.3.0) > Make the

[GitHub] [kafka] divijvaidya opened a new pull request, #12484: KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest.java

2022-08-04 Thread GitBox
divijvaidya opened a new pull request, #12484: URL: https://github.com/apache/kafka/pull/12484 This PR is created on top of https://github.com/apache/kafka/pull/10904 and includes commits from original author for attribution. ## Testing 1. `./gradlew connect:runtime:unitTest

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575362#comment-17575362 ] Sagar Rao commented on KAFKA-12495: --- [~ChrisEgerton] You summed it up correctly. Regarding #1, you are

[jira] [Assigned] (KAFKA-13060) Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest.java

2022-08-04 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-13060: Assignee: Divij Vaidya (was: Chun-Hao Tang) > Replace EasyMock and PowerMock with

[GitHub] [kafka] jsancio commented on pull request #12414: KAFKA-14073 Logging the reason for Snapshot

2022-08-04 Thread GitBox
jsancio commented on PR #12414: URL: https://github.com/apache/kafka/pull/12414#issuecomment-1205508037 Thanks for the changes @ashmeet13 they look good in general. > 1. How do we handle multiple reasons for starting a snapshot in an enum? Instead of using

[GitHub] [kafka] yashmayya commented on a diff in pull request #12450: KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors

2022-08-04 Thread GitBox
yashmayya commented on code in PR #12450: URL: https://github.com/apache/kafka/pull/12450#discussion_r938025993 ## docs/connect.html: ## @@ -423,9 +422,7 @@ Connector @Override public void start(MapString, String props) { -// The complete version includes error

[GitHub] [kafka] jsancio commented on a diff in pull request #12457: KAFKA-14104: Add CRC validation when iterating over Metadata Log Records

2022-08-04 Thread GitBox
jsancio commented on code in PR #12457: URL: https://github.com/apache/kafka/pull/12457#discussion_r938007440 ## raft/src/test/java/org/apache/kafka/raft/internals/RecordsIteratorTest.java: ## @@ -110,6 +114,15 @@ public void testCrcValidation( // Verify check does not

[GitHub] [kafka] yashmayya commented on a diff in pull request #12450: KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors

2022-08-04 Thread GitBox
yashmayya commented on code in PR #12450: URL: https://github.com/apache/kafka/pull/12450#discussion_r938000827 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -16,40 +16,35 @@ */ package org.apache.kafka.connect.file;

[jira] [Resolved] (KAFKA-10000) Atomic commit of source connector records and offsets

2022-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-1. --- Resolution: Done > Atomic commit of source connector records and offsets >

[jira] [Resolved] (KAFKA-6080) Transactional EoS for source connectors

2022-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-6080. -- Fix Version/s: 3.3.0 Resolution: Fixed > Transactional EoS for source connectors >

[jira] [Commented] (KAFKA-10000) Atomic commit of source connector records and offsets

2022-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575322#comment-17575322 ] Chris Egerton commented on KAFKA-1: --- Done. Filed

[jira] [Created] (KAFKA-14143) Exactly-once source system tests

2022-08-04 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-14143: - Summary: Exactly-once source system tests Key: KAFKA-14143 URL: https://issues.apache.org/jira/browse/KAFKA-14143 Project: Kafka Issue Type: Task

[jira] [Created] (KAFKA-14142) Improve information returned about the cluster metadata partition

2022-08-04 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-14142: -- Summary: Improve information returned about the cluster metadata partition Key: KAFKA-14142 URL: https://issues.apache.org/jira/browse/KAFKA-14142

[GitHub] [kafka] C0urante commented on a diff in pull request #12450: KAFKA-13809: Propagate full connector configuration to tasks in FileStream connectors

2022-08-04 Thread GitBox
C0urante commented on code in PR #12450: URL: https://github.com/apache/kafka/pull/12450#discussion_r936225081 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -16,40 +16,35 @@ */ package org.apache.kafka.connect.file;

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12480: MINOR: Small cleanups in integration.kafka tests

2022-08-04 Thread GitBox
divijvaidya commented on code in PR #12480: URL: https://github.com/apache/kafka/pull/12480#discussion_r937932086 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -217,7 +213,7 @@ class DynamicBrokerReconfigurationTest extends

[GitHub] [kafka] divijvaidya commented on pull request #12229: MINOR: Include the inner exception stack trace when re-throwing an exception

2022-08-04 Thread GitBox
divijvaidya commented on PR #12229: URL: https://github.com/apache/kafka/pull/12229#issuecomment-1205402792 @tombentley requesting code review bandwidth from you here. We already have 3 non-committer approvals on this one. -- This is an automated message from the Apache Git Service. To

[jira] [Assigned] (KAFKA-14077) KRaft should support recovery from failed disk

2022-08-04 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-14077: -- Assignee: Jose Armando Garcia Sancio > KRaft should support

[jira] [Updated] (KAFKA-14077) KRaft should support recovery from failed disk

2022-08-04 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14077: --- Fix Version/s: 3.4.0 (was: 3.3.0) > KRaft

[GitHub] [kafka] divijvaidya commented on pull request #12230: MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

2022-08-04 Thread GitBox
divijvaidya commented on PR #12230: URL: https://github.com/apache/kafka/pull/12230#issuecomment-1205399727 @showuon requesting for your code review time on this one. We already have two approvals from non-committers. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-14140) Ensure a fenced or in-controlled-shutdown replica is not eligible to become leader in ZK mode

2022-08-04 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14140: --- Priority: Blocker (was: Major) > Ensure a fenced or in-controlled-shutdown replica is not

[jira] [Created] (KAFKA-14141) Unable to abort a stale transaction

2022-08-04 Thread Yordan Pavlov (Jira)
Yordan Pavlov created KAFKA-14141: - Summary: Unable to abort a stale transaction Key: KAFKA-14141 URL: https://issues.apache.org/jira/browse/KAFKA-14141 Project: Kafka Issue Type: Bug

[jira] [Assigned] (KAFKA-14126) Convert remaining DynamicBrokerReconfigurationTest tests to KRaft

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14126: - Assignee: David Arthur (was: Sagar Rao) > Convert remaining DynamicBrokerReconfigurationTest

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-08-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575299#comment-17575299 ] Chris Egerton commented on KAFKA-12495: --- [~sagarrao] it seems like there are two ideas at play

[jira] [Commented] (KAFKA-14126) Convert remaining DynamicBrokerReconfigurationTest tests to KRaft

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575295#comment-17575295 ] Sagar Rao commented on KAFKA-14126: --- Hey . I saw it was unassigned so assigned it to myself. If it’s

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14132: -- Description: {color:#DE350B}Some of the tests below use EasyMock as well. For those migrate

[jira] [Commented] (KAFKA-14126) Convert remaining DynamicBrokerReconfigurationTest tests to KRaft

2022-08-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575278#comment-17575278 ] David Arthur commented on KAFKA-14126: -- [~sagarrao], just a heads up, I have converted some of the

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

2022-08-04 Thread GitBox
clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r937576532 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -103,36 +103,57 @@ public class KafkaOffsetBackingStoreTest {

[jira] [Commented] (KAFKA-13813) left/outer joins can wait indefinitely for emitted record with spurious record fix

2022-08-04 Thread Tim te Beek (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575268#comment-17575268 ] Tim te Beek commented on KAFKA-13813: - I guess we're running into this issue with a simplified use

[jira] [Commented] (KAFKA-14138) The Exception Throwing Behavior of Transactional Producer is Inconsistent

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575246#comment-17575246 ] Sagar Rao commented on KAFKA-14138: --- [~guozhang] , I did some analysis. From what I understood,

[jira] [Assigned] (KAFKA-14138) The Exception Throwing Behavior of Transactional Producer is Inconsistent

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14138: - Assignee: Sagar Rao > The Exception Throwing Behavior of Transactional Producer is

[jira] [Assigned] (KAFKA-14118) Generate and persist storage uuiid

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14118: - Assignee: Sagar Rao > Generate and persist storage uuiid > --

[jira] [Assigned] (KAFKA-14121) AlterPartitionReassignments API should allow callers to specify the option of preserving the replication factor

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14121: - Assignee: Sagar Rao > AlterPartitionReassignments API should allow callers to specify the

[jira] [Assigned] (KAFKA-14131) KafkaBasedLog#readToLogEnd() may accciedently falls into infinite loop

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14131: - Assignee: Sagar Rao > KafkaBasedLog#readToLogEnd() may accciedently falls into infinite loop >

[jira] [Assigned] (KAFKA-14091) Suddenly-killed tasks can leave hanging transactions open

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14091: - Assignee: Sagar Rao > Suddenly-killed tasks can leave hanging transactions open >

[jira] [Commented] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-08-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575189#comment-17575189 ] Luke Chen commented on KAFKA-13840: --- I should make it clear, I tested with the reproducer in

[jira] [Commented] (KAFKA-13840) KafkaConsumer is unable to recover connection to group coordinator after commitOffsetsAsync exception

2022-08-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575186#comment-17575186 ] Luke Chen commented on KAFKA-13840: --- [~kyle.stehbens] , I've tested with Kafka 3.2.1 and it works

[jira] [Assigned] (KAFKA-14126) Convert remaining DynamicBrokerReconfigurationTest tests to KRaft

2022-08-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14126: - Assignee: Sagar Rao > Convert remaining DynamicBrokerReconfigurationTest tests to KRaft >

[GitHub] [kafka] dengziming commented on pull request #12103: KAFKA-13850: Show missing record type in MetadataShell

2022-08-04 Thread GitBox
dengziming commented on PR #12103: URL: https://github.com/apache/kafka/pull/12103#issuecomment-1205027275 ping @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-08-04 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14132: -- Description: {color:#DE350B}Some of the tests below use EasyMock as well. For those migrate

[GitHub] [kafka] clolov commented on pull request #12480: MINOR: Small cleanups in integration.kafka tests

2022-08-04 Thread GitBox
clolov commented on PR #12480: URL: https://github.com/apache/kafka/pull/12480#issuecomment-1204980467 Looks great!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (KAFKA-13941) Re-enable ARM builds following INFRA-23305

2022-08-04 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575121#comment-17575121 ] Divij Vaidya edited comment on KAFKA-13941 at 8/4/22 8:41 AM: -- [~mumrah]

[jira] [Commented] (KAFKA-13941) Re-enable ARM builds following INFRA-23305

2022-08-04 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17575121#comment-17575121 ] Divij Vaidya commented on KAFKA-13941: -- [~mumrah] ARM build have been timing out consistently

[GitHub] [kafka] divijvaidya commented on pull request #12473: KAFKA-13133: Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2022-08-04 Thread GitBox
divijvaidya commented on PR #12473: URL: https://github.com/apache/kafka/pull/12473#issuecomment-1204943631 @C0urante this is ready for your review when you get some time. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12281: KAFKA-13971: Fix atomicity violations caused by improper usage of ConcurrentHashMap - part2

2022-08-04 Thread GitBox
divijvaidya commented on code in PR #12281: URL: https://github.com/apache/kafka/pull/12281#discussion_r937504331 ## streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecordingTrigger.java: ## @@ -32,12 +32,12 @@ public

[GitHub] [kafka] divijvaidya closed pull request #12281: KAFKA-13971: Fix atomicity violations caused by improper usage of ConcurrentHashMap - part2

2022-08-04 Thread GitBox
divijvaidya closed pull request #12281: KAFKA-13971: Fix atomicity violations caused by improper usage of ConcurrentHashMap - part2 URL: https://github.com/apache/kafka/pull/12281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mimaison commented on pull request #11929: MINOR: s390x Stage

2022-08-04 Thread GitBox
mimaison commented on PR #11929: URL: https://github.com/apache/kafka/pull/11929#issuecomment-1204931663 We've had issues with the ARM and PowerPC builds. See https://lists.apache.org/thread/opk7o1tn7m0vzyqzhzkvgpf4xwst4qm6 So holding off merging this until we decide what to do with

[GitHub] [kafka] stanislavkozlovski commented on a diff in pull request #12179: [KAFKA-13848] Clients remain connected after SASL re-authentication f…

2022-08-04 Thread GitBox
stanislavkozlovski commented on code in PR #12179: URL: https://github.com/apache/kafka/pull/12179#discussion_r937463263 ## build.gradle: ## @@ -1243,7 +1243,7 @@ project(':clients') { testImplementation libs.bcpkix testImplementation libs.junitJupiter -