showuon commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r952117995
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -63,20 +76,26 @@ public boolean equals(Object o) {
if (this == o) return true;
yashmayya commented on code in PR #12502:
URL: https://github.com/apache/kafka/pull/12502#discussion_r952177573
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/MaskFieldTest.java:
##
@@ -250,4 +250,22 @@ public void testReplacementTypeMismatch() {
pu
mnegodaev commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1223577752
> @pjmagee I commented in the discuss thread last week, see
https://lists.apache.org/thread/92y0qqlwb75xqkxnzwbw7jywfdw8gs8k. Can you reply
to my question there?
I've fixed this
dplavcic commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r952160010
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
shouldThrowIfDbToAddW
jsancio commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r952058593
##
clients/src/main/resources/common/message/DescribeQuorumResponse.json:
##
@@ -38,7 +38,9 @@
"about": "The latest known leader epoch"},
{ "name": "
hachikuji commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r952055798
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -167,8 +167,18 @@ public enum MetadataVersion {
public static fina
hachikuji commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r952030392
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
hachikuji opened a new pull request, #12548:
URL: https://github.com/apache/kafka/pull/12548
For debugging, it is useful to know not only the current raft high
watermark, but also when it was updated. This gives an operator an easy way to
tell whether the quorum is healthy through commit pr
cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r951937315
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -229,6 +243,12 @@ private ApiError updateMetadataVersion(
return inv
mumrah commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r951824786
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -229,6 +243,12 @@ private ApiError updateMetadataVersion(
return inva
mumrah commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r951824786
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -229,6 +243,12 @@ private ApiError updateMetadataVersion(
return inva
guozhangwang merged PR #12547:
URL: https://github.com/apache/kafka/pull/12547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on PR #12547:
URL: https://github.com/apache/kafka/pull/12547#issuecomment-1222779068
Jenkins failures are not relevant. I'm merging to trunk now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-13911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-13911.
Reviewer: Ismael Juma
Resolution: Fixed
Closing as it was me
[
https://issues.apache.org/jira/browse/KAFKA-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-13410.
--
Resolution: Fixed
The unfinished tasks from this issue were moved to KAFKA-14175
> KRaft Upgr
[
https://issues.apache.org/jira/browse/KAFKA-13935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-13935.
--
Assignee: David Arthur
Resolution: Fixed
> Factor out static IBP usages from broker
> --
mimaison merged PR #12509:
URL: https://github.com/apache/kafka/pull/12509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-13956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13956:
-
Parent Issue: KAFKA-14175 (was: KAFKA-13410)
> kafka-storage should accept a release version
>
[
https://issues.apache.org/jira/browse/KAFKA-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13912:
-
Parent Issue: KAFKA-14175 (was: KAFKA-13410)
> Generate metadata snapshot prior to metadata.ver
[
https://issues.apache.org/jira/browse/KAFKA-14175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-14175:
-
Issue Type: New Feature (was: Bug)
> KRaft Upgrades Part 2
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-13896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13896:
-
Parent Issue: KAFKA-14175 (was: KAFKA-13410)
> Support unsafe downgrades in KRaft
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-13156:
-
Assignee: Chris Egerton (was: Nigel Liang)
> KafkaStatusBackingStore making incorrect
David Arthur created KAFKA-14175:
Summary: KRaft Upgrades Part 2
Key: KAFKA-14175
URL: https://issues.apache.org/jira/browse/KAFKA-14175
Project: Kafka
Issue Type: Bug
Reporter: D
Jose Armando Garcia Sancio created KAFKA-14174:
--
Summary: Documentation for KRaft
Key: KAFKA-14174
URL: https://issues.apache.org/jira/browse/KAFKA-14174
Project: Kafka
Issue Typ
C0urante commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r951657274
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {
[
https://issues.apache.org/jira/browse/KAFKA-13166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583117#comment-17583117
]
Jason Gustafson edited comment on KAFKA-13166 at 8/22/22 5:42 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583117#comment-17583117
]
Jason Gustafson commented on KAFKA-13166:
-
I am going to resolve this jira. Ther
[
https://issues.apache.org/jira/browse/KAFKA-13166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-13166:
Fix Version/s: (was: 3.4.0)
> EOFException when Controller handles unknown API
> -
[
https://issues.apache.org/jira/browse/KAFKA-13166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13166.
-
Resolution: Fixed
> EOFException when Controller handles unknown API
> -
mimaison commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1222635310
@pjmagee I commented in the discuss thread last week, see
https://lists.apache.org/thread/92y0qqlwb75xqkxnzwbw7jywfdw8gs8k. Can you reply
to my question there?
--
This is an automated
C0urante commented on PR #12473:
URL: https://github.com/apache/kafka/pull/12473#issuecomment-1222533204
Since this is already receiving attention, I'll redirect my focus to other
PRs that haven't gotten anything yet for now.
@mimaison Please LMK if you'd like me to lend a hand on thi
C0urante commented on code in PR #12502:
URL: https://github.com/apache/kafka/pull/12502#discussion_r951590758
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/MaskFieldTest.java:
##
@@ -250,4 +250,22 @@ public void testReplacementTypeMismatch() {
pub
pjmagee commented on PR #11442:
URL: https://github.com/apache/kafka/pull/11442#issuecomment-1222517478
Hi @hachikuji Sorry to pull you in on this PR - I notice you have been
active on some merged PR's quite recently. We have had some input from others
regarding the process around creating
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r951536188
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
shouldThrowIfDbToA
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r951535914
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
shouldThrowIfDbToA
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r951511866
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
shouldThrowIfDbToA
C0urante merged PR #12490:
URL: https://github.com/apache/kafka/pull/12490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582972#comment-17582972
]
Sagar Rao commented on KAFKA-14000:
---
I took a look at this today. Looking at the trace
[
https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582899#comment-17582899
]
Yash Mayya edited comment on KAFKA-13431 at 8/22/22 12:16 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582899#comment-17582899
]
Yash Mayya edited comment on KAFKA-13431 at 8/22/22 12:15 PM:
mdedetrich commented on PR #12475:
URL: https://github.com/apache/kafka/pull/12475#issuecomment-158165
Actually lets wait on merging this PR, it may be possible to fix the
underlying problem in spotless (see
https://github.com/diffplug/spotless/issues/1273#issuecomment-121116)
--
sudeshwasnik commented on code in PR #12462:
URL: https://github.com/apache/kafka/pull/12462#discussion_r951338206
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -273,26 +273,29 @@ public RecordAppendResult append(String topic,
sudeshwasnik commented on code in PR #12462:
URL: https://github.com/apache/kafka/pull/12462#discussion_r951338206
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -273,26 +273,29 @@ public RecordAppendResult append(String topic,
sudeshwasnik commented on code in PR #12462:
URL: https://github.com/apache/kafka/pull/12462#discussion_r951324954
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -273,26 +273,29 @@ public RecordAppendResult append(String topic,
cadonna opened a new pull request, #12547:
URL: https://github.com/apache/kafka/pull/12547
Removes tasks from the state updater when the input partitions of
the tasks are revoked or partitions are lost during a rebalance.
### Committer Checklist (excluded from commit message)
- [
[
https://issues.apache.org/jira/browse/KAFKA-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guido Josquin updated KAFKA-14173:
--
Description:
I am trying to test a stream-stream join with `TopologyTestDriver`. My goal is
t
Guido Josquin created KAFKA-14173:
-
Summary: TopologyTestDriver does not perform left join on two
streams when right side is missing
Key: KAFKA-14173
URL: https://issues.apache.org/jira/browse/KAFKA-14173
[
https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582899#comment-17582899
]
Yash Mayya edited comment on KAFKA-13431 at 8/22/22 10:48 AM:
[
https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582899#comment-17582899
]
Yash Mayya edited comment on KAFKA-13431 at 8/22/22 10:49 AM:
[
https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582899#comment-17582899
]
Yash Mayya commented on KAFKA-13431:
Thanks Diego.
[~ChrisEgerton] with regard t
[
https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582899#comment-17582899
]
Yash Mayya edited comment on KAFKA-13431 at 8/22/22 10:47 AM:
[
https://issues.apache.org/jira/browse/KAFKA-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582897#comment-17582897
]
Eslam commented on KAFKA-14166:
---
[~hachikuji] in which component actually we need that fix
cadonna commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r951241927
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
shouldThrowIfDbToAddWa
showuon commented on PR #12539:
URL: https://github.com/apache/kafka/pull/12539#issuecomment-1222123096
> If you think that the two similar lines I mentioned above can be optimized
(distinguish the details of the exception thrown in the two places), I can
resubmit a PR to improve.
I
showuon commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r951112014
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -534,6 +537,9 @@ object KafkaConfig {
val TransactionsAbortTimedOutTransactionCleanupIntervalMsProp =
"t
RivenSun2 commented on PR #12539:
URL: https://github.com/apache/kafka/pull/12539#issuecomment-1222087142
Hi @showuon Thanks for your reply.
I agree with you that the error stack does get printed in the upper layer.
The log printing here is a little redundant.
If you think that the tw
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951187834
##
core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala:
##
@@ -488,6 +488,31 @@ class ConsoleConsumerTest {
assertTrue(formatter.keyDeserializer.get.asIn
[
https://issues.apache.org/jira/browse/KAFKA-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14097.
-
Fix Version/s: 3.4.0
Reviewer: David Jacot
Assignee: Justine Olshan
Reso
dajac merged PR #12501:
URL: https://github.com/apache/kafka/pull/12501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
MPeli commented on PR #3283:
URL: https://github.com/apache/kafka/pull/3283#issuecomment-1222048956
Hi, I have created a new pull request. See #12331. It fixes some issues
mentioned in this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the messag
MPeli commented on PR #4431:
URL: https://github.com/apache/kafka/pull/4431#issuecomment-1222044459
Hi, I have created a new pull request. See #12331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
MPeli commented on PR #154:
URL: https://github.com/apache/kafka/pull/154#issuecomment-1222042101
Hi, I have created a new pull request. See #12331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
MPeli commented on PR #1757:
URL: https://github.com/apache/kafka/pull/1757#issuecomment-1222041656
Hi, I have created a new pull request. See #12331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951166345
##
core/src/main/scala/kafka/tools/ConsoleConsumer.scala:
##
@@ -307,7 +311,11 @@ object ConsoleConsumer extends Logging {
val partitionArg = if (options.has(partiti
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951165709
##
core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala:
##
@@ -140,6 +141,29 @@ class ConsoleProducerTest {
assert(reader.parseKey)
}
+ @Test
+ def
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951165346
##
core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala:
##
@@ -140,6 +141,29 @@ class ConsoleProducerTest {
assert(reader.parseKey)
}
+ @Test
+ def
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951165980
##
core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala:
##
@@ -140,6 +141,29 @@ class ConsoleProducerTest {
assert(reader.parseKey)
}
+ @Test
+ def
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951140387
##
core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala:
##
@@ -488,6 +488,31 @@ class ConsoleConsumerTest {
assertTrue(formatter.keyDeserializer.get.asIn
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951135651
##
core/src/main/scala/kafka/tools/ConsoleConsumer.scala:
##
@@ -307,7 +311,11 @@ object ConsoleConsumer extends Logging {
val partitionArg = if (options.has(partiti
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951133696
##
core/src/main/scala/kafka/tools/ConsoleProducer.scala:
##
@@ -71,7 +71,10 @@ object ConsoleProducer {
}
def getReaderProps(config: ProducerConfig): Properties
zigarn commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r951133696
##
core/src/main/scala/kafka/tools/ConsoleProducer.scala:
##
@@ -71,7 +71,10 @@ object ConsoleProducer {
}
def getReaderProps(config: ProducerConfig): Properties
71 matches
Mail list logo
