[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-08-27 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r956662529 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -356,6 +362,95 @@ private void mergeDuplicateSourceNodes() {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12562: KAFKA-10199: Remove tasks from state updater on shutdown

2022-08-27 Thread GitBox
guozhangwang commented on code in PR #12562: URL: https://github.com/apache/kafka/pull/12562#discussion_r956661497 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java: ## @@ -125,6 +125,80 @@ public void

[jira] [Updated] (KAFKA-13909) Restart Kafka in KRaft mode with ACLs ends in a RuntimeException

2022-08-27 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-13909: --- Fix Version/s: (was: 3.3.0) > Restart Kafka in KRaft mode with

[jira] [Updated] (KAFKA-13937) StandardAuthorizer throws "ID 5t1jQ3zWSfeVLMYkN3uong not found in aclsById" exceptions into broker logs

2022-08-27 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-13937: --- Fix Version/s: (was: 3.3.0) > StandardAuthorizer throws "ID

[jira] [Updated] (KAFKA-13897) Add 3.1.1 to system tests and streams upgrade tests

2022-08-27 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-13897: --- Fix Version/s: (was: 3.3.0) (was: 3.1.2)

[jira] [Updated] (KAFKA-14142) Improve information returned about the cluster metadata partition

2022-08-27 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14142: --- Fix Version/s: (was: 3.3.0) > Improve information returned

[jira] [Updated] (KAFKA-14050) Older clients cannot deserialize ApiVersions response with finalized feature epoch

2022-08-27 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14050: --- Fix Version/s: (was: 3.3.0) > Older clients cannot deserialize

[jira] [Resolved] (KAFKA-14183) Kraft bootstrap metadata file should use snapshot header/footer

2022-08-27 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-14183. Resolution: Fixed > Kraft bootstrap metadata file should use

[jira] [Updated] (KAFKA-12622) Automate LICENSE file validation

2022-08-27 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12622: --- Fix Version/s: 3.4.0 (was: 3.3.0) > Automate

[GitHub] [kafka] jsancio merged pull request #12565: KAFKA-14183; Cluster metadata bootstrap file should use header/footer

2022-08-27 Thread GitBox
jsancio merged PR #12565: URL: https://github.com/apache/kafka/pull/12565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on pull request #12565: KAFKA-14183; Cluster metadata bootstrap file should use header/footer

2022-08-27 Thread GitBox
jsancio commented on PR #12565: URL: https://github.com/apache/kafka/pull/12565#issuecomment-1229357606 Unrelated test failure: >Build / JDK 11 and Scala 2.13 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota() -- This is an automated

[GitHub] [kafka] jsancio commented on pull request #12565: KAFKA-14183; Cluster metadata bootstrap file should use header/footer

2022-08-27 Thread GitBox
jsancio commented on PR #12565: URL: https://github.com/apache/kafka/pull/12565#issuecomment-1229357539 > @jsancio thanks for the patch! A few minor non-blocking comments inline. I filed a follow-up to add unit tests for BatchFileWrite since I realize I never included any (not needed for

[GitHub] [kafka] ashmeet13 commented on pull request #12414: KAFKA-14073 Logging the reason for Snapshot

2022-08-27 Thread GitBox
ashmeet13 commented on PR #12414: URL: https://github.com/apache/kafka/pull/12414#issuecomment-1229214713 Hi @jsancio, bumping this PR up in case it got missed. Could please have a look at this? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mumrah commented on a diff in pull request #12565: KAFKA-14183; Cluster metadata bootstrap file should use header/footer

2022-08-27 Thread GitBox
mumrah commented on code in PR #12565: URL: https://github.com/apache/kafka/pull/12565#discussion_r956585846 ## metadata/src/main/java/org/apache/kafka/metadata/util/BatchFileWriter.java: ## @@ -36,16 +39,24 @@ /** - * Write an arbitrary set of metadata records into a

[jira] [Created] (KAFKA-14186) Add unit tests for BatchFileWriter

2022-08-27 Thread David Arthur (Jira)
David Arthur created KAFKA-14186: Summary: Add unit tests for BatchFileWriter Key: KAFKA-14186 URL: https://issues.apache.org/jira/browse/KAFKA-14186 Project: Kafka Issue Type: Test

[jira] [Comment Edited] (KAFKA-14015) ConfigProvider with ttl fails to restart tasks

2022-08-27 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585390#comment-17585390 ] Yash Mayya edited comment on KAFKA-14015 at 8/27/22 8:51 AM: - In essence,

[jira] [Comment Edited] (KAFKA-14015) ConfigProvider with ttl fails to restart tasks

2022-08-27 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17585390#comment-17585390 ] Yash Mayya edited comment on KAFKA-14015 at 8/27/22 8:50 AM: - In essence,

[GitHub] [kafka] showuon commented on a diff in pull request #12229: MINOR: Include the inner exception stack trace when re-throwing an exception

2022-08-27 Thread GitBox
showuon commented on code in PR #12229: URL: https://github.com/apache/kafka/pull/12229#discussion_r956553207 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java: ## @@ -326,7 +326,7 @@ static String

[GitHub] [kafka] showuon commented on a diff in pull request #12230: MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

2022-08-27 Thread GitBox
showuon commented on code in PR #12230: URL: https://github.com/apache/kafka/pull/12230#discussion_r956552230 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -463,8 +463,7 @@ public static T newParameterizedInstance(String className, Object... params)

[GitHub] [kafka] showuon merged pull request #12564: MINOR: Cleanups from KAFKA-14097

2022-08-27 Thread GitBox
showuon merged PR #12564: URL: https://github.com/apache/kafka/pull/12564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #12564: MINOR: Cleanups from KAFKA-14097

2022-08-27 Thread GitBox
showuon commented on PR #12564: URL: https://github.com/apache/kafka/pull/12564#issuecomment-1229143307 Failed tests are unrelated. ``` Build / JDK 17 and Scala 2.13 / org.apache.kafka.clients.consumer.StickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription()