[GitHub] [kafka] mdedetrich commented on a diff in pull request #12475: MINOR; Update scalafmt to latest version

2022-08-30 Thread GitBox
mdedetrich commented on code in PR #12475: URL: https://github.com/apache/kafka/pull/12475#discussion_r958078922 ## checkstyle/.scalafmt.conf: ## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific

[GitHub] [kafka] mdedetrich commented on pull request #12475: MINOR; Update scalafmt to latest version

2022-08-30 Thread GitBox
mdedetrich commented on PR #12475: URL: https://github.com/apache/kafka/pull/12475#issuecomment-1231234530 > I've kicked off another Jenkins run to see if we can get at least one green build with Scala 2.12. So Jenkins did in fact pass this PR as green build. I have just pushed to th

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12475: MINOR; Update scalafmt to latest version

2022-08-30 Thread GitBox
mdedetrich commented on code in PR #12475: URL: https://github.com/apache/kafka/pull/12475#discussion_r958078922 ## checkstyle/.scalafmt.conf: ## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific

[GitHub] [kafka] songnon commented on pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

2022-08-30 Thread GitBox
songnon commented on PR #12543: URL: https://github.com/apache/kafka/pull/12543#issuecomment-1231238770 Update the code and commit message. It looks like partitions being reassigned can also benefit from auto preferred leader election -- This is an automated message from the Apache Git Se

[GitHub] [kafka] showuon commented on pull request #12059: MINOR: Enable testUpdateFeaturesWithForwarding

2022-08-30 Thread GitBox
showuon commented on PR #12059: URL: https://github.com/apache/kafka/pull/12059#issuecomment-1231240877 Let's wait for the test results :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] showuon closed pull request #11822: [WIP] MINOR: add test

2022-08-30 Thread GitBox
showuon closed pull request #11822: [WIP] MINOR: add test URL: https://github.com/apache/kafka/pull/11822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [kafka] showuon closed pull request #11444: [WIP] Kafka 13406: fix for v2.8

2022-08-30 Thread GitBox
showuon closed pull request #11444: [WIP] Kafka 13406: fix for v2.8 URL: https://github.com/apache/kafka/pull/11444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [kafka] showuon closed pull request #9104: KAFKA-10266: Update the connector config header.converter

2022-08-30 Thread GitBox
showuon closed pull request #9104: KAFKA-10266: Update the connector config header.converter URL: https://github.com/apache/kafka/pull/9104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] showuon closed pull request #10773: [WIP] MINOR: Working in progress

2022-08-30 Thread GitBox
showuon closed pull request #10773: [WIP] MINOR: Working in progress URL: https://github.com/apache/kafka/pull/10773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [kafka] showuon closed pull request #11206: MINOR: Update streams doc to close KeyValueIterator in example code

2022-08-30 Thread GitBox
showuon closed pull request #11206: MINOR: Update streams doc to close KeyValueIterator in example code URL: https://github.com/apache/kafka/pull/11206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (KAFKA-14173) TopologyTestDriver does not perform left join on two streams when right side is missing

2022-08-30 Thread Guido Josquin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guido Josquin updated KAFKA-14173: -- Description: I am trying to test a stream-stream join with `TopologyTestDriver`. My goal is t

[jira] [Updated] (KAFKA-14173) TopologyTestDriver does not use mock wall clock time when sending test records

2022-08-30 Thread Guido Josquin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guido Josquin updated KAFKA-14173: -- Summary: TopologyTestDriver does not use mock wall clock time when sending test records (was:

[jira] [Updated] (KAFKA-14173) TopologyTestDriver does not use mock wall clock time when sending test records

2022-08-30 Thread Guido Josquin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guido Josquin updated KAFKA-14173: -- Description: I am trying to test a stream-stream join with `TopologyTestDriver`. My goal is t

[GitHub] [kafka] vpapavas commented on a diff in pull request #12555: Optimize self-join

2022-08-30 Thread GitBox
vpapavas commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r958320960 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMetada

[GitHub] [kafka] vpapavas commented on a diff in pull request #12555: Optimize self-join

2022-08-30 Thread GitBox
vpapavas commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r958321621 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -663,6 +663,12 @@ public class StreamsConfig extends AbstractConfig { public static fin

[GitHub] [kafka] cadonna commented on a diff in pull request #12459: KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-08-30 Thread GitBox
cadonna commented on code in PR #12459: URL: https://github.com/apache/kafka/pull/12459#discussion_r958373716 ## streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java: ## @@ -70,105 +73,133 @@ public class RocksDBMetricsRecorderTe

[GitHub] [kafka] C0urante commented on a diff in pull request #12475: MINOR; Update scalafmt to latest version

2022-08-30 Thread GitBox
C0urante commented on code in PR #12475: URL: https://github.com/apache/kafka/pull/12475#discussion_r958380812 ## checkstyle/.scalafmt.conf: ## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific la

[GitHub] [kafka] C0urante commented on pull request #11783: KAFKA-14143: Exactly-once source connector system tests (KIP-618)

2022-08-30 Thread GitBox
C0urante commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1231565587 @showuon @mimaison @tombentley any chance we could revisit this soon? I think we've probably missed the 3.3.0 boat but it'd be nice to get this in just to have the testing framework avai

[GitHub] [kafka] C0urante commented on pull request #12475: MINOR; Update scalafmt to latest version

2022-08-30 Thread GitBox
C0urante commented on PR #12475: URL: https://github.com/apache/kafka/pull/12475#issuecomment-1231567747 @vvcephei @cadonna would either of you have time to double-check this quick Scalafmt bump? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] cadonna commented on a diff in pull request #12459: KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-08-30 Thread GitBox
cadonna commented on code in PR #12459: URL: https://github.com/apache/kafka/pull/12459#discussion_r958391930 ## streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java: ## @@ -381,157 +395,115 @@ public void shouldThrowIfValueProv

[jira] [Created] (KAFKA-14189) reuse connection of coordinator and leader in KafkaConsumer

2022-08-30 Thread Junyang Liu (Jira)
Junyang Liu created KAFKA-14189: --- Summary: reuse connection of coordinator and leader in KafkaConsumer Key: KAFKA-14189 URL: https://issues.apache.org/jira/browse/KAFKA-14189 Project: Kafka Is

[jira] [Updated] (KAFKA-14189) connection count limit of coordinator and leader in KafkaConsumer

2022-08-30 Thread Junyang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyang Liu updated KAFKA-14189: Summary: connection count limit of coordinator and leader in KafkaConsumer (was: reuse connection

[jira] [Updated] (KAFKA-14189) improve connection limit and reuse of coordinator and leader in KafkaConsumer

2022-08-30 Thread Junyang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyang Liu updated KAFKA-14189: Summary: improve connection limit and reuse of coordinator and leader in KafkaConsumer (was: conn

[jira] [Updated] (KAFKA-14189) improve connection limit and reuse of coordinator and leader in KafkaConsumer

2022-08-30 Thread Junyang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyang Liu updated KAFKA-14189: Description: The connection id of connection with coordinator in KafkaConsumer is Integer.MAX_VAL

[jira] [Updated] (KAFKA-14189) Improve connection limit and reuse of coordinator and leader in KafkaConsumer

2022-08-30 Thread Junyang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyang Liu updated KAFKA-14189: Summary: Improve connection limit and reuse of coordinator and leader in KafkaConsumer (was: impr

[jira] [Updated] (KAFKA-14189) Improve connection limit and reuse of coordinator and leader in KafkaConsumer

2022-08-30 Thread Junyang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyang Liu updated KAFKA-14189: Description: The connection id of connection with coordinator in KafkaConsumer is Integer.MAX_VAL

[jira] [Commented] (KAFKA-14189) Improve connection limit and reuse of coordinator and leader in KafkaConsumer

2022-08-30 Thread Von Gosling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597851#comment-17597851 ] Von Gosling commented on KAFKA-14189: - I'd like to hear some suggestions from [~junr

[jira] [Updated] (KAFKA-14189) Improve connection limit and reuse of coordinator and leader in KafkaConsumer

2022-08-30 Thread Junyang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyang Liu updated KAFKA-14189: Description: The connection id of connection with coordinator in KafkaConsumer is Integer.MAX_VAL

[jira] [Created] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
Alexandre Dupriez created KAFKA-14190: - Summary: Corruption of Topic IDs with pre-2.8.0 admin clients Key: KAFKA-14190 URL: https://issues.apache.org/jira/browse/KAFKA-14190 Project: Kafka

[jira] [Updated] (KAFKA-14189) Improve connection limit and reuse of coordinator and leader in KafkaConsumer

2022-08-30 Thread Junyang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junyang Liu updated KAFKA-14189: Description: The connection id of connection with coordinator in KafkaConsumer is Integer.MAX_VAL

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Description: h3. Scope The problem reported below has been verified to occur in Zooke

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Description: h3. Scope The problem reported below has been verified to occur in Zooke

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Description: h3. Scope The problem reported below has been verified to occur in Zooke

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Summary: Corruption of Topic IDs with pre-2.8.0 ZK admin clients (was: Corruption of

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Description: h3. Scope The problem reported below has been verified to occur in Zooke

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Description: h3. Scope The problem reported below has been verified to occur in Zooke

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Affects Version/s: 2.8.0 > Corruption of Topic IDs with pre-2.8.0 ZK admin clients > -

[jira] [Commented] (KAFKA-5337) Partition assignment strategy that distributes lag evenly across consumers in each group

2022-08-30 Thread Rajesh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597900#comment-17597900 ] Rajesh commented on KAFKA-5337: --- [~grantneale] Are we planning to add this feature. It woul

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12459: KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-08-30 Thread GitBox
divijvaidya commented on code in PR #12459: URL: https://github.com/apache/kafka/pull/12459#discussion_r958565181 ## streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java: ## @@ -381,157 +395,115 @@ public void shouldThrowIfValue

[jira] [Created] (KAFKA-14191) Add end-to-end latency metrics to Connectors

2022-08-30 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-14191: Summary: Add end-to-end latency metrics to Connectors Key: KAFKA-14191 URL: https://issues.apache.org/jira/browse/KAFKA-14191 Project:

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Description: h3. Scope The problem reported below has been verified to occur in Zooke

[jira] [Updated] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14190: -- Description: h3. Scope The problem reported below has been verified to occur in Zooke

[jira] [Comment Edited] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597928#comment-17597928 ] Ismael Juma edited comment on KAFKA-14190 at 8/30/22 3:11 PM:

[jira] [Commented] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597928#comment-17597928 ] Ismael Juma commented on KAFKA-14190: - Thanks for the JIRA. To clarify, the issue is

[jira] [Comment Edited] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597928#comment-17597928 ] Ismael Juma edited comment on KAFKA-14190 at 8/30/22 3:13 PM:

[jira] [Comment Edited] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597928#comment-17597928 ] Ismael Juma edited comment on KAFKA-14190 at 8/30/22 3:14 PM:

[jira] [Comment Edited] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597928#comment-17597928 ] Ismael Juma edited comment on KAFKA-14190 at 8/30/22 3:14 PM:

[jira] [Commented] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597935#comment-17597935 ] Ismael Juma commented on KAFKA-14190: - {quote}The ID of a topic is lost when an Admi

[jira] [Commented] (KAFKA-14182) KRaft and ACL + GSSAPI

2022-08-30 Thread Svyatoslav (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597950#comment-17597950 ] Svyatoslav commented on KAFKA-14182: [~showuon] on a latest trunk branch some other

[jira] [Updated] (KAFKA-14156) Built-in partitioner may create suboptimal batches with large linger.ms

2022-08-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14156: --- Fix Version/s: 3.3.0 > Built-in partitioner may create suboptimal ba

[jira] [Updated] (KAFKA-14187) kafka-features.sh: add support for --metadata

2022-08-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14187: --- Fix Version/s: 3.3.0 > kafka-features.sh: add support for --metadata

[GitHub] [kafka] jsancio commented on pull request #11786: MINOR: Add KRaft broker api to protocol docs

2022-08-30 Thread GitBox
jsancio commented on PR #11786: URL: https://github.com/apache/kafka/pull/11786#issuecomment-1231900372 Yeah @showuon . I'll cherry pick this to the 3.3 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] cmccabe commented on a diff in pull request #12571: KAFKA-14187: kafka-featuressh: add support for --metadata

2022-08-30 Thread GitBox
cmccabe commented on code in PR #12571: URL: https://github.com/apache/kafka/pull/12571#discussion_r958710277 ## docs/upgrade.html: ## @@ -61,8 +61,27 @@ Upgrading to 3.3.0 from any vers +Upgrading a KRaft-based cluster to 3.3.0 from any version 3.0.x through 3.2.x +

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12569: KAFKA-10199: Shutdown state updater on task manager shutdown

2022-08-30 Thread GitBox
guozhangwang commented on code in PR #12569: URL: https://github.com/apache/kafka/pull/12569#discussion_r958716921 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1180,6 +1182,68 @@ void shutdown(final boolean clean) { }

[GitHub] [kafka] C0urante commented on a diff in pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

2022-08-30 Thread GitBox
C0urante commented on code in PR #12543: URL: https://github.com/apache/kafka/pull/12543#discussion_r958619212 ## core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala: ## @@ -490,6 +490,41 @@ class ControllerIntegrationTest extends QuorumTestHarness {

[GitHub] [kafka] cadonna commented on pull request #12459: KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-08-30 Thread GitBox
cadonna commented on PR #12459: URL: https://github.com/apache/kafka/pull/12459#issuecomment-1231952039 The test failures are unrelated: ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.controller.QuorumControllerTest.testDelayedConfigurationOperations() Build / JDK 11 and Scala

[GitHub] [kafka] cadonna merged pull request #12459: KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-08-30 Thread GitBox
cadonna merged PR #12459: URL: https://github.com/apache/kafka/pull/12459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597994#comment-17597994 ] Alexandre Dupriez commented on KAFKA-14190: --- Hi Ismael, Thanks for the follow

[jira] [Comment Edited] (KAFKA-14190) Corruption of Topic IDs with pre-2.8.0 ZK admin clients

2022-08-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597994#comment-17597994 ] Alexandre Dupriez edited comment on KAFKA-14190 at 8/30/22 5:49 PM: --

[jira] [Updated] (KAFKA-14174) Operation documentation for KRaft

2022-08-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14174: --- Affects Version/s: 3.3.0 > Operation documentation for KRaft > -

[jira] [Updated] (KAFKA-14188) Quickstart for KRaft

2022-08-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14188: --- Fix Version/s: 3.3.0 > Quickstart for KRaft > >

[jira] [Updated] (KAFKA-14174) Operation documentation for KRaft

2022-08-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14174: --- Fix Version/s: 3.3.0 > Operation documentation for KRaft > -

[jira] [Updated] (KAFKA-14179) Improve docs/upgrade.html to talk about metadata.version upgrades

2022-08-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14179: --- Fix Version/s: 3.3.0 > Improve docs/upgrade.html to talk about metad

[jira] [Updated] (KAFKA-14188) Quickstart for KRaft

2022-08-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14188: --- Affects Version/s: 3.3.0 > Quickstart for KRaft > --

[jira] [Resolved] (KAFKA-14170) KRaft Controller: Possible NPE when we remove topics with any offline partitions in the cluster

2022-08-30 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Chaganti resolved KAFKA-14170. --- Resolution: Fixed > KRaft Controller: Possible NPE when we remove topics with any of

[jira] [Updated] (KAFKA-14179) Improve docs/upgrade.html to talk about metadata.version upgrades

2022-08-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14179: --- Affects Version/s: 3.3.0 > Improve docs/upgrade.html to talk about m

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-08-30 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r958780670 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMe

[GitHub] [kafka] dtwitty opened a new pull request, #12572: [LI-HOTFIX] Downgrade FETCH_SESSION_ID_NOT_FOUND logging from info to debug

2022-08-30 Thread GitBox
dtwitty opened a new pull request, #12572: URL: https://github.com/apache/kafka/pull/12572 TICKET = LIKAFKA-44865 LI_DESCRIPTION = Whenever the fetch session has a cache miss on the broker, the client logs FETCH_SESSION_ID_NOT_FOUND at the `info` level. This message isn't actionable t

[GitHub] [kafka] dtwitty commented on pull request #12572: [LI-HOTFIX] Downgrade FETCH_SESSION_ID_NOT_FOUND logging from info to debug

2022-08-30 Thread GitBox
dtwitty commented on PR #12572: URL: https://github.com/apache/kafka/pull/12572#issuecomment-1232010612 Clearly something has gone screwy with this PR. Closing to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dtwitty closed pull request #12572: [LI-HOTFIX] Downgrade FETCH_SESSION_ID_NOT_FOUND logging from info to debug

2022-08-30 Thread GitBox
dtwitty closed pull request #12572: [LI-HOTFIX] Downgrade FETCH_SESSION_ID_NOT_FOUND logging from info to debug URL: https://github.com/apache/kafka/pull/12572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-12835) Topic IDs can mismatch on brokers (after interbroker protocol version update)

2022-08-30 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598006#comment-17598006 ] Sergey Ivanov commented on KAFKA-12835: --- Hi All, It seems this ticket already sol

[jira] [Commented] (KAFKA-13077) Replication failing after unclean shutdown of ZK and all brokers

2022-08-30 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598009#comment-17598009 ] Sergey Ivanov commented on KAFKA-13077: --- Hi, we faced the same issue with Kafka 2

[jira] [Comment Edited] (KAFKA-13077) Replication failing after unclean shutdown of ZK and all brokers

2022-08-30 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598009#comment-17598009 ] Sergey Ivanov edited comment on KAFKA-13077 at 8/30/22 6:41 PM: --

[jira] [Updated] (KAFKA-13036) Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-08-30 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-13036: - Fix Version/s: 3.4.0 > Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTes

[GitHub] [kafka] mumrah commented on a diff in pull request #12571: KAFKA-14187: kafka-featuressh: add support for --metadata

2022-08-30 Thread GitBox
mumrah commented on code in PR #12571: URL: https://github.com/apache/kafka/pull/12571#discussion_r958851048 ## clients/src/main/java/org/apache/kafka/clients/admin/SupportedVersionRange.java: ## @@ -36,10 +36,10 @@ public class SupportedVersionRange { * @throws IllegalArg

[GitHub] [kafka] cmccabe commented on a diff in pull request #12571: KAFKA-14187: kafka-featuressh: add support for --metadata

2022-08-30 Thread GitBox
cmccabe commented on code in PR #12571: URL: https://github.com/apache/kafka/pull/12571#discussion_r958914091 ## clients/src/main/java/org/apache/kafka/clients/admin/SupportedVersionRange.java: ## @@ -36,10 +36,10 @@ public class SupportedVersionRange { * @throws IllegalAr

[jira] [Commented] (KAFKA-14154) Persistent URP after controller soft failure

2022-08-30 Thread Artem Livshits (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598086#comment-17598086 ] Artem Livshits commented on KAFKA-14154: > 1. Broker 1 loses its session in Zook

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-08-30 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r958991975 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMe

[jira] [Commented] (KAFKA-5337) Partition assignment strategy that distributes lag evenly across consumers in each group

2022-08-30 Thread Grant Neale (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598108#comment-17598108 ] Grant Neale commented on KAFKA-5337: There is no plan to implement this as a core fea

[GitHub] [kafka] cmccabe merged pull request #12571: KAFKA-14187: kafka-featuressh: add support for --metadata

2022-08-30 Thread GitBox
cmccabe merged PR #12571: URL: https://github.com/apache/kafka/pull/12571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-14187) kafka-features.sh: add support for --metadata

2022-08-30 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14187. -- Resolution: Fixed > kafka-features.sh: add support for --metadata > --

[GitHub] [kafka] showuon commented on pull request #11786: MINOR: Add KRaft broker api to protocol docs

2022-08-30 Thread GitBox
showuon commented on PR #11786: URL: https://github.com/apache/kafka/pull/11786#issuecomment-1232357443 Thank you, @jsancio and @dengziming ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Assigned] (KAFKA-13404) Kafka sink connectors do not commit offset correctly if messages are produced in transaction

2022-08-30 Thread Anupam Aggarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anupam Aggarwal reassigned KAFKA-13404: --- Assignee: Anupam Aggarwal > Kafka sink connectors do not commit offset correctly if

[jira] [Assigned] (KAFKA-13631) Warning "Ignoring await stop request for non-present connector..." when shutting down connector via API in distributed mode

2022-08-30 Thread Anupam Aggarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anupam Aggarwal reassigned KAFKA-13631: --- Assignee: Anupam Aggarwal > Warning "Ignoring await stop request for non-present co

[GitHub] [kafka] songnon commented on a diff in pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

2022-08-30 Thread GitBox
songnon commented on code in PR #12543: URL: https://github.com/apache/kafka/pull/12543#discussion_r959153232 ## core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala: ## @@ -490,6 +490,41 @@ class ControllerIntegrationTest extends QuorumTestHarness {

[jira] [Commented] (KAFKA-13386) Foreign Key Join filtering out valid records after a code change / schema evolved

2022-08-30 Thread Luke Jackson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598168#comment-17598168 ] Luke Jackson commented on KAFKA-13386: -- Thanks [~guozhang] for the detail, and expl