[jira] [Commented] (KAFKA-13419) sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Cooperative protocol

[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624885#comment-17624885 ] Luke Chen commented on KAFKA-13419: --- [~ableegoldman] , you are right. We have the logi

[GitHub] [kafka] snehashisp commented on a diff in pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

snehashisp commented on code in PR #12784: URL: https://github.com/apache/kafka/pull/12784#discussion_r1006427140 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -280,15 +282,16 @@ private void commitTransaction() {

[jira] [Commented] (KAFKA-13419) sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Cooperative protocol

[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624866#comment-17624866 ] A. Sophie Blee-Goldman commented on KAFKA-13419: {quote}  can we just tr

[GitHub] [kafka] ableegoldman commented on pull request #12140: KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS

ableegoldman commented on PR #12140: URL: https://github.com/apache/kafka/pull/12140#issuecomment-1293017276 Thanks @showuon ! Unfortunately I'm now seeing that the situation may be more complicated than I'd initially thought :/ Just came across this followup to the patch here: https://issu

[GitHub] [kafka] sudeshwasnik commented on pull request #12784: MINOR: Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

sudeshwasnik commented on PR #12784: URL: https://github.com/apache/kafka/pull/12784#issuecomment-1292941491 hi @C0urante, could you ptal on this quick small change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] jeffkbkim commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on PR #12783: URL: https://github.com/apache/kafka/pull/12783#issuecomment-1292841267 thanks @showuon @dajac for the review. i have addressed the comments. i am preparing a benchmark for the comparison. -- This is an automated message from the Apache Git Service

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006315710 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006313513 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] showuon commented on pull request #12140: KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS

showuon commented on PR #12140: URL: https://github.com/apache/kafka/pull/12140#issuecomment-1292836807 Agree to backported to 3.2 - 3.0. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r100619 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006311802 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

[ https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13891: --- Fix Version/s: 3.2.4 > sync group failed with rebalanceInProgress error caus

[GitHub] [kafka] ableegoldman commented on pull request #12140: KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS

ableegoldman commented on PR #12140: URL: https://github.com/apache/kafka/pull/12140#issuecomment-1292795314 Hey @dajac @showuon just came across this from a user who's running into this on 3.0, given it was part of a series of fixes leading up to/included in 3.0, I think it can/should be b

[GitHub] [kafka] philipnee commented on a diff in pull request #12545: KIP-863: Reduce Fetcher#parseRecord() memory copy

philipnee commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1006249694 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1413,22 +1414,19 @@ private ConsumerRecord parseRecord(TopicPartition parti

[GitHub] [kafka] philipnee commented on a diff in pull request #12545: KIP-863: Reduce Fetcher#parseRecord() memory copy

philipnee commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1006246642 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -263,6 +264,16 @@ public String deserialize(String topic, byte[] data) {

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r100619 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r100619 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1006187535 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -331,6 +331,15 @@ class ReplicaManager(val config: KafkaConfig, delayedFetchPurgatory.checkAndCom

[GitHub] [kafka] philipnee opened a new pull request, #12792: [Test]gradle oom fix

philipnee opened a new pull request, #12792: URL: https://github.com/apache/kafka/pull/12792 tbd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jir

[GitHub] [kafka] philipnee closed pull request #12788: [Test]Testing Gradle OOM

philipnee closed pull request #12788: [Test]Testing Gradle OOM URL: https://github.com/apache/kafka/pull/12788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1006147200 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1005833555 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

gharris1727 commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1006005644 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java: ## @@ -98,7 +98,7 @@ private Optional> producer; private TopicAdmin adm

[GitHub] [kafka] gharris1727 opened a new pull request, #12791: KAFKA-14338: Use MockTime in RetryUtilTest to eliminate flakiness

gharris1727 opened a new pull request, #12791: URL: https://github.com/apache/kafka/pull/12791 Signed-off-by: Greg Harris There is existing flakiness in this test even with the previous patch to address flakiness https://github.com/apache/kafka/pull/11871 This should resolve the o

[jira] [Created] (KAFKA-14338) Connect RetryUtilTest flakey in CPU-limited environments

Greg Harris created KAFKA-14338: --- Summary: Connect RetryUtilTest flakey in CPU-limited environments Key: KAFKA-14338 URL: https://issues.apache.org/jira/browse/KAFKA-14338 Project: Kafka Issue

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1005833555 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1005833555 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] C0urante commented on a diff in pull request #12735: Replace EasyMock and PowerMock with Mockito in connect/runtime/ErrorHandlingTaskTest | KAFKA-14059

C0urante commented on code in PR #12735: URL: https://github.com/apache/kafka/pull/12735#discussion_r998501094 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java: ## @@ -197,10 +191,11 @@ public void setup() { workerProps.put("v

[GitHub] [kafka] divijvaidya commented on pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

divijvaidya commented on PR #12465: URL: https://github.com/apache/kafka/pull/12465#issuecomment-1292129360 Rebased from latest commits in trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] nicktelford commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

nicktelford commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r1005391821 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractTransactionalStore.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Assigned] (KAFKA-10149) Do not prevent automatic preferred election when reassignment in progress

[ https://issues.apache.org/jira/browse/KAFKA-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-10149: - Assignee: (was: Bob Barrett) > Do not prevent automatic preferred election when rea

[jira] [Resolved] (KAFKA-10149) Do not prevent automatic preferred election when reassignment in progress

[ https://issues.apache.org/jira/browse/KAFKA-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-10149. --- Fix Version/s: 3.4.0 Resolution: Fixed > Do not prevent automatic preferred election

[GitHub] [kafka] C0urante merged pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

C0urante merged PR #12543: URL: https://github.com/apache/kafka/pull/12543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] divijvaidya commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1291792183 @kirktrue @dajac please take a look when you get a chance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (KAFKA-14269) Partition Assignment Strategy - Topic Round Robin Assignor

[ https://issues.apache.org/jira/browse/KAFKA-14269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Amblard resolved KAFKA-14269. - Resolution: Abandoned > Partition Assignment Strategy - Topic Round Robin Assignor > ---

[jira] [Commented] (KAFKA-13999) Add ProducerCount metrics (KIP-847)

[ https://issues.apache.org/jira/browse/KAFKA-13999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624331#comment-17624331 ] Luke Chen commented on KAFKA-13999: --- [~alivshits] , will this feature complete in v3.4

[GitHub] [kafka] mathieu-amblard closed pull request #12705: KAFKA-14269: client-side, add TopicRoundRobinAssignor as a possible partition assignment strategy

mathieu-amblard closed pull request #12705: KAFKA-14269: client-side, add TopicRoundRobinAssignor as a possible partition assignment strategy URL: https://github.com/apache/kafka/pull/12705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1005398780 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java: ## @@ -98,7 +98,7 @@ private Optional> producer; private TopicAdmin admi

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1005398337 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +540,22 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1005359301 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +540,22 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[jira] [Updated] (KAFKA-14337) topic name with "." cannot be created after deletion

[ https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14337: -- Component/s: kraft (was: admin) > topic name with "." cannot be created after del

[jira] [Updated] (KAFKA-14337) topic name with "." cannot be created after deletion

[ https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14337: -- Labels: (was: pull-request-available) > topic name with "." cannot be created after deletion > -

[jira] [Updated] (KAFKA-14337) topic name with "." cannot be created after deletion

[ https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14337: -- Environment: (was: Stagging) > topic name with "." cannot be created after deletion >

[jira] [Updated] (KAFKA-14337) topic name with "." cannot be created after deletion

[ https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14337: -- Summary: topic name with "." cannot be created after deletion (was: bugs kafka 3.3.1 create topic aft

[GitHub] [kafka] showuon commented on pull request #12790: KAFKA-14337: correctly remove topicsWithCollisionChars after topic deletion

showuon commented on PR #12790: URL: https://github.com/apache/kafka/pull/12790#issuecomment-1291601760 @dengziming @cmccabe , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] showuon commented on a diff in pull request #12790: KAFKA-14337: correctly remove topicsWithCollisionChars after topic deletion

showuon commented on code in PR #12790: URL: https://github.com/apache/kafka/pull/12790#discussion_r1005304318 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -527,7 +527,7 @@ public void replay(RemoveTopicRecord record) {

[GitHub] [kafka] showuon opened a new pull request, #12790: KAFKA-14337: correctly remove topicsWithCollisionChars after topic deletion

showuon opened a new pull request, #12790: URL: https://github.com/apache/kafka/pull/12790 In https://github.com/apache/kafka/pull/11910 , we added a feature to prevent topics with conflicting metrics names from being created. We added a map to store the normalized topic name to the topic n