mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1298085160
@C0urante Due to a conflict I rebased this test off of `origin/trunk` and
there was a merge conflict due to the `StandaloneHerderTest` being updated,
just make sure you check the botto
[
https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626972#comment-17626972
]
thanhnd96 commented on KAFKA-14337:
---
thank you [~showuon] !!!
> topic name with "." c
philipnee opened a new pull request, #12807:
URL: https://github.com/apache/kafka/pull/12807
[KAFKA-14264](https://issues.apache.org/jira/browse/KAFKA-14264)
In this PR we are adding
1. Commit feature and moving the callback invocation to the application
level, so that it can be execut
gharris1727 commented on PR #12806:
URL: https://github.com/apache/kafka/pull/12806#issuecomment-1297970309
cc @apovzner @splett2 for awareness of this bound change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gharris1727 opened a new pull request, #12806:
URL: https://github.com/apache/kafka/pull/12806
Signed-off-by: Greg Harris
The existing hard-coded error bound in the test is inaccurate, such that
certain patterns
of request arrival cause this test to exceed the bound slightly. Thi
Greg Harris created KAFKA-14345:
---
Summary: Flakey DynamicConnectionQuotaTest should use correct
error bounds
Key: KAFKA-14345
URL: https://issues.apache.org/jira/browse/KAFKA-14345
Project: Kafka
hachikuji commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1009809439
##
metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java:
##
@@ -467,36 +467,41 @@ public void testIterator(MetadataVersion metadataVersio
C0urante merged PR #12725:
URL: https://github.com/apache/kafka/pull/12725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante merged PR #12789:
URL: https://github.com/apache/kafka/pull/12789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mdedetrich commented on code in PR #12725:
URL: https://github.com/apache/kafka/pull/12725#discussion_r1009811060
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java:
##
@@ -262,127 +254,96 @@ public void testFullExpandCon
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1297554373
@ijuma Sorry for the delay.
The tradeoff involved is whether we want to account for direct calls to
`System::exit` or not. If we're confident enough in our review process to catch
vvcephei merged PR #12775:
URL: https://github.com/apache/kafka/pull/12775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
vvcephei commented on PR #12775:
URL: https://github.com/apache/kafka/pull/12775#issuecomment-1297534916
All right, thanks for that fix, @philipnee !
This time, the failures look unrelated:
```
Build / JDK 11 and Scala 2.13 /
kafka.api.TransactionsTest.testFailureToFence
C0urante commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r1009729516
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -374,30 +350,40 @@ public void testErrorHandlingInSourceTasks() thr
gharris1727 commented on code in PR #12789:
URL: https://github.com/apache/kafka/pull/12789#discussion_r1009699428
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -108,7 +109,7 @@ public class AbstractHerderTest {
CONN1_C
gharris1727 commented on PR #10475:
URL: https://github.com/apache/kafka/pull/10475#issuecomment-129767
Superseded by #12805.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gharris1727 opened a new pull request, #12805:
URL: https://github.com/apache/kafka/pull/12805
Copied from original PR #10475:
The default implementation, which is inheritted from ClassLoader, searches
the
classloader tree from parent first. This causes issues when the resource is
C0urante commented on code in PR #12789:
URL: https://github.com/apache/kafka/pull/12789#discussion_r1009675386
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -108,7 +109,7 @@ public class AbstractHerderTest {
CONN1_CONF
C0urante commented on code in PR #12725:
URL: https://github.com/apache/kafka/pull/12725#discussion_r1009671725
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java:
##
@@ -899,250 +750,199 @@ public void
testFenceZombiesW
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1009669418
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java:
##
@@ -0,0 +1,553 @@
+/*
+ *
OmniaGM opened a new pull request, #12804:
URL: https://github.com/apache/kafka/pull/12804
jira [KAFKA-14344](https://issues.apache.org/jira/browse/KAFKA-14344)
This pr will simplify setting up MM2 integration test with AclAuthorizer
enabled
*More detailed description of your chan
C0urante commented on code in PR #12725:
URL: https://github.com/apache/kafka/pull/12725#discussion_r1009666486
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java:
##
@@ -841,55 +702,45 @@ public void testRestartConnector
C0urante commented on code in PR #12725:
URL: https://github.com/apache/kafka/pull/12725#discussion_r1009665839
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java:
##
@@ -262,127 +254,96 @@ public void testFullExpandConne
gharris1727 commented on code in PR #12789:
URL: https://github.com/apache/kafka/pull/12789#discussion_r1009665594
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -192,6 +193,41 @@ public void testConnectorStatus() {
Conn
C0urante commented on code in PR #12725:
URL: https://github.com/apache/kafka/pull/12725#discussion_r1009655795
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java:
##
@@ -262,127 +254,96 @@ public void testFullExpandConne
[
https://issues.apache.org/jira/browse/KAFKA-14344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim updated KAFKA-14344:
--
Component/s: mirrormaker
> Improve MM2 integration test by building EmbeddedKafkaCluster with
[
https://issues.apache.org/jira/browse/KAFKA-14344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim updated KAFKA-14344:
--
Summary: Improve MM2 integration test by building EmbeddedKafkaCluster with
common configs use
hachikuji merged PR #12798:
URL: https://github.com/apache/kafka/pull/12798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
Omnia Ibrahim created KAFKA-14344:
-
Summary: Build EmbeddedKafkaCluster with common configs used for
all clients
Key: KAFKA-14344
URL: https://issues.apache.org/jira/browse/KAFKA-14344
Project: Kafka
C0urante commented on code in PR #12725:
URL: https://github.com/apache/kafka/pull/12725#discussion_r1009539544
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java:
##
@@ -153,19 +157,23 @@ public class ConnectorsResourceT
C0urante commented on PR #12784:
URL: https://github.com/apache/kafka/pull/12784#issuecomment-1297203987
@sudeshwasnik Good point. I think with the code base as it is right now, we
do get the invariant that asynchronous failures occur if and only if an offset
is dispatched to `Producer::sen
LinShunKang commented on PR #12545:
URL: https://github.com/apache/kafka/pull/12545#issuecomment-1297164414
@showuon @guozhangwang @C0urante
PTAL : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
LinShunKang commented on code in PR #12545:
URL: https://github.com/apache/kafka/pull/12545#discussion_r1009466849
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1413,22 +1414,19 @@ private ConsumerRecord parseRecord(TopicPartition
par
LinShunKang commented on code in PR #12545:
URL: https://github.com/apache/kafka/pull/12545#discussion_r1009465243
##
clients/src/main/java/org/apache/kafka/common/serialization/Deserializer.java:
##
@@ -60,6 +62,17 @@ default T deserialize(String topic, Headers headers, byte[]
cadonna commented on code in PR #12771:
URL: https://github.com/apache/kafka/pull/12771#discussion_r1009446157
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1432,7 +1432,36 @@ public void
shouldRethrowTaskCorruptedExceptionFr
cadonna commented on code in PR #12771:
URL: https://github.com/apache/kafka/pull/12771#discussion_r1009441403
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -810,10 +810,19 @@ private void transitRestoredTaskToRunning(final Task ta
cadonna commented on code in PR #12771:
URL: https://github.com/apache/kafka/pull/12771#discussion_r1009441403
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -810,10 +810,19 @@ private void transitRestoredTaskToRunning(final Task ta
cadonna commented on code in PR #12771:
URL: https://github.com/apache/kafka/pull/12771#discussion_r1009425293
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -810,10 +810,19 @@ private void transitRestoredTaskToRunning(final Task ta
cadonna commented on code in PR #12684:
URL: https://github.com/apache/kafka/pull/12684#discussion_r1009410493
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1450,4 +1453,15 @@ public static String[] enumOptions(Class> enumClass) {
.to
dengziming commented on code in PR #12711:
URL: https://github.com/apache/kafka/pull/12711#discussion_r1009380357
##
shell/src/test/java/org/apache/kafka/shell/MetadataShellTest.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
vamossagar12 opened a new pull request, #12803:
URL: https://github.com/apache/kafka/pull/12803
This PR implements
[KIP-837](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211883356)
which enhances StreamPartitioner to multicast records.
--
This is an automated message
mdedetrich commented on PR #12675:
URL: https://github.com/apache/kafka/pull/12675#issuecomment-1296985623
I was busy last week so I didn't have time for it, will try to look later
this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
divijvaidya commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r1009324268
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -374,30 +350,40 @@ public void testErrorHandlingInSourceTasks()
dengziming closed pull request #11017: KAFKA-12950 Replace EasyMock and
PowerMock with Mockito for KafkaStream
URL: https://github.com/apache/kafka/pull/11017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
divijvaidya commented on PR #12465:
URL: https://github.com/apache/kafka/pull/12465#issuecomment-1296957526
@dengziming yes please. It can be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vamossagar12 commented on PR #12802:
URL: https://github.com/apache/kafka/pull/12802#issuecomment-1296940738
@C0urante , can you plz review this small-ish PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vamossagar12 opened a new pull request, #12802:
URL: https://github.com/apache/kafka/pull/12802
When the DistributedHerder::stop() method called, it triggers asynchronous
shutdown of the background herder thread, and continues with synchronous
shutdown of some other resources, including the
omkreddy commented on PR #12675:
URL: https://github.com/apache/kafka/pull/12675#issuecomment-1296868004
@mdedetrich any update here? let us know if you need any help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1009237373
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,76 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertE
lucasbru opened a new pull request, #12801:
URL: https://github.com/apache/kafka/pull/12801
[KAFKA-14343](https://issues.apache.org/jira/browse/KAFKA-14343): Upgrade
tests for state updater
A test that verifies the upgrade from a version of Streams with
state updater disabled to a vers
Lucas Brutschy created KAFKA-14343:
--
Summary: Write upgrade/downgrade tests for enabling the state
updater
Key: KAFKA-14343
URL: https://issues.apache.org/jira/browse/KAFKA-14343
Project: Kafka
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1009197631
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,76 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertE
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1009200035
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,73 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertE
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1009197631
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,76 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertE
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1009197852
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,76 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertE
yashmayya commented on PR #12800:
URL: https://github.com/apache/kafka/pull/12800#issuecomment-1296770120
@C0urante, @sidd1809 could you please take a look at this small fix /
improvement whenever you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to
yashmayya opened a new pull request, #12800:
URL: https://github.com/apache/kafka/pull/12800
- https://issues.apache.org/jira/browse/KAFKA-14342
-
[KafkaOffsetBackingStore](https://github.com/apache/kafka/blob/56d588d55ac313c0efca586a3bcd984c99a89018/connect/runtime/src/main/java/org/apac
dajac merged PR #12799:
URL: https://github.com/apache/kafka/pull/12799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
Scanteianu commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1009132503
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,73 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertE
Yash Mayya created KAFKA-14342:
--
Summary: KafkaOffsetBackingStore should clear offsets for source
partitions on tombstone messages
Key: KAFKA-14342
URL: https://issues.apache.org/jira/browse/KAFKA-14342
dajac commented on PR #12748:
URL: https://github.com/apache/kafka/pull/12748#issuecomment-1296693798
Will review it this week. Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon commented on PR #12639:
URL: https://github.com/apache/kafka/pull/12639#issuecomment-1296684059
@hachikuji @mumrah , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
showuon commented on PR #12711:
URL: https://github.com/apache/kafka/pull/12711#issuecomment-1296683138
@dengziming @jsancio , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
showuon commented on PR #12748:
URL: https://github.com/apache/kafka/pull/12748#issuecomment-1296682750
@dajac @guozhangwang , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626438#comment-17626438
]
Luke Chen commented on KAFKA-14337:
---
[~thanhnd96] , this bug fix will be in Kafka v3.3
showuon commented on PR #12796:
URL: https://github.com/apache/kafka/pull/12796#issuecomment-1296676515
Thanks for helping adding the tests, @hachikuji !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
showuon commented on code in PR #12753:
URL: https://github.com/apache/kafka/pull/12753#discussion_r1009083247
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -694,6 +694,73 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
67 matches
Mail list logo
