[GitHub] [kafka] showuon commented on pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

2022-12-05 Thread GitBox
showuon commented on PR #12729: URL: https://github.com/apache/kafka/pull/12729#issuecomment-1338855328 @aglicacha , there is compile error, could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] lihaosky commented on a diff in pull request #12944: [KAFKA-14395] add config to configure client supplier

2022-12-05 Thread GitBox
lihaosky commented on code in PR #12944: URL: https://github.com/apache/kafka/pull/12944#discussion_r1040472261 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -1088,6 +1088,28 @@ public void shouldTriggerRecordingOfRocksDBMetricsIfRecordingLevelI

[jira] [Commented] (KAFKA-14440) Local state wipeout with EOS

2022-12-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643642#comment-17643642 ] Matthias J. Sax commented on KAFKA-14440: - What you observe is behavior by-desig

[jira] [Resolved] (KAFKA-14440) Local state wipeout with EOS

2022-12-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14440. - Resolution: Duplicate > Local state wipeout with EOS > > >

[GitHub] [kafka] showuon merged pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)

2022-12-05 Thread GitBox
showuon merged PR #12908: URL: https://github.com/apache/kafka/pull/12908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)

2022-12-05 Thread GitBox
showuon commented on PR #12908: URL: https://github.com/apache/kafka/pull/12908#issuecomment-1338657516 Failed tests are unrelated ``` Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslVersionsTransportLayerTest.tlsServerProtocol = [TLSv1.2, TLSv1.3], tlsClientProtoco

[GitHub] [kafka] cmccabe opened a new pull request, #12958: MINOR: Move dynamic config logic to DynamicConfigPublisher

2022-12-05 Thread GitBox
cmccabe opened a new pull request, #12958: URL: https://github.com/apache/kafka/pull/12958 Split out the logic for applying dynamic configurations to a KafkaConfig object from BrokerMetadataPublisher into a new class, DynamicConfigPublisher. This will allow the ControllerServer to also run

[GitHub] [kafka] mjsax commented on a diff in pull request #12944: [KAFKA-14395] add config to configure client supplier

2022-12-05 Thread GitBox
mjsax commented on code in PR #12944: URL: https://github.com/apache/kafka/pull/12944#discussion_r1040281808 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -1088,6 +1088,28 @@ public void shouldTriggerRecordingOfRocksDBMetricsIfRecordingLevelIsDe

[GitHub] [kafka] anatasiavela opened a new pull request, #12957: MINOR: Fix flaky testClientDisconnectionUpdatesRequestMetrics() (#11987)

2022-12-05 Thread GitBox
anatasiavela opened a new pull request, #12957: URL: https://github.com/apache/kafka/pull/12957 Cherry-pick of [ae45c59](https://github.com/apache/kafka/commit/ae45c59e61c34fcf1abb5d4731a99d400d2c79be). This PR fixes the flaky SocketServerTest.testClientDisconnectionUpdatesRequestMet

[GitHub] [kafka] andymg3 commented on a diff in pull request #12892: KAFKA-14386: Return TopicAssignment from the ReplicaPlacer

2022-12-05 Thread GitBox
andymg3 commented on code in PR #12892: URL: https://github.com/apache/kafka/pull/12892#discussion_r1037646348 ## metadata/src/main/java/org/apache/kafka/metadata/placement/PartitionAssignment.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12956: Kafka 14379 client preferred read replica

2022-12-05 Thread GitBox
artemlivshits commented on code in PR #12956: URL: https://github.com/apache/kafka/pull/12956#discussion_r1040244300 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1154,7 +1155,9 @@ Node selectReadReplica(TopicPartition partition, Node

[GitHub] [kafka] artemlivshits opened a new pull request, #12956: Kafka 14379 client preferred read replica

2022-12-05 Thread GitBox
artemlivshits opened a new pull request, #12956: URL: https://github.com/apache/kafka/pull/12956 KAFKA-14379: consumer should refresh preferred read replica on update metadata The consumer (fetcher) used to refresh the preferred read replica on three conditions: 1. t

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12903: KAFKA-14415: Faster ThreadCache

2022-12-05 Thread GitBox
ableegoldman commented on code in PR #12903: URL: https://github.com/apache/kafka/pull/12903#discussion_r1040224575 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java: ## @@ -81,9 +85,11 @@ public synchronized void resize(final long newCacheSizeB

[jira] [Created] (KAFKA-14444) Simplify user experience of customizing partitioning strategy in Streams

2022-12-05 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-1: -- Summary: Simplify user experience of customizing partitioning strategy in Streams Key: KAFKA-1 URL: https://issues.apache.org/jira/browse/KAFKA-1

[jira] [Commented] (KAFKA-14438) Stop supporting empty consumer groupId

2022-12-05 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643596#comment-17643596 ] Philip Nee commented on KAFKA-14438: I think we could un-support the groupId="" afte

[jira] [Commented] (KAFKA-14438) Stop supporting empty consumer groupId

2022-12-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643592#comment-17643592 ] Kirk True commented on KAFKA-14438: --- [~pnee] - is this something you want to provide a

[jira] [Commented] (KAFKA-14438) Stop supporting empty consumer groupId

2022-12-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643591#comment-17643591 ] Kirk True commented on KAFKA-14438: --- +1 > Stop supporting empty consumer groupId > --

[GitHub] [kafka] andymg3 commented on a diff in pull request #12892: KAFKA-14386: Return TopicAssignment from the ReplicaPlacer

2022-12-05 Thread GitBox
andymg3 commented on code in PR #12892: URL: https://github.com/apache/kafka/pull/12892#discussion_r1037481276 ## metadata/src/main/java/org/apache/kafka/metadata/placement/TopicAssignment.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] andymg3 commented on a diff in pull request #12892: KAFKA-14386: Return TopicAssignment from the ReplicaPlacer

2022-12-05 Thread GitBox
andymg3 commented on code in PR #12892: URL: https://github.com/apache/kafka/pull/12892#discussion_r1037646184 ## metadata/src/main/java/org/apache/kafka/metadata/placement/TopicAssignment.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] divijvaidya commented on pull request #12940: MINOR: Remove lock contention while adding sensors

2022-12-05 Thread GitBox
divijvaidya commented on PR #12940: URL: https://github.com/apache/kafka/pull/12940#issuecomment-1338178759 I am moving this PR to draft mode. Please hold the review. I need to add a proof here that the when we relax synchronisation amongst operations in this class by allowing concurr

[jira] [Resolved] (KAFKA-14398) Update EndToEndAuthorizerTest.scala to test with ZK and KRAFT quorum servers

2022-12-05 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano resolved KAFKA-14398. --- Resolution: Resolved > Update EndToEndAuthorizerTest.scala to test with ZK and KRAFT

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12955: KAFKA-14443: Close topic creation Admin clients in MM2 connectors

2022-12-05 Thread GitBox
OmniaGM commented on code in PR #12955: URL: https://github.com/apache/kafka/pull/12955#discussion_r1040002739 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -159,8 +159,11 @@ Collection listConsumerGroups() } pr

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12955: KAFKA-14443: Close topic creation Admin clients in MM2 connectors

2022-12-05 Thread GitBox
OmniaGM commented on code in PR #12955: URL: https://github.com/apache/kafka/pull/12955#discussion_r1040002739 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -159,8 +159,11 @@ Collection listConsumerGroups() } pr

[GitHub] [kafka] gharris1727 commented on pull request #12955: KAFKA-14443: Close topic creation Admin clients in MM2 connectors

2022-12-05 Thread GitBox
gharris1727 commented on PR #12955: URL: https://github.com/apache/kafka/pull/12955#issuecomment-1337986105 cc @OmniaGM @tombentley @mimaison This is a regression introduced in #12577 and should be merged to all branches which have that feature (AFAIU, only trunk presently.) -- Thi

[GitHub] [kafka] gharris1727 opened a new pull request, #12955: KAFKA-14443: Close topic creation Admin clients in MM2 connectors

2022-12-05 Thread GitBox
gharris1727 opened a new pull request, #12955: URL: https://github.com/apache/kafka/pull/12955 The MirrorCheckpointConnector, MirrorHeartbeatConnector, and MirrorSourceConnector all create internal topics, but leak the Admin client used to do so. Instead, this Admin client should be persist

[jira] [Created] (KAFKA-14443) Mirror Maker Connectors leak admin clients used for topic creation

2022-12-05 Thread Greg Harris (Jira)
Greg Harris created KAFKA-14443: --- Summary: Mirror Maker Connectors leak admin clients used for topic creation Key: KAFKA-14443 URL: https://issues.apache.org/jira/browse/KAFKA-14443 Project: Kafka

[GitHub] [kafka] ijuma commented on pull request #12948: MINOR: Add JDK 19 & Scala 2.13 CI build

2022-12-05 Thread GitBox
ijuma commented on PR #12948: URL: https://github.com/apache/kafka/pull/12948#issuecomment-1337904630 Interesting failure with Java 19: > 09:03:40 Gradle Test Run :core:integrationTest > Gradle Test Executor 166 > DynamicBrokerReconfigurationTest > testTrustStoreAlter(String) > kafk

[jira] [Commented] (KAFKA-14439) Specify returned errors for various APIs and versions

2022-12-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643491#comment-17643491 ] David Jacot commented on KAFKA-14439: - +1 for having supported errors in the protoco

[GitHub] [kafka] yashmayya commented on a diff in pull request #12800: KAFKA-14342: KafkaOffsetBackingStore should clear offsets for source partitions on tombstone messages

2022-12-05 Thread GitBox
yashmayya commented on code in PR #12800: URL: https://github.com/apache/kafka/pull/12800#discussion_r1039917846 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -329,6 +329,60 @@ public void testGetSetNull() throws Except

[GitHub] [kafka] gharris1727 commented on pull request #12937: KAFKA-13881: Add Connect package infos

2022-12-05 Thread GitBox
gharris1727 commented on PR #12937: URL: https://github.com/apache/kafka/pull/12937#issuecomment-1337868192 @C0urante Could you take a look at this? TIA! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] ijuma commented on pull request #12939: MINOR; Avoid unnecessarily requesting node for post step in Jenkinsfile

2022-12-05 Thread GitBox
ijuma commented on PR #12939: URL: https://github.com/apache/kafka/pull/12939#issuecomment-1337848624 Well spotted, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2022-12-05 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643477#comment-17643477 ] Justine Olshan commented on KAFKA-12671: KIP-890 should be able to help with thi

[GitHub] [kafka] mimaison commented on a diff in pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

2022-12-05 Thread GitBox
mimaison commented on code in PR #12366: URL: https://github.com/apache/kafka/pull/12366#discussion_r1039892964 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -69,6 +75,8 @@ public class MirrorSourceConnector extends SourceConne

[GitHub] [kafka] dajac commented on a diff in pull request #12954: KAFKA-14352: Rack-aware consumer partition assignment protocol changes (KIP-881)

2022-12-05 Thread GitBox
dajac commented on code in PR #12954: URL: https://github.com/apache/kafka/pull/12954#discussion_r1039862483 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocolTest.java: ## @@ -56,7 +56,7 @@ public void serializeDeserializeSubscriptionAllVersio

[GitHub] [kafka] C0urante commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-05 Thread GitBox
C0urante commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1039787775 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1645,6 +1646,8 @@ private void startAndStop(Collection> c

[GitHub] [kafka] dajac commented on a diff in pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-05 Thread GitBox
dajac commented on code in PR #12914: URL: https://github.com/apache/kafka/pull/12914#discussion_r1039767650 ## clients/src/main/java/org/apache/kafka/clients/consumer/RangeAssignor.java: ## @@ -76,43 +88,145 @@ private Map> consumersPerTopic(Map> topicToConsumers = new HashMap

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-05 Thread GitBox
rajinisivaram commented on code in PR #12914: URL: https://github.com/apache/kafka/pull/12914#discussion_r1039763712 ## clients/src/main/java/org/apache/kafka/clients/consumer/RangeAssignor.java: ## @@ -76,43 +88,145 @@ private Map> consumersPerTopic(Map> topicToConsumers = new

[GitHub] [kafka] dajac merged pull request #12939: MINOR; Avoid unnecessarily requesting node for post step in Jenkinsfile

2022-12-05 Thread GitBox
dajac merged PR #12939: URL: https://github.com/apache/kafka/pull/12939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] cadonna commented on pull request #12935: KAFKA-14432: RocksDBStore relies on finalizers to not leak memory

2022-12-05 Thread GitBox
cadonna commented on PR #12935: URL: https://github.com/apache/kafka/pull/12935#issuecomment-1337593210 @lucasbru Actually, I didn't want to approve. Could you please answer my questions before I merge? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] cadonna commented on a diff in pull request #12935: KAFKA-14432: RocksDBStore relies on finalizers to not leak memory

2022-12-05 Thread GitBox
cadonna commented on code in PR #12935: URL: https://github.com/apache/kafka/pull/12935#discussion_r1039754929 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ## @@ -526,6 +521,9 @@ public synchronized void close() { fOptions.close()

[GitHub] [kafka] C0urante commented on a diff in pull request #12800: KAFKA-14342: KafkaOffsetBackingStore should clear offsets for source partitions on tombstone messages

2022-12-05 Thread GitBox
C0urante commented on code in PR #12800: URL: https://github.com/apache/kafka/pull/12800#discussion_r1039745954 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -329,6 +329,60 @@ public void testGetSetNull() throws Excepti

[GitHub] [kafka] jonathan-albrecht-ibm commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-12-05 Thread GitBox
jonathan-albrecht-ibm commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1039745728 ## clients/src/main/java/org/apache/kafka/common/utils/Java.java: ## @@ -44,6 +44,10 @@ public static boolean isIbmJdk() { return System.getPrope

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-05 Thread GitBox
rajinisivaram commented on code in PR #12914: URL: https://github.com/apache/kafka/pull/12914#discussion_r1039723313 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPartitionAssignor.java: ## @@ -84,13 +110,65 @@ protected static List partitions(Stri

[GitHub] [kafka] C0urante commented on a diff in pull request #12947: KAFKA-6586: Refactor ConnectDistributed and ConnectStandalone to re-use shared logic

2022-12-05 Thread GitBox
C0urante commented on code in PR #12947: URL: https://github.com/apache/kafka/pull/12947#discussion_r1039714073 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java: ## @@ -21,41 +21,51 @@ import org.apache.kafka.common.utils.Utils; import org.

[GitHub] [kafka] ijuma commented on pull request #12951: MINOR: Move MetadataQuorumCommand from `core` to `tools`

2022-12-05 Thread GitBox
ijuma commented on PR #12951: URL: https://github.com/apache/kafka/pull/12951#issuecomment-1337534591 > It would be very useful to new contributors if you could add this information (about package structure/ownership) to https://kafka.apache.org/coding-guide or a package info file. W

[GitHub] [kafka] ijuma commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-12-05 Thread GitBox
ijuma commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1039711882 ## clients/src/test/java/org/apache/kafka/common/utils/JavaTest.java: ## @@ -46,9 +49,22 @@ public void testIsIBMJdk() { assertTrue(Java.isIbmJdk()); } +

[GitHub] [kafka] jonathan-albrecht-ibm commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-12-05 Thread GitBox
jonathan-albrecht-ibm commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1039696317 ## clients/src/test/java/org/apache/kafka/common/utils/JavaTest.java: ## @@ -46,9 +49,22 @@ public void testIsIBMJdk() { assertTrue(Java.isIbmJdk

[GitHub] [kafka] rajinisivaram closed pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-05 Thread GitBox
rajinisivaram closed pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881) URL: https://github.com/apache/kafka/pull/12914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-05 Thread GitBox
rajinisivaram commented on PR #12914: URL: https://github.com/apache/kafka/pull/12914#issuecomment-1337488793 @dajac Opened https://github.com/apache/kafka/pull/12954 with just the protocol changes. Please take a look when you have time. I will close this PR. Thank you! -- This is an aut

[GitHub] [kafka] C0urante merged pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
C0urante merged PR #12846: URL: https://github.com/apache/kafka/pull/12846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] ijuma commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-12-05 Thread GitBox
ijuma commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1039681666 ## clients/src/main/java/org/apache/kafka/common/utils/Java.java: ## @@ -44,6 +44,10 @@ public static boolean isIbmJdk() { return System.getProperty("java.vendor

[GitHub] [kafka] ijuma commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-12-05 Thread GitBox
ijuma commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1039681666 ## clients/src/main/java/org/apache/kafka/common/utils/Java.java: ## @@ -44,6 +44,10 @@ public static boolean isIbmJdk() { return System.getProperty("java.vendor

[GitHub] [kafka] ijuma commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-12-05 Thread GitBox
ijuma commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1039680283 ## clients/src/test/java/org/apache/kafka/common/utils/JavaTest.java: ## @@ -46,9 +49,22 @@ public void testIsIBMJdk() { assertTrue(Java.isIbmJdk()); } +

[GitHub] [kafka] rajinisivaram opened a new pull request, #12954: KAFKA-14352: Rack-aware consumer partition assignment protocol changes (KIP-881)

2022-12-05 Thread GitBox
rajinisivaram opened a new pull request, #12954: URL: https://github.com/apache/kafka/pull/12954 Protocol changes for KIP-881 to support rack-aware partition assignment for consumers. Default assignors will be updated in subsequent PRs to use racks to improve locality. ### Committer

[GitHub] [kafka] C0urante commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
C0urante commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039679491 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,84 @@ public void handle(C

[GitHub] [kafka] C0urante commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
C0urante commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039679491 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,84 @@ public void handle(C

[jira] [Assigned] (KAFKA-14405) Log a warning when users attempt to set a config controlled by Streams

2022-12-05 Thread Ashmeet Lamba (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashmeet Lamba reassigned KAFKA-14405: - Assignee: Ashmeet Lamba > Log a warning when users attempt to set a config controlled b

[GitHub] [kafka] ijuma commented on pull request #12953: MINOR: Remove unnecessary scalac warnings suppression

2022-12-05 Thread GitBox
ijuma commented on PR #12953: URL: https://github.com/apache/kafka/pull/12953#issuecomment-1337450974 JDK 11 and 17 passed, JDK 8 had 4 unrelated failures: > Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegration

[GitHub] [kafka] ijuma merged pull request #12953: MINOR: Remove unnecessary scalac warnings suppression

2022-12-05 Thread GitBox
ijuma merged PR #12953: URL: https://github.com/apache/kafka/pull/12953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma merged pull request #12950: MINOR: Remove KafkaTimer

2022-12-05 Thread GitBox
ijuma merged PR #12950: URL: https://github.com/apache/kafka/pull/12950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dengziming commented on pull request #12946: KAFKA-14427 ZK client support for migrations

2022-12-05 Thread GitBox
dengziming commented on PR #12946: URL: https://github.com/apache/kafka/pull/12946#issuecomment-1337436123 Thanks for this PR @mumrah , I have added this to my review backlog and will take a look this week. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] rajinisivaram commented on pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-05 Thread GitBox
rajinisivaram commented on PR #12914: URL: https://github.com/apache/kafka/pull/12914#issuecomment-1337328993 @dajac Makes sense, will do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-05 Thread GitBox
dajac commented on PR #12914: URL: https://github.com/apache/kafka/pull/12914#issuecomment-1337323399 @rajinisivaram Would it make sense to split into three pull requests? One for the protocol changes, one for the range and another one for the sticky assignor. I think that we could definite

[GitHub] [kafka] rajinisivaram commented on pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-05 Thread GitBox
rajinisivaram commented on PR #12914: URL: https://github.com/apache/kafka/pull/12914#issuecomment-1337313522 @dajac Thanks for reviewing the PR. I was thinking of splitting the PR earlier to include the protocol changes and RangeAssignor changes in the first PR and move sticky assignor cha

[GitHub] [kafka] dajac commented on pull request #12933: MINOR: Optimize metric recording when quota check not required

2022-12-05 Thread GitBox
dajac commented on PR #12933: URL: https://github.com/apache/kafka/pull/12933#issuecomment-1337296109 Merged to trunk. @divijvaidya Thanks for the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dajac merged pull request #12933: MINOR: Optimize metric recording when quota check not required

2022-12-05 Thread GitBox
dajac merged PR #12933: URL: https://github.com/apache/kafka/pull/12933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] divijvaidya commented on pull request #12951: MINOR: Move MetadataQuorumCommand from `core` to `tools`

2022-12-05 Thread GitBox
divijvaidya commented on PR #12951: URL: https://github.com/apache/kafka/pull/12951#issuecomment-1337275148 > core should only be used for legacy cli tools and tools that don't require access to core classes instead of communicating via the kafka protocol (typically by using the client

[GitHub] [kafka] cadonna merged pull request #12931: MINOR: Fix log message used in version probing system test

2022-12-05 Thread GitBox
cadonna merged PR #12931: URL: https://github.com/apache/kafka/pull/12931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

2022-12-05 Thread GitBox
divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r1039472517 ## clients/src/main/java/org/apache/kafka/common/network/Selector.java: ## @@ -809,6 +810,13 @@ private void maybeCloseOldestConnection(long currentTimeNanos) {

[GitHub] [kafka] divijvaidya commented on pull request #12228: KAFKA-13950: Fix resource leaks

2022-12-05 Thread GitBox
divijvaidya commented on PR #12228: URL: https://github.com/apache/kafka/pull/12228#issuecomment-1337176412 Rebased from trunk to fix conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039449554 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,84 @@ public void han

[GitHub] [kafka] divijvaidya commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-12-05 Thread GitBox
divijvaidya commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1337141200 @ijuma would you please take a look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] divijvaidya commented on pull request #12228: KAFKA-13950: Fix resource leaks

2022-12-05 Thread GitBox
divijvaidya commented on PR #12228: URL: https://github.com/apache/kafka/pull/12228#issuecomment-1337140082 @ijuma what are your thoughts on this one? I would either like to discard it or have it merged since it is pending for a long time! Let me know your thoughts. -- This is an automat

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039441717 ## connect/basic-auth-extension/src/test/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilterTest.java: ## @@ -211,6 +214,18 @@ public void

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039441425 ## connect/basic-auth-extension/src/test/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilterTest.java: ## @@ -211,6 +214,18 @@ public void

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039440782 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,85 @@ public void han

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039440440 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,85 @@ public void han

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039439925 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,85 @@ public void han

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039439337 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,85 @@ public void han

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039438953 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,85 @@ public void han

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-12-05 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1039438778 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,84 @@ public void han

[GitHub] [kafka] divijvaidya commented on pull request #12940: MINOR: Remove lock contention while adding sensors

2022-12-05 Thread GitBox
divijvaidya commented on PR #12940: URL: https://github.com/apache/kafka/pull/12940#issuecomment-1337109469 Thank you for your review @ijuma. I see that you back to reviewing PRs after a bit of break :) I did not understand your comment about weaker semantics. I believe that the sem

[jira] [Created] (KAFKA-14442) GlobalKTable restoration waits requestTimeout during application restart

2022-12-05 Thread Jira
Gergo L��p created KAFKA-14442: -- Summary: GlobalKTable restoration waits requestTimeout during application restart Key: KAFKA-14442 URL: https://issues.apache.org/jira/browse/KAFKA-14442 Project: Kafka

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12803: KAFKA-13602: Adding ability to multicast records.

2022-12-05 Thread GitBox
vamossagar12 commented on code in PR #12803: URL: https://github.com/apache/kafka/pull/12803#discussion_r1039384220 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java: ## @@ -459,12 +461,23 @@ private List rebuildMetadataForSingleTop

[GitHub] [kafka] omkreddy closed pull request #12812: MINOR: Fix SaslPlainSslEndToEndAuthorizationTest

2022-12-05 Thread GitBox
omkreddy closed pull request #12812: MINOR: Fix SaslPlainSslEndToEndAuthorizationTest URL: https://github.com/apache/kafka/pull/12812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] Anuragkillswitch commented on pull request #12950: MINOR: Remove KafkaTimer

2022-12-05 Thread GitBox
Anuragkillswitch commented on PR #12950: URL: https://github.com/apache/kafka/pull/12950#issuecomment-1336957971 @ijuma I can see multiple tests failing https://user-images.githubusercontent.com/70265851/205591295-28e1740b-a57e-42c2-9463-70bca1e53ed9.png";> e.g. https://user-images.

[GitHub] [kafka] dajac merged pull request #12850: KAFKA-14367; Add `LeaveGroup` to the new `GroupCoordinator` interface

2022-12-05 Thread GitBox
dajac merged PR #12850: URL: https://github.com/apache/kafka/pull/12850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or