showuon commented on PR #11390:
URL: https://github.com/apache/kafka/pull/11390#issuecomment-1340522323
@junrao , do you want to have another review? Since branch 3.4 has created,
and this PR blocks some following tiered storage feature development (ex:
copying segments to tiered storage, r
showuon commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1041821188
##
core/src/main/scala/kafka/log/remote/RemoteLogManager.scala:
##
@@ -0,0 +1,290 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
ableegoldman commented on code in PR #12960:
URL: https://github.com/apache/kafka/pull/12960#discussion_r1041793005
##
tests/kafkatest/version.py:
##
@@ -119,7 +119,7 @@ def get_version(node=None):
return DEV_BRANCH
DEV_BRANCH = KafkaVersion("dev")
-DEV_VERSION = Kaf
ableegoldman opened a new pull request, #12962:
URL: https://github.com/apache/kafka/pull/12962
First PR for [KIP-878: Internal Topic Autoscaling for Kafka
Streams](https://cwiki.apache.org/confluence/display/KAFKA/KIP-878%3A+Internal+Topic+Autoscaling+for+Kafka+Streams)
Introduces tw
[
https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644129#comment-17644129
]
A. Sophie Blee-Goldman commented on KAFKA-14260:
Ok I did merge a patch
[
https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-14260.
Resolution: Fixed
> InMemoryKeyValueStore iterator still throws Concurrent
[
https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14260:
---
Fix Version/s: 3.4.0
> InMemoryKeyValueStore iterator still throws Concurren
ableegoldman commented on PR #12893:
URL: https://github.com/apache/kafka/pull/12893#issuecomment-1340330339
Merged to trunk and cherrypicked to 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ableegoldman merged PR #12893:
URL: https://github.com/apache/kafka/pull/12893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
[
https://issues.apache.org/jira/browse/KAFKA-13602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-13602.
Resolution: Fixed
> Allow to broadcast a result record
> -
akhileshchg opened a new pull request, #12961:
URL: https://github.com/apache/kafka/pull/12961
KAFKA-14446: API forwarding support from zkBrokers to the controller
**Changes**
* Enable `EnvelopeRequest` to support zkBroker to zkController forwarding.
* Changes to `BrokerToControl
Akhilesh Chaganti created KAFKA-14446:
-
Summary: API forwarding support in ZkBrokers
Key: KAFKA-14446
URL: https://issues.apache.org/jira/browse/KAFKA-14446
Project: Kafka
Issue Type: Sub
[
https://issues.apache.org/jira/browse/KAFKA-13602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-13602:
---
Fix Version/s: 3.4.0
> Allow to broadcast a result record
>
ableegoldman commented on PR #12955:
URL: https://github.com/apache/kafka/pull/12955#issuecomment-1340276915
> This change may be scope-creep for this PR, and maybe better handled as a
lateral refactor after the release blocker bug is resolved.
Just my 2 cents as the 3.4 release manag
[
https://issues.apache.org/jira/browse/KAFKA-14443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14443:
---
Fix Version/s: 3.4.0
> Mirror Maker Connectors leak admin clients used for t
ableegoldman opened a new pull request, #12960:
URL: https://github.com/apache/kafka/pull/12960
Version bumps in trunk after the creation of the 3.4 branch.
Also fixed the comment in `gradle.properties` which was missing several
files related to the streams quickstart from the list of
[
https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-14415.
Resolution: Fixed
> ThreadCache is getting slower with every additional st
[
https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14415:
---
Fix Version/s: 3.4.0
> ThreadCache is getting slower with every additional s
ableegoldman merged PR #12903:
URL: https://github.com/apache/kafka/pull/12903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
ableegoldman commented on code in PR #12903:
URL: https://github.com/apache/kafka/pull/12903#discussion_r1041651458
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java:
##
@@ -81,9 +85,13 @@ public synchronized void resize(final long
newCacheSizeB
ableegoldman commented on code in PR #12903:
URL: https://github.com/apache/kafka/pull/12903#discussion_r1041650741
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java:
##
@@ -81,9 +85,13 @@ public synchronized void resize(final long
newCacheSizeB
ableegoldman commented on code in PR #12903:
URL: https://github.com/apache/kafka/pull/12903#discussion_r1041647625
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java:
##
@@ -241,35 +267,30 @@ private boolean isOverflowing(final long size) {
ableegoldman commented on code in PR #12903:
URL: https://github.com/apache/kafka/pull/12903#discussion_r1041646981
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java:
##
@@ -81,9 +85,11 @@ public synchronized void resize(final long
newCacheSizeB
cmccabe commented on PR #12946:
URL: https://github.com/apache/kafka/pull/12946#issuecomment-1340220864
> WDYT about adding the idempotent stuff as a follow-on PR?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14379:
---
Priority: Blocker (was: Critical)
> consumer should refresh preferred read
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1033516642
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -289,13 +296,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
@volatile var partitionMetadataFil
[
https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644055#comment-17644055
]
Haruki Okada commented on KAFKA-14445:
--
[~kirktrue] Oh I was not aware of KAFKA-143
mumrah commented on PR #12946:
URL: https://github.com/apache/kafka/pull/12946#issuecomment-1340102935
@cmccabe I've added a large constant (10M) to the controller epoch when
persisting it in ZK. I think this workaround should allow us to move forward
with integration/system testing prior t
mumrah commented on code in PR #12958:
URL: https://github.com/apache/kafka/pull/12958#discussion_r1041510271
##
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
cmccabe commented on code in PR #12958:
URL: https://github.com/apache/kafka/pull/12958#discussion_r1041503192
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -71,7 +71,7 @@ class BrokerServer(
val initialOfflineDirs: Seq[String],
) extends KafkaBroker {
val
lucasbru commented on code in PR #12903:
URL: https://github.com/apache/kafka/pull/12903#discussion_r1040930847
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java:
##
@@ -133,7 +139,12 @@ public void flush(final String namespace) {
if (ca
jsancio merged PR #12892:
URL: https://github.com/apache/kafka/pull/12892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kirktrue commented on code in PR #12945:
URL: https://github.com/apache/kafka/pull/12945#discussion_r1041415886
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsFinder.java:
##
@@ -0,0 +1,805 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jolshan commented on PR #12915:
URL: https://github.com/apache/kafka/pull/12915#issuecomment-1339938684
Did we want to cherry pick this back to older branches @hachikuji? Or wait
for the server side version for that?
--
This is an automated message from the Apache Git Service.
To respond
hachikuji merged PR #12915:
URL: https://github.com/apache/kafka/pull/12915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
gharris1727 commented on code in PR #12937:
URL: https://github.com/apache/kafka/pull/12937#discussion_r1041375736
##
connect/api/src/main/java/org/apache/kafka/connect/connector/policy/package-info.java:
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
gharris1727 commented on PR #12955:
URL: https://github.com/apache/kafka/pull/12955#issuecomment-1339870223
@OmniaGM I believe that failure is flaky, as I cannot reproduce it locally.
Those sorts of flaky failures are what got me looking at this code in the first
place, coincidentally.
[
https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644001#comment-17644001
]
Kirk True commented on KAFKA-14445:
---
[~ocadaruma] - I modified the code in `completeBa
[
https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644001#comment-17644001
]
Kirk True edited comment on KAFKA-14445 at 12/6/22 6:42 PM:
vamossagar12 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1041307783
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1645,6 +1646,8 @@ private void startAndStop(Collection
cmccabe commented on PR #12946:
URL: https://github.com/apache/kafka/pull/12946#issuecomment-1339779087
* need to add idempotence stuff (handle error where we create something and
it already exists, or delete something and it's already gone)
--
This is an automated message from the Apache
cmccabe commented on PR #12946:
URL: https://github.com/apache/kafka/pull/12946#issuecomment-1339772134
We do need a temporary workaround for KAFKA-14436. We discussed offline
about just adding a big constant to it
--
This is an automated message from the Apache Git Service.
To respond to
cmccabe commented on code in PR #12946:
URL: https://github.com/apache/kafka/pull/12946#discussion_r1041288418
##
metadata/src/main/java/org/apache/kafka/metadata/migration/ZkMigrationLeadershipState.java:
##
@@ -100,26 +106,30 @@ public boolean zkMigrationComplete() {
@Ove
cmccabe commented on code in PR #12946:
URL: https://github.com/apache/kafka/pull/12946#discussion_r1041287139
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -54,6 +54,19 @@ import org.apache.kafka.common.utils.Sanitizer
import scala.collection.{Map, mutable, _
dajac commented on PR #12932:
URL: https://github.com/apache/kafka/pull/12932#issuecomment-1339754347
@cmccabe Could you review this one please? The vote is not closed yet but we
have all the votes.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
lucasbru opened a new pull request, #12959:
URL: https://github.com/apache/kafka/pull/12959
Various tests in the streams park were leaking native memory.
Most tests were fixed by closing the corresponding rocksdb resource.
I tested that the corresponding leak is gone by using a
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1041219212
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -386,11 +397,147 @@ class ReplicaFetcherThread(name: String,
}
/**
- * To avoid ISR thr
mumrah commented on code in PR #12958:
URL: https://github.com/apache/kafka/pull/12958#discussion_r1041165700
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -71,7 +71,7 @@ class BrokerServer(
val initialOfflineDirs: Seq[String],
) extends KafkaBroker {
val
[
https://issues.apache.org/jira/browse/KAFKA-14443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14443:
--
Priority: Critical (was: Major)
> Mirror Maker Connectors leak admin clients used for topic c
[
https://issues.apache.org/jira/browse/KAFKA-14443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14443:
--
Affects Version/s: 3.4.0
> Mirror Maker Connectors leak admin clients used for topic creation
C0urante commented on code in PR #12937:
URL: https://github.com/apache/kafka/pull/12937#discussion_r1041131493
##
connect/api/src/main/java/org/apache/kafka/connect/header/package-info.java:
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
C0urante merged PR #12800:
URL: https://github.com/apache/kafka/pull/12800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #12935:
URL: https://github.com/apache/kafka/pull/12935#issuecomment-1339425004
Failing tests are unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cadonna commented on code in PR #12935:
URL: https://github.com/apache/kafka/pull/12935#discussion_r1041000955
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -229,40 +230,34 @@ void openDB(final Map configs, final File
stateDir) {
[
https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-14445:
-
Description:
Produce requests may fail with timeout by `request.timeout.ms` in below two
cases:
C0urante commented on code in PR #12800:
URL: https://github.com/apache/kafka/pull/12800#discussion_r1039745954
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -329,6 +329,60 @@ public void testGetSetNull() throws Excepti
lucasbru closed pull request #12925: Revert "[KAFKA-14324] Upgrade RocksDB to
7.1.2 (#12809)"
URL: https://github.com/apache/kafka/pull/12925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
lucasbru commented on code in PR #12935:
URL: https://github.com/apache/kafka/pull/12935#discussion_r1040889287
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -229,40 +230,34 @@ void openDB(final Map configs, final File
stateDir) {
cadonna commented on code in PR #12935:
URL: https://github.com/apache/kafka/pull/12935#discussion_r1040845929
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -229,40 +230,34 @@ void openDB(final Map configs, final File
stateDir) {
lucasbru commented on code in PR #12935:
URL: https://github.com/apache/kafka/pull/12935#discussion_r1040808154
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -229,40 +230,34 @@ void openDB(final Map configs, final File
stateDir) {
lucasbru commented on code in PR #12935:
URL: https://github.com/apache/kafka/pull/12935#discussion_r1040807515
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -346,20 +346,6 @@ public void
shouldNotAddItselfToRec
lucasbru commented on code in PR #12935:
URL: https://github.com/apache/kafka/pull/12935#discussion_r1040792337
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -526,6 +521,9 @@ public synchronized void close() {
fOptions.close(
[
https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-14445:
-
Description:
Produce requests may fail with timeout by `request.timeout.ms` in below two
cases:
[
https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643768#comment-17643768
]
Haruki Okada commented on KAFKA-14445:
--
If the suggestion makes sense, we're happy
ableegoldman merged PR #12803:
URL: https://github.com/apache/kafka/pull/12803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
Haruki Okada created KAFKA-14445:
Summary: Producer doesn't request metadata update on
REQUEST_TIMED_OUT
Key: KAFKA-14445
URL: https://issues.apache.org/jira/browse/KAFKA-14445
Project: Kafka
rajinisivaram commented on PR #12954:
URL: https://github.com/apache/kafka/pull/12954#issuecomment-1339003475
@dajac Thanks for the review, have addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
rajinisivaram commented on code in PR #12954:
URL: https://github.com/apache/kafka/pull/12954#discussion_r1040687385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -245,7 +248,8 @@ protected
JoinGroupRequestData.JoinGroupReq
[
https://issues.apache.org/jira/browse/KAFKA-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643737#comment-17643737
]
Abdullah alkhawatrah commented on KAFKA-14440:
--
Makes sense. Thanks!
> Loc
rajinisivaram commented on code in PR #12954:
URL: https://github.com/apache/kafka/pull/12954#discussion_r1040685932
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPartitionAssignor.java:
##
@@ -47,23 +51,37 @@ public abstract class AbstractPartitio
70 matches
Mail list logo
