[jira] [Commented] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Endre Vig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648357#comment-17648357 ] Endre Vig commented on KAFKA-14496: --- [~kirktrue], thanks for acting so fast upon the ticket and

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12985: KAFKA-13602: Remove unwanted logging in RecordCollectorImpl.java

2022-12-15 Thread GitBox
vamossagar12 commented on code in PR #12985: URL: https://github.com/apache/kafka/pull/12985#discussion_r1050389751 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -159,7 +159,8 @@ public void send(final String topic,

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12998: KAFKA-14493: Introduce Zk to KRaft migration state machine STUBs in KRaft controller.

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12998: URL: https://github.com/apache/kafka/pull/12998#discussion_r1050300078 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -88,14 +83,23 @@ private void initializeMigrationState() { }

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12998: KAFKA-14493: Introduce Zk to KRaft migration state machine STUBs in KRaft controller.

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12998: URL: https://github.com/apache/kafka/pull/12998#discussion_r1050297925 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -88,14 +83,23 @@ private void initializeMigrationState() { }

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1050278848 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1050276330 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker

[GitHub] [kafka] cmccabe merged pull request #12983: MINOR: ControllerServer should use the new metadata loader and snapshot generator

2022-12-15 Thread GitBox
cmccabe merged PR #12983: URL: https://github.com/apache/kafka/pull/12983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-15 Thread GitBox
cmccabe commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1050263765 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker

[GitHub] [kafka] cmccabe commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-15 Thread GitBox
cmccabe commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1050263485 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -290,29 +295,27 @@ case class BrokerToControllerQueueItem( ) class

[GitHub] [kafka] bbejeck opened a new pull request, #13002: Minor no error with zero results state query

2022-12-15 Thread GitBox
bbejeck opened a new pull request, #13002: URL: https://github.com/apache/kafka/pull/13002 This PR updates `StateQueryResult.getOnlyPartitionResult()` to not throw an `IllegaArgumentException` when there are 0 query results. Added a test that will fail without this patch ###

[GitHub] [kafka] akhileshchg opened a new pull request, #13001: KAFKA-14446: Follow up to the comments unaddressed on Zk brokers API …

2022-12-15 Thread GitBox
akhileshchg opened a new pull request, #13001: URL: https://github.com/apache/kafka/pull/13001 …forwarding patch Original patch: https://github.com/apache/kafka/pull/12961/files# -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kirktrue commented on pull request #13000: KAFKA-14496: Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread GitBox
kirktrue commented on PR #13000: URL: https://github.com/apache/kafka/pull/13000#issuecomment-1353884809 @omkreddy - would you be willing to review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648297#comment-17648297 ] Kirk True commented on KAFKA-14496: --- [~vendre] - I've made a pull request

[GitHub] [kafka] kirktrue opened a new pull request, #13000: KAFKA-14496: Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread GitBox
kirktrue opened a new pull request, #13000: URL: https://github.com/apache/kafka/pull/13000 The OAuth code to generate the `Authentication` header was incorrectly using the URL-safe base64 encoder. For client IDs and/or secrets with dashes and/or plus signs would not be encoded correctly,

[GitHub] [kafka] ableegoldman commented on pull request #12985: KAFKA-13602: Remove unwanted logging in RecordCollectorImpl.java

2022-12-15 Thread GitBox
ableegoldman commented on PR #12985: URL: https://github.com/apache/kafka/pull/12985#issuecomment-1353835646 Cherrypicked to 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ableegoldman commented on pull request #12977: KAFKA-13602: Removing Multicasting partitioner for IQ

2022-12-15 Thread GitBox
ableegoldman commented on PR #12977: URL: https://github.com/apache/kafka/pull/12977#issuecomment-1353835301 Merged to trunk and cherrypicked to 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12985: KAFKA-13602: Remove unwanted logging in RecordCollectorImpl.java

2022-12-15 Thread GitBox
ableegoldman commented on code in PR #12985: URL: https://github.com/apache/kafka/pull/12985#discussion_r1050225672 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -159,7 +159,8 @@ public void send(final String topic,

[GitHub] [kafka] ableegoldman merged pull request #12977: KAFKA-13602: Removing Multicasting partitioner for IQ

2022-12-15 Thread GitBox
ableegoldman merged PR #12977: URL: https://github.com/apache/kafka/pull/12977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14496: -- Priority: Blocker (was: Major) > Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler >

[jira] [Assigned] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-14496: - Assignee: Kirk True > Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler >

[jira] [Commented] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648281#comment-17648281 ] Kirk True commented on KAFKA-14496: --- [~vendre] - thanks for the timely response! I appreciate your

[GitHub] [kafka] cmccabe merged pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
cmccabe merged PR #12961: URL: https://github.com/apache/kafka/pull/12961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Endre Vig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648245#comment-17648245 ] Endre Vig commented on KAFKA-14496: --- [~kirktrue], there would be no technical issue for me to submit a

[jira] [Commented] (KAFKA-14494) Kafka Java client can't send data when behind SOCKS proxy - while native client can

2022-12-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648241#comment-17648241 ] Kirk True commented on KAFKA-14494: --- [~taiga-elephant] - thanks for finding and reporting this! I

[jira] [Commented] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648239#comment-17648239 ] Kirk True commented on KAFKA-14496: --- [~vendre] - has been deemed a release blocker for AK 3.3.2 and

[GitHub] [kafka] mumrah commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
mumrah commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050096386 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -364,11 +399,13 @@ class BrokerToControllerRequestThread( } override def

[jira] [Commented] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648231#comment-17648231 ] Kirk True commented on KAFKA-14496: --- Thanks for catching this, Endre! > Wrong Base64 encoder used by

[GitHub] [kafka] ijuma commented on pull request #12890: KAFKA-14414: Remove unnecessary usage of ObjectSerializationCache

2022-12-15 Thread GitBox
ijuma commented on PR #12890: URL: https://github.com/apache/kafka/pull/12890#issuecomment-1353646247 @divijvaidya Thanks. Can you please attach the html file? I think it's possible to do it here, but if not then the JIRA would be helpful. I can take a closer look on the bits that seemed a

[jira] [Created] (KAFKA-14497) LastStableOffset is advanced prematurely when a log is reopened.

2022-12-15 Thread Vincent Jiang (Jira)
Vincent Jiang created KAFKA-14497: - Summary: LastStableOffset is advanced prematurely when a log is reopened. Key: KAFKA-14497 URL: https://issues.apache.org/jira/browse/KAFKA-14497 Project: Kafka

[GitHub] [kafka] mumrah commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
mumrah commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050078269 ## core/src/main/scala/kafka/server/MetadataCache.scala: ## @@ -103,13 +110,18 @@ trait MetadataCache { def metadataVersion(): MetadataVersion def features():

[GitHub] [kafka] mumrah commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
mumrah commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050076979 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -248,7 +258,12 @@ class ZkMetadataCache(brokerId: Int, metadataVersion: MetadataVersion,

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050074366 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1318,14 +1317,20 @@ class KafkaApis(val requestChannel: RequestChannel, trace("Sending topic

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050065115 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -248,7 +258,12 @@ class ZkMetadataCache(brokerId: Int, metadataVersion: MetadataVersion,

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050065115 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -248,7 +258,12 @@ class ZkMetadataCache(brokerId: Int, metadataVersion: MetadataVersion,

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050063855 ## core/src/main/scala/kafka/server/MetadataCache.scala: ## @@ -103,13 +110,18 @@ trait MetadataCache { def metadataVersion(): MetadataVersion def

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050049320 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -364,11 +399,13 @@ class BrokerToControllerRequestThread( } override def

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050047950 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -60,16 +60,24 @@ trait ZkFinalizedFeatureCache { * A cache for the state (e.g.,

[GitHub] [kafka] junrao commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-15 Thread GitBox
junrao commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1050008020 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -574,6 +594,12 @@ class UnifiedLog(@volatile var logStartOffset: Long, explicitMetricName(pkgStr, "Log",

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050037434 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -276,17 +290,38 @@ case class BrokerToControllerQueueItem( ) class

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050036052 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -276,17 +290,38 @@ case class BrokerToControllerQueueItem( ) class

[jira] [Commented] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Endre Vig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648208#comment-17648208 ] Endre Vig commented on KAFKA-14496: --- [~omkreddy] I would be very glad to submit a fix. > Wrong Base64

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050028258 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -276,17 +290,38 @@ case class BrokerToControllerQueueItem( ) class

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050026488 ## clients/src/main/resources/common/message/StopReplicaRequest.json: ## @@ -31,7 +31,7 @@ "fields": [ { "name": "ControllerId", "type": "int32",

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
akhileshchg commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1050026225 ## clients/src/main/resources/common/message/LeaderAndIsrRequest.json: ## @@ -36,7 +36,7 @@ "fields": [ { "name": "ControllerId", "type": "int32",

[GitHub] [kafka] vamossagar12 opened a new pull request, #12999: [REVERT] Kip-837

2022-12-15 Thread GitBox
vamossagar12 opened a new pull request, #12999: URL: https://github.com/apache/kafka/pull/12999 Reverts https://github.com/apache/kafka/pull/12803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-15 Thread GitBox
vamossagar12 commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1049987971 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1645,6 +1646,8 @@ private void

[GitHub] [kafka] gharris1727 commented on pull request #12995: KAFKA-14396: De-flake memory tests with new TestUtils.restrictMemory

2022-12-15 Thread GitBox
gharris1727 commented on PR #12995: URL: https://github.com/apache/kafka/pull/12995#issuecomment-1353446482 @ijuma Thanks for pointing that out. I never noticed any effects of the OOMEs on the persistent JVM or other tests, but if I'm trying to de-flake the tests, introducing a new kind of

[GitHub] [kafka] divijvaidya commented on pull request #12890: KAFKA-14414: Remove unnecessary usage of ObjectSerializationCache

2022-12-15 Thread GitBox
divijvaidya commented on PR #12890: URL: https://github.com/apache/kafka/pull/12890#issuecomment-1353397300 @ijuma yes, there was a warm up workload prior to profiling. The JVM was probably alive for ~7-8 min. before the profile capture started. What are the fishy things that you notice

[jira] [Updated] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-14496: -- Fix Version/s: 3.4.0 3.3.2 > Wrong Base64 encoder used by OIDC

[jira] [Commented] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648154#comment-17648154 ] Manikumar commented on KAFKA-14496: --- [~vendre] Thanks for reporting the issue. Would you like to

[GitHub] [kafka] C0urante commented on pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

2022-12-15 Thread GitBox
C0urante commented on PR #12941: URL: https://github.com/apache/kafka/pull/12941#issuecomment-1353348389 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] C0urante merged pull request #12941: KAFKA-13709: Add docs for exactly-once support in Connect

2022-12-15 Thread GitBox
C0urante merged PR #12941: URL: https://github.com/apache/kafka/pull/12941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on a diff in pull request #12961: KAFKA-14446: API forwarding support from zkBrokers to the Controller

2022-12-15 Thread GitBox
mumrah commented on code in PR #12961: URL: https://github.com/apache/kafka/pull/12961#discussion_r1046431404 ## clients/src/main/resources/common/message/StopReplicaRequest.json: ## @@ -31,7 +31,7 @@ "fields": [ { "name": "ControllerId", "type": "int32", "versions":

[GitHub] [kafka] ijuma commented on pull request #12890: KAFKA-14414: Remove unnecessary usage of ObjectSerializationCache

2022-12-15 Thread GitBox
ijuma commented on PR #12890: URL: https://github.com/apache/kafka/pull/12890#issuecomment-1353303765 Was this profile taken after the broker was running for long enough for the JIT compilation to have completed? The profile seems to show some things that look a bit odd. That said,

[GitHub] [kafka] clolov commented on a diff in pull request #12821: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in streams tests

2022-12-15 Thread GitBox
clolov commented on code in PR #12821: URL: https://github.com/apache/kafka/pull/12821#discussion_r1049809566 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java: ## @@ -187,151 +139,92 @@ public void

[GitHub] [kafka] dajac commented on pull request #12865: MINOR: Serialize response in KafkaApisTest

2022-12-15 Thread GitBox
dajac commented on PR #12865: URL: https://github.com/apache/kafka/pull/12865#issuecomment-1353286898 @mimaison Will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Resolved] (KAFKA-14427) Add support for ZK migration multi-ops transaction

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14427. -- Resolution: Fixed > Add support for ZK migration multi-ops transaction >

[jira] [Assigned] (KAFKA-14427) Add support for ZK migration multi-ops transaction

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-14427: Assignee: David Arthur (was: Colin McCabe) > Add support for ZK migration multi-ops

[jira] [Updated] (KAFKA-14304) ZooKeeper to KRaft Migration

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14304: - Fix Version/s: 3.4.1 (was: 3.4.0) > ZooKeeper to KRaft Migration >

[jira] [Updated] (KAFKA-14427) Add support for ZK migration multi-ops transaction

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14427: - Fix Version/s: 3.4.0 (was: 3.4.1) > Add support for ZK migration

[jira] [Resolved] (KAFKA-14448) ZK brokers register with KRaft during migration

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14448. -- Resolution: Fixed > ZK brokers register with KRaft during migration >

[jira] [Updated] (KAFKA-14428) Add Records, RPCs and Configs for KIP-866

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14428: - Fix Version/s: 3.4.0 > Add Records, RPCs and Configs for KIP-866 >

[jira] [Updated] (KAFKA-14447) Controlled shutdown for ZK brokers during migration

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14447: - Fix Version/s: 3.4.1 > Controlled shutdown for ZK brokers during migration >

[jira] [Updated] (KAFKA-14448) ZK brokers register with KRaft during migration

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14448: - Fix Version/s: 3.4.0 > ZK brokers register with KRaft during migration >

[jira] [Resolved] (KAFKA-14428) Add Records, RPCs and Configs for KIP-866

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14428. -- Resolution: Fixed > Add Records, RPCs and Configs for KIP-866 >

[jira] [Reopened] (KAFKA-14427) Add support for ZK migration multi-ops transaction

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reopened KAFKA-14427: -- Assignee: Colin McCabe (was: David Arthur) > Add support for ZK migration multi-ops

[jira] [Updated] (KAFKA-14427) Add support for ZK migration multi-ops transaction

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14427: - Fix Version/s: 3.4.0 > Add support for ZK migration multi-ops transaction >

[jira] [Updated] (KAFKA-14427) Add support for ZK migration multi-ops transaction

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14427: - Fix Version/s: 3.4.1 (was: 3.4.0) > Add support for ZK migration

[jira] [Resolved] (KAFKA-14427) Add support for ZK migration multi-ops transaction

2022-12-15 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14427. -- Resolution: Fixed > Add support for ZK migration multi-ops transaction >

[GitHub] [kafka] mimaison commented on pull request #12865: MINOR: Serialize response in KafkaApisTest

2022-12-15 Thread GitBox
mimaison commented on PR #12865: URL: https://github.com/apache/kafka/pull/12865#issuecomment-1353178569 @dajac Can we rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] Scanteianu commented on pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

2022-12-15 Thread GitBox
Scanteianu commented on PR #12753: URL: https://github.com/apache/kafka/pull/12753#issuecomment-1353147822 @showuon jdk17/scala 2.13 passed, and the failures in the other runs seem unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] PhantomMaa commented on pull request #12997: KAFKA-14492: Extract a method to create LogManager, in order to be overrided by subclass of KafkaServer

2022-12-15 Thread GitBox
PhantomMaa commented on PR #12997: URL: https://github.com/apache/kafka/pull/12997#issuecomment-1353022198 hi, those failed checks are not caused by my modification in this time. what can i do next ? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Endre Vig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Vig updated KAFKA-14496: -- Description: Currently our team is setting up a blueprint for our Kafka consumers/producers to

[jira] [Updated] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Endre Vig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Vig updated KAFKA-14496: -- Description: Currently our team is setting up a blueprint for our Kafka consumers/producers to

[jira] [Updated] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Endre Vig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Vig updated KAFKA-14496: -- Attachment: base64test.zip > Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler >

[jira] [Created] (KAFKA-14496) Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-15 Thread Endre Vig (Jira)
Endre Vig created KAFKA-14496: - Summary: Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler Key: KAFKA-14496 URL: https://issues.apache.org/jira/browse/KAFKA-14496 Project: Kafka

[GitHub] [kafka] divijvaidya commented on pull request #12890: KAFKA-14414: Remove unnecessary usage of ObjectSerializationCache

2022-12-15 Thread GitBox
divijvaidya commented on PR #12890: URL: https://github.com/apache/kafka/pull/12890#issuecomment-1352933410 Hey @ijuma - thank you for your question. 1. I used [Amazon CodeGuru Profiler](https://docs.aws.amazon.com/codeguru/latest/profiler-ug/what-is-codeguru-profiler.html). I ran

[jira] [Assigned] (KAFKA-14466) Refactor ClassLoaderAwareRemoteStorageManager.scala to ClassLoaderAwareRemoteStorageManager.java and move it to storage module.

2022-12-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-14466: - Assignee: Satish Duggana (was: Luke Chen) > Refactor

[jira] [Comment Edited] (KAFKA-14466) Refactor ClassLoaderAwareRemoteStorageManager.scala to ClassLoaderAwareRemoteStorageManager.java and move it to storage module.

2022-12-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647977#comment-17647977 ] Luke Chen edited comment on KAFKA-14466 at 12/15/22 10:01 AM: -- I can also

[jira] [Commented] (KAFKA-14466) Refactor ClassLoaderAwareRemoteStorageManager.scala to ClassLoaderAwareRemoteStorageManager.java and move it to storage module.

2022-12-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647977#comment-17647977 ] Luke Chen commented on KAFKA-14466: --- I can also help on this if you haven't started it yet.   >

[jira] [Commented] (KAFKA-14467) Add a test to validate the replica state after processing the OFFSET_MOVED_TO_TIERED_STORAGE error, especially for the transactional state

2022-12-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647976#comment-17647976 ] Luke Chen commented on KAFKA-14467: --- Discussed offline, I'm going to take over this task.   > Add a

[jira] [Assigned] (KAFKA-14466) Refactor ClassLoaderAwareRemoteStorageManager.scala to ClassLoaderAwareRemoteStorageManager.java and move it to storage module.

2022-12-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-14466: - Assignee: Luke Chen (was: Satish Duggana) > Refactor

[jira] [Commented] (KAFKA-14467) Add a test to validate the replica state after processing the OFFSET_MOVED_TO_TIERED_STORAGE error, especially for the transactional state

2022-12-15 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647965#comment-17647965 ] Satish Duggana commented on KAFKA-14467: Sure [~showuon]. (y) > Add a test to validate the

[jira] [Assigned] (KAFKA-14467) Add a test to validate the replica state after processing the OFFSET_MOVED_TO_TIERED_STORAGE error, especially for the transactional state

2022-12-15 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-14467: -- Assignee: Luke Chen (was: Satish Duggana) > Add a test to validate the replica

[GitHub] [kafka] divijvaidya closed pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration

2022-12-15 Thread GitBox
divijvaidya closed pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration URL: https://github.com/apache/kafka/pull/12989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] divijvaidya commented on pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration

2022-12-15 Thread GitBox
divijvaidya commented on PR #12989: URL: https://github.com/apache/kafka/pull/12989#issuecomment-1352777373 Thanks @satishd. I will discard this PR in that case. When you get a chance, please update the KIP to make it consistent with the above. -- This is an automated message from the

[GitHub] [kafka] showuon commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-15 Thread GitBox
showuon commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1049396894 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Created] (KAFKA-14495) Improve the RemoteIndexCacheTest

2022-12-15 Thread Luke Chen (Jira)
Luke Chen created KAFKA-14495: - Summary: Improve the RemoteIndexCacheTest Key: KAFKA-14495 URL: https://issues.apache.org/jira/browse/KAFKA-14495 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] showuon commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-15 Thread GitBox
showuon commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1049393028 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] showuon commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-15 Thread GitBox
showuon commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1049392445 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -0,0 +1,224 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-14494) Kafka Java client can't send data when behind SOCKS proxy - while native client can

2022-12-15 Thread Oleg Zhovtanyuk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhovtanyuk updated KAFKA-14494: Description: When Kafka Java client sits behind the SOCK5 proxy, it connects to the

[jira] [Updated] (KAFKA-14494) Kafka Java client can't send data when behind SOCKS proxy - while native client can

2022-12-15 Thread Oleg Zhovtanyuk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhovtanyuk updated KAFKA-14494: Description: When Kafka Java client sits behind the SOCK5 proxy, it connects to the

[GitHub] [kafka] mimaison merged pull request #12895: KAFKA-13881: Add Clients package description javadocs

2022-12-15 Thread GitBox
mimaison merged PR #12895: URL: https://github.com/apache/kafka/pull/12895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14494) Kafka Java client can't send data when behind SOCKS proxy - while native client can

2022-12-15 Thread Oleg Zhovtanyuk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhovtanyuk updated KAFKA-14494: Attachment: kafka-client-java-direct.log.gz kafka-client-java-socks.log.gz

[jira] [Updated] (KAFKA-14494) Kafka Java client can't send data when behind SOCKS proxy - while native client can

2022-12-15 Thread Oleg Zhovtanyuk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhovtanyuk updated KAFKA-14494: Description: When Kafka Java client sits behind the SOCK5 proxy, it connects to the

[GitHub] [kafka] dajac merged pull request #12858: KAFKA-14367; Add `DeleteGroups` to the new `GroupCoordinator` interface

2022-12-15 Thread GitBox
dajac merged PR #12858: URL: https://github.com/apache/kafka/pull/12858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14494) Kafka Java client can't send data when behind SOCKS proxy - while native client can

2022-12-15 Thread Oleg Zhovtanyuk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Zhovtanyuk updated KAFKA-14494: Attachment: client-java.tar.gz client-nodejs.tar.gz > Kafka Java client