[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070928680 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp =

[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1383408137 @fvaleri , thanks. I made the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1070782792 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1070781463 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1070781326 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1070781134 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1070780996 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma closed pull request #4321: KAFKA-6342 : Move workaround for JSON parsing of non-escaped strings

ijuma closed pull request #4321: KAFKA-6342 : Move workaround for JSON parsing of non-escaped strings URL: https://github.com/apache/kafka/pull/4321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-5841) Open old index files with read-only permission

[ https://issues.apache.org/jira/browse/KAFKA-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-5841. Resolution: Not A Problem We have a constructor parameter for this, so I don't think we need this

[GitHub] [kafka] ijuma closed pull request #3798: KAFKA-5841: AbstractIndex should offer `makeReadOnly` method

ijuma closed pull request #3798: KAFKA-5841: AbstractIndex should offer `makeReadOnly` method URL: https://github.com/apache/kafka/pull/3798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #3798: KAFKA-5841: AbstractIndex should offer `makeReadOnly` method

ijuma commented on PR #3798: URL: https://github.com/apache/kafka/pull/3798#issuecomment-1383285149 We have a constructor parameter for this, so I don't think we need this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma closed pull request #3018: KAFKA-5209 : Transient failure: kafka.server.MetadataRequestTest.testControllerId

ijuma closed pull request #3018: KAFKA-5209 : Transient failure: kafka.server.MetadataRequestTest.testControllerId URL: https://github.com/apache/kafka/pull/3018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ijuma commented on pull request #3018: KAFKA-5209 : Transient failure: kafka.server.MetadataRequestTest.testControllerId

ijuma commented on PR #3018: URL: https://github.com/apache/kafka/pull/3018#issuecomment-1383280252 Closing the PR since no activity for several years. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] ijuma closed pull request #2107: KAFKA-4385-avoid-unnecessary-meta-request-overhead

ijuma closed pull request #2107: KAFKA-4385-avoid-unnecessary-meta-request-overhead URL: https://github.com/apache/kafka/pull/2107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma commented on pull request #2107: KAFKA-4385-avoid-unnecessary-meta-request-overhead

ijuma commented on PR #2107: URL: https://github.com/apache/kafka/pull/2107#issuecomment-1383279844 Closing the PR since a KIP hasn't been submitted in several years. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma closed pull request #2784: KAFKA-4999: Add convenience overloads to seek* methods

ijuma closed pull request #2784: KAFKA-4999: Add convenience overloads to seek* methods URL: https://github.com/apache/kafka/pull/2784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma commented on pull request #2784: KAFKA-4999: Add convenience overloads to seek* methods

ijuma commented on PR #2784: URL: https://github.com/apache/kafka/pull/2784#issuecomment-1383279420 Thanks for the PR. As stated in the JIRA, this would require a KIP. Closing the PR until then. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma merged pull request #12229: MINOR: Include the inner exception stack trace when re-throwing an exception

ijuma merged PR #12229: URL: https://github.com/apache/kafka/pull/12229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rondagostino commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1383262505 @cmccabe I updated this to deal with create topic requests that either set an explicit assignment or that use the default partition count. Note that this is logic that exists

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

fqaiser94 commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1070670176 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -46,33 +45,40 @@ public void setIfUnset(final SerdeGetter getter) {

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

fqaiser94 commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1070669075 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedDeserializer.java: ## @@ -44,18 +42,30 @@ public void setIfUnset(final SerdeGetter getter)

[jira] [Comment Edited] (KAFKA-14624) State restoration is broken with standby tasks and cache-enabled stores in processor API

[ https://issues.apache.org/jira/browse/KAFKA-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677074#comment-17677074 ] Balaji Rao edited comment on KAFKA-14624 at 1/15/23 6:20 PM: - [~mjsax], I've

[jira] [Comment Edited] (KAFKA-14624) State restoration is broken with standby tasks and cache-enabled stores in processor API

[ https://issues.apache.org/jira/browse/KAFKA-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677074#comment-17677074 ] Balaji Rao edited comment on KAFKA-14624 at 1/15/23 6:20 PM: - [~mjsax], I've

[jira] [Commented] (KAFKA-14624) State restoration is broken with standby tasks and cache-enabled stores in processor API

[ https://issues.apache.org/jira/browse/KAFKA-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677074#comment-17677074 ] Balaji Rao commented on KAFKA-14624: [~mjsax], I've added a README to the

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1070638073 ## server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java: ## @@ -72,7 +71,7 @@ public CheckpointFile(File file, tempPath =

[GitHub] [kafka] ijuma commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

ijuma commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1070638073 ## server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java: ## @@ -72,7 +71,7 @@ public CheckpointFile(File file, tempPath =

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1070621323 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Assigned] (KAFKA-14579) Move DumpLogSegments to tools

[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14579: --- Assignee: Federico Valeri > Move DumpLogSegments to tools >

[GitHub] [kafka] satishd commented on pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on PR #13046: URL: https://github.com/apache/kafka/pull/13046#issuecomment-1383152672 Thanks @ijuma for your review. Addressed them with inline comments and/or updated commits. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] satishd commented on a diff in pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

satishd commented on code in PR #13046: URL: https://github.com/apache/kafka/pull/13046#discussion_r1070596038 ## server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java: ## @@ -72,7 +71,7 @@ public CheckpointFile(File file, tempPath =

[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1383104841 @fvaleri , i removed the code changes related to argparse4j. That way the interface of the tool is exactly similar to what it was previously. Thanks -- This is an automated

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1070545176 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,309 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1070539477 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -70,7 +70,9 @@ class DelayedOperations(topicPartition: TopicPartition, def numDelayedDelete: Int =

[GitHub] [kafka] curie71 commented on a diff in pull request #13090: KAFKA-14605 Change the log level to info when logIfAllowed is set, warn when logIfDenied is set.

curie71 commented on code in PR #13090: URL: https://github.com/apache/kafka/pull/13090#discussion_r1070537837 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java: ## @@ -329,7 +329,7 @@ private void logAuditMessage( //

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1070536098 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

ijuma commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1070527140 ## core/src/main/scala/kafka/controller/ControllerContext.scala: ## @@ -487,7 +487,7 @@ class ControllerContext extends ControllerChannelContext {

[GitHub] [kafka] ijuma commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

ijuma commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1070527140 ## core/src/main/scala/kafka/controller/ControllerContext.scala: ## @@ -487,7 +487,7 @@ class ControllerContext extends ControllerChannelContext {

[GitHub] [kafka] ijuma commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ijuma commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1070526324 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ijuma commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1070523929 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ijuma commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1070521647 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -293,14 +295,14 @@ class Partition(val topicPartition: TopicPartition, private var controllerEpoch: Int =