[jira] [Updated] (KAFKA-14295) FetchMessageConversionsPerSec meter not recorded

2023-02-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14295: -- Fix Version/s: 3.4.1 > FetchMessageConversionsPerSec meter not recorded >

[jira] [Resolved] (KAFKA-14743) MessageConversionsTimeMs for fetch request metric is not updated

2023-02-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14743. --- Fix Version/s: 3.5.0 3.4.1 Resolution: Fixed > MessageConversionsTimeMs fo

[GitHub] [kafka] showuon merged pull request #13297: Kafka-14743: update request metrics after callback

2023-02-25 Thread via GitHub
showuon merged PR #13297: URL: https://github.com/apache/kafka/pull/13297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #13297: Kafka-14743: update request metrics after callback

2023-02-25 Thread via GitHub
showuon commented on PR #13297: URL: https://github.com/apache/kafka/pull/13297#issuecomment-1445285392 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / kafka.admin.DescribeConsumerGroupTest.testDescribeExistingGroupWithNoMembers() Build / JDK 8 and Scala 2.12

[GitHub] [kafka] showuon commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

2023-02-25 Thread via GitHub
showuon commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1118032062 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -202,7 +202,7 @@ final class KafkaMetadataLog private ( } override def highWatermark: LogOffsetM

[GitHub] [kafka] showuon commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

2023-02-25 Thread via GitHub
showuon commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1118031367 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] showuon commented on pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

2023-02-25 Thread via GitHub
showuon commented on PR #13102: URL: https://github.com/apache/kafka/pull/13102#issuecomment-1445268492 @tinaselenge , could you check the failed test: `testCompatibilityWithClusterId`? https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13102/4/ Also, please try to reba

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

2023-02-25 Thread via GitHub
philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1445261315 The failures seem irrelevant to the change here: i.e. they dont' show up in both rounds. ``` Build / JDK 11 and Scala 2.13 / testDynamicListenerConnectionCreationRateQuota() – ka

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2023-02-25 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693546#comment-17693546 ] Jorge Esteban Quilcate Otoya commented on KAFKA-2967: - Hi everyone. I

[GitHub] [kafka] chia7712 commented on a diff in pull request #13308: MINOR: update docs of 'replica.socket.receive.buffer.bytes'

2023-02-25 Thread via GitHub
chia7712 commented on code in PR #13308: URL: https://github.com/apache/kafka/pull/13308#discussion_r1117987586 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -888,7 +888,7 @@ object KafkaConfig { val ReplicaLagTimeMaxMsDoc = "If a follower hasn't sent any fetch

[GitHub] [kafka] chia7712 opened a new pull request, #13308: MINOR: update docs of 'replica.socket.receive.buffer.bytes'

2023-02-25 Thread via GitHub
chia7712 opened a new pull request, #13308: URL: https://github.com/apache/kafka/pull/13308 as title. make the doc more readable. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] hogimn commented on pull request #13305: MINOR: Replace String literal with existing String variable

2023-02-25 Thread via GitHub
hogimn commented on PR #13305: URL: https://github.com/apache/kafka/pull/13305#issuecomment-1445201773 Thanks for your kind reply :) I am a newbie to Kafka and learning the concept and code through unit tests. I am happy to commit for the first time 😄. -- This is an automated m

[jira] [Commented] (KAFKA-14587) Move AclCommand to tools

2023-02-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693514#comment-17693514 ] Omnia Ibrahim commented on KAFKA-14587: --- [~mimaison] AclCommand  depends on `kafka

[GitHub] [kafka] divijvaidya opened a new pull request, #13307: MINOR: Make ByteUtilsBenchmark deterministic

2023-02-25 Thread via GitHub
divijvaidya opened a new pull request, #13307: URL: https://github.com/apache/kafka/pull/13307 # Motivation The current implementation of the benchmark may produce different set of integers across benchmarks and hence, may not provide apples to apples comparison. # Changes 1. W

[jira] [Commented] (KAFKA-14762) Remove 0_8_2_LATEST from rolling upgrade system test

2023-02-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693490#comment-17693490 ] Ismael Juma commented on KAFKA-14762: - The actual policy has been to support upgrade

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat threa

2023-02-25 Thread via GitHub
RivenSun2 commented on code in PR #13270: URL: https://github.com/apache/kafka/pull/13270#discussion_r1117936096 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java: ## @@ -1206,10 +1206,21 @@ public void testUncaughtExceptionInHeart

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat threa

2023-02-25 Thread via GitHub
RivenSun2 commented on code in PR #13270: URL: https://github.com/apache/kafka/pull/13270#discussion_r1117934696 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -355,6 +355,12 @@ protected synchronized long timeToNextHeartbeat

[jira] [Updated] (KAFKA-14705) Remove redirection/deprecated classes

2023-02-25 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Summary: Remove redirection/deprecated classes (was: Remove redirection/deprected classes

[jira] [Updated] (KAFKA-14705) Remove redirection/deprected classes

2023-02-25 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Affects Version/s: 3.5.0 Description: - core/kafka.tools.JmxTool - core/kafka.to

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: Upgrade gradle version from 7.6 to 8.0.1

2023-02-25 Thread via GitHub
dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1445120790 > @dejan2609 would you be willing to submit a ticket for the Scala plugin for IntelliJ so it doesn't set `-target` if `-release` is set? @ijuma ticket is created here: https://yo

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: Upgrade gradle version from 7.6 to 8.0.1

2023-02-25 Thread via GitHub
dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1445083330 @chia7712 I just pushed PR that (hopefully) solves this regression, feel free to check it. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] dejan2609 opened a new pull request, #13306: KAFKA-14680: `spotlessCheck` task is disabled

2023-02-25 Thread via GitHub
dejan2609 opened a new pull request, #13306: URL: https://github.com/apache/kafka/pull/13306 **Note**: this solves build regression (after Gradle version was bumped from 7.6 to 8.0.1) **Rationale**: see this comment made by @chia7712: https://github.com/apache/kafka/pull/13205#issuec

[GitHub] [kafka] chia7712 commented on pull request #13205: KAFKA-14680: Upgrade gradle version from 7.6 to 8.0.1

2023-02-25 Thread via GitHub
chia7712 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1445064363 @dejan2609 thanks for nice explanation! That is why I suggested to disable spotlessScala from build.gradle :) -- This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: Upgrade gradle version from 7.6 to 8.0.1

2023-02-25 Thread via GitHub
dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1445054141 @chia7712 Correct, `./gradlew build` executed against trunk does fail. For the last few days we (@ijuma and me): - merged into a trunk Jenkinsfile change that removes 'spotlessS

[GitHub] [kafka] hogimn opened a new pull request, #13305: MINOR: Replace String literal with existing String variable

2023-02-25 Thread via GitHub
hogimn opened a new pull request, #13305: URL: https://github.com/apache/kafka/pull/13305 It is minor change. I found out that String literal is used even though there is existing static String variable. So, I replaced literal with variable. Thank you :) ### Committer Che