lanshiqin opened a new pull request, #13584:
URL: https://github.com/apache/kafka/pull/13584
Add log segment unit tests, If the maximum offset beyond index, appended to
the log section, it throws LogSegmentOffsetOverflowException
*More detailed description of change
The unit tests
[
https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Farooq Qaiser reassigned KAFKA-12446:
-
Assignee: Farooq Qaiser (was: Ben Ellis)
> Define KGroupedTable#aggregate subtractor +
fqaiser94 commented on PR #10747:
URL: https://github.com/apache/kafka/pull/10747#issuecomment-1510003420
Thanks for your support with this PR/KIP!
> Hope we can get a system test earlier than later. If you are too busy,
maybe somebody else can pick it up.
Yea, sorry, I wont ha
fqaiser94 commented on code in PR #10747:
URL: https://github.com/apache/kafka/pull/10747#discussion_r1167669456
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java:
##
@@ -45,34 +49,87 @@ public void setIfUnset(final SerdeGetter getter) {
Farooq Qaiser created KAFKA-14911:
-
Summary: Add system tests for rolling upgrade path of KIP-904
Key: KAFKA-14911
URL: https://issues.apache.org/jira/browse/KAFKA-14911
Project: Kafka
Issue
fqaiser94 commented on code in PR #13533:
URL: https://github.com/apache/kafka/pull/13533#discussion_r1167581045
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java:
##
@@ -113,9 +113,9 @@ public byte[] serialize(final String topic, final H
fqaiser94 commented on code in PR #13533:
URL: https://github.com/apache/kafka/pull/13533#discussion_r1167560778
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedDeserializer.java:
##
@@ -52,10 +52,10 @@ public Change deserialize(final String topic, fin
aiven-anton opened a new pull request, #13583:
URL: https://github.com/apache/kafka/pull/13583
The CRC field of Record Batch was incorrectly documented as int32 while in
reality it's an [unsigned uint32
field](https://github.com/apache/kafka/blob/9c12e462106343fbc6af5873074d48f98687af39/cli
ijuma commented on PR #13312:
URL: https://github.com/apache/kafka/pull/13312#issuecomment-1509978997
@divijvaidya Do we have any end to end test results? As stated previously,
I'm not quite sure about the varint64 implementations - they seem to be the
kind of thing that helps with microben
ijuma commented on PR #13579:
URL: https://github.com/apache/kafka/pull/13579#issuecomment-1509969944
We should also cherry-pick this to 3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
ijuma commented on PR #13575:
URL: https://github.com/apache/kafka/pull/13575#issuecomment-1509969810
We should cherry-pick this to 3.5 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ijuma commented on PR #12830:
URL: https://github.com/apache/kafka/pull/12830#issuecomment-1509969743
Merged to trunk and 3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ijuma commented on PR #13567:
URL: https://github.com/apache/kafka/pull/13567#issuecomment-1509969717
Merged to trunk and 3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ijuma commented on PR #13543:
URL: https://github.com/apache/kafka/pull/13543#issuecomment-1509969596
Cherry-picking this to 3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jeqo commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1167636433
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
jeqo commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1167635238
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Foundation
ijuma opened a new pull request, #13582:
URL: https://github.com/apache/kafka/pull/13582
An example of the warning:
> warning: [lossy-conversions] implicit cast from long to int in compound
assignment is possibly lossy
### Committer Checklist (excluded from commit message)
- [ ]
jeqo commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1167632114
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/MultiFieldPaths.java:
##
@@ -0,0 +1,578 @@
+/*
+ * Licensed to the Apache Software Foundation
ijuma merged PR #13567:
URL: https://github.com/apache/kafka/pull/13567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on PR #13567:
URL: https://github.com/apache/kafka/pull/13567#issuecomment-1509937606
There are a bunch of mirrormaker related failures that are being addressed
via a different PR and are unrelated to this change.
--
This is an automated message from the Apache Git Service
ijuma merged PR #12830:
URL: https://github.com/apache/kafka/pull/12830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on PR #12830:
URL: https://github.com/apache/kafka/pull/12830#issuecomment-1509935873
Failures seem to be related to `MirrorConnectors` only. There is a separate
PR trying to fix that.
> Build / JDK 17 and Scala 2.13 /
org.apache.kafka.connect.mirror.integration.Mirro
ijuma commented on PR #13579:
URL: https://github.com/apache/kafka/pull/13579#issuecomment-1509935179
@jolshan Thanks for the PR. Can you please share details regarding the
frequency of failures before/after the change when you run this test locally in
a loop?
--
This is an automated mes
ijuma commented on code in PR #13579:
URL: https://github.com/apache/kafka/pull/13579#discussion_r1167627192
##
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##
@@ -396,8 +397,14 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
jeqo commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1167626084
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/FieldSyntaxVersion.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundat
bmscomp commented on PR #13569:
URL: https://github.com/apache/kafka/pull/13569#issuecomment-1509884313
I think it's enough to use a `bin` distribution type instead instead of
`all` one for Gradle wrapper
--
This is an automated message from the Apache Git Service.
To respond to the me
ijuma commented on code in PR #12830:
URL: https://github.com/apache/kafka/pull/12830#discussion_r1167565330
##
trogdor/src/main/java/org/apache/kafka/trogdor/rest/JsonRestServer.java:
##
@@ -138,13 +138,13 @@ public void beginShutdown() {
log.info("Stopping
[
https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712649#comment-17712649
]
Sagar Rao commented on KAFKA-14750:
---
Thanks for your response [~morozov] . I have crea
[
https://issues.apache.org/jira/browse/KAFKA-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712647#comment-17712647
]
Proven Provenzano commented on KAFKA-14881:
---
Please move it back to 3.5.0. The
vamossagar12 commented on PR #13557:
URL: https://github.com/apache/kafka/pull/13557#issuecomment-1509738740
Thanks for the PR @urbandan . This looks good. Now that you have introduced
this method, I am thinking if other executors can use this method? I can see
`herderExectuor`, `forwardReq
[
https://issues.apache.org/jira/browse/KAFKA-14323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14323:
---
Fix Version/s: 3.6.0
(was: 3.5.0)
> KRaft broker time based snapshots
[
https://issues.apache.org/jira/browse/KAFKA-14323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712636#comment-17712636
]
Mickael Maison commented on KAFKA-14323:
We're past feature freeze for 3.5.0 so
[
https://issues.apache.org/jira/browse/KAFKA-14852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14852:
---
Fix Version/s: 3.6.0
(was: 3.5.0)
> Propagate Topic Ids to the Group
[
https://issues.apache.org/jira/browse/KAFKA-14852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712635#comment-17712635
]
Mickael Maison commented on KAFKA-14852:
We're past feature freeze for 3.5.0, so
[
https://issues.apache.org/jira/browse/KAFKA-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712633#comment-17712633
]
Mickael Maison commented on KAFKA-14881:
3.5.0 is in feature freeze, so I'm movi
[
https://issues.apache.org/jira/browse/KAFKA-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14881:
---
Fix Version/s: 3.6.0
(was: 3.5.0)
> Update UserScramCredentialRecord
[
https://issues.apache.org/jira/browse/KAFKA-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14077:
---
Fix Version/s: 3.6.0
(was: 3.5.0)
> KRaft should support recovery fro
[
https://issues.apache.org/jira/browse/KAFKA-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712630#comment-17712630
]
Mickael Maison commented on KAFKA-14077:
The associated KIP is not voted yet, so
[
https://issues.apache.org/jira/browse/KAFKA-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14690:
---
Fix Version/s: 3.6.0
(was: 3.5.0)
> OffsetCommit API Version 9
>
[
https://issues.apache.org/jira/browse/KAFKA-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712629#comment-17712629
]
Mickael Maison commented on KAFKA-14690:
Since we're past feature freeze for 3.5
sudeshwasnik commented on code in PR #13361:
URL: https://github.com/apache/kafka/pull/13361#discussion_r1167474596
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java:
##
@@ -316,6 +316,9 @@ public Map convert(Void result) {
/
Scanteianu commented on PR #13341:
URL: https://github.com/apache/kafka/pull/13341#issuecomment-1509668648
> @Scanteianu as a next step, we need to wait for a committer to look into
this one so that it can be merged.
>
> Since it's related to consumers, perhaps @dajac would be interes
yashmayya commented on code in PR #13465:
URL: https://github.com/apache/kafka/pull/13465#discussion_r1167415541
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName,
ConnectorOffse
yashmayya commented on code in PR #13465:
URL: https://github.com/apache/kafka/pull/13465#discussion_r1167415436
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName,
ConnectorOffse
44 matches
Mail list logo
