jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r1167635238
########## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java: ########## @@ -0,0 +1,585 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.connect.transforms.field; + +import org.apache.kafka.common.cache.Cache; +import org.apache.kafka.common.cache.LRUCache; +import org.apache.kafka.common.cache.SynchronizedCache; +import org.apache.kafka.connect.data.Field; +import org.apache.kafka.connect.data.Schema; +import org.apache.kafka.connect.data.Schema.Type; +import org.apache.kafka.connect.data.SchemaBuilder; +import org.apache.kafka.connect.data.Struct; +import org.apache.kafka.connect.transforms.util.SchemaUtil; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * A FieldPath is composed by one or many field names, known as steps, + * to access values within a data object (either {@code Struct} or {@code Map<String, Object>}).a + * <p> + * If the SMT requires accessing multiple fields on the same data object, + * use {@code FieldPaths} instead. + * <p> + * The field path semantics are defined by the syntax version {@code FieldSyntaxVersion}. + * <p> + * Paths are calculated once and cached for further access. + * <p> + * Invariants: + * <li> + * <ul>A field path can contain one or more steps</ul> + * </li> + * + * See KIP-821. + * + * @see FieldSyntaxVersion + * @see MultiFieldPaths + */ +public class SingleFieldPath implements FieldPath { + + private static final char BACKTICK_CHAR = '`'; + private static final char DOT_CHAR = '.'; + private static final char BACKSLASH_CHAR = '\\'; + + private static final Cache<String, SingleFieldPath> PATHS_CACHE = new SynchronizedCache<>(new LRUCache<>(16)); Review Comment: Agree. At the beginning was thinking paths were going to be built at runtime, but as they are built at construction no much value. Removing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
