[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919367 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -249,62 +272,62 @@ public void doJoinFromLeftThenDel

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919730 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyVersionedJoinIntegrationTest.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171925337 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableAggregate.java: ## @@ -116,10 +118,13 @@ public void process(final Record> record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171926005 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java: ## @@ -118,10 +120,13 @@ public void process(final Record record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171926280 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java: ## @@ -118,10 +120,13 @@ public void process(final Record record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171929315 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableInnerJoin.java: ## @@ -139,7 +139,7 @@ public void process(final Record> record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171930805 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableRepartitionMap.java: ## @@ -154,27 +154,25 @@ public void process(final Record> record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171930596 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableInnerJoin.java: ## @@ -139,7 +139,7 @@ public void process(final Record> record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13188: KAFKA-14491: [5/N] Basic operations for RocksDB versioned store

vcrfxia commented on code in PR #13188: URL: https://github.com/apache/kafka/pull/13188#discussion_r1171931840 ## streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

vcrfxia commented on code in PR #13615: URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110 ## streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java: ## @@ -36,6 +37,7 @@ * @param value The value to update, it can be {@code null};

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

vcrfxia commented on code in PR #13615: URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110 ## streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java: ## @@ -36,6 +37,7 @@ * @param value The value to update, it can be {@code null};

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171934758 ## core/src/main/scala/kafka/zk/ZkMigrationClient.scala: ## @@ -16,71 +16,79 @@ */ package kafka.zk -import kafka.api.LeaderAndIsr -import kafka.controller.{Leader

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171935467 ## metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingTopicMigrationClient.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171935467 ## metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingTopicMigrationClient.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

vcrfxia commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1171939132 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java: ## @@ -73,6 +74,7 @@ KTable build(final Map, Aggregator

[GitHub] [kafka] cmccabe commented on pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on PR #13461: URL: https://github.com/apache/kafka/pull/13461#issuecomment-1515504502 Thanks for this @mumrah . Can we have a ZkConfigMigrationClientTest and so on, for the other new migrationclient classes? Should we wrap the calls to `quotaEntityConsumer.acc

[GitHub] [kafka] mjsax merged pull request #13610: MINOR: update comments for FK join processor renames

mjsax merged PR #13610: URL: https://github.com/apache/kafka/pull/13610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171941706 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -0,0 +1,333 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171941841 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -0,0 +1,333 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171943462 ## core/src/main/scala/kafka/zk/migration/ZkAclMigrationClient.scala: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

vcrfxia commented on code in PR #13615: URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110 ## streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java: ## @@ -36,6 +37,7 @@ * @param value The value to update, it can be {@code null};

[GitHub] [kafka] mjsax merged pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

mjsax merged PR #13609: URL: https://github.com/apache/kafka/pull/13609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945097 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -174,12 +173,12 @@ private boolean areZkBrokersReadyForMigration() {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945520 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945520 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945830 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171946214 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -2175,7 +2182,7 @@ public void testClusterAuthorizationExceptionInProduce

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171947129 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -2175,7 +2182,7 @@ public void testClusterAuthorizationExceptionInProduceRe

[GitHub] [kafka] cmccabe commented on a diff in pull request #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

cmccabe commented on code in PR #13532: URL: https://github.com/apache/kafka/pull/13532#discussion_r1171947569 ## core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala: ## @@ -160,10 +160,12 @@ class FinalizedFeatureChangeListener(private val finalizedFeatureCac

[GitHub] [kafka] cmccabe merged pull request #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

cmccabe merged PR #13532: URL: https://github.com/apache/kafka/pull/13532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1171950562 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -869,19 +906,30 @@ public CompletableFuture acceptBatch(List recordBatch)

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1171950976 ## metadata/src/test/java/org/apache/kafka/image/publisher/SnapshotGeneratorTest.java: ## @@ -48,7 +48,7 @@ public class SnapshotGeneratorTest { static class MockE

[GitHub] [kafka] mjsax commented on pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

mjsax commented on PR #13609: URL: https://github.com/apache/kafka/pull/13609#issuecomment-1515524362 Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

artemlivshits commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1171959120 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -565,6 +565,12 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendErrorR

[GitHub] [kafka] rreddy-22 opened a new pull request, #13616: KAFKA-14514: Add Optimized Uniform Assignor (KIP-848)

rreddy-22 opened a new pull request, #13616: URL: https://github.com/apache/kafka/pull/13616 Part of KIP-848 https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol As a part of the new protocol, there will be assignors on

[GitHub] [kafka] ykubota commented on a diff in pull request #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

ykubota commented on code in PR #13532: URL: https://github.com/apache/kafka/pull/13532#discussion_r1171979375 ## core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala: ## @@ -160,10 +160,12 @@ class FinalizedFeatureChangeListener(private val finalizedFeatureCac

[jira] [Commented] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

[ https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714354#comment-17714354 ] Matthias J. Sax commented on KAFKA-14922: - Thanks for creating this ticket. It's

[jira] [Updated] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

[ https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14922: Component/s: streams tools > kafka-streams-application-reset deletes topi

[GitHub] [kafka] dengziming commented on pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dengziming commented on PR #13432: URL: https://github.com/apache/kafka/pull/13432#issuecomment-1515639065 Notable changes better than old logic: 1. Retry lookup stage on receiving `NOT_LEADER_OR_FOLLOWER` and `LEADER_NOT_AVAILABLE`, whereas in the past we failed the partition directly w

[GitHub] [kafka] hudeqi opened a new pull request, #13617: MINOR:code optimization in QuorumController

hudeqi opened a new pull request, #13617: URL: https://github.com/apache/kafka/pull/13617 1. add hint in switch item "BROKER_LOGGER" in ConfigResourceExistenceChecker, otherwise, it will be classified as default break and deleted directly. I don’t know if adding hint is better than deleting

[GitHub] [kafka] dengziming merged pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dengziming merged PR #13432: URL: https://github.com/apache/kafka/pull/13432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1172068360 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -565,6 +565,12 @@ class KafkaApis(val requestChannel: RequestChannel, requestHelper.sendErrorRespons

[GitHub] [kafka] philipnee opened a new pull request, #13618: MINOR: Fixing typos in the ConsumerCoordinators

philipnee opened a new pull request, #13618: URL: https://github.com/apache/kafka/pull/13618 Not very much really, just fixing some typos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1172072549 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncRespons

[GitHub] [kafka] ijuma commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

ijuma commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1172120422 ## server-common/src/main/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMap.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ijuma commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

ijuma commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1172120422 ## server-common/src/main/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMap.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hudeqi commented on pull request #13618: MINOR: Fixing typos in the ConsumerCoordinators

hudeqi commented on PR #13618: URL: https://github.com/apache/kafka/pull/13618#issuecomment-1515775034 In fact, it seems that there are many such grammatical problems in the kafka project? I think only those typos like "many" written as "manyy" need to be corrected? This is just my personal

[GitHub] [kafka] rvansa opened a new pull request, #13619: Initial support for OpenJDK CRaC snapshotting

rvansa opened a new pull request, #13619: URL: https://github.com/apache/kafka/pull/13619 This change intends to support an application using Vertx GRPC server to perform the Checkpoint and Restore on JVM implementing this, specifically using [OpenJDK CRaC](https://github.com/openjdk/crac/t

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1171245421 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo read(Rem

<    1   2