vcrfxia commented on code in PR #13522:
URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919367
##
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##
@@ -249,62 +272,62 @@ public void doJoinFromLeftThenDel
vcrfxia commented on code in PR #13522:
URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919730
##
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyVersionedJoinIntegrationTest.java:
##
@@ -0,0 +1,301 @@
+/*
+ * Licensed to the Apac
vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1171925337
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableAggregate.java:
##
@@ -116,10 +118,13 @@ public void process(final Record>
record) {
vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1171926005
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java:
##
@@ -118,10 +120,13 @@ public void process(final Record record) {
vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1171926280
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java:
##
@@ -118,10 +120,13 @@ public void process(final Record record) {
vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1171929315
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableInnerJoin.java:
##
@@ -139,7 +139,7 @@ public void process(final Record> record) {
vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1171930805
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableRepartitionMap.java:
##
@@ -154,27 +154,25 @@ public void process(final Record> record) {
vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1171930596
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableInnerJoin.java:
##
@@ -139,7 +139,7 @@ public void process(final Record> record) {
vcrfxia commented on code in PR #13188:
URL: https://github.com/apache/kafka/pull/13188#discussion_r1171931840
##
streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
vcrfxia commented on code in PR #13615:
URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110
##
streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java:
##
@@ -36,6 +37,7 @@
* @param value The value to update, it can be {@code null};
vcrfxia commented on code in PR #13615:
URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110
##
streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java:
##
@@ -36,6 +37,7 @@
* @param value The value to update, it can be {@code null};
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171934758
##
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##
@@ -16,71 +16,79 @@
*/
package kafka.zk
-import kafka.api.LeaderAndIsr
-import kafka.controller.{Leader
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171935467
##
metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingTopicMigrationClient.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171935467
##
metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingTopicMigrationClient.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation
vcrfxia commented on code in PR #13552:
URL: https://github.com/apache/kafka/pull/13552#discussion_r1171939132
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java:
##
@@ -73,6 +74,7 @@ KTable build(final Map, Aggregator
cmccabe commented on PR #13461:
URL: https://github.com/apache/kafka/pull/13461#issuecomment-1515504502
Thanks for this @mumrah .
Can we have a ZkConfigMigrationClientTest and so on, for the other new
migrationclient classes?
Should we wrap the calls to `quotaEntityConsumer.acc
mjsax merged PR #13610:
URL: https://github.com/apache/kafka/pull/13610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171941706
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171941841
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171943462
##
core/src/main/scala/kafka/zk/migration/ZkAclMigrationClient.scala:
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
vcrfxia commented on code in PR #13615:
URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110
##
streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java:
##
@@ -36,6 +37,7 @@
* @param value The value to update, it can be {@code null};
mjsax merged PR #13609:
URL: https://github.com/apache/kafka/pull/13609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945097
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -174,12 +173,12 @@ private boolean areZkBrokersReadyForMigration() {
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945520
##
core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala:
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945520
##
core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala:
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945830
##
core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala:
##
@@ -0,0 +1,250 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
philipnee commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1171946214
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -2175,7 +2182,7 @@ public void
testClusterAuthorizationExceptionInProduce
jolshan commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1171947129
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -2175,7 +2182,7 @@ public void
testClusterAuthorizationExceptionInProduceRe
cmccabe commented on code in PR #13532:
URL: https://github.com/apache/kafka/pull/13532#discussion_r1171947569
##
core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala:
##
@@ -160,10 +160,12 @@ class FinalizedFeatureChangeListener(private val
finalizedFeatureCac
cmccabe merged PR #13532:
URL: https://github.com/apache/kafka/pull/13532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1171950562
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -869,19 +906,30 @@ public CompletableFuture
acceptBatch(List recordBatch)
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1171950976
##
metadata/src/test/java/org/apache/kafka/image/publisher/SnapshotGeneratorTest.java:
##
@@ -48,7 +48,7 @@ public class SnapshotGeneratorTest {
static class MockE
mjsax commented on PR #13609:
URL: https://github.com/apache/kafka/pull/13609#issuecomment-1515524362
Merged to `trunk` and cherry-picked to `3.5` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
artemlivshits commented on code in PR #13607:
URL: https://github.com/apache/kafka/pull/13607#discussion_r1171959120
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -565,6 +565,12 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendErrorR
rreddy-22 opened a new pull request, #13616:
URL: https://github.com/apache/kafka/pull/13616
Part of KIP-848
https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol
As a part of the new protocol, there will be assignors on
ykubota commented on code in PR #13532:
URL: https://github.com/apache/kafka/pull/13532#discussion_r1171979375
##
core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala:
##
@@ -160,10 +160,12 @@ class FinalizedFeatureChangeListener(private val
finalizedFeatureCac
[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714354#comment-17714354
]
Matthias J. Sax commented on KAFKA-14922:
-
Thanks for creating this ticket. It's
[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14922:
Component/s: streams
tools
> kafka-streams-application-reset deletes topi
dengziming commented on PR #13432:
URL: https://github.com/apache/kafka/pull/13432#issuecomment-1515639065
Notable changes better than old logic:
1. Retry lookup stage on receiving `NOT_LEADER_OR_FOLLOWER` and
`LEADER_NOT_AVAILABLE`, whereas in the past we failed the partition directly
w
hudeqi opened a new pull request, #13617:
URL: https://github.com/apache/kafka/pull/13617
1. add hint in switch item "BROKER_LOGGER" in
ConfigResourceExistenceChecker, otherwise, it will be classified as default
break and deleted directly. I don’t know if adding hint is better than deleting
dengziming merged PR #13432:
URL: https://github.com/apache/kafka/pull/13432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
jolshan commented on code in PR #13607:
URL: https://github.com/apache/kafka/pull/13607#discussion_r1172068360
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -565,6 +565,12 @@ class KafkaApis(val requestChannel: RequestChannel,
requestHelper.sendErrorRespons
philipnee opened a new pull request, #13618:
URL: https://github.com/apache/kafka/pull/13618
Not very much really, just fixing some typos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
philipnee commented on code in PR #13550:
URL: https://github.com/apache/kafka/pull/13550#discussion_r1172072549
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncRespons
ijuma commented on code in PR #13280:
URL: https://github.com/apache/kafka/pull/13280#discussion_r1172120422
##
server-common/src/main/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMap.java:
##
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the Apache Software
ijuma commented on code in PR #13280:
URL: https://github.com/apache/kafka/pull/13280#discussion_r1172120422
##
server-common/src/main/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMap.java:
##
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the Apache Software
hudeqi commented on PR #13618:
URL: https://github.com/apache/kafka/pull/13618#issuecomment-1515775034
In fact, it seems that there are many such grammatical problems in the kafka
project? I think only those typos like "many" written as "manyy" need to be
corrected? This is just my personal
rvansa opened a new pull request, #13619:
URL: https://github.com/apache/kafka/pull/13619
This change intends to support an application using Vertx GRPC server to
perform the Checkpoint and Restore on JVM implementing this, specifically using
[OpenJDK CRaC](https://github.com/openjdk/crac/t
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1171245421
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -600,6 +622,176 @@ public String toString() {
}
}
+public FetchDataInfo read(Rem
101 - 149 of 149 matches
Mail list logo