hudeqi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1535663733
There are indeed corresponding recovery methods for this issue, such as
directly deleting the future log on the disk and restarting the corresponding
broker. Therefore, if the failed
showuon commented on code in PR #13312:
URL: https://github.com/apache/kafka/pull/13312#discussion_r1185666434
##
clients/src/test/java/org/apache/kafka/common/utils/ByteUtilsTest.java:
##
@@ -241,6 +244,119 @@ public void testDouble() throws IOException {
showuon commented on code in PR #13515:
URL: https://github.com/apache/kafka/pull/13515#discussion_r1185665409
##
examples/src/main/java/kafka/examples/Producer.java:
##
@@ -21,133 +21,164 @@
import org.apache.kafka.clients.producer.ProducerConfig;
import
showuon commented on code in PR #13660:
URL: https://github.com/apache/kafka/pull/13660#discussion_r1185661328
##
docs/security.html:
##
@@ -2089,6 +2089,144 @@
hudeqi commented on code in PR #13617:
URL: https://github.com/apache/kafka/pull/13617#discussion_r1185655736
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1635,7 +1636,7 @@ private enum ImbalanceSchedule {
/**
* Tracks if a
hudeqi commented on code in PR #13617:
URL: https://github.com/apache/kafka/pull/13617#discussion_r1185653614
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1635,7 +1636,7 @@ private enum ImbalanceSchedule {
/**
* Tracks if a
hudeqi commented on code in PR #13617:
URL: https://github.com/apache/kafka/pull/13617#discussion_r1185653614
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1635,7 +1636,7 @@ private enum ImbalanceSchedule {
/**
* Tracks if a
[
https://issues.apache.org/jira/browse/KAFKA-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719585#comment-17719585
]
Luke Chen commented on KAFKA-14914:
---
[~flashmouse] , thanks for reporting this issue. Does the offset
clayburn commented on code in PR #13676:
URL: https://github.com/apache/kafka/pull/13676#discussion_r1185635216
##
build.gradle:
##
@@ -39,7 +39,6 @@ plugins {
id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8"
id "com.github.spotbugs" version '5.0.13' apply
mjsax commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1185622586
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
bmscomp commented on code in PR #13676:
URL: https://github.com/apache/kafka/pull/13676#discussion_r1185622030
##
build.gradle:
##
@@ -39,7 +39,6 @@ plugins {
id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8"
id "com.github.spotbugs" version '5.0.13' apply
mjsax commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1185621879
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
mjsax commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1185618918
##
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##
@@ -106,7 +106,11 @@ private static class ValueList {
}
int next() {
[
https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719572#comment-17719572
]
A. Sophie Blee-Goldman commented on KAFKA-13891:
Thanks [~pnee] – just to round out the
bmscomp commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1535547766
It's a good think to keep dependencies up to date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719570#comment-17719570
]
A. Sophie Blee-Goldman commented on KAFKA-14016:
Nice job [~pnee] – thanks for taking
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1185605065
##
metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingTopicMigrationClient.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1185604698
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1185604580
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundation
mumrah commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1185602073
##
metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingTopicMigrationClient.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation
mumrah commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1185600997
##
core/src/main/scala/kafka/zk/migration/ZkAclMigrationClient.scala:
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
mumrah commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1185600867
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -0,0 +1,333 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1535524442
@divijvaidya this pull request targets an update to version 2.15.0, please
can you tell me better about updating not only minor versions ?
--
This is an automated message from
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1535516492
Ok. Dug into this a little bit, and some test are broken, because KS is
broken.
The original PR for https://issues.apache.org/jira/browse/KAFKA-13769 broke
KS, but it also added the
junrao commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1184289360
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1160,48 +1172,100 @@ class ReplicaManager(val config: KafkaConfig,
fetchPartitionStatus +=
sfc-gh-japatel commented on PR #12647:
URL: https://github.com/apache/kafka/pull/12647#issuecomment-1535462677
Hi team, any progress/plans on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1185544285
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -3273,17 +3274,46 @@ class PartitionTest extends AbstractPartitionTest {
baseOffset = 0L,
kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1185533261
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1090,6 +1090,9 @@ private void maybeFailWithError() {
kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1185525137
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -3405,6 +3406,54 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,
kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1185524662
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -3405,6 +3406,52 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,
kirktrue commented on PR #13640:
URL: https://github.com/apache/kafka/pull/13640#issuecomment-1535394647
> With this PR I consistently get failures with the following tests
Thanks for catching that. I was not setting the client ID to the correct
value for the `KafkaAdminClient`'s
clayburn commented on code in PR #13676:
URL: https://github.com/apache/kafka/pull/13676#discussion_r1185496911
##
build.gradle:
##
@@ -39,7 +39,6 @@ plugins {
id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8"
id "com.github.spotbugs" version '5.0.13' apply
clayburn opened a new pull request, #13676:
URL: https://github.com/apache/kafka/pull/13676
This PR publishes a build scan for every CI build on Jenkins and GitHub
Actions and for every local build from an authenticated Apache committer. The
build will not fail if publishing fails.
jeffkbkim commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1185475014
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java:
##
@@ -0,0 +1,558 @@
+/*
+ * Licensed to the Apache
jeffkbkim commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1185460028
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java:
##
@@ -0,0 +1,558 @@
+/*
+ * Licensed to the Apache
jeffkbkim commented on code in PR #13644:
URL: https://github.com/apache/kafka/pull/13644#discussion_r1185446129
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java:
##
@@ -0,0 +1,560 @@
+/**
+ * Licensed to the Apache Software
jeffkbkim commented on code in PR #13644:
URL: https://github.com/apache/kafka/pull/13644#discussion_r1185444113
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java:
##
@@ -0,0 +1,499 @@
+/**
+ * Licensed to the Apache Software
jeffkbkim commented on code in PR #13644:
URL: https://github.com/apache/kafka/pull/13644#discussion_r1185441081
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java:
##
@@ -0,0 +1,499 @@
+/**
+ * Licensed to the Apache Software
hertzsprung commented on PR #13671:
URL: https://github.com/apache/kafka/pull/13671#issuecomment-1535283665
`:clients:test:` succeeded locally but fails in CI due to a gradle
configuration problem:
> Could not create task ':clients:test'.
>
> [2023-05-04T16:19:19.121Z]
>
cmccabe closed pull request #13540: MINOR: improve QuorumController logging
URL: https://github.com/apache/kafka/pull/13540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jeffkbkim commented on code in PR #13644:
URL: https://github.com/apache/kafka/pull/13644#discussion_r1185332905
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java:
##
@@ -0,0 +1,499 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-14958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14958:
---
Description:
KAFKA-14916 was created after I incorrectly assumed transaction ID in the
[
https://issues.apache.org/jira/browse/KAFKA-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-14916.
Resolution: Fixed
> Fix code that assumes transactional ID implies all records are
[
https://issues.apache.org/jira/browse/KAFKA-13668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee resolved KAFKA-13668.
Fix Version/s: 3.6.0
Resolution: Fixed
> Failed cluster authorization should not be fatal
[
https://issues.apache.org/jira/browse/KAFKA-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719425#comment-17719425
]
Lucas Brutschy commented on KAFKA-14624:
This seems to be a duplicate of
jolshan merged PR #13607:
URL: https://github.com/apache/kafka/pull/13607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Hangleton commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1535077333
Agree that this change should be ideally confined to the Windows platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cmccabe commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1535052942
I'm going to leave a -1 here because there are a number of issues in the
patch and it's not ready to commit yet. I would encourage you to split this
patch into several parts and clearly
jolshan merged PR #12149:
URL: https://github.com/apache/kafka/pull/12149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1185204551
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -0,0 +1,415 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1185195017
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1185193708
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1185188619
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -0,0 +1,415 @@
+/*
+ * Licensed to the Apache
jeffkbkim commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1185172881
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -0,0 +1,415 @@
+/*
+ * Licensed to the Apache
jeffkbkim commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1185168753
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache
clolov commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1185137613
##
core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala:
##
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
fvaleri commented on code in PR #13515:
URL: https://github.com/apache/kafka/pull/13515#discussion_r1185104750
##
examples/src/main/java/kafka/examples/Producer.java:
##
@@ -21,133 +21,164 @@
import org.apache.kafka.clients.producer.ProducerConfig;
import
lucasbru commented on code in PR #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r1185039728
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -342,7 +342,19 @@ public void handleAssignment(final Map> activeTasks,
dajac commented on code in PR #13644:
URL: https://github.com/apache/kafka/pull/13644#discussion_r118500
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java:
##
@@ -0,0 +1,499 @@
+/**
+ * Licensed to the Apache Software
clolov commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1185002319
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -129,16 +150,19 @@
import static
machi1990 commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1534757023
> > In relation to dependency upgrade, has there been any discussion around
automated tooling e.g usage of dependabot or renovate?
>
> I don't know. I have seen @ijuma being the
divijvaidya commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1534729885
> In relation to dependency upgrade, has there been any discussion around
automated tooling e.g usage of dependabot or renovate?
I don't know. I have seen @ijuma being the one
dajac opened a new pull request, #13675:
URL: https://github.com/apache/kafka/pull/13675
This patch introduces the `PartitionWriter` interface in the
`group-coordinator` module. The `ReplicaManager` resides in the `core` module
and it is thus not accessible from the `group-coordinator`
divijvaidya commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1534725676
Thanks for your comment @machi1990. In principle what you say is right but
given the limited committer bandwidth in the community, I am trying to optimize
for code reviewer comfort
machi1990 commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1534706839
In relation to dependency upgrade, has there been any discussion around
automated tooling e.g usage of dependabot or renovate?
--
This is an automated message from the Apache Git
machi1990 commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1534704953
Thanks @divijvaidya I am wondering whether it is best to separate each
upgrade on a separate PR? That makes each dependency update atomic and thus
easier to revert in case we notice
divijvaidya opened a new pull request, #13674:
URL: https://github.com/apache/kafka/pull/13674
FetcherTest fails intermittently with OOM since it doesn't close the spied
resources properly.
```
org.gradle.api.internal.tasks.testing.TestSuiteExecutionException: Could not
complete
divijvaidya opened a new pull request, #13673:
URL: https://github.com/apache/kafka/pull/13673
All dependency upgrades in the PR are minor upgrades with backward
compatible changes. Note that no major version for dependencies have been
changed to make it a low risk change (and possibly
[
https://issues.apache.org/jira/browse/KAFKA-14817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719288#comment-17719288
]
Sergey Ivanov commented on KAFKA-14817:
---
[~showuon], thank you for explanation!
At the moment we
[
https://issues.apache.org/jira/browse/KAFKA-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719274#comment-17719274
]
Jonas Lundholm Bertelsen edited comment on KAFKA-13392 at 5/4/23 11:12 AM:
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1184873142
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -670,6 +875,14 @@ public void close() {
} catch (InterruptedException e) {
[
https://issues.apache.org/jira/browse/KAFKA-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719274#comment-17719274
]
Jonas Lundholm Bertelsen commented on KAFKA-13392:
--
We have seen this same issue with a
divijvaidya opened a new pull request, #13672:
URL: https://github.com/apache/kafka/pull/13672
# Motivation
PlaintextAdminIntegrationTest fails in a flaky manner with the follow trace
(e.g. in [this
hertzsprung opened a new pull request, #13671:
URL: https://github.com/apache/kafka/pull/13671
instead of passing `null` to the future, pass a populated
`TopicAndMetadataConfig`
`MockAdminClient` has no tests that I'm aware of.
The contribution is my original work and that I
showuon commented on code in PR #13515:
URL: https://github.com/apache/kafka/pull/13515#discussion_r1184835821
##
examples/src/main/java/kafka/examples/Producer.java:
##
@@ -21,133 +21,164 @@
import org.apache.kafka.clients.producer.ProducerConfig;
import
[
https://issues.apache.org/jira/browse/KAFKA-14817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719250#comment-17719250
]
Luke Chen edited comment on KAFKA-14817 at 5/4/23 10:11 AM:
[
https://issues.apache.org/jira/browse/KAFKA-14817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719250#comment-17719250
]
Luke Chen commented on KAFKA-14817:
---
[~polaris.alioth] [~mrMigles] , thanks for reporting this issue.
mimaison merged PR #13122:
URL: https://github.com/apache/kafka/pull/13122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #13659:
URL: https://github.com/apache/kafka/pull/13659#issuecomment-1534435900
@kirktrue could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
divijvaidya commented on code in PR #13623:
URL: https://github.com/apache/kafka/pull/13623#discussion_r1184786130
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -62,6 +65,39 @@ class LogCleanerTest {
Utils.delete(tmpdir)
}
+ @Test
+ def
sandybis commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-1534414079
@MPeli
I found AccessDenied exception again when a topic is deleted. This causes a
crash same way it used to while deleting message.
Could the same fix be applied to delete topic
showuon commented on code in PR #13515:
URL: https://github.com/apache/kafka/pull/13515#discussion_r1184761649
##
examples/src/main/java/kafka/examples/Producer.java:
##
@@ -21,133 +21,159 @@
import org.apache.kafka.clients.producer.ProducerConfig;
import
[
https://issues.apache.org/jira/browse/KAFKA-14967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Shaw updated KAFKA-14967:
---
Description:
Calling {{CreateTopicsResult.topicId().get()}} throws
{{{}NullPointerException{}}},
showuon commented on code in PR #13515:
URL: https://github.com/apache/kafka/pull/13515#discussion_r1184756806
##
examples/src/main/java/kafka/examples/Producer.java:
##
@@ -21,133 +21,159 @@
import org.apache.kafka.clients.producer.ProducerConfig;
import
[
https://issues.apache.org/jira/browse/KAFKA-14967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Shaw updated KAFKA-14967:
---
Description:
Calling {{CreateTopicsResult.topicId().get()}} throws
{{{}NullPointerException{}}},
[
https://issues.apache.org/jira/browse/KAFKA-14967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Shaw updated KAFKA-14967:
---
Description:
Calling {{CreateTopicsResult.topicId().get()}} throws
{{{}NullPointerException{}}},
fvaleri commented on code in PR #13515:
URL: https://github.com/apache/kafka/pull/13515#discussion_r1183960378
##
examples/src/main/java/kafka/examples/Producer.java:
##
@@ -21,133 +21,159 @@
import org.apache.kafka.clients.producer.ProducerConfig;
import
James Shaw created KAFKA-14967:
--
Summary: MockAdminClient throws NullPointerException in
CreateTopicsResult
Key: KAFKA-14967
URL: https://issues.apache.org/jira/browse/KAFKA-14967
Project: Kafka
fvaleri commented on code in PR #13669:
URL: https://github.com/apache/kafka/pull/13669#discussion_r1184732376
##
clients/src/main/java/org/apache/kafka/clients/producer/Callback.java:
##
@@ -36,7 +36,7 @@ public interface Callback {
* Non-Retriable
dajac commented on code in PR #13623:
URL: https://github.com/apache/kafka/pull/13623#discussion_r1184723565
##
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##
@@ -62,6 +65,39 @@ class LogCleanerTest {
Utils.delete(tmpdir)
}
+ @Test
+ def
dajac commented on PR #13666:
URL: https://github.com/apache/kafka/pull/13666#issuecomment-1534317488
@kirktrue Thanks for your comments. I have addressed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1184718825
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1184688955
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEvent.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1184687089
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache
dajac commented on PR #13638:
URL: https://github.com/apache/kafka/pull/13638#issuecomment-1534267271
@jeffkbkim @jolshan Thanks for your comments. I have addressed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1184677397
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java:
##
@@ -0,0 +1,548 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1184669415
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java:
##
@@ -0,0 +1,548 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r118484
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java:
##
@@ -0,0 +1,548 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1184655502
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #13638:
URL: https://github.com/apache/kafka/pull/13638#discussion_r1184654172
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java:
##
@@ -0,0 +1,415 @@
+/*
+ * Licensed to the Apache
1 - 100 of 103 matches
Mail list logo
