cmccabe commented on PR #13686:
URL: https://github.com/apache/kafka/pull/13686#issuecomment-1543363569
> Also noting that this significantly changes the directory structure that
the metadata shell presents.
Agreed. The shell contents are interface-unstable, though.
Maybe
cmccabe commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1190653264
##
metadata/src/main/java/org/apache/kafka/image/node/ScramCredentialDataNode.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
hudeqi commented on PR #13473:
URL: https://github.com/apache/kafka/pull/13473#issuecomment-1543327504
@dajac When you get a chance, please take a look. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hudeqi commented on PR #13473:
URL: https://github.com/apache/kafka/pull/13473#issuecomment-1543326829
> Hey @hudeqi I had a similar PR merge recently (#13623) and the comments I
received in that PR could be applied to this one also. Specifically,
>
> 1. the metric names could be
kamalcph commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1190617224
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -600,25 +623,212 @@ public String toString() {
}
}
-long
fqaiser94 commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1190413444
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
fqaiser94 commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1190413444
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
fqaiser94 commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1190418116
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
fqaiser94 commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1190413444
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
fqaiser94 commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1190412985
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
hudeqi commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1190576044
##
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##
@@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {
dengziming merged PR #13693:
URL: https://github.com/apache/kafka/pull/13693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dengziming commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1190566126
##
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##
@@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {
[
https://issues.apache.org/jira/browse/KAFKA-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-14983:
--
Fix Version/s: 3.4.1
> Upgrade jetty-server to 9.4.51
> --
>
>
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190519534
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190517157
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
jeffkbkim opened a new pull request, #13704:
URL: https://github.com/apache/kafka/pull/13704
This PR enables the new group metadata manager to generate
GroupMetadataKey/Value records.
Built on top of https://github.com/apache/kafka/pull/13663. Files to review:
*
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190477811
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
cmccabe commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1190463495
##
metadata/src/main/java/org/apache/kafka/image/node/ConfigurationsImageNode.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190455545
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190454574
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190437758
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190447106
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190445435
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
cmccabe commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1190440507
##
metadata/src/main/java/org/apache/kafka/image/node/ConfigurationImageNode.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190438367
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190437758
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190436747
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
cmccabe commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1190434740
##
metadata/src/main/java/org/apache/kafka/image/node/ClientQuotasImageNode.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190433019
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721555#comment-17721555
]
Farooq Qaiser commented on KAFKA-14911:
---
My apologies, I only saw this message yesterday, let me
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190428691
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
fqaiser94 commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1190418116
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
fqaiser94 commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1190412985
##
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##
@@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self,
from_version, to_version):
cmccabe commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1190417412
##
metadata/src/main/java/org/apache/kafka/image/node/MetadataImageNode.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
cmccabe commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1190417412
##
metadata/src/main/java/org/apache/kafka/image/node/MetadataImageNode.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190417026
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190416089
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1190415641
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software
jeqo commented on PR #12647:
URL: https://github.com/apache/kafka/pull/12647#issuecomment-1542836120
@sfc-gh-japatel thanks for the interest and reminder! Bumping the vote
thread on the mailing list as there is 1 binding vote missing.
--
This is an automated message from the Apache Git
cmccabe commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1190379066
##
metadata/src/main/java/org/apache/kafka/image/node/ProducerIdsImageNode.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
ableegoldman commented on PR #13695:
URL: https://github.com/apache/kafka/pull/13695#issuecomment-1542782902
Merged to trunk and cherrypicked to 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ableegoldman merged PR #13695:
URL: https://github.com/apache/kafka/pull/13695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721546#comment-17721546
]
A. Sophie Blee-Goldman commented on KAFKA-14981:
Have we resolved all the known issues
rondagostino commented on PR #13686:
URL: https://github.com/apache/kafka/pull/13686#issuecomment-1542774765
Also noting that this significantly changes the directory structure that the
metadata shell presents. We have `/local` and `/image`, for example, with
whatever is currently under
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190358529
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190358529
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190358529
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190358529
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190356950
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190339738
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rondagostino commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1190240987
##
metadata/src/main/java/org/apache/kafka/image/node/ProducerIdsImageNode.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r119078
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190331659
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190330383
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190329439
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190316117
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupState.java:
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190315524
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupState.java:
##
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190313449
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/generic/GenericGroupTest.java:
##
@@ -0,0 +1,936 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190312512
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190308136
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190306648
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190300876
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190295837
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190294950
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,958 @@
+/*
+ * Licensed to the Apache Software
vamossagar12 commented on PR #13701:
URL: https://github.com/apache/kafka/pull/13701#issuecomment-1542610652
Thanks @viktorsomogyi . I am assuming there would be a PR against trunk as
well(could find only against 3.3, 3.4, 3.5)?
--
This is an automated message from the Apache Git
vamossagar12 commented on PR #13701:
URL: https://github.com/apache/kafka/pull/13701#issuecomment-1542609157
LGTM, @viktorsomogyi . I see 3 PRs with more or less the same changes. I am
assuming those would be closed?
--
This is an automated message from the Apache Git Service.
To respond
cmccabe opened a new pull request, #13703:
URL: https://github.com/apache/kafka/pull/13703
Standardize controller log4j output for replaying important records. The log
message should include word "replayed" to make it clear that this is a record
replay. Log the replay of records for ACLs,
machi1990 commented on PR #13702:
URL: https://github.com/apache/kafka/pull/13702#issuecomment-1542588642
Thanks @divijvaidya thanks.
I'll close this PR in favor of https://github.com/apache/kafka/pull/12045
--
This is an automated message from the Apache Git Service.
To respond to
machi1990 closed pull request #13702: KAFKA-14985: attempt to fix
ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()
test by bumping episilon to 8 from 7
URL: https://github.com/apache/kafka/pull/13702
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721490#comment-17721490
]
Manyanda Chitimbo commented on KAFKA-14985:
---
Thanks [~divijvaidya]
>
divijvaidya commented on PR #13702:
URL: https://github.com/apache/kafka/pull/13702#issuecomment-1542584930
@machi1990 I am afraid just changing the bound is not going to help. Please
see open PR https://github.com/apache/kafka/pull/12045 associated with this fix
for details and let me
kirktrue commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1190226530
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long
[
https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya resolved KAFKA-14985.
--
Resolution: Duplicate
Resolving as duplicate of existing open JIRA.
>
[
https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721486#comment-17721486
]
Divij Vaidya commented on KAFKA-14985:
--
We already have an open Jira (and a pending PR) for this:
kirktrue commented on code in PR #13678:
URL: https://github.com/apache/kafka/pull/13678#discussion_r1190210077
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1132,6 +1136,7 @@ public void onSuccess(Void value) {
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190204060
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,967 @@
+/*
+ * Licensed to the Apache Software
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190199871
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/generic/GenericGroupTest.java:
##
@@ -0,0 +1,876 @@
+/*
+ * Licensed to the Apache Software
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190181383
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,967 @@
+/*
+ * Licensed to the Apache Software
jlprat commented on code in PR #13170:
URL: https://github.com/apache/kafka/pull/13170#discussion_r1190178039
##
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##
@@ -223,7 +204,7 @@ class CoreUtilsTest extends Logging {
val map = new ConcurrentHashMap[Int,
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190177045
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,967 @@
+/*
+ * Licensed to the Apache Software
machi1990 commented on PR #13702:
URL: https://github.com/apache/kafka/pull/13702#issuecomment-1542524201
@rajinisivaram @apovzner can you've a look once you've some time? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
machi1990 opened a new pull request, #13702:
URL: https://github.com/apache/kafka/pull/13702
The test was observed to be failing with
```
ConnectionQuotasTest >
testListenerConnectionRateLimitWhenActualRateAboveLimit() FAILED
java.util.concurrent.ExecutionException:
[
https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manyanda Chitimbo reassigned KAFKA-14985:
-
Assignee: Manyanda Chitimbo
>
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190175577
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,967 @@
+/*
+ * Licensed to the Apache Software
machi1990 commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1542514663
@ableegoldman @showuon can you've a look at this draft PR once you've
sometime? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721469#comment-17721469
]
Manyanda Chitimbo commented on KAFKA-14985:
---
A quick fix will be to bump the epsilon to a
jeffkbkim commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1190154104
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,967 @@
+/*
+ * Licensed to the Apache Software
dajac commented on PR #13694:
URL: https://github.com/apache/kafka/pull/13694#issuecomment-1542496068
Let me re-trigger the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jeffkbkim commented on PR #13694:
URL: https://github.com/apache/kafka/pull/13694#issuecomment-1542491308
@dajac the test failures look unrelated but i've noticed that sometimes the
same tests fail altogether
--
This is an automated message from the Apache Git Service.
To respond to the
erikvanoosten commented on PR #13678:
URL: https://github.com/apache/kafka/pull/13678#issuecomment-1542480034
> Hey @erikvanoosten, Thanks for the PR! Could you add checks for
inflightCommits count gets set to 0 in a few of the callback testing function
like
machi1990 commented on PR #13664:
URL: https://github.com/apache/kafka/pull/13664#issuecomment-1542460521
Thanks @philipnee this should be good to be merged @vvcephei thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viktorsomogyi opened a new pull request, #13701:
URL: https://github.com/apache/kafka/pull/13701
…(#13690)
Reviewers: Chris Egerton , Viktor Somogyi-Vass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Manyanda Chitimbo created KAFKA-14985:
-
Summary:
ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()
test is flaky
Key: KAFKA-14985
URL:
machi1990 commented on PR #13700:
URL: https://github.com/apache/kafka/pull/13700#issuecomment-1542448724
I am wondering if these sensors that are dynamically created should be
removed as well:
machi1990 commented on PR #13700:
URL: https://github.com/apache/kafka/pull/13700#issuecomment-1542446635
@rajinisivaram @dajac please review when you've the chance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
machi1990 opened a new pull request, #13700:
URL: https://github.com/apache/kafka/pull/13700
Follows up on
https://github.com/apache/kafka/pull/13623#discussion_r1182592921
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
Manyanda Chitimbo created KAFKA-14984:
-
Summary: DynamicBrokerReconfigurationTest.testThreadPoolResize()
test is flaky
Key: KAFKA-14984
URL: https://issues.apache.org/jira/browse/KAFKA-14984
C0urante commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1542437079
We don't have this automated (to my knowledge). For backports, we can
cherry-pick and push directly to the branch. PRs aren't necessary but if you'd
like a second pair of eyes to, e.g.,
viktorsomogyi commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1542434744
@C0urante thanks. I'll cherry-pick it to 3.3 soon and open a PR. Btw does
Kafka have an automated way or do you usually do it manually by git cherry-pick
and creating PR either via
1 - 100 of 136 matches
Mail list logo