rondagostino commented on PR #13686: URL: https://github.com/apache/kafka/pull/13686#issuecomment-1542774765
Also noting that this significantly changes the directory structure that the metadata shell presents. We have `/local` and `/image`, for example, with whatever is currently under `/` moving under `/image`. We also have no `data` directory underneath a topic partition. For example: `tree /` ``` image: acls: byId: clientQuotas: cluster: 1: BrokerRegistration(id=1, epoch=6147, incarnationId=M6koIGKwQdCU_PMCtLatew, listeners=[Endpoint(listenerName='PLAINTEXT', securityProtocol=PLAINTEXT, host='localhost', port=9092)], supportedFeatures={metadata.version: 1-11}, rack=Optional.empty, fenced=false, inControlledShutdown=false, isMigratingZkBroker=false) configs: features: metadataVersion: 3.5-IV2 zkMigrationState: NONE producerIds: nextProducerId: -1 provenance: offset 6, epoch 3, time 2023-05-10T20:06:51.486Z[UTC] scram: SCRAM-SHA-256: SCRAM-SHA-512: topics: byId: 8ba_iKksTFagQTBNJksHPw: 0: PartitionRegistration(replicas=[1], isr=[1], removingReplicas=[], addingReplicas=[], leader=1, leaderRecoveryState=RECOVERED, leaderEpoch=0, partitionEpoch=0) 1: PartitionRegistration(replicas=[1], isr=[1], removingReplicas=[], addingReplicas=[], leader=1, leaderRecoveryState=RECOVERED, leaderEpoch=0, partitionEpoch=0) id: 8ba_iKksTFagQTBNJksHPw name: foo byName: foo: 0: PartitionRegistration(replicas=[1], isr=[1], removingReplicas=[], addingReplicas=[], leader=1, leaderRecoveryState=RECOVERED, leaderEpoch=0, partitionEpoch=0) 1: PartitionRegistration(replicas=[1], isr=[1], removingReplicas=[], addingReplicas=[], leader=1, leaderRecoveryState=RECOVERED, leaderEpoch=0, partitionEpoch=0) id: 8ba_iKksTFagQTBNJksHPw name: foo local: commitId: f42187de19772e83 version: 3.6.0-SNAPSHOT ``` Whereas with the current version (there is no `tree` command -- a really nice addition!) `ls /` ``` brokers features local metadataQuorum topicIds topics ``` `cat /topics/foo/0/data` ``` { "partitionId" : 0, "topicId" : "8ba_iKksTFagQTBNJksHPw", "replicas" : [ 1 ], "isr" : [ 1 ], "removingReplicas" : [ ], "addingReplicas" : [ ], "leader" : 1, "leaderEpoch" : 0, "partitionEpoch" : 0 } ``` I don't think this is problematic and does not require a KIP, but would like to confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org