[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-10 Thread via GitHub
philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1190097766 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long

[GitHub] [kafka] C0urante commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics

2023-05-10 Thread via GitHub
C0urante commented on PR #13690: URL: https://github.com/apache/kafka/pull/13690#issuecomment-1542423054 @viktorsomogyi the feature was introduced in 3.3, so that should be far back enough. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dplavcic commented on pull request #12449: KAFKA-12947: Replace EasyMock and PowerMock with Mockito for StreamsMetricsImplTest

2023-05-10 Thread via GitHub
dplavcic commented on PR #12449: URL: https://github.com/apache/kafka/pull/12449#issuecomment-1542382627 > Hello @dplavcic and @cadonna, how is this pull request fairing? Is there something outstanding as a review or comments to be addressed? @clolov , I will work on this during the

[GitHub] [kafka] viktorsomogyi opened a new pull request, #13699: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics …

2023-05-10 Thread via GitHub
viktorsomogyi opened a new pull request, #13699: URL: https://github.com/apache/kafka/pull/13699 …(#13690) Reviewers: Chris Egerton , Viktor Somogyi-Vass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] divijvaidya commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

2023-05-10 Thread via GitHub
divijvaidya commented on PR #13473: URL: https://github.com/apache/kafka/pull/13473#issuecomment-1542365763 Hey @hudeqi I had a similar PR merge recently (https://github.com/apache/kafka/pull/13623) and the comments I received in that PR could be applied to this one also.

[GitHub] [kafka] viktorsomogyi opened a new pull request, #13698: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics …

2023-05-10 Thread via GitHub
viktorsomogyi opened a new pull request, #13698: URL: https://github.com/apache/kafka/pull/13698 …(#13690) Reviewers: Chris Egerton , Viktor Somogyi-Vass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] dplavcic commented on pull request #12449: KAFKA-12947: Replace EasyMock and PowerMock with Mockito for StreamsMetricsImplTest

2023-05-10 Thread via GitHub
dplavcic commented on PR #12449: URL: https://github.com/apache/kafka/pull/12449#issuecomment-1542350805 @clolov , apologies for a delayed response. I unfortunately don't have time to finish this anytime soon  -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] divijvaidya commented on pull request #13673: MINOR: Update dependencies (minor versions only)

2023-05-10 Thread via GitHub
divijvaidya commented on PR #13673: URL: https://github.com/apache/kafka/pull/13673#issuecomment-1542344954 @ijuma, requesting your thoughts about merging this in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] viktorsomogyi merged pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics

2023-05-10 Thread via GitHub
viktorsomogyi merged PR #13690: URL: https://github.com/apache/kafka/pull/13690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

2023-05-10 Thread via GitHub
jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1189924161 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,967 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-14983) Upgrade jetty-server to 9.4.51

2023-05-10 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721352#comment-17721352 ] Divij Vaidya commented on KAFKA-14983: -- There is a PR open for this

[jira] [Updated] (KAFKA-14983) Upgrade jetty-server to 9.4.51

2023-05-10 Thread Beltran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Beltran updated KAFKA-14983: Fix Version/s: 3.5.0 Affects Version/s: 3.4.0 > Upgrade jetty-server to 9.4.51 >

[jira] [Created] (KAFKA-14983) Upgrade jetty-server to 9.4.51

2023-05-10 Thread Beltran (Jira)
Beltran created KAFKA-14983: --- Summary: Upgrade jetty-server to 9.4.51 Key: KAFKA-14983 URL: https://issues.apache.org/jira/browse/KAFKA-14983 Project: Kafka Issue Type: Task Reporter:

[jira] [Resolved] (KAFKA-14514) Implement range broker side assignor

2023-05-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14514. - Fix Version/s: 3.6.0 Resolution: Fixed > Implement range broker side assignor >

[GitHub] [kafka] dajac merged pull request #13443: KAFKA-14514: Add Range Assignor on the Server (KIP-848)

2023-05-10 Thread via GitHub
dajac merged PR #13443: URL: https://github.com/apache/kafka/pull/13443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] kamalcph commented on pull request #13060: KAFKA-14559: Fix JMX tool to handle the object names with wild cards and optional attributes

2023-05-10 Thread via GitHub
kamalcph commented on PR #13060: URL: https://github.com/apache/kafka/pull/13060#issuecomment-1541980719 @fvaleri @mimaison @showuon @satishd Updated the patch with the Java JMX tool. Currently, the tool fails when using the pattern in the Object name. Covered the patch with the

[GitHub] [kafka] showuon commented on pull request #13695: HOTFIX: fix the VersionedKeyValueToBytesStoreAdapter#isOpen API

2023-05-10 Thread via GitHub
showuon commented on PR #13695: URL: https://github.com/apache/kafka/pull/13695#issuecomment-1541865141 The results look better ``` Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsTest.testFailureToFenceEpoch(String).quorum=kraft Build / JDK 17 and Scala 2.13 /

[GitHub] [kafka] hudeqi commented on a diff in pull request #13697: MINOR:code optimization in QuorumController

2023-05-10 Thread via GitHub
hudeqi commented on code in PR #13697: URL: https://github.com/apache/kafka/pull/13697#discussion_r1189682174 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {

[GitHub] [kafka] showuon commented on pull request #13695: HOTFIX: fix the VersionedKeyValueToBytesStoreAdapter#isOpen API

2023-05-10 Thread via GitHub
showuon commented on PR #13695: URL: https://github.com/apache/kafka/pull/13695#issuecomment-1541861122 I've re-triggered the build since it seems have infra issue. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13695/2/ -- This is an automated message from the Apache Git

[GitHub] [kafka] dengziming commented on a diff in pull request #13697: MINOR:code optimization in QuorumController

2023-05-10 Thread via GitHub
dengziming commented on code in PR #13697: URL: https://github.com/apache/kafka/pull/13697#discussion_r1189676045 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {

[jira] [Updated] (KAFKA-14982) Improve the kafka-metadata-quorum output

2023-05-10 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14982: Labels: need-kip (was: ) > Improve the kafka-metadata-quorum output >

[jira] [Updated] (KAFKA-14980) MirrorMaker consumers don't get configs prefixed with source.cluster

2023-05-10 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14980: --- Fix Version/s: 3.5.0 > MirrorMaker consumers don't get configs prefixed with source.cluster

[GitHub] [kafka] viktorsomogyi commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics

2023-05-10 Thread via GitHub
viktorsomogyi commented on PR #13690: URL: https://github.com/apache/kafka/pull/13690#issuecomment-1541805837 @C0urante I can backport it. Which branches were you thinking of? 3.5, 3.4, 3.3 or should I go back to an earlier release as well? -- This is an automated message from the Apache

[GitHub] [kafka] viktorsomogyi commented on pull request #11565: KAFKA-13504: Retry connect internal topics' creation in case of InvalidReplicationFactorException

2023-05-10 Thread via GitHub
viktorsomogyi commented on PR #11565: URL: https://github.com/apache/kafka/pull/11565#issuecomment-1541792221 @akatona84 seems like there is a compile issue. Please fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (KAFKA-14982) Improve the kafka-metadata-quorum output

2023-05-10 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14982: Labels: (was: need-kip) > Improve the kafka-metadata-quorum output >

[GitHub] [kafka] showuon merged pull request #13691: MINOR: remove kraft readme link

2023-05-10 Thread via GitHub
showuon merged PR #13691: URL: https://github.com/apache/kafka/pull/13691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon closed pull request #13687: MINOR: test

2023-05-10 Thread via GitHub
showuon closed pull request #13687: MINOR: test URL: https://github.com/apache/kafka/pull/13687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13660: KAFKA-14662: Update the ACL list in the doc

2023-05-10 Thread via GitHub
showuon commented on PR #13660: URL: https://github.com/apache/kafka/pull/13660#issuecomment-1541563266 backport to v3.5 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (KAFKA-14982) Improve the kafka-metadata-quorum output

2023-05-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14982: -- Labels: need-kip (was: ) > Improve the kafka-metadata-quorum output >

[jira] [Updated] (KAFKA-14982) Improve the kafka-metadata-quorum output

2023-05-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14982: -- Affects Version/s: 3.5.0 > Improve the kafka-metadata-quorum output >

[jira] [Created] (KAFKA-14982) Improve the kafka-metadata-quorum output

2023-05-10 Thread Luke Chen (Jira)
Luke Chen created KAFKA-14982: - Summary: Improve the kafka-metadata-quorum output Key: KAFKA-14982 URL: https://issues.apache.org/jira/browse/KAFKA-14982 Project: Kafka Issue Type: Improvement

[jira] [Assigned] (KAFKA-8982) Admin.deleteRecords should retry when failing to fetch metadata

2023-05-10 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-8982: Assignee: Gantigmaa Selenge > Admin.deleteRecords should retry when failing to

[GitHub] [kafka] jeqo commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-10 Thread via GitHub
jeqo commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1189509107 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +623,204 @@ public String toString() { } } -long

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-10 Thread via GitHub
satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1189455928 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +622,208 @@ public String toString() { } } -long

[GitHub] [kafka] erikvanoosten commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-10 Thread via GitHub
erikvanoosten commented on PR #13678: URL: https://github.com/apache/kafka/pull/13678#issuecomment-1541455680 @philipnee Did you get a chance to look at this PR already? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dengziming commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse

2023-05-10 Thread via GitHub
dengziming commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1541425575 @showuon There are a lot of errors, I find that `ApiVersionRequest` is very important, when all nodes start, the `NetworkClient` will be initialized and `ApiVersionRequest` will be

<    1   2