[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13453: KAFKA-12525: Ignoring Stale status statuses when reading from Status …

2023-05-19 Thread via GitHub
vamossagar12 commented on code in PR #13453: URL: https://github.com/apache/kafka/pull/13453#discussion_r1199554121 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java: ## @@ -608,6 +608,20 @@ private void readTaskStatus(String key,

[jira] [Commented] (KAFKA-15005) Status of KafkaConnect task not correct

2023-05-19 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724481#comment-17724481 ] Sagar Rao commented on KAFKA-15005: --- Thanks for the comment [~LucentWong] . Yeah in that PR, I had

[GitHub] [kafka] vamossagar12 commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-19 Thread via GitHub
vamossagar12 commented on PR #13733: URL: https://github.com/apache/kafka/pull/13733#issuecomment-1555458221 Thanks @akatona84 initially I had the same question as @divijvaidya but your explanation cleared up that doubt to some extent. If I understood the problem correctly that you

[GitHub] [kafka] hudeqi commented on pull request #13696: KAFKA-14979:Incorrect lag was calculated when markPartitionsForTruncation in ReplicaAlterLogDirsThread

2023-05-19 Thread via GitHub
hudeqi commented on PR #13696: URL: https://github.com/apache/kafka/pull/13696#issuecomment-1555415608 Hi, do you have time to review this? @divijvaidya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] hudeqi commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-19 Thread via GitHub
hudeqi commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1199516296 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val

[jira] [Created] (KAFKA-15010) KRaft Controller doesn't reconcile with Zookeeper metadata upon becoming new controller while in dual write mode.

2023-05-19 Thread Akhilesh Chaganti (Jira)
Akhilesh Chaganti created KAFKA-15010: - Summary: KRaft Controller doesn't reconcile with Zookeeper metadata upon becoming new controller while in dual write mode. Key: KAFKA-15010 URL:

[jira] [Updated] (KAFKA-15009) ClientQuotas and ACLs are not correctly synchronized while handling snapshot during migration (dual write)

2023-05-19 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Chaganti updated KAFKA-15009: -- Labels: kraft migration (was: ) > ClientQuotas and ACLs are not correctly

[jira] [Created] (KAFKA-15009) ClientQuotas and ACLs are not correctly synchronized while handling snapshot during migration (dual write)

2023-05-19 Thread Akhilesh Chaganti (Jira)
Akhilesh Chaganti created KAFKA-15009: - Summary: ClientQuotas and ACLs are not correctly synchronized while handling snapshot during migration (dual write) Key: KAFKA-15009 URL:

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

2023-05-19 Thread via GitHub
jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1199479050 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -183,6 +184,19 @@ private void clearProducerIds() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

2023-05-19 Thread via GitHub
jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1199478295 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java: ## @@ -104,27 +122,63 @@ public boolean maybeUpdateProducerEpoch(short

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

2023-05-19 Thread via GitHub
jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1199477543 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -183,6 +184,19 @@ private void clearProducerIds() {

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

2023-05-19 Thread via GitHub
hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1199413525 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +130,107 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[jira] [Assigned] (KAFKA-13504) Retry connect internal topics' creation in case of InvalidReplicationFactorException

2023-05-19 Thread Andras Katona (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Katona reassigned KAFKA-13504: - Assignee: Andras Katona (was: Viktor Somogyi-Vass) > Retry connect internal topics'

[jira] [Commented] (KAFKA-15007) MV is not set correctly in the MetadataPropagator in migration.

2023-05-19 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724371#comment-17724371 ] Akhilesh Chaganti commented on KAFKA-15007: --- PR: https://github.com/apache/kafka/pull/13732 >

[jira] [Assigned] (KAFKA-15007) MV is not set correctly in the MetadataPropagator in migration.

2023-05-19 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Chaganti reassigned KAFKA-15007: - Assignee: Akhilesh Chaganti > MV is not set correctly in the

[jira] [Assigned] (KAFKA-15003) TopicIdReplicaAssignment is not updated in migration (dual-write) when partitions are changed for topic

2023-05-19 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Chaganti reassigned KAFKA-15003: - Assignee: Akhilesh Chaganti > TopicIdReplicaAssignment is not updated in

[jira] [Commented] (KAFKA-15003) TopicIdReplicaAssignment is not updated in migration (dual-write) when partitions are changed for topic

2023-05-19 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724368#comment-17724368 ] Akhilesh Chaganti commented on KAFKA-15003: --- [~mimaison] I gave more details. Please see if it

[jira] [Commented] (KAFKA-15003) TopicIdReplicaAssignment is not updated in migration (dual-write) when partitions are changed for topic

2023-05-19 Thread Akhilesh Chaganti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724366#comment-17724366 ] Akhilesh Chaganti commented on KAFKA-15003: --- Hi, I raised a PR for the issue here:

[GitHub] [kafka] akhileshchg opened a new pull request, #13735: KAFKA-15003: When partitions are partition assignments change we do n…

2023-05-19 Thread via GitHub
akhileshchg opened a new pull request, #13735: URL: https://github.com/apache/kafka/pull/13735 …ot update TopicIdReplicaAssignment during migration (DUAL_WRITE). Fixed the metadata change events in the Migration component to check correctly for the diff in existing topic changes and

[GitHub] [kafka] mumrah commented on pull request #13732: KAFKA-15007: Always update the MetadataPropagator with correct MV.

2023-05-19 Thread via GitHub
mumrah commented on PR #13732: URL: https://github.com/apache/kafka/pull/13732#issuecomment-1554999869 @akhileshchg what do you think about passing a supplier down to MetadataPropagator rather than the MV value? This way, we'll always be guaranteed to be using the MV in the MetadataImage

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

2023-05-19 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724335#comment-17724335 ] Owen C.H. Leung commented on KAFKA-14995: - Hi there, I'm a newcomer to the kafka community & I

[jira] [Comment Edited] (KAFKA-14995) Automate asf.yaml collaborators refresh

2023-05-19 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724335#comment-17724335 ] Owen C.H. Leung edited comment on KAFKA-14995 at 5/19/23 4:27 PM: -- Hi

[GitHub] [kafka] AmareshB commented on a diff in pull request #6247: KAFKA-7466: Add IncrementalAlterConfigs API (KIP-339)

2023-05-19 Thread via GitHub
AmareshB commented on code in PR #6247: URL: https://github.com/apache/kafka/pull/6247#discussion_r1197203647 ## clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java: ## @@ -388,6 +388,48 @@ public AlterConfigsResult alterConfigs(Map configs) { */

[GitHub] [kafka] mjsax opened a new pull request, #13734: KAFKA-14862 (HOTFIX): Fix ConcurrentModificationException

2023-05-19 Thread via GitHub
mjsax opened a new pull request, #13734: URL: https://github.com/apache/kafka/pull/13734 We observed a ConcurrentModificationException. Need to use ConcurrentHashMap to fix it. ``` Caused by: java.util.ConcurrentModificationException: null at

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

2023-05-19 Thread via GitHub
Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1199068761 ## core/src/test/java/kafka/zk/ZkBrokerRegistrationTest.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Comment Edited] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

2023-05-19 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724307#comment-17724307 ] Edoardo Comar edited comment on KAFKA-14996 at 5/19/23 2:55 PM: given

[jira] [Comment Edited] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

2023-05-19 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724307#comment-17724307 ] Edoardo Comar edited comment on KAFKA-14996 at 5/19/23 2:55 PM: given

[jira] [Commented] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

2023-05-19 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724308#comment-17724308 ] Edoardo Comar commented on KAFKA-14996: --- The controller.log s are full of {{[2023-05-19

[jira] [Commented] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

2023-05-19 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724307#comment-17724307 ] Edoardo Comar commented on KAFKA-14996: --- given that this means a client request can cause a

[jira] [Updated] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

2023-05-19 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-14996: -- Priority: Critical (was: Major) > CreateTopic falis with UnknownServerException if num

[jira] [Comment Edited] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

2023-05-19 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724300#comment-17724300 ] Edoardo Comar edited comment on KAFKA-14996 at 5/19/23 2:48 PM: Similar

[jira] [Commented] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

2023-05-19 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724300#comment-17724300 ] Edoardo Comar commented on KAFKA-14996: --- Similar error is encounter if creating partitions >

[jira] [Commented] (KAFKA-13279) Implement CreateTopicsPolicy for KRaft

2023-05-19 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724293#comment-17724293 ] Edoardo Comar commented on KAFKA-13279: --- should this one not marked as closed / resolved ? >

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13705: MINOR:Optimize the use of metrics in ReplicaManager and remove checks

2023-05-19 Thread via GitHub
divijvaidya commented on code in PR #13705: URL: https://github.com/apache/kafka/pull/13705#discussion_r1199022749 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -369,9 +369,12 @@ class ReplicaManagerTest { // Use the second instance of metrics

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-19 Thread via GitHub
divijvaidya commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1199008645 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val

[jira] [Resolved] (KAFKA-14980) MirrorMaker consumers don't get configs prefixed with source.cluster

2023-05-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14980. Resolution: Fixed > MirrorMaker consumers don't get configs prefixed with source.cluster

[GitHub] [kafka] mimaison commented on pull request #13723: KAFKA-14980: Fix MirrorSourceConnector source consumer configuration

2023-05-19 Thread via GitHub
mimaison commented on PR #13723: URL: https://github.com/apache/kafka/pull/13723#issuecomment-1554625003 Backported to 3.5 too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mimaison closed pull request #11929: MINOR: s390x Stage

2023-05-19 Thread via GitHub
mimaison closed pull request #11929: MINOR: s390x Stage URL: https://github.com/apache/kafka/pull/11929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #11929: MINOR: s390x Stage

2023-05-19 Thread via GitHub
mimaison commented on PR #11929: URL: https://github.com/apache/kafka/pull/11929#issuecomment-1554612312 No updates, so I'm going to close this draft PR for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] akatona84 commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-19 Thread via GitHub
akatona84 commented on PR #13733: URL: https://github.com/apache/kafka/pull/13733#issuecomment-1554580666 Without filtering out non-readable ones it fails later but getting ignored, it won't load any plugins, not just the problematic one skipped. around here:

[GitHub] [kafka] divijvaidya commented on pull request #13730: Feature/shuai add comment

2023-05-19 Thread via GitHub
divijvaidya commented on PR #13730: URL: https://github.com/apache/kafka/pull/13730#issuecomment-1554575567 Hi @DengShuaiSimon Thank you for your first contributions to Apache Kafka. Unfortunately, we cannot merge this change. As per ASF code of conduct policy [1], we expect all

[GitHub] [kafka] divijvaidya closed pull request #13730: Feature/shuai add comment

2023-05-19 Thread via GitHub
divijvaidya closed pull request #13730: Feature/shuai add comment URL: https://github.com/apache/kafka/pull/13730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] divijvaidya closed pull request #13731: SASL_Kerberos support Kraft mode?

2023-05-19 Thread via GitHub
divijvaidya closed pull request #13731: SASL_Kerberos support Kraft mode? URL: https://github.com/apache/kafka/pull/13731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] divijvaidya commented on pull request #13731: SASL_Kerberos support Kraft mode?

2023-05-19 Thread via GitHub
divijvaidya commented on PR #13731: URL: https://github.com/apache/kafka/pull/13731#issuecomment-1554551555 Hi @sjzghw123 I would suggest to ask this question in the mailing list at d...@apache.kafka.org You can find the instructions on how to write to the mailing list at

[GitHub] [kafka] divijvaidya commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-19 Thread via GitHub
divijvaidya commented on PR #13733: URL: https://github.com/apache/kafka/pull/13733#issuecomment-1554545574 It would be helpful if you could also explain why skipping the plugin (instead of failing hard) is ok? Would silently starting up with some missing plugins be ok? -- This is an

[GitHub] [kafka] divijvaidya commented on pull request #13662: MINOR: Upgrade Jackson dependencies to version 2.15.0

2023-05-19 Thread via GitHub
divijvaidya commented on PR #13662: URL: https://github.com/apache/kafka/pull/13662#issuecomment-1554532930 Breaking changes between 2.13.x and 2.15.x: 1. `@JsonIgnore` gets more precedence than `@JsonProperty` in 2.15.x in case both annotations are assigned to a property. Prior to

[jira] [Commented] (KAFKA-15003) TopicIdReplicaAssignment is not updated in migration (dual-write) when partitions are changed for topic

2023-05-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724262#comment-17724262 ] Mickael Maison commented on KAFKA-15003: [~akhileshchg] Can you share more details? It would

[GitHub] [kafka] viktorsomogyi closed pull request #11371: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Con…

2023-05-19 Thread via GitHub
viktorsomogyi closed pull request #11371: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Con… URL: https://github.com/apache/kafka/pull/11371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Assigned] (KAFKA-13337) Scanning for Connect plugins can fail with AccessDeniedException

2023-05-19 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-13337: --- Assignee: Andras Katona (was: Tamás Héri) > Scanning for Connect plugins

[GitHub] [kafka] viktorsomogyi commented on pull request #11371: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Con…

2023-05-19 Thread via GitHub
viktorsomogyi commented on PR #11371: URL: https://github.com/apache/kafka/pull/11371#issuecomment-1554529099 Since #13733 is the continuation of this task, I'll close this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-13337) Scanning for Connect plugins can fail with AccessDeniedException

2023-05-19 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724260#comment-17724260 ] Viktor Somogyi-Vass commented on KAFKA-13337: - [~akatona] took this task over in a new PR:

[GitHub] [kafka] machi1990 commented on a diff in pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13733: URL: https://github.com/apache/kafka/pull/13733#discussion_r1198923768 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java: ## @@ -142,8 +142,12 @@ public class PluginUtils { +

[jira] [Updated] (KAFKA-14978) ExactlyOnceWorkerSourceTask does not remove parent metrics

2023-05-19 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-14978: Fix Version/s: 3.5.0 3.3.3 > ExactlyOnceWorkerSourceTask does

[GitHub] [kafka] mimaison merged pull request #13723: KAFKA-14980: Fix MirrorSourceConnector source consumer configuration

2023-05-19 Thread via GitHub
mimaison merged PR #13723: URL: https://github.com/apache/kafka/pull/13723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] akatona84 opened a new pull request, #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-19 Thread via GitHub
akatona84 opened a new pull request, #13733: URL: https://github.com/apache/kafka/pull/13733 org.apache.kafka.connect.runtime.isolation.PluginUtils.pluginUrls scans a path and collects plugin candidates from there. However, if a directory is not readable, it fails with

[jira] [Updated] (KAFKA-14911) Add system tests for rolling upgrade path of KIP-904

2023-05-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14911: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Add system tests for rolling

[jira] [Commented] (KAFKA-14911) Add system tests for rolling upgrade path of KIP-904

2023-05-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724230#comment-17724230 ] Mickael Maison commented on KAFKA-14911: I'm moving this ticket to the next release, 3.6.0. >

[jira] [Resolved] (KAFKA-15008) GCS Sink Connector to parse JSON having leading 0's for an integer field

2023-05-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-15008. Resolution: Invalid The issue you describe does not seem to be in Kafka Connect. This

[GitHub] [kafka] soarez commented on pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

2023-05-19 Thread via GitHub
soarez commented on PR #13558: URL: https://github.com/apache/kafka/pull/13558#issuecomment-1554360896 Thanks for explaining! I agree it makes sense for the client to account for this behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] soarez commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

2023-05-19 Thread via GitHub
soarez commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1198804390 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -2113,7 +2113,12 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo }

[GitHub] [kafka] soarez commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

2023-05-19 Thread via GitHub
soarez commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1198793889 ## core/src/test/java/kafka/zk/ZkBrokerRegistrationTest.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198712020 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -346,6 +355,10 @@ private Exception

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198690005 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1007,16 +1047,33 @@ public Map fetchCommittedOffsets(final Set

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198690005 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1007,16 +1047,33 @@ public Map fetchCommittedOffsets(final Set

[GitHub] [kafka] Hangleton commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-19 Thread via GitHub
Hangleton commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1198685373 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val

[GitHub] [kafka] hudeqi commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-19 Thread via GitHub
hudeqi commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1198674020 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198624271 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -346,6 +355,10 @@ private Exception

[GitHub] [kafka] hudeqi commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-19 Thread via GitHub
hudeqi commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1198671464 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val

[GitHub] [kafka] viktorsomogyi merged pull request #13701: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics …

2023-05-19 Thread via GitHub
viktorsomogyi merged PR #13701: URL: https://github.com/apache/kafka/pull/13701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] machi1990 commented on pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-19 Thread via GitHub
machi1990 commented on PR #13664: URL: https://github.com/apache/kafka/pull/13664#issuecomment-1554135959 Hi @vvcephei @showuon can you've a look at this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1554132616 Thank you for the review @showuon I'll address the comments by pushing code change in the next while. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198624271 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -346,6 +355,10 @@ private Exception

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198622895 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1007,16 +1047,33 @@ public Map fetchCommittedOffsets(final Set

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198621580 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -222,6 +225,7 @@ public ConsumerCoordinator(GroupRebalanceConfig

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198621058 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -234,6 +238,11 @@ SubscriptionState subscriptionState() {

[GitHub] [kafka] machi1990 commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-19 Thread via GitHub
machi1990 commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1198620869 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -123,6 +124,8 @@ public final class ConsumerCoordinator extends

[jira] [Created] (KAFKA-15008) GCS Sink Connector to parse JSON having leading 0's for an integer field

2023-05-19 Thread Lubna Naqvi (Jira)
Lubna Naqvi created KAFKA-15008: --- Summary: GCS Sink Connector to parse JSON having leading 0's for an integer field Key: KAFKA-15008 URL: https://issues.apache.org/jira/browse/KAFKA-15008 Project: