dengziming commented on code in PR #13679:
URL: https://github.com/apache/kafka/pull/13679#discussion_r1220994605
##
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##
@@ -112,4 +157,8 @@ class DefaultApiVersionManager(
zkMigrationEnabled
)
}
+
+ overri
urbandan commented on PR #13796:
URL: https://github.com/apache/kafka/pull/13796#issuecomment-1580030486
@viktorsomogyi Since this part of the code is quite tricky, I would try to
address the different issues in different PRs. I believe that the fix I'm
proposing will solve the issue report
showuon commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1580008259
@bmscomp , could you respond to @divijvaidya 's comments above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Xuguang zhan created KAFKA-15064:
Summary: Use KafkaTemplate to send message with below exception -
IllegalMonitorStateException
Key: KAFKA-15064
URL: https://issues.apache.org/jira/browse/KAFKA-15064
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1579948195
@dajac Can you check the please check the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
sambhav-jain-16 commented on PR #13646:
URL: https://github.com/apache/kafka/pull/13646#issuecomment-1579930237
Hi @C0urante, Did you get a chance to take a look at it? TIA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
[
https://issues.apache.org/jira/browse/KAFKA-15062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vaibhav updated KAFKA-15062:
Reviewer: David Jacot
> Power(ppc64le) support for Kafka
>
>
>
[
https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729848#comment-17729848
]
Scott Rowley edited comment on KAFKA-15000 at 6/7/23 3:41 AM:
ijuma commented on code in PR #13679:
URL: https://github.com/apache/kafka/pull/13679#discussion_r1220723779
##
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##
@@ -112,4 +157,8 @@ class DefaultApiVersionManager(
zkMigrationEnabled
)
}
+
+ override de
showuon closed pull request #13822: MINOR: update system test for 3.4.1
URL: https://github.com/apache/kafka/pull/13822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
showuon opened a new pull request, #13822:
URL: https://github.com/apache/kafka/pull/13822
update system test for 3.4.1
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify do
showuon commented on PR #13807:
URL: https://github.com/apache/kafka/pull/13807#issuecomment-1579729897
Retriggered:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13807/4/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
satishd commented on PR #13807:
URL: https://github.com/apache/kafka/pull/13807#issuecomment-1579719397
@showuon can you retrigger the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
hgeraldino commented on code in PR #13383:
URL: https://github.com/apache/kafka/pull/13383#discussion_r1220625126
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java:
##
@@ -706,95 +662,72 @@ public void testSourceTaskIgnoresProducerExcept
jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1220560961
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1040 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1220554821
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1009 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13811:
URL: https://github.com/apache/kafka/pull/13811#discussion_r1220507827
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1376,7 +1376,7 @@ public void handleResponse(AbstractResponse respo
jolshan commented on code in PR #13811:
URL: https://github.com/apache/kafka/pull/13811#discussion_r1220504060
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1599,6 +1599,8 @@ public void handleResponse(AbstractResponse respo
jolshan commented on code in PR #13811:
URL: https://github.com/apache/kafka/pull/13811#discussion_r1220504060
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1599,6 +1599,8 @@ public void handleResponse(AbstractResponse respo
[
https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729848#comment-17729848
]
Scott Rowley commented on KAFKA-15000:
--
[~showuon] Thank you for your time on this.
C0urante commented on PR #13819:
URL: https://github.com/apache/kafka/pull/13819#issuecomment-1579470948
@mimaison @viktorsomogyi if either of you has a moment, would you mind
taking a look? This change is deceptively small but I've tried to highlight in
the description both why it's valuab
C0urante commented on PR #13819:
URL: https://github.com/apache/kafka/pull/13819#issuecomment-1579468092
The next run also had [no failing integration
tests](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13819/2/tests)
for MirrorMaker 2.
Marking r
jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1220268552
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1009 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1220268287
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1009 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13795:
URL: https://github.com/apache/kafka/pull/13795#discussion_r1220267344
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -0,0 +1,1009 @@
+/*
+ * Licensed to the Apache Software Fou
gharris1727 commented on code in PR #13816:
URL: https://github.com/apache/kafka/pull/13816#discussion_r1220234170
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/TestUtils.java:
##
@@ -34,14 +38,39 @@ static Map makeProps(String... keyValues) {
}
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1220212149
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1220161797
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software
wcarlson5 commented on PR #13756:
URL: https://github.com/apache/kafka/pull/13756#issuecomment-1579290388
@vcrfxia Once you are good with this can you take a look
here[https://github.com/wcarlson5/kafka/pull/1]? Its the second part and has
the new joining logic in it. After that I should ad
vcrfxia commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1220108194
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Fo
jolshan commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1220078561
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -575,8 +575,12 @@ class Partition(val topicPartition: TopicPartition,
}
}
- def hasOngoingTransac
gharris1727 opened a new pull request, #13821:
URL: https://github.com/apache/kafka/pull/13821
In order to support multiple scanning modes, we should refactor the existing
scanning mechanism out of the DelegatingClassLoader. This is because KIP-898
will require more functionality that relie
C0urante commented on PR #12290:
URL: https://github.com/apache/kafka/pull/12290#issuecomment-1579174340
@tombentley @viktorsomogyi if you have a moment, would you mind taking a
look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
C0urante commented on PR #12444:
URL: https://github.com/apache/kafka/pull/12444#issuecomment-1579167201
Downgrading to a draft until I can revisit and fix the merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
C0urante commented on PR #12307:
URL: https://github.com/apache/kafka/pull/12307#issuecomment-1579164297
@mimaison @showuon if you have a moment, would you mind taking a look?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
C0urante commented on PR #11608:
URL: https://github.com/apache/kafka/pull/11608#issuecomment-1579162986
Downgrading to a draft until I can revisit and fix the merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
C0urante commented on PR #11369:
URL: https://github.com/apache/kafka/pull/11369#issuecomment-1579162605
Downgrading to a draft until I can revisit and fix the merge conflicts. I
may also split this into several PRs to make review easier.
--
This is an automated message from the Apache Gi
C0urante closed pull request #11986: KAFKA-7509: Clean up incorrect warnings
logged by Connect
URL: https://github.com/apache/kafka/pull/11986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
C0urante commented on PR #11986:
URL: https://github.com/apache/kafka/pull/11986#issuecomment-1579157272
Closing due to lack of review. We can revisit in the future, although the
downgrade of these log messages from `WARN` to `INFO` level in
https://github.com/apache/kafka/pull/13225 likely
C0urante closed pull request #12666: KAFKA-14244: Add guard against accidental
calls to halt JVM during testing
URL: https://github.com/apache/kafka/pull/12666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1579153067
Closing due to lack of interest; we can revisit this if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
C0urante commented on code in PR #13816:
URL: https://github.com/apache/kafka/pull/13816#discussion_r1219842657
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/TestUtils.java:
##
@@ -34,14 +38,39 @@ static Map makeProps(String... keyValues) {
}
clolov commented on PR #13712:
URL: https://github.com/apache/kafka/pull/13712#issuecomment-1579134299
Heya @cadonna! I hope I have addressed your comment, rebased and updated the
overview!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
C0urante commented on PR #13819:
URL: https://github.com/apache/kafka/pull/13819#issuecomment-1579102183
The first CI run has finished with [no failing integration
tests](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13819/1/tests/)
for MirrorMaker 2 🎉
wcarlson5 commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1219946644
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-15021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JosĂ© Armando GarcĂa Sancio updated KAFKA-15021:
---
Fix Version/s: 3.6.0
> KRaft controller increases leader epoch when
[
https://issues.apache.org/jira/browse/KAFKA-15021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JosĂ© Armando GarcĂa Sancio reopened KAFKA-15021:
> KRaft controller increases leader epoch when shrinking ISR
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JosĂ© Armando GarcĂa Sancio resolved KAFKA-15021.
Resolution: Fixed
> KRaft controller increases leader epoch when s
vvcephei commented on PR #13796:
URL: https://github.com/apache/kafka/pull/13796#issuecomment-1578989020
Just checking to see if the github/jenkins trigger still works. It looks
like it does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
vvcephei commented on PR #13796:
URL: https://github.com/apache/kafka/pull/13796#issuecomment-1578988387
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jsancio merged PR #13772:
URL: https://github.com/apache/kafka/pull/13772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
vvcephei commented on PR #13803:
URL: https://github.com/apache/kafka/pull/13803#issuecomment-1578986116
Yeah, sorry for the weird drive-bys. I was indeed trying to see if those
commands still work. Apparently, they do not.
I think this is the plugin documentation, but it also looks l
C0urante commented on PR #13803:
URL: https://github.com/apache/kafka/pull/13803#issuecomment-1578983184
@vvcephei I kicked off another Jenkins build--I haven't seen GitHub comments
working for a while to re-trigger them. Are you trying to test that out?
--
This is an automated message fr
vvcephei commented on PR #13803:
URL: https://github.com/apache/kafka/pull/13803#issuecomment-157898
test this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vvcephei commented on PR #13803:
URL: https://github.com/apache/kafka/pull/13803#issuecomment-1578980743
re-test this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
vvcephei commented on PR #13803:
URL: https://github.com/apache/kafka/pull/13803#issuecomment-1578980602
re-test this, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
vvcephei commented on PR #13803:
URL: https://github.com/apache/kafka/pull/13803#issuecomment-1578980388
Retest this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
vvcephei commented on PR #13802:
URL: https://github.com/apache/kafka/pull/13802#issuecomment-1578974789
retest this, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
vvcephei commented on PR #13802:
URL: https://github.com/apache/kafka/pull/13802#issuecomment-1578973821
retest this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
vvcephei commented on PR #13802:
URL: https://github.com/apache/kafka/pull/13802#issuecomment-1578973157
I'm going to try something out for triggering builds...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mumrah commented on code in PR #13802:
URL: https://github.com/apache/kafka/pull/13802#discussion_r1219834583
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -223,16 +223,16 @@ public void visitPartition(TopicIdPartition
topicIdP
mumrah commented on code in PR #13802:
URL: https://github.com/apache/kafka/pull/13802#discussion_r1219833727
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -267,6 +267,9 @@ void handleTopicsDelta(
) {
topicsDelta.d
[
https://issues.apache.org/jira/browse/KAFKA-15063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim updated KAFKA-15063:
--
Description:
{color:#172b4d}Ticket to track KIP-936. Since KIP-679 idempotent{color}
{color:#
[
https://issues.apache.org/jira/browse/KAFKA-15063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim updated KAFKA-15063:
--
Description:
{color:#172b4d}Ticket to track KIP-936. Since KIP-679 idempotent{color}
{color:#
[
https://issues.apache.org/jira/browse/KAFKA-14791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grant resolved KAFKA-14791.
--
Resolution: Fixed
> Create a builder class for PartitionRegistration
> ---
dajac commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1219799829
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -579,9 +579,30 @@ class UnifiedLog(@volatile var logStartOffset: Long,
result
}
+ /**
+ * Maybe crea
jsancio merged PR #13788:
URL: https://github.com/apache/kafka/pull/13788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jsancio commented on PR #13788:
URL: https://github.com/apache/kafka/pull/13788#issuecomment-1578924954
Merging. Unrelated rest failures:
```
testBalancePartitionLeaders() –
org.apache.kafka.controller.QuorumControllerTest
```
--
This is an automated message from the Apache Git S
Omnia Ibrahim created KAFKA-15063:
-
Summary: Throttle number of active PIDs
Key: KAFKA-15063
URL: https://issues.apache.org/jira/browse/KAFKA-15063
Project: Kafka
Issue Type: New Feature
mumrah commented on code in PR #13802:
URL: https://github.com/apache/kafka/pull/13802#discussion_r1219791584
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -475,12 +478,13 @@ void handleProducerIdSnapshot(ProducerIdsImage image,
hudeqi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1578890756
> @hudeqi I added myself as a reviewer, I may not have time to review this
today but will get to it this week.
OK，thanks your time.
--
This is an automated message from the Apache
dajac merged PR #13675:
URL: https://github.com/apache/kafka/pull/13675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
viktorsomogyi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1578862889
@hudeqi I added myself as a reviewer, I may not have time to review this
today but will get to it this week.
--
This is an automated message from the Apache Git Service.
To respon
dajac opened a new pull request, #13820:
URL: https://github.com/apache/kafka/pull/13820
WIP
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
ijuma commented on code in PR #13313:
URL: https://github.com/apache/kafka/pull/13313#discussion_r1219692414
##
tests/kafkatest/directory_layout/kafka_path.py:
##
@@ -49,6 +49,11 @@
CORE_DEPENDANT_TEST_LIBS_JAR_NAME:
"core/build/dependant-testlibs/*.jar",
TOOL
ijuma commented on PR #13313:
URL: https://github.com/apache/kafka/pull/13313#issuecomment-1578803245
@gharris1727 do the system tests pass with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mimaison closed pull request #3955: KAFKA-5969: Use correct error message when
the JSON file is invalid
URL: https://github.com/apache/kafka/pull/3955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mimaison commented on PR #3955:
URL: https://github.com/apache/kafka/pull/3955#issuecomment-1578794742
`PreferredReplicaLeaderElectionCommand` does not exist anymore and
`LeaderElectionCommand` does not have this issue so closing this PR.
--
This is an automated message from the Apache Gi
C0urante merged PR #13771:
URL: https://github.com/apache/kafka/pull/13771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante commented on PR #13771:
URL: https://github.com/apache/kafka/pull/13771#issuecomment-1578788384
Test failures appear unrelated (there is a known bug in the reflections
library that we use that caused a test failure which may appear related, but is
not). Merging...
--
This is an
jeffkbkim commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1219669199
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/PartitionWriter.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Founda
yashmayya commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1219648522
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java:
##
@@ -192,6 +197,220 @@ public void testCancelAfterAwaitFlush() throw
yashmayya commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1219596953
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,10 +280,33 @@ public Future set(Map
values, Callback c
showuon commented on code in PR #13807:
URL: https://github.com/apache/kafka/pull/13807#discussion_r1219562194
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3701,6 +3721,11 @@ class ReplicaManagerTest {
assertEquals(None,
replicaManager.repl
clolov commented on PR #13711:
URL: https://github.com/apache/kafka/pull/13711#issuecomment-1578656781
Heya @cadonna, I hope I have addressed all of your comments:
* Updated the PR's overview
* Rebased
* Comments on the code itself
Interestingly enough the test `shouldInitiali
viktorsomogyi commented on PR #13796:
URL: https://github.com/apache/kafka/pull/13796#issuecomment-1578650158
I had a short chat with @urbandan yesterday to understand the scope of this
fix. During the conversation we came to the conclusion that bumping the epoch
without a safety check is g
yashmayya commented on code in PR #13818:
URL: https://github.com/apache/kafka/pull/13818#discussion_r1219524567
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1320,89 +1338,188 @@ void alterSinkConnectorOffsets(String connName,
Connector
[
https://issues.apache.org/jira/browse/KAFKA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729709#comment-17729709
]
Chris Egerton commented on KAFKA-15059:
---
On second thought, it may be unnecessary
yashmayya commented on PR #13818:
URL: https://github.com/apache/kafka/pull/13818#issuecomment-1578630274
Sink connector offsets alter requests:
```
ConnectorsResource::alterConnectorOffsets ->
AbstractHerder::alterConnectorOffsets ->
(Distributed|Standalone)Herder::modifyConnect
yashmayya opened a new pull request, #13818:
URL: https://github.com/apache/kafka/pull/13818
- https://issues.apache.org/jira/browse/KAFKA-14784
- [KIP-875: First-class offsets support in Kafka
Connect](https://cwiki.apache.org/confluence/display/KAFKA/KIP-875%3A+First-class+offsets+suppo
[
https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada reassigned KAFKA-14445:
Assignee: Haruki Okada
> Producer doesn't request metadata update on REQUEST_TIMED_OUT
>
[
https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729695#comment-17729695
]
Haruki Okada commented on KAFKA-14445:
--
[~kirktrue] Thanks for your patch about
ht
urbandan commented on code in PR #13813:
URL: https://github.com/apache/kafka/pull/13813#discussion_r1219366831
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -464,10 +465,22 @@ ConfigInfos validateConnectorConfig(Map
connectorProps
Vaibhav-Nazare opened a new pull request, #13817:
URL: https://github.com/apache/kafka/pull/13817
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
Vaibhav created KAFKA-15062:
---
Summary: Power(ppc64le) support for Kafka
Key: KAFKA-15062
URL: https://issues.apache.org/jira/browse/KAFKA-15062
Project: Kafka
Issue Type: Task
Components:
lucasbru commented on code in PR #13811:
URL: https://github.com/apache/kafka/pull/13811#discussion_r1219320732
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1661,6 +1663,10 @@ public void handleResponse(AbstractResponse res
lucasbru commented on PR #13811:
URL: https://github.com/apache/kafka/pull/13811#issuecomment-1578303825
> Hey Lucas -- thanks for the PR. Just wanted to confirm -- these changes
are in line with what is proposed as part of KIP-691? It looks to me that is
the case, but wanted to confirm.
hudeqi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1578277690
Hello, are you free to help review this PR? @mimaison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
satishd commented on code in PR #13807:
URL: https://github.com/apache/kafka/pull/13807#discussion_r1219258912
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3701,6 +3721,11 @@ class ReplicaManagerTest {
assertEquals(None,
replicaManager.repl
mimaison merged PR #13473:
URL: https://github.com/apache/kafka/pull/13473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
1 - 100 of 109 matches
Mail list logo
