hudeqi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1595613347
> Sorry I'm late to the party but I had a question on this:
>
> > It seems like @clolov is right, I tested it both in quorum and zk mode,
Kafka successfully reconciles the
hudeqi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1595608359
> @viktorsomogyi Trogdor has some fault injection capabilities. I'm not sure
if disk errors are among them, but it could probably be added. See
iblislin opened a new pull request, #13871:
URL: https://github.com/apache/kafka/pull/13871
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
José Armando García Sancio created KAFKA-15100:
--
Summary: Unsafe to call tryCompleteFetchResponse on request timeout
Key: KAFKA-15100
URL: https://issues.apache.org/jira/browse/KAFKA-15100
wcarlson5 commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1232831833
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java:
##
@@ -56,10 +75,63 @@ public void init(final ProcessorContext
jolshan commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1232859633
##
core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala:
##
@@ -196,6 +201,110 @@ class ReplicaAlterLogDirsThreadTest {
assertEquals(0,
jolshan commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1595410641
Sorry I'm late to the party but I had a question on this:
>It seems like @clolov is right, I tested it both in quorum and zk mode,
Kafka successfully reconciles the questionable case
jolshan commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1232859633
##
core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala:
##
@@ -196,6 +201,110 @@ class ReplicaAlterLogDirsThreadTest {
assertEquals(0,
jolshan commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1232859045
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -706,6 +706,8 @@ abstract class AbstractFetcherThread(name: String,
*- the request
jolshan commented on PR #13721:
URL: https://github.com/apache/kafka/pull/13721#issuecomment-1595392012
Yup, looks like this is what the KIP mentioned. It's very possible this was
just missed in the initial implementation. I don't think this should cause
major issues since the defaults are
mumrah commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1595373852
@viktorsomogyi Trogdor has some fault injection capabilities. I'm not sure
if disk errors are among them, but it could probably be added. See
jeffkbkim opened a new pull request, #13870:
URL: https://github.com/apache/kafka/pull/13870
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
jolshan commented on PR #13848:
URL: https://github.com/apache/kafka/pull/13848#issuecomment-1595350950
Btw, @dajac do we typically autocreate this topic? Just curious because I've
seen some issues with __transaction_state not having enough replicas in tests
(taking 10 or so seconds to get
Justine Olshan created KAFKA-15099:
--
Summary: Flaky Test
kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft
Key: KAFKA-15099
URL: https://issues.apache.org/jira/browse/KAFKA-15099
jolshan commented on PR #13868:
URL: https://github.com/apache/kafka/pull/13868#issuecomment-1595345954
Thanks for the fix. The thread leaks have been bugging me.
Did we also want to set the hw argument to false here too?
jolshan commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1232797807
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -342,9 +347,7 @@ class ReplicaManagerTest {
rm.becomeLeaderOrFollower(1,
jolshan commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1232796642
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -84,7 +84,7 @@ import scala.jdk.CollectionConverters._
class ReplicaManagerTest {
val
[
https://issues.apache.org/jira/browse/KAFKA-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-15098:
--
Description:
[ERROR] 2023-06-16 20:14:14,298 [main] kafka.Kafka$ - Exiting Kafka due to
Ron Dagostino created KAFKA-15098:
-
Summary: KRaft migration does not proceed and broker dies if
authorizer.class.name is set
Key: KAFKA-15098
URL: https://issues.apache.org/jira/browse/KAFKA-15098
vp224 closed pull request #13869: Ktls test
URL: https://github.com/apache/kafka/pull/13869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vp224 opened a new pull request, #13869:
URL: https://github.com/apache/kafka/pull/13869
Description: Rebased the repo with ktls-jni changes and modified the
ktls-jni library version
JIRA Ticket: https://jira01.corp.linkedin.com:8443/browse/LIKAFKA-53140
Changes:
- Added
divijvaidya commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1595092684
@ijuma do you have any other questions wrt this PR? This is a useful feature
to debug our flaky tests and I would like to ensure that your questions are
addressed since you were
machi1990 commented on PR #13865:
URL: https://github.com/apache/kafka/pull/13865#issuecomment-1595032501
Thanks for the review @divijvaidya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
divijvaidya opened a new pull request, #13868:
URL: https://github.com/apache/kafka/pull/13868
Fixes thread leaks by closing the ReplicaManager properly at the end of each
test. The leaks were leading to flaky test failures in ReplicaManagerTest with
errors such as:
```
tkuramoto33 opened a new pull request, #13867:
URL: https://github.com/apache/kafka/pull/13867
The current help message for kafka-metadata-shell.sh is as follows.
```
$ ~/kafka_2.13-3.5.0/bin/kafka-metadata-shell.sh -h
usage: metadata-tool [-h] [--snapshot SNAPSHOT] [command
dajac merged PR #13854:
URL: https://github.com/apache/kafka/pull/13854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elkhan Eminov updated KAFKA-14112:
--
Description:
The offset lag is the difference of the last replicated record's (LRO) source
dajac commented on PR #13854:
URL: https://github.com/apache/kafka/pull/13854#issuecomment-1594960723
The number if failed tests is scary but none of them are related to this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
machi1990 opened a new pull request, #13866:
URL: https://github.com/apache/kafka/pull/13866
I was going through the LogCleaner.scala file to familiarise myself with
that part of the codebase and I noticed this minor improvement to help with
code navigation.
### Committer Checklist
hudeqi commented on PR #13839:
URL: https://github.com/apache/kafka/pull/13839#issuecomment-1594953593
> Thanks for the PR @hudeqi. I think it's always good to improve JavaDocs or
ScalaDocs.
>
> I was looking at the `LogCleaner.scala` file and I saw there are plenty of
[
https://issues.apache.org/jira/browse/KAFKA-15097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukesh Mishra updated KAFKA-15097:
--
Description:
Currently we are facing NoSuchFileException in LogCleaner, which is critical
[
https://issues.apache.org/jira/browse/KAFKA-15097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukesh Mishra updated KAFKA-15097:
--
Affects Version/s: 3.3.1
> NoSuchFileException in LogCleaner Operation.
>
C0urante commented on PR #13864:
URL: https://github.com/apache/kafka/pull/13864#issuecomment-1594925376
Thanks Josep! Will merge without awaiting CI results as this is a clean
revert and I've verified locally that the
`MirrorConnectorsIntegrationTransactionsTest::testReplication` test
[
https://issues.apache.org/jira/browse/KAFKA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733576#comment-17733576
]
Manyanda Chitimbo edited comment on KAFKA-15096 at 6/16/23 4:09 PM:
[
https://issues.apache.org/jira/browse/KAFKA-15097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukesh Mishra updated KAFKA-15097:
--
Priority: Blocker (was: Critical)
> NoSuchFileException in LogCleaner Operation.
>
machi1990 commented on PR #13865:
URL: https://github.com/apache/kafka/pull/13865#issuecomment-1594915227
@showuon @mimaison @divijvaidya can one of you have a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
machi1990 opened a new pull request, #13865:
URL: https://github.com/apache/kafka/pull/13865
Upgrade to 1.1.10.1 to fix CVE 2023-34455
The release notes are available at
https://github.com/xerial/snappy-java/releases/tag/v1.1.10.1
### Committer Checklist (excluded from commit
Mukesh Mishra created KAFKA-15097:
-
Summary: NoSuchFileException in LogCleaner Operation.
Key: KAFKA-15097
URL: https://issues.apache.org/jira/browse/KAFKA-15097
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manyanda Chitimbo reassigned KAFKA-15096:
-
Assignee: Manyanda Chitimbo
> CVE 2023-34455 - Vulnerability identified with
maniekes commented on PR #13321:
URL: https://github.com/apache/kafka/pull/13321#issuecomment-1594900986
some extra research. i rolled back changes for cygpath --windows
in MSYS2 MINGW64 i got following error:
```bash
*@rafal-laptok MINGW64 /c/rafal/git/maniekes-kafka
$
hudeqi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1594893813
Thanks for your comment, I have merged the latest trunk to see if it can
pass the CI check. @viktorsomogyi
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sasikumar Muthukrishnan Sampath updated KAFKA-15096:
Description:
A new vulnerability CVE-2023-34455 is
Sasikumar Muthukrishnan Sampath created KAFKA-15096:
---
Summary: CVE 2023-34455 - Vulnerability identified with Apache
kafka
Key: KAFKA-15096
URL: https://issues.apache.org/jira/browse/KAFKA-15096
dajac opened a new pull request, #13863:
URL: https://github.com/apache/kafka/pull/13863
This test still fails regularly with the following error:
```
Error
java.util.concurrent.ExecutionException:
org.opentest4j.AssertionFailedError: Timed out while awaiting expected
mumrah merged PR #13257:
URL: https://github.com/apache/kafka/pull/13257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on code in PR #12976:
URL: https://github.com/apache/kafka/pull/12976#discussion_r1232345504
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -156,6 +156,21 @@ object TestUtils extends Logging {
*/
def tempFile(prefix: String, suffix:
tombentley commented on code in PR #13862:
URL: https://github.com/apache/kafka/pull/13862#discussion_r1232343003
##
docs/streams/quickstart.html:
##
@@ -91,8 +91,8 @@ Step
zigarn commented on PR #12976:
URL: https://github.com/apache/kafka/pull/12976#issuecomment-1594798209
@divijvaidya: rebased!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
justinrlee commented on PR #12797:
URL: https://github.com/apache/kafka/pull/12797#issuecomment-1594792962
Sorry for the delay here! I recently went on paternity leave but will pick
this up (and add tests) when I get back in a month or two.
--
This is an automated message from the Apache
divijvaidya commented on PR #13099:
URL: https://github.com/apache/kafka/pull/13099#issuecomment-1594751739
@showuon rebase from trunk please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
divijvaidya commented on PR #12976:
URL: https://github.com/apache/kafka/pull/12976#issuecomment-1594744324
@zigarn can you please rebase this PR with trunk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
C0urante commented on PR #13819:
URL: https://github.com/apache/kafka/pull/13819#issuecomment-1594743764
Thanks guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
divijvaidya commented on PR #12852:
URL: https://github.com/apache/kafka/pull/12852#issuecomment-1594740256
Hey @likeyoukang
Thank you for your first contribution. Could you please rebase this PR from
trunk? And also change the title of the PR to "MINOR: Use "constant equals
object"
divijvaidya closed pull request #12905: fix check for MinGW64 compatibility
URL: https://github.com/apache/kafka/pull/12905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
divijvaidya commented on PR #12905:
URL: https://github.com/apache/kafka/pull/12905#issuecomment-1594742425
We have another PR https://github.com/apache/kafka/pull/13321 opened for
this. Closing this in favour of the other one.
--
This is an automated message from the Apache Git Service.
divijvaidya commented on PR #12797:
URL: https://github.com/apache/kafka/pull/12797#issuecomment-1594727580
ping @justinrlee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
divijvaidya closed pull request #12636: KAFKA-14214: Convert StandardAuthorizer
to copy-on-write
URL: https://github.com/apache/kafka/pull/12636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
divijvaidya commented on PR #12636:
URL: https://github.com/apache/kafka/pull/12636#issuecomment-1594725046
> I uploaded a new version at https://github.com/apache/kafka/pull/12662
In that case, closing this one.
--
This is an automated message from the Apache Git Service.
To
mumrah commented on PR #13257:
URL: https://github.com/apache/kafka/pull/13257#issuecomment-1594723400
Thanks @mimaison, updated with your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
divijvaidya commented on PR #12662:
URL: https://github.com/apache/kafka/pull/12662#issuecomment-1594720549
@cmccabe I guess this can be closed now since it is superseded by
https://github.com/apache/kafka/pull/13437 ?
--
This is an automated message from the Apache Git Service.
To
divijvaidya commented on PR #12667:
URL: https://github.com/apache/kafka/pull/12667#issuecomment-1594713861
@nicktelford ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
divijvaidya commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1594708038
@OmniaGM can you please rebase this with trunk and I would be happy to begin
a review for this.
--
This is an automated message from the Apache Git Service.
To respond to the
divijvaidya commented on PR #13321:
URL: https://github.com/apache/kafka/pull/13321#issuecomment-1594696603
> hope you test is also in pipeline for cygwin to be double sure
No, we don't have any tests based on windows (or cygwin) in our pipeline. We
don't officially promise to
divijvaidya merged PR #13858:
URL: https://github.com/apache/kafka/pull/13858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #13858:
URL: https://github.com/apache/kafka/pull/13858#issuecomment-1594662486
Unrelated test failures:
```
[Build / JDK 8 and Scala 2.12 /
Divij Vaidya created KAFKA-15095:
Summary: Flaky test
EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2[true]
Key: KAFKA-15095
URL: https://issues.apache.org/jira/browse/KAFKA-15095
maniekes commented on PR #13321:
URL: https://github.com/apache/kafka/pull/13321#issuecomment-1594651760
okay, i think i found root cause for it:
https://github.com/apache/kafka/blob/trunk/bin/kafka-server-start.sh#L25
[
https://issues.apache.org/jira/browse/KAFKA-15066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-15066.
---
Fix Version/s: 3.6.0
Resolution: Fixed
> passing listener name config into
showuon merged PR #13828:
URL: https://github.com/apache/kafka/pull/13828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on PR #13854:
URL: https://github.com/apache/kafka/pull/13854#issuecomment-1594627878
```
% ./gradlew rat --dry-run
> Configure project :
Starting build with version 3.6.0-SNAPSHOT (commit id 55373f1f) using Gradle
8.1.1, Java 17 and Scala 2.13.10
Build
maniekes commented on PR #13321:
URL: https://github.com/apache/kafka/pull/13321#issuecomment-1594625896
ok, good catch with MSYS2 @divijvaidya. i have installed git bash, msys2,
cygwin and tested on all of them(on msys2 i testes on msys2-mingw and on pure
msys2).
what i noticed
divijvaidya commented on PR #13854:
URL: https://github.com/apache/kafka/pull/13854#issuecomment-1594625865
This is perfect. I was trying a similar approach but somehow my `it.tasks`
wasn't returning the `processMessages`?!
Can you please verify that it is working fine by running
showuon commented on PR #13828:
URL: https://github.com/apache/kafka/pull/13828#issuecomment-1594624985
Failed tests are unrelated and the failed `testReplication` also fail in
trunk build. I've identified it's caused by this change:
https://github.com/apache/kafka/pull/13838 . Go ahead to
dajac commented on PR #13854:
URL: https://github.com/apache/kafka/pull/13854#issuecomment-1594618113
@divijvaidya I just push another approach. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
viktorsomogyi commented on PR #13696:
URL: https://github.com/apache/kafka/pull/13696#issuecomment-1594603126
@hudeqi I can get to this early next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
viktorsomogyi commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1232168660
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -97,6 +97,16 @@ class ReplicaAlterLogDirsThread(name: String,
}
}
+ // For
viktorsomogyi merged PR #13719:
URL: https://github.com/apache/kafka/pull/13719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #13854:
URL: https://github.com/apache/kafka/pull/13854#issuecomment-1594554215
I just encountered another idea.
Just put `rat.dependsOn compileJava` at
https://github.com/apache/kafka/blob/e1d59920f4fed5c4bc890e53e249d3439e148bab/build.gradle#L211
lvillaca commented on PR #12358:
URL: https://github.com/apache/kafka/pull/12358#issuecomment-1594475316
> @yuz10 are you able to ping someone to get this moving forward? This must
be blocking a lot of people of upgrading existing installs.
>
> Thanks.
Our project is also
divijvaidya commented on PR #13854:
URL: https://github.com/apache/kafka/pull/13854#issuecomment-1594472639
This problem is annoying and real. Thank you for starting a PR to fix this.
Another example build that fails with similar problems:
[
https://issues.apache.org/jira/browse/KAFKA-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733444#comment-17733444
]
Elkhan Eminov commented on KAFKA-14112:
---
[~viktorsomogyi] is this this actual? This went out of my
[ https://issues.apache.org/jira/browse/KAFKA-14112 ]
Elkhan Eminov deleted comment on KAFKA-14112:
---
was (Author: JIRAUSER285952):
Hey [~viktorsomogyi], this is WIP, I'll submit a PR soon
> Expose replication-offset-lag Mirror metric
>
viktorsomogyi merged PR #13819:
URL: https://github.com/apache/kafka/pull/13819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733434#comment-17733434
]
Kumar Shivendu commented on KAFKA-15050:
Nice! I'll pick up something else then.
> Prompts in
dajac commented on PR #13719:
URL: https://github.com/apache/kafka/pull/13719#issuecomment-1594414022
@viktorsomogyi Nope. LGTM. Feel free to merge it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
viktorsomogyi commented on PR #13719:
URL: https://github.com/apache/kafka/pull/13719#issuecomment-1594411657
@dajac do you have other comments or can I merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
divijvaidya commented on PR #13321:
URL: https://github.com/apache/kafka/pull/13321#issuecomment-1594389639
Thank you @maniekes. MINGW64 looks good. Can you also please provide test
details for MSYS?
--
This is an automated message from the Apache Git Service.
To respond to the message,
divijvaidya commented on PR #13850:
URL: https://github.com/apache/kafka/pull/13850#issuecomment-1594369804
Thank you for looking into this @satishd
> But we observed an impact when there is a degradation in our remote
storage(HDFS) clusters.
Yes, you are right, the impact
divijvaidya commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1231951562
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -37,88 +40,125 @@ object RemoteIndexCache {
val TmpFileSuffix = ".tmp"
}
-class
divijvaidya commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1231937722
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -37,88 +40,125 @@ object RemoteIndexCache {
val TmpFileSuffix = ".tmp"
}
-class
divijvaidya commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1231938032
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -170,44 +190,173 @@ class RemoteIndexCacheTest {
divijvaidya commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1231931509
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -167,14 +210,14 @@ class RemoteIndexCache(maxSize: Int = 1024,
remoteStorageManager:
satishd commented on code in PR #13850:
URL: https://github.com/apache/kafka/pull/13850#discussion_r1231867641
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -37,88 +40,125 @@ object RemoteIndexCache {
val TmpFileSuffix = ".tmp"
}
-class Entry(val
jlprat commented on PR #13824:
URL: https://github.com/apache/kafka/pull/13824#issuecomment-1594214535
Hi @satishd or @showuon any opinions on this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cmccabe commented on code in PR #13826:
URL: https://github.com/apache/kafka/pull/13826#discussion_r1230241309
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -441,23 +441,14 @@ class ControllerApis(val requestChannel: RequestChannel,
if
[
https://issues.apache.org/jira/browse/KAFKA-15094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana reassigned KAFKA-15094:
--
Assignee: Abhijeet Kumar
> Add RemoteIndexCache metrics like
satishd commented on PR #13850:
URL: https://github.com/apache/kafka/pull/13850#issuecomment-1594160765
Thanks for the clarification @ben-manes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Satish Duggana created KAFKA-15094:
--
Summary: Add RemoteIndexCache metrics like
misses/evictions/load-failures.
Key: KAFKA-15094
URL: https://issues.apache.org/jira/browse/KAFKA-15094
Project: Kafka
98 matches
Mail list logo
