[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-19 Thread via GitHub
wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1234687152 ## streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinWithGraceIntegrationTest.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] wcarlson5 opened a new pull request, #13878: Minor: Move RocksDBTimeOrderedKeyValueBufferTest to use Junit5

2023-06-19 Thread via GitHub
wcarlson5 opened a new pull request, #13878: URL: https://github.com/apache/kafka/pull/13878 Upgrade RocksDBTimeOrderedKeyValueBufferTest to use Junit5 *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected

[GitHub] [kafka] wcarlson5 commented on pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-19 Thread via GitHub
wcarlson5 commented on PR #13855: URL: https://github.com/apache/kafka/pull/13855#issuecomment-1598038798 @cadonna I got around to updating the tests as well like you asked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] hudeqi opened a new pull request, #13877: MINOR:Fix wrong semantics hint in TROGDOR.md

2023-06-19 Thread via GitHub
hudeqi opened a new pull request, #13877: URL: https://github.com/apache/kafka/pull/13877 A minor fix hint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-19 Thread via GitHub
wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1232839068 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinWithGraceTest.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-15107) Additional custom metadata for remote log segment

2023-06-19 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15107: --- Labels: tiered-storage (was: ) > Additional custom metadata for remote log segment >

[GitHub] [kafka] cmccabe closed pull request #13826: KAFKA-15060: fix the ApiVersionManager interface

2023-06-19 Thread via GitHub
cmccabe closed pull request #13826: KAFKA-15060: fix the ApiVersionManager interface URL: https://github.com/apache/kafka/pull/13826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cmccabe commented on pull request #13826: KAFKA-15060: fix the ApiVersionManager interface

2023-06-19 Thread via GitHub
cmccabe commented on PR #13826: URL: https://github.com/apache/kafka/pull/13826#issuecomment-1597881564 merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] abbccdda closed pull request #6895: KAFKA-8489: Remove group immediately upon Dead state

2023-06-19 Thread via GitHub
abbccdda closed pull request #6895: KAFKA-8489: Remove group immediately upon Dead state URL: https://github.com/apache/kafka/pull/6895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] abbccdda closed pull request #8110: DEBUG: Handle OutOfSequence error on Stream Thread

2023-06-19 Thread via GitHub
abbccdda closed pull request #8110: DEBUG: Handle OutOfSequence error on Stream Thread URL: https://github.com/apache/kafka/pull/8110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] lucasbru opened a new pull request, #13876: Make txn offset commit fencing fatal

2023-06-19 Thread via GitHub
lucasbru opened a new pull request, #13876: URL: https://github.com/apache/kafka/pull/13876 - In one case, throw `CorrelationIdMismatchException` instead of `RuntimeException`. - Use `IllegalStateException` for all states that should be impossible to reach - `FENCED_INSTANCE_ID`,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
divijvaidya commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1234237168 ## core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala: ## @@ -28,13 +28,12 @@ import org.apache.kafka.server.quota.ClientQuotaCallback import

[GitHub] [kafka] cadonna commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2023-06-19 Thread via GitHub
cadonna commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1597409327 Once the build are acceptable, I am going to merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] cadonna commented on a diff in pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2023-06-19 Thread via GitHub
cadonna commented on code in PR #12739: URL: https://github.com/apache/kafka/pull/12739#discussion_r1234220438 ## streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java: ## @@ -144,45 +148,35 @@ public void closeStore() {

[jira] [Updated] (KAFKA-15108) task.timeout.ms does not work when TimeoutException is thrown by streams producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms does not work when TimeoutException is

[GitHub] [kafka] jlprat commented on pull request #13840: MINOR: Upgrade Scala for Java 20/21 support

2023-06-19 Thread via GitHub
jlprat commented on PR #13840: URL: https://github.com/apache/kafka/pull/13840#issuecomment-1597378453 > So, I think the change I made makes things clearer in the end. I agree. Thanks @ijuma -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

2023-06-19 Thread via GitHub
ijuma commented on PR #13582: URL: https://github.com/apache/kafka/pull/13582#issuecomment-1597377059 Looks like there is a spotbugs issue, I'll investigate that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] ijuma commented on pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

2023-06-19 Thread via GitHub
ijuma commented on PR #13582: URL: https://github.com/apache/kafka/pull/13582#issuecomment-1597375537 @divijvaidya if you're comfortable, I think this is ready to be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ijuma commented on pull request #13840: MINOR: Upgrade Scala for Java 20/21 support

2023-06-19 Thread via GitHub
ijuma commented on PR #13840: URL: https://github.com/apache/kafka/pull/13840#issuecomment-1597374541 Thanks for the reviews. A couple of responses. > I don't think we are hitting those, but I just wanted to make sure we are aware of these before merging. Yes, I saw that note

[GitHub] [kafka] ijuma commented on a diff in pull request #13840: MINOR: Upgrade Scala for Java 20/21 support

2023-06-19 Thread via GitHub
ijuma commented on code in PR #13840: URL: https://github.com/apache/kafka/pull/13840#discussion_r1234197390 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2499,15 +2499,16 @@ class ReplicaManagerTest {

[GitHub] [kafka] machi1990 commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
machi1990 commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1234194014 ## core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala: ## @@ -28,13 +28,12 @@ import org.apache.kafka.server.quota.ClientQuotaCallback import

[jira] [Updated] (KAFKA-15108) task.timeout.ms does not work when TimeoutException is thrown by streams producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms does not work when TimeoutException is

[jira] [Updated] (KAFKA-15108) task.timeout.ms does not work when TimeoutException is thrown by streams producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms does not work when TimeoutException is

[jira] [Updated] (KAFKA-15108) task.timeout.ms does not work when TimeoutException is thrown by streams producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms does not work when TimeoutException is

[jira] [Updated] (KAFKA-15108) task.timeout.ms does not work when TimeoutException is thrown by stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms does not work when TimeoutException is

[jira] [Updated] (KAFKA-15108) task.timeout.ms does not work when TimeoutException is thrown by streams producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Summary: task.timeout.ms does not work when TimeoutException is thrown by streams

[jira] [Updated] (KAFKA-15108) task.timeout.ms does not work when TimeoutException is thrown by stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Summary: task.timeout.ms does not work when TimeoutException is thrown by stream

[jira] [Updated] (KAFKA-15108) task.timeout.ms does not work when TimeoutException is thrown by stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms does not work when TimeoutException is

[jira] [Updated] (KAFKA-15108) Task.timeout.ms does not work when TimeoutException is thrown by stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms does not work when TimeoutException is

[jira] [Updated] (KAFKA-15108) Task.timeout.ms does not work when TimeoutException is thrown by stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Summary: Task.timeout.ms does not work when TimeoutException is thrown by stream

[jira] [Updated] (KAFKA-15108) task.timeout.ms doesn't work for the stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms doesn't work for the stream producer --

[jira] [Updated] (KAFKA-15108) task.timeout.ms doesn't work for the stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms doesn't work for the stream producer --

[jira] [Updated] (KAFKA-15108) task.timeout.ms doesn't work for the stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms doesn't work for the stream producer --

[jira] [Updated] (KAFKA-15108) task.timeout.ms doesn't work for the stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms doesn't work for the stream producer --

[jira] [Updated] (KAFKA-15108) task.timeout.ms doesn't work for the stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15108: --- Description: [Problem] - task.timeout.ms doesn't work for the stream producer --

[jira] [Created] (KAFKA-15108) task.timeout.ms doesn't work for the stream producer

2023-06-19 Thread Tomonari Yamashita (Jira)
Tomonari Yamashita created KAFKA-15108: -- Summary: task.timeout.ms doesn't work for the stream producer Key: KAFKA-15108 URL: https://issues.apache.org/jira/browse/KAFKA-15108 Project: Kafka

[GitHub] [kafka] machi1990 commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
machi1990 commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1234178162 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -574,6 +574,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, def

[GitHub] [kafka] mimaison merged pull request #13875: MINOR: Close code tag in Producer configs

2023-06-19 Thread via GitHub
mimaison merged PR #13875: URL: https://github.com/apache/kafka/pull/13875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15107) Additional custom metadata for remote log segment

2023-06-19 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Yurchenko updated KAFKA-15107: --- Description: Based on the [KIP-917: Additional custom metadata for remote log

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
divijvaidya commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1234166769 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -574,6 +574,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, def

[GitHub] [kafka] machi1990 commented on pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
machi1990 commented on PR #13700: URL: https://github.com/apache/kafka/pull/13700#issuecomment-1597319479 > Thank you for the PR. It's worth noting that the ClientQuotaManagers are shutdown on broker shutdown and hence, it's not a big deal if we are leaking metrics right now. Nevertheless,

[GitHub] [kafka] machi1990 commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
machi1990 commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1234159704 ## core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala: ## @@ -418,6 +418,17 @@ class ClientQuotaManagerTest extends BaseClientQuotaManagerTest {

[GitHub] [kafka] divijvaidya commented on pull request #13850: KAFKA-15084: Remove lock contention from RemoteIndexCache

2023-06-19 Thread via GitHub
divijvaidya commented on PR #13850: URL: https://github.com/apache/kafka/pull/13850#issuecomment-1597273967 Rebasing from trunk to fix flaky CI test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] mimaison commented on pull request #13875: MINOR: Close code tag in Producer configs

2023-06-19 Thread via GitHub
mimaison commented on PR #13875: URL: https://github.com/apache/kafka/pull/13875#issuecomment-1597266192 Matching PR for kafka-site: https://github.com/apache/kafka/pull/13875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] machi1990 commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
machi1990 commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1234120547 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -572,6 +572,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, }

[GitHub] [kafka] mimaison opened a new pull request, #13875: MINOR: Close code tag in Producer configs

2023-06-19 Thread via GitHub
mimaison opened a new pull request, #13875: URL: https://github.com/apache/kafka/pull/13875 This unclosed `code` tag messes with the formatting: https://github.com/apache/kafka/assets/903615/c7b4f391-b527-4674-acd0-3d92595fa5b1;> ### Committer Checklist (excluded from commit

[GitHub] [kafka] machi1990 commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
machi1990 commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1234120168 ## core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala: ## @@ -418,6 +418,17 @@ class ClientQuotaManagerTest extends BaseClientQuotaManagerTest {

[GitHub] [kafka] machi1990 commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
machi1990 commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1234119510 ## core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala: ## @@ -418,6 +418,17 @@ class ClientQuotaManagerTest extends BaseClientQuotaManagerTest {

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-06-19 Thread via GitHub
machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1597260242 @showuon I was looking onto this and after several local runs, I managed to eliminate some flasky test and came up with the list of failures that are only caused by this change. The

[jira] [Resolved] (KAFKA-15085) Make Timer.java implement AutoCloseable

2023-06-19 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15085. -- Reviewer: Divij Vaidya Resolution: Fixed > Make Timer.java implement AutoCloseable >

[jira] [Assigned] (KAFKA-15085) Make Timer.java implement AutoCloseable

2023-06-19 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-15085: Assignee: Joobi S B > Make Timer.java implement AutoCloseable >

[jira] [Updated] (KAFKA-15085) Make Timer.java implement AutoCloseable

2023-06-19 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15085: - Fix Version/s: 3.6.0 > Make Timer.java implement AutoCloseable >

[GitHub] [kafka] divijvaidya merged pull request #13872: KAFKA-15085: Make Timer.java implement AutoCloseable

2023-06-19 Thread via GitHub
divijvaidya merged PR #13872: URL: https://github.com/apache/kafka/pull/13872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #12290: MINOR: Stop leaking threads in BlockingConnectorTest

2023-06-19 Thread via GitHub
viktorsomogyi commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1234081443 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -350,13 +353,16 @@ private void

[GitHub] [kafka] showuon commented on a diff in pull request #13850: KAFKA-15084: Remove lock contention from RemoteIndexCache

2023-06-19 Thread via GitHub
showuon commented on code in PR #13850: URL: https://github.com/apache/kafka/pull/13850#discussion_r1233980545 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -117,51 +128,60 @@ class RemoteIndexCacheTest { @Test def

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233967737 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -37,7 +39,8 @@ class TransactionDataAndCallbacks(val transactionData:

[GitHub] [kafka] satishd commented on pull request #13850: KAFKA-15084: Remove lock contention from RemoteIndexCache

2023-06-19 Thread via GitHub
satishd commented on PR #13850: URL: https://github.com/apache/kafka/pull/13850#issuecomment-1597070428 >I understand what you are saying. I did consider that approach. So that we are on the same page, the approach looks like: ... Caffeine on the other hand doesn't have any of the

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233955360 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -366,16 +367,16 @@ class BrokerToControllerRequestThread( val

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

2023-06-19 Thread via GitHub
divijvaidya commented on code in PR #13700: URL: https://github.com/apache/kafka/pull/13700#discussion_r1233939989 ## core/src/test/scala/unit/kafka/server/ClientQuotaManagerTest.scala: ## @@ -418,6 +418,17 @@ class ClientQuotaManagerTest extends BaseClientQuotaManagerTest {

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233946298 ## server-common/src/test/java/org/apache/kafka/server/util/InterBrokerSendThreadTest.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233945004 ## server-common/src/test/java/org/apache/kafka/server/util/InterBrokerSendThreadTest.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] satishd commented on pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-06-19 Thread via GitHub
satishd commented on PR #13561: URL: https://github.com/apache/kafka/pull/13561#issuecomment-1597034800 > @satishd , any update for this PR? If you don't have time on it, just let me know. :) addressing the review comments in progress, needs minor refactoring which is going on. Will

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233937877 ## server-common/src/test/java/org/apache/kafka/server/util/InterBrokerSendThreadTest.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] yashmayya commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

2023-06-19 Thread via GitHub
yashmayya commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1233861544 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -140,6 +142,9 @@ public static ConnectorOffsetBackingStore

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233934433 ## server-common/src/main/java/org/apache/kafka/server/util/RequestAndCompletionHandler.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233928519 ## server-common/src/main/java/org/apache/kafka/server/util/RequestAndCompletionHandler.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-15107) Additional custom metadata for remote log segment

2023-06-19 Thread Ivan Yurchenko (Jira)
Ivan Yurchenko created KAFKA-15107: -- Summary: Additional custom metadata for remote log segment Key: KAFKA-15107 URL: https://issues.apache.org/jira/browse/KAFKA-15107 Project: Kafka Issue

[GitHub] [kafka] divijvaidya merged pull request #13341: MINOR: add comment that timestamp unit is milliseconds

2023-06-19 Thread via GitHub
divijvaidya merged PR #13341: URL: https://github.com/apache/kafka/pull/13341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] viktorsomogyi commented on pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

2023-06-19 Thread via GitHub
viktorsomogyi commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1596994184 > In addition, if we add integration tests, put them in this PR, or need to open another PR? Let's add them to this PR. -- This is an automated message from the Apache Git

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233905670 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] zigarn commented on pull request #12976: Improve TestUtils for temporary properties file

2023-06-19 Thread via GitHub
zigarn commented on PR #12976: URL: https://github.com/apache/kafka/pull/12976#issuecomment-1596990442 Thanks @divijvaidya! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] divijvaidya merged pull request #12976: Improve TestUtils for temporary properties file

2023-06-19 Thread via GitHub
divijvaidya merged PR #12976: URL: https://github.com/apache/kafka/pull/12976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vamossagar12 commented on pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

2023-06-19 Thread via GitHub
vamossagar12 commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1596987677 > > I would keep the work that has been done > > I agree. This work is already in use in another PR. I see. In that case, I need to fix the build issue and ask folks for

[GitHub] [kafka] divijvaidya commented on pull request #12976: Improve TestUtils for temporary properties file

2023-06-19 Thread via GitHub
divijvaidya commented on PR #12976: URL: https://github.com/apache/kafka/pull/12976#issuecomment-1596983653 Unrelated failures: ``` [Build / JDK 17 and Scala 2.13 /

[GitHub] [kafka] clolov commented on a diff in pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

2023-06-19 Thread via GitHub
clolov commented on code in PR #13421: URL: https://github.com/apache/kafka/pull/13421#discussion_r1233898970 ## core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala: ## @@ -196,6 +201,110 @@ class ReplicaAlterLogDirsThreadTest { assertEquals(0,

[jira] [Updated] (KAFKA-15052) Fix flaky test QuorumControllerTest.testBalancePartitionLeaders()

2023-06-19 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15052: - Labels: flaky-test (was: ) > Fix flaky test QuorumControllerTest.testBalancePartitionLeaders()

[GitHub] [kafka] clolov commented on a diff in pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

2023-06-19 Thread via GitHub
clolov commented on code in PR #13421: URL: https://github.com/apache/kafka/pull/13421#discussion_r1233892585 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -706,6 +706,8 @@ abstract class AbstractFetcherThread(name: String, *- the request

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233888595 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-15096) CVE 2023-34455 - Vulnerability identified with Apache kafka

2023-06-19 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15096: - Fix Version/s: 3.4.2 3.3.3 3.6.0 > CVE 2023-34455 -

[jira] [Commented] (KAFKA-15096) CVE 2023-34455 - Vulnerability identified with Apache kafka

2023-06-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734119#comment-17734119 ] Josep Prat commented on KAFKA-15096: I cherry-picked this to 3.3, 3.4 and 3.5 > CVE 2023-34455 -

[jira] [Updated] (KAFKA-15096) CVE 2023-34455 - Vulnerability identified with Apache kafka

2023-06-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-15096: --- Fix Version/s: 3.5.1 > CVE 2023-34455 - Vulnerability identified with Apache kafka >

[GitHub] [kafka] clolov commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

2023-06-19 Thread via GitHub
clolov commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1233880437 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -881,6 +881,7 @@ class ReplicaManager(val config: KafkaConfig, if

[jira] [Updated] (KAFKA-15096) CVE 2023-34455 - Vulnerability identified with Apache kafka

2023-06-19 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-15096: --- Affects Version/s: 3.4.1 3.5.0 3.3.2

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233883878 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233883671 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage

2023-06-19 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1596959362 HI @divijvaidya Thanks for the information , I have created a discussion thread for the KIP as per given process

[jira] [Commented] (KAFKA-15099) Flaky Test kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft

2023-06-19 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17734117#comment-17734117 ] Divij Vaidya commented on KAFKA-15099: -- Another instance for kraft only failure:

[jira] [Updated] (KAFKA-15099) Flaky Test kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft

2023-06-19 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15099: - Component/s: unit tests > Flaky Test >

[jira] [Updated] (KAFKA-15099) Flaky Test kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft

2023-06-19 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15099: - Labels: flaky-test (was: ) > Flaky Test >

[jira] [Updated] (KAFKA-15106) AbstractStickyAssignor may stuck in 3.5

2023-06-19 Thread li xiangyuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] li xiangyuan updated KAFKA-15106: - Description: this could reproduce in ut easy, just int

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13856: KAFKA-15087 Move/rewrite InterBrokerSendThread to server-commons

2023-06-19 Thread via GitHub
dimitarndimitrov commented on code in PR #13856: URL: https://github.com/apache/kafka/pull/13856#discussion_r1233880362 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jlprat commented on pull request #13865: KAFKA-15096: Update snappy-java to 1.1.10.1

2023-06-19 Thread via GitHub
jlprat commented on PR #13865: URL: https://github.com/apache/kafka/pull/13865#issuecomment-1596954634 Cherry-picked to 3.3, 3.4 and 3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] clolov opened a new pull request, #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

2023-06-19 Thread via GitHub
clolov opened a new pull request, #13873: URL: https://github.com/apache/kafka/pull/13873 This pull requests migrates the Consumer mock in TaskManagerTest from EasyMock to Mockito. The change is restricted to a single mock to minimize the scope and make it easier for review. The

[jira] [Updated] (KAFKA-15106) AbstractStickyAssignor may stuck in 3.5

2023-06-19 Thread li xiangyuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] li xiangyuan updated KAFKA-15106: - Due Date: 19/Jun/23 (was: 14/Apr/23) > AbstractStickyAssignor may stuck in 3.5 >

[jira] [Created] (KAFKA-15106) AbstractStickyAssignor may stuck in 3.5

2023-06-19 Thread li xiangyuan (Jira)
li xiangyuan created KAFKA-15106: Summary: AbstractStickyAssignor may stuck in 3.5 Key: KAFKA-15106 URL: https://issues.apache.org/jira/browse/KAFKA-15106 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-15106) AbstractStickyAssignor may stuck in 3.5

2023-06-19 Thread li xiangyuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] li xiangyuan updated KAFKA-15106: - Description: this could reproduce in ut easy, just int

[jira] [Updated] (KAFKA-15106) AbstractStickyAssignor may stuck in 3.5

2023-06-19 Thread li xiangyuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] li xiangyuan updated KAFKA-15106: - Description: this could reproduce in ut easily, just int

[GitHub] [kafka] viktorsomogyi commented on pull request #13819: KAFKA-15059: Remove pending rebalance check when fencing zombie source connector tasks

2023-06-19 Thread via GitHub
viktorsomogyi commented on PR #13819: URL: https://github.com/apache/kafka/pull/13819#issuecomment-1596930181 no problem  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13850: KAFKA-15084: Remove lock contention from RemoteIndexCache

2023-06-19 Thread via GitHub
divijvaidya commented on code in PR #13850: URL: https://github.com/apache/kafka/pull/13850#discussion_r1233856967 ## core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala: ## @@ -37,88 +40,125 @@ object RemoteIndexCache { val TmpFileSuffix = ".tmp" } -class

[GitHub] [kafka] showuon commented on pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-06-19 Thread via GitHub
showuon commented on PR #13561: URL: https://github.com/apache/kafka/pull/13561#issuecomment-1596907836 @satishd , any update for this PR? If you don't have time on it, just let me know. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >