YORICHEONG opened a new pull request, #13879:
URL: https://github.com/apache/kafka/pull/13879
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
YORICHEONG closed pull request #13879: Yoricheong kafka read note
URL: https://github.com/apache/kafka/pull/13879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
machi1990 commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1598287543
One of my PR[1] was bitten again by this test.
Would people be open to getting in a tactical fix[2] to stabilize CI while
this PR is being reviewed? @mimaison @tombentley @divijvaidy
dajac opened a new pull request, #13880:
URL: https://github.com/apache/kafka/pull/13880
This patch adds a coordinator loader implementation.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build sta
dajac commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1234893680
##
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
dajac commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1234894652
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerDe.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
divijvaidya commented on code in PR #13878:
URL: https://github.com/apache/kafka/pull/13878#discussion_r1234904954
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##
@@ -32,31 +32,28 @@
import org.apache.kafka.test.Mo
divijvaidya commented on code in PR #13877:
URL: https://github.com/apache/kafka/pull/13877#discussion_r1234911426
##
TROGDOR.md:
##
@@ -143,7 +143,7 @@ RoundTripWorkload tests both production and consumption.
The workload starts a
### ConsumeBench
ConsumeBench starts one
[
https://issues.apache.org/jira/browse/KAFKA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Bentley reassigned KAFKA-15050:
---
Assignee: Joobi S B
> Prompts in the quickstarts
> --
>
>
leo0842 opened a new pull request, #13881:
URL: https://github.com/apache/kafka/pull/13881
ADPATIVE -> ADAPTIVE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
hudeqi commented on code in PR #13877:
URL: https://github.com/apache/kafka/pull/13877#discussion_r1234947715
##
TROGDOR.md:
##
@@ -143,7 +143,7 @@ RoundTripWorkload tests both production and consumption.
The workload starts a
### ConsumeBench
ConsumeBench starts one or mo
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1234978872
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1331,7 +1370,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private def deleteOldSegments(predi
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1234980098
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -618,6 +625,230 @@ public void run() {
}
}
+public void handleLogSta
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1234980957
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -152,16 +152,42 @@ class UnifiedLog(@volatile var logStartOffset: Long,
locally {
initializePartitionMe
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735197#comment-17735197
]
Jorge Esteban Quilcate Otoya commented on KAFKA-7739:
-
[~satish.dugga
[
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735200#comment-17735200
]
Jorge Esteban Quilcate Otoya commented on KAFKA-14953:
--
I think thi
divijvaidya commented on code in PR #13873:
URL: https://github.com/apache/kafka/pull/13873#discussion_r1234973245
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1046,15 +1036,13 @@ public void shouldTransitRestoredTaskToRunnin
hudeqi commented on PR #13839:
URL: https://github.com/apache/kafka/pull/13839#issuecomment-1598433842
Hi, are you still following this pr? @jlprat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jlprat commented on PR #13839:
URL: https://github.com/apache/kafka/pull/13839#issuecomment-1598437574
Hi @hudeqi, it's on my list, yes.
I'll try to review this either today or tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
dimitarndimitrov commented on PR #13856:
URL: https://github.com/apache/kafka/pull/13856#issuecomment-1598445990
Rebased and force-pushed to address a trivial conflict in
`checkstyle/import-control-server-common.xml`.
--
This is an automated message from the Apache Git Service.
To respond
dajac commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235012466
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -343,6 +348,7 @@ class ReplicaManagerTest {
assertTrue(appendResult.hasFired)
} fin
[
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735219#comment-17735219
]
Luke Chen commented on KAFKA-14953:
---
[~jeqo] , which PR are you referring to? We haven
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735221#comment-17735221
]
Luke Chen commented on KAFKA-7739:
--
[~jeqo] , please open a JIRA and welcome to contribu
divijvaidya commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235057956
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -343,6 +348,7 @@ class ReplicaManagerTest {
assertTrue(appendResult.hasFired)
divijvaidya commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235061965
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4935,12 +4991,17 @@ class ReplicaManagerTest {
topicPartition, leaderEpoch + leader
xiaocairush opened a new pull request, #13882:
URL: https://github.com/apache/kafka/pull/13882
*More detailed description of your change,
Hi there, I found lots of typos in this repo.
I believe you will be mad If I committed all typos.
So this PR is just a fix for core module.
divijvaidya commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235094378
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4935,12 +4991,17 @@ class ReplicaManagerTest {
topicPartition, leaderEpoch + leader
cadonna commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1235096344
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final
KTable table,
cadonna commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1235102765
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final
KTable table,
cadonna commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1235096344
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final
KTable table,
divijvaidya commented on code in PR #13874:
URL: https://github.com/apache/kafka/pull/13874#discussion_r1235104678
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -3550,14 +3538,12 @@ public void shouldCommitViaProducerIfEosV2Ena
cadonna commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1235135157
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final
KTable table,
cadonna commented on PR #12739:
URL: https://github.com/apache/kafka/pull/12739#issuecomment-1598624082
Build failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cadonna merged PR #12739:
URL: https://github.com/apache/kafka/pull/12739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
drawxy commented on code in PR #13847:
URL: https://github.com/apache/kafka/pull/13847#discussion_r1235160754
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -881,6 +881,7 @@ class ReplicaManager(val config: KafkaConfig,
if (partition.futureReplica
xiaocairush opened a new pull request, #13883:
URL: https://github.com/apache/kafka/pull/13883
*More detailed description of your change,
Fix some typos for documents
*Summary of testing strategy (including rationale)
### Committer Checklist (excluded from commit message
xiaocairush commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1598643673
sorry for that commit so many changes. Please review
https://github.com/apache/kafka/pull/13882 first. When that PR is merged then
the change will be only in doc module.
--
This is
lukestephenson-zendesk commented on code in PR #13447:
URL: https://github.com/apache/kafka/pull/13447#discussion_r1235166042
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -399,8 +399,13 @@ private Optional
updateLatestMetadata(
// Betw
machi1990 commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1598653771
> @showuon I was looking onto this and after several local runs, I managed
to eliminate some flasky test and came up with the list of failures that are
only caused by this change. The f
drawxy commented on code in PR #13847:
URL: https://github.com/apache/kafka/pull/13847#discussion_r1235172202
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig,
// pause cleaning for part
showuon commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1598673535
@machi1990 , could you explain more about this:
> The test neither calls commitSync, nor commitAsync which means that the
cache is never updated in [2] after initially set in [1].
[
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735279#comment-17735279
]
Abhijeet Kumar commented on KAFKA-14953:
I am working on the unit tests and the
xiaocairush opened a new pull request, #13884:
URL: https://github.com/apache/kafka/pull/13884
*More detailed description of your change,
Fix typos for client
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test c
xiaocairush opened a new pull request, #13885:
URL: https://github.com/apache/kafka/pull/13885
*More detailed description of your change,
Fix typos for connect*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
xiaocairush opened a new pull request, #13886:
URL: https://github.com/apache/kafka/pull/13886
*More detailed description of your change,
Fix typos for group coordinator.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
machi1990 commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1598817722
> @machi1990 , could you explain more about this:
>
> > The test neither calls commitSync, nor commitAsync which means that the
cache is never updated in [2] after initially set i
xiaocairush opened a new pull request, #13887:
URL: https://github.com/apache/kafka/pull/13887
*More detailed description of your change,
Fix typos for server common*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify te
xiaocairush opened a new pull request, #13888:
URL: https://github.com/apache/kafka/pull/13888
*More detailed description of your change,
Fix typos for streams*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
[
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735298#comment-17735298
]
Jorge Esteban Quilcate Otoya commented on KAFKA-14953:
--
[~showuon]
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735299#comment-17735299
]
Jorge Esteban Quilcate Otoya commented on KAFKA-7739:
-
Thanks [~showu
xiaocairush commented on PR #13888:
URL: https://github.com/apache/kafka/pull/13888#issuecomment-1598872442
> nice catches!
Thanks, there are still little typos in other module. I will commit in the
future after these PR is merged.
--
This is an automated message from the Apache Gi
mimaison commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1598926367
Thanks, this is a useful improvement. I was not aware the ASF had a GE
instance. The changes look good to me.
@ijuma any concerns?
--
This is an automated message from the Apac
xiaocairush opened a new pull request, #13889:
URL: https://github.com/apache/kafka/pull/13889
*More detailed description of your change,
Fix typos for meatadata*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify te
dajac merged PR #13856:
URL: https://github.com/apache/kafka/pull/13856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15087.
-
Fix Version/s: 3.6.0
Reviewer: David Jacot
Resolution: Fixed
> Move InterBrokerS
[
https://issues.apache.org/jira/browse/KAFKA-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735327#comment-17735327
]
Elkhan Eminov commented on KAFKA-15075:
---
[~durban] hi there, is this up for grabs
jsancio commented on code in PR #13845:
URL: https://github.com/apache/kafka/pull/13845#discussion_r1235409277
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1017,7 +1017,16 @@ private FetchResponseData tryCompleteFetchRequest(
long fetchOf
C0urante commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235437562
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
ijuma commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1599025907
As long as there are no restrictions due to this proprietary plugin, I am ok
with it. That is, others (including several companies) run these builds too. Is
there some official comms from A
jolshan commented on code in PR #13447:
URL: https://github.com/apache/kafka/pull/13447#discussion_r1235450231
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -399,8 +399,13 @@ private Optional
updateLatestMetadata(
// Between the time th
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235455670
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235458225
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -271,12 +271,12 @@ public synchronized void shutdown() {
void d
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235458225
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -271,12 +271,12 @@ public synchronized void shutdown() {
void d
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235460018
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
C0urante commented on PR #13885:
URL: https://github.com/apache/kafka/pull/13885#issuecomment-1599050843
Thanks! Will merge pending CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
mimaison commented on code in PR #13842:
URL: https://github.com/apache/kafka/pull/13842#discussion_r1235448777
##
refresh-collaborators.py:
##
@@ -0,0 +1,44 @@
+import os
Review Comment:
We need to have the Apache license at the top of the file.
##
refresh-collab
[
https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735344#comment-17735344
]
ASF GitHub Bot commented on KAFKA-14995:
mimaison commented on PR #521:
URL: htt
mimaison commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1599080971
I've not setup the system tests recently. If the provided instructions are
not clear enough, let's discuss it on the dev mailing list. You can also open
Jiras for the issues you encounte
David Arthur created KAFKA-15109:
Summary: ISR not expanding on ZK brokers during migration
Key: KAFKA-15109
URL: https://issues.apache.org/jira/browse/KAFKA-15109
Project: Kafka
Issue Type:
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235497178
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -171,70 +260,152 @@ GroupMetadataManager build() {
/**
[
https://issues.apache.org/jira/browse/KAFKA-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15109:
-
Description:
KAFKA-15021 introduced a new controller behavior that avoids increasing the
leader
[
https://issues.apache.org/jira/browse/KAFKA-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15109:
-
Summary: ISR shrink/expand issues on ZK brokers during migration (was: ISR
not expanding on ZK
wcarlson5 commented on code in PR #13878:
URL: https://github.com/apache/kafka/pull/13878#discussion_r1235506750
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##
@@ -32,31 +32,28 @@
import org.apache.kafka.test.Mock
wcarlson5 commented on code in PR #13878:
URL: https://github.com/apache/kafka/pull/13878#discussion_r1235507430
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##
@@ -32,31 +32,28 @@
import org.apache.kafka.test.Mock
clayburn commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1599144163
@ijuma - good question. I do not have an answer myself, but I can get in
touch with those involved in the agreement between ASF and Gradle and get back
to you on that case.
--
This is
[
https://issues.apache.org/jira/browse/KAFKA-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15109:
-
Affects Version/s: 3.6.0
(was: 3.5.0)
> ISR shrink/expand issues on Z
ijuma commented on PR #13840:
URL: https://github.com/apache/kafka/pull/13840#issuecomment-1599220710
JDK 11 build passed, there were two unrelated failures outside of that:
> Build / JDK 17 and Scala 2.13 / testMaxConnectionsPerIp() –
kafka.network.SocketServerTest
15s
Build /
ijuma merged PR #13840:
URL: https://github.com/apache/kafka/pull/13840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235639793
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235640808
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235650169
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235651106
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235653740
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -171,70 +260,152 @@ GroupMetadataManager build() {
/**
divijvaidya commented on PR #13850:
URL: https://github.com/apache/kafka/pull/13850#issuecomment-1599308163
Thank you @showuon @satishd for your review so far. I have added another
commit to de-flake some tests, improved thread safety for `Entry`, added new
unit tests and added log stateme
mumrah commented on PR #13890:
URL: https://github.com/apache/kafka/pull/13890#issuecomment-1599310423
This system test was failing on trunk, with this patch it's passing again.
```
SESSION REPORT (
dajac commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235693242
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundatio
dajac commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235694270
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundatio
dajac commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235696555
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundatio
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235734010
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
consumerG
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235733198
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
consumerG
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235752587
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
consumerG
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235773175
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235772593
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Foundat
C0urante merged PR #13885:
URL: https://github.com/apache/kafka/pull/13885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jolshan commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235803368
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -75,31 +75,31 @@ import org.mockito.invocation.InvocationOnMock
import org.mockito.stubbing.An
divijvaidya commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235807347
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -75,31 +75,31 @@ import org.mockito.invocation.InvocationOnMock
import org.mockito.stubbin
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235808438
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
consumerG
jolshan commented on code in PR #13876:
URL: https://github.com/apache/kafka/pull/13876#discussion_r1235809528
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1013,16 +1013,8 @@ private void maybeFailWithError() {
if
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235813521
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
consumerG
divijvaidya merged PR #13882:
URL: https://github.com/apache/kafka/pull/13882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
1 - 100 of 139 matches
Mail list logo
