[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage

Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1603698336 Hi @divijvaidya any further updates for us? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1239320095 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1072,1338 @@ public void replay( consumerG

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1239318379 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1045,1265 @@ public void replay( consumerG

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1239316537 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1045,1265 @@ public void replay( consumerG

[GitHub] [kafka] github-actions[bot] commented on pull request #12922: KAFKA-14397; Don't reset producer sequence number after delivery timeout

github-actions[bot] commented on PR #12922: URL: https://github.com/apache/kafka/pull/12922#issuecomment-1603639700 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] github-actions[bot] commented on pull request #12940: MINOR: Remove lock contention while adding sensors

github-actions[bot] commented on PR #12940: URL: https://github.com/apache/kafka/pull/12940#issuecomment-1603639683 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] github-actions[bot] commented on pull request #12967: MINOR: Replace ArrayBuffer with ListBuffer for better performance

github-actions[bot] commented on PR #12967: URL: https://github.com/apache/kafka/pull/12967#issuecomment-1603639665 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] github-actions[bot] commented on pull request #12988: KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams

github-actions[bot] commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-1603639642 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] github-actions[bot] commented on pull request #12997: KAFKA-14492: Extract a method to create LogManager, in order to be overrided by subclass of KafkaServer

github-actions[bot] commented on PR #12997: URL: https://github.com/apache/kafka/pull/12997#issuecomment-1603639624 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] github-actions[bot] commented on pull request #13003: MINOR: only allow certain operations when in KRaft premigration

github-actions[bot] commented on PR #13003: URL: https://github.com/apache/kafka/pull/13003#issuecomment-1603639603 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] github-actions[bot] commented on pull request #13004: [WIP] KAFKA-14498: investigate flaky

github-actions[bot] commented on PR #13004: URL: https://github.com/apache/kafka/pull/13004#issuecomment-1603639585 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] hikaru1232 closed pull request #13907: Sync ak3.5 to ccs3.5 and update ccs kafka version to 7.5.1-0-ccs

hikaru1232 closed pull request #13907: Sync ak3.5 to ccs3.5 and update ccs kafka version to 7.5.1-0-ccs URL: https://github.com/apache/kafka/pull/13907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] hikaru1232 opened a new pull request, #13907: Sync ak3.5 to ccs3.5 and update ccs kafka version to 7.5.1-0-ccs

hikaru1232 opened a new pull request, #13907: URL: https://github.com/apache/kafka/pull/13907 The jenkins job fails on auto merge AK3.5 to CCS 3.5 https://jenkins.confluent.io/job/apache-kafka-test/job/3.5/8/console ``` 14:08:02 + ./kafka-test/merge.sh https://github.com/apache

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

yeralin commented on PR #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-1603491428 @venkatesh010 could you please provide a code snippet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] lukestephenson-zendesk commented on a diff in pull request #13447: MINOR: Change ordering of checks to prevent log spam on metadata updates

lukestephenson-zendesk commented on code in PR #13447: URL: https://github.com/apache/kafka/pull/13447#discussion_r1239157410 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -399,8 +399,13 @@ private Optional updateLatestMetadata( // Betw

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

vcrfxia commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1239142854 ## streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java: ## @@ -189,7 +221,22 @@ public Joined withOtherValueSerde(final Serde otherValueSerde) { *

[GitHub] [kafka] vvcephei commented on a diff in pull request #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

vvcephei commented on code in PR #13842: URL: https://github.com/apache/kafka/pull/13842#discussion_r1239120109 ## refresh-collaborators.py: ## @@ -0,0 +1,44 @@ +import os +from bs4 import BeautifulSoup +from github import Github +import yaml + +### GET THE NAMES OF THE KAFKA CO

[GitHub] [kafka] cmccabe commented on a diff in pull request #13900: MINOR: some minor cleanups for process startup

cmccabe commented on code in PR #13900: URL: https://github.com/apache/kafka/pull/13900#discussion_r1239118404 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -75,6 +76,8 @@ class BrokerServer( // Get raftManager from SharedServer. It will be initialized during

[GitHub] [kafka] cmccabe commented on a diff in pull request #13890: KAFKA-15109 Don't skip leader epoch bump while in migration mode

cmccabe commented on code in PR #13890: URL: https://github.com/apache/kafka/pull/13890#discussion_r1239115751 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -140,6 +144,11 @@ public PartitionChangeBuilder setTargetLeaderRecoveryState(L

[GitHub] [kafka] cmccabe commented on a diff in pull request #13890: KAFKA-15109 Don't skip leader epoch bump while in migration mode

cmccabe commented on code in PR #13890: URL: https://github.com/apache/kafka/pull/13890#discussion_r1239113984 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -140,6 +144,11 @@ public PartitionChangeBuilder setTargetLeaderRecoveryState(L

[GitHub] [kafka] kirktrue commented on pull request #13898: KAFKA-14966; [2/N] Extract OffsetFetcher reusable logic

kirktrue commented on PR #13898: URL: https://github.com/apache/kafka/pull/13898#issuecomment-1603388253 > @philipnee @vvcephei Can you tag this as `ctr`, please? Thanks @dajac! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jsancio commented on a diff in pull request #13890: KAFKA-15109 Don't skip leader epoch bump while in migration mode

jsancio commented on code in PR #13890: URL: https://github.com/apache/kafka/pull/13890#discussion_r1239082472 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -140,6 +144,11 @@ public PartitionChangeBuilder setTargetLeaderRecoveryState(L

[GitHub] [kafka] wcarlson5 commented on pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on PR #13855: URL: https://github.com/apache/kafka/pull/13855#issuecomment-1603313016 The next PR is the restore logic https://github.com/wcarlson5/kafka/pull/2 I have it targeted to this branch for easy reading and will retarget it when this is merged. @vc

[GitHub] [kafka] wcarlson5 closed pull request #13906: KAFKA-14936: Add restore logic (3/N)

wcarlson5 closed pull request #13906: KAFKA-14936: Add restore logic (3/N) URL: https://github.com/apache/kafka/pull/13906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Resolved] (KAFKA-15109) ISR shrink/expand issues on ZK brokers during migration

[ https://issues.apache.org/jira/browse/KAFKA-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-15109. -- Resolution: Fixed > ISR shrink/expand issues on ZK brokers during migration >

[jira] [Updated] (KAFKA-15109) ISR shrink/expand issues on ZK brokers during migration

[ https://issues.apache.org/jira/browse/KAFKA-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15109: - Fix Version/s: 3.6.0 > ISR shrink/expand issues on ZK brokers during migration > ---

[jira] [Updated] (KAFKA-15098) KRaft migration does not proceed and broker dies if authorizer.class.name is set

[ https://issues.apache.org/jira/browse/KAFKA-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15098: - Fix Version/s: 3.6.0 3.5.1 > KRaft migration does not proceed and broker dies

[jira] [Resolved] (KAFKA-15098) KRaft migration does not proceed and broker dies if authorizer.class.name is set

[ https://issues.apache.org/jira/browse/KAFKA-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-15098. -- Resolution: Fixed > KRaft migration does not proceed and broker dies if authorizer.class.name

[GitHub] [kafka] wcarlson5 opened a new pull request, #13906: Grace get write batches

wcarlson5 opened a new pull request, #13906: URL: https://github.com/apache/kafka/pull/13906 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testi

[GitHub] [kafka] venkatesh010 commented on pull request #6592: KAFKA-8326: Introduce List Serde

venkatesh010 commented on PR #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-1603284146 This is while using List where E is class which is Inner Serde used for Inner is JsonSerde of Type E -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13900: MINOR: some minor cleanups for process startup

divijvaidya commented on code in PR #13900: URL: https://github.com/apache/kafka/pull/13900#discussion_r1238998513 ## core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala: ## @@ -94,6 +96,22 @@ class LinuxIoMetricsCollector(procRoot: String, val time: Time, val logge

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13900: MINOR: some minor cleanups for process startup

divijvaidya commented on code in PR #13900: URL: https://github.com/apache/kafka/pull/13900#discussion_r1238997925 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -75,6 +76,8 @@ class BrokerServer( // Get raftManager from SharedServer. It will be initialized dur

[GitHub] [kafka] venkatesh010 commented on pull request #6592: KAFKA-8326: Introduce List Serde

venkatesh010 commented on PR #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-1603267651 Hey @yeralin @mjsax @ableegoldman Getting SerializationException in this serde SerializationException: Invalid serialization strategy flag value Flag value is derived from b

[jira] [Created] (KAFKA-15115) Implement resetPositions functionality in ListOffsetRequestManager

Lianet Magrans created KAFKA-15115: -- Summary: Implement resetPositions functionality in ListOffsetRequestManager Key: KAFKA-15115 URL: https://issues.apache.org/jira/browse/KAFKA-15115 Project: Kafka

[jira] [Comment Edited] (KAFKA-15053) Regression for security.protocol validation starting from 3.3.0

[ https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736201#comment-17736201 ] Bo Gao edited comment on KAFKA-15053 at 6/22/23 6:36 PM: - Thanks

[GitHub] [kafka] kirktrue commented on pull request #13898: KAFKA-14966; [2/N] Extract OffsetFetcher reusable logic

kirktrue commented on PR #13898: URL: https://github.com/apache/kafka/pull/13898#issuecomment-1603067666 @philipnee @vvcephei Can you tag this as `ctr`, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] jolshan commented on pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on PR #13798: URL: https://github.com/apache/kafka/pull/13798#issuecomment-1603056522 I've updated the PR, but I'm seeing a thread leak in the tests, not sure if that's just from trunk or my change. Will investigate. -- This is an automated message from the Apache Git Se

[jira] [Resolved] (KAFKA-14694) RPCProducerIdManager should not wait for a new block

[ https://issues.apache.org/jira/browse/KAFKA-14694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14694. - Fix Version/s: 3.6.0 Resolution: Fixed > RPCProducerIdManager should not wait for

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

wcarlson5 commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1238801056 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -56,10 +77,60 @@ public void init(final ProcessorContext co

[GitHub] [kafka] lihaosky commented on a diff in pull request #13846: KAFKA-15022: [1/N] add configs to control rack aware assignment

lihaosky commented on code in PR #13846: URL: https://github.com/apache/kafka/pull/13846#discussion_r1238821866 ## streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java: ## @@ -1375,6 +1375,18 @@ public void shouldReturnDefaultClientSupplier() { assertTr

[GitHub] [kafka] lihaosky commented on pull request #13846: KAFKA-15022: [1/N] add configs to control rack aware assignment

lihaosky commented on PR #13846: URL: https://github.com/apache/kafka/pull/13846#issuecomment-1603047119 > Thanks @lihaosky for the PR! > > Are you sure you want to start with adding the config? > > I would have added the config as the last step in the implementation. If we add

[GitHub] [kafka] hachikuji merged pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji merged PR #13267: URL: https://github.com/apache/kafka/pull/13267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1238656502 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java: ## @@ -122,12 +122,12 @@ public Maybe> priorValueForBuffered(f

[jira] [Commented] (KAFKA-15053) Regression for security.protocol validation starting from 3.3.0

[ https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736201#comment-17736201 ] Bo Gao commented on KAFKA-15053: Thanks [~ChrisEgerton]! If we backport this to 3.3.0, i

[GitHub] [kafka] C0urante commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

C0urante commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1238782864 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1317,192 @@ void alterSinkConnectorOffsets(String connName, Connector c

[GitHub] [kafka] C0urante commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

C0urante commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1238782864 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1317,192 @@ void alterSinkConnectorOffsets(String connName, Connector c

[GitHub] [kafka] blacktooth opened a new pull request, #13905: Fix MM2 not consuming from latest when "auto.offset.reset=latest

blacktooth opened a new pull request, #13905: URL: https://github.com/apache/kafka/pull/13905 …=latest" is set. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.

[GitHub] [kafka] cmccabe commented on a diff in pull request #13900: MINOR: some minor cleanups for process startup

cmccabe commented on code in PR #13900: URL: https://github.com/apache/kafka/pull/13900#discussion_r1238763103 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -75,6 +76,8 @@ class BrokerServer( // Get raftManager from SharedServer. It will be initialized during

[GitHub] [kafka] cmccabe commented on a diff in pull request #13900: MINOR: some minor cleanups for process startup

cmccabe commented on code in PR #13900: URL: https://github.com/apache/kafka/pull/13900#discussion_r1238763103 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -75,6 +76,8 @@ class BrokerServer( // Get raftManager from SharedServer. It will be initialized during

[GitHub] [kafka] C0urante commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

C0urante commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1238757251 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1338,188 @@ void alterSinkConnectorOffsets(String connName, Connector c

[GitHub] [kafka] C0urante commented on pull request #13646: KAFKA-14938: Fixing flaky test testConnectorBoundary

C0urante commented on PR #13646: URL: https://github.com/apache/kafka/pull/13646#issuecomment-1602941862 Thanks for the detailed analysis, everyone! ## Root cause I believe @sudeshwasnik's latest theory is correct: the Connect runtime invokes `SourceTask::commitRecord` even for

[jira] [Commented] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736180#comment-17736180 ] Andrew Schofield commented on KAFKA-9800: - [~showuon] I wonder what the current s

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1238725344 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -266,9 +295,21 @@ public CompletableFuture joinGroup(

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1238720569 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -291,7 +291,7 @@ public long skip(long toSkip) throws IOException { // Skip

[jira] [Comment Edited] (KAFKA-15113) Gracefully handle cases where a sink connector's admin and consumer client config overrides target different Kafka clusters

[ https://issues.apache.org/jira/browse/KAFKA-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736177#comment-17736177 ] Chris Egerton edited comment on KAFKA-15113 at 6/22/23 3:35 PM: --

[jira] [Commented] (KAFKA-15113) Gracefully handle cases where a sink connector's admin and consumer client config overrides target different Kafka clusters

[ https://issues.apache.org/jira/browse/KAFKA-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736177#comment-17736177 ] Chris Egerton commented on KAFKA-15113: --- [~yash.mayya] Thanks for filing this! On

[GitHub] [kafka] ijuma merged pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

ijuma merged PR #13582: URL: https://github.com/apache/kafka/pull/13582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

ijuma commented on PR #13582: URL: https://github.com/apache/kafka/pull/13582#issuecomment-1602803318 After several test runs, it looks like the failures in the last run are flakes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] pprovenzano commented on pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on PR #13374: URL: https://github.com/apache/kafka/pull/13374#issuecomment-1602781584 PR to fix the issue is out for review: https://github.com/apache/kafka/pull/13904 --Proven On Wed, Jun 21, 2023 at 12:16 PM Proven Provenzano ***@***.***> wrote:

[GitHub] [kafka] pprovenzano opened a new pull request, #13904: KAFKA-15114: Update help in StorageTool for creating SCRAM credentials for KRaft bootstrap.

pprovenzano opened a new pull request, #13904: URL: https://github.com/apache/kafka/pull/13904 The choice of using name vs. user as a parameter is because internally the record uses name, all tests using the StorageTool use name as a parameter, KafkaPrincipals are created with name and beca

[jira] [Created] (KAFKA-15114) StorageTool help specifies user as parameter not name

Proven Provenzano created KAFKA-15114: - Summary: StorageTool help specifies user as parameter not name Key: KAFKA-15114 URL: https://issues.apache.org/jira/browse/KAFKA-15114 Project: Kafka

[jira] [Updated] (KAFKA-15113) Gracefully handle cases where a sink connector's admin and consumer client config overrides target different Kafka clusters

[ https://issues.apache.org/jira/browse/KAFKA-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15113: -- Priority: Minor (was: Major) > Gracefully handle cases where a sink connector's admin and con

[GitHub] [kafka] jeffkbkim commented on pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on PR #13267: URL: https://github.com/apache/kafka/pull/13267#issuecomment-1602740242 failure in `testBumpTransactionalEpoch(String).quorum=kraft – kafka.api.TransactionsTest` again ``` org.apache.kafka.common.errors.TimeoutException: Timeout expired after 6000

[GitHub] [kafka] machi1990 commented on pull request #13903: MINOR: Bump requests from 2.24.0 to 2.31.0 in /tests

machi1990 commented on PR #13903: URL: https://github.com/apache/kafka/pull/13903#issuecomment-1602701557 > Thank you for the change. We had an automated open PR #13743 for it for quite some time now. Right, I wasn't aware of that PR. I should have checked before opening a similar o

[GitHub] [kafka] divijvaidya commented on pull request #13903: MINOR: Bump requests from 2.24.0 to 2.31.0 in /tests

divijvaidya commented on PR #13903: URL: https://github.com/apache/kafka/pull/13903#issuecomment-1602677237 Thank you for the change. We had an automated open PR https://github.com/apache/kafka/pull/13743 for it for quite some time now. Can you please explain how did you test this change?

[GitHub] [kafka] mumrah commented on pull request #13895: KAFKA-15098 Allow authorizers to be configured in ZK migration

mumrah commented on PR #13895: URL: https://github.com/apache/kafka/pull/13895#issuecomment-1602650945 Test failures are the same as on trunk (left over thread) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] mumrah merged pull request #13895: KAFKA-15098 Allow authorizers to be configured in ZK migration

mumrah merged PR #13895: URL: https://github.com/apache/kafka/pull/13895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] machi1990 opened a new pull request, #13903: MINOR: Bump requests from 2.24.0 to 2.31.0 in /tests

machi1990 opened a new pull request, #13903: URL: https://github.com/apache/kafka/pull/13903 Update "requests" lib used in system tests to version "2.31.0" to fix CVE-2023-32681: Unintended leak of Proxy-Authorization header in requests The update is done as a best practice after I no

[GitHub] [kafka] chia7712 opened a new pull request, #13902: MINOR: fix flaky ZkMigrationIntegrationTest.testNewAndChangedTopicsIn…

chia7712 opened a new pull request, #13902: URL: https://github.com/apache/kafka/pull/13902 ``` org.apache.kafka.server.fault.FaultHandlerException: nonFatalFaultHandler: Unhandled error in MetadataChangeEvent: Session expired either before or while waiting for connection at app

[GitHub] [kafka] mimaison commented on a diff in pull request #13859: KAFKA-15093: Add 3.4 and 3.5 to core upgrade and compatibility tests

mimaison commented on code in PR #13859: URL: https://github.com/apache/kafka/pull/13859#discussion_r1238507645 ## tests/kafkatest/tests/core/upgrade_test.py: ## @@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None): self.

[GitHub] [kafka] mimaison commented on pull request #13849: Add 3.5.0 and 3.4.1 to system tests

mimaison commented on PR #13849: URL: https://github.com/apache/kafka/pull/13849#issuecomment-1602609810 I still don't see the packages in the S3 bucket, so re-pinging @mjsax @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] lucasbru closed pull request #13725: Backport KAFKA-14172 to 3.2

lucasbru closed pull request #13725: Backport KAFKA-14172 to 3.2 URL: https://github.com/apache/kafka/pull/13725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13900: MINOR: some minor cleanups for process startup

divijvaidya commented on code in PR #13900: URL: https://github.com/apache/kafka/pull/13900#discussion_r1238424518 ## core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala: ## @@ -94,6 +96,22 @@ class LinuxIoMetricsCollector(procRoot: String, val time: Time, val logge

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1238418966 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -171,70 +260,152 @@ GroupMetadataManager build() { /** *

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1238417804 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -171,70 +260,152 @@ GroupMetadataManager build() { /** *

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1238403670 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerDe.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cadonna commented on a diff in pull request #13846: KAFKA-15022: [1/N] add configs to control rack aware assignment

cadonna commented on code in PR #13846: URL: https://github.com/apache/kafka/pull/13846#discussion_r1238377947 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -755,6 +755,18 @@ public class StreamsConfig extends AbstractConfig { public static fin

[GitHub] [kafka] vamossagar12 commented on pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-1602461968 Thanks @yashmayya , I addressed your comments and added a response for one of the questions. Let me know if that makes sense. Regarding https://github.com/apache/kafka/pull/13801#dis

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1238381420 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,10 +284,61 @@ public Future set(Map values, Callbac

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1238380902 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,10 +284,61 @@ public Future set(Map values, Callbac

[jira] [Commented] (KAFKA-15083) Passing "remote.log.metadata.*" configs into RLMM

[ https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736073#comment-17736073 ] Luke Chen commented on KAFKA-15083: --- [~satishd] , had a try and I think we still need

[jira] [Assigned] (KAFKA-15083) Passing "remote.log.metadata.*" configs into RLMM

[ https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-15083: - Assignee: Luke Chen (was: Satish Duggana) > Passing "remote.log.metadata.*" configs into RLMM

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1238371990 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,10 +284,61 @@ public Future set(Map values, Callbac

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1238370253 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,10 +284,61 @@ public Future set(Map values, Callbac

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1238369128 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,10 +284,61 @@ public Future set(Map values, Callbac

[GitHub] [kafka] hudeqi commented on pull request #13852: KAFKA-15086:Set a reasonable segment size upper limit for MM2 internal topics

hudeqi commented on PR #13852: URL: https://github.com/apache/kafka/pull/13852#issuecomment-1602409354 Thank you for your reply! @C0urante, seeing so many of your thoughts, I think it is very meaningful to think about! Below I will give my actual results and thoughts for each question. 1

[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

yashmayya commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1238244318 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1317,192 @@ void alterSinkConnectorOffsets(String connName, Connector

[GitHub] [kafka] showuon commented on pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

showuon commented on PR #13760: URL: https://github.com/apache/kafka/pull/13760#issuecomment-1602323587 @tinaselenge , it looks like some tests are failed: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13760/6/ Please also take a look. Thanks. -- This is an automated messa

[GitHub] [kafka] showuon commented on a diff in pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

showuon commented on code in PR #13760: URL: https://github.com/apache/kafka/pull/13760#discussion_r1238266317 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] showuon commented on a diff in pull request #13760: KAFKA-8982: Add retry of fetching metadata to Admin.deleteRecords

showuon commented on code in PR #13760: URL: https://github.com/apache/kafka/pull/13760#discussion_r1238257723 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2359,31 +2334,22 @@ public void testDeleteRecords() throws Exception {

[GitHub] [kafka] dajac opened a new pull request, #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac opened a new pull request, #13901: URL: https://github.com/apache/kafka/pull/13901 This patch adds (1) the logic to propagate a new MetadataImage to the running coordinators; and (2) the logic to ensure that all the consumer groups subscribed to topics with changes will refresh their

[jira] [Created] (KAFKA-15113) Gracefully handle cases where a sink connector's admin and consumer client config overrides target different Kafka clusters

Yash Mayya created KAFKA-15113: -- Summary: Gracefully handle cases where a sink connector's admin and consumer client config overrides target different Kafka clusters Key: KAFKA-15113 URL: https://issues.apache.org/ji

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1238107526 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] dajac commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1238104197 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] dajac merged pull request #13812: KAFKA-14462; [18/N] Add GroupCoordinatorService

dajac merged PR #13812: URL: https://github.com/apache/kafka/pull/13812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac commented on pull request #13812: KAFKA-14462; [18/N] Add GroupCoordinatorService

dajac commented on PR #13812: URL: https://github.com/apache/kafka/pull/13812#issuecomment-1602115656 Failed tests are not related: ``` Build / JDK 17 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrat