dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263354270
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundat
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263349060
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-15188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15188:
--
Description:
There are several Consumer APIs that only touch the {{ConsumerMetadata}} and/or
{{Subscr
[
https://issues.apache.org/jira/browse/KAFKA-15188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15188:
--
Description:
There are several {{Consumer}} APIs that only touch the {{ConsumerMetadata}}
and/or {{Su
[
https://issues.apache.org/jira/browse/KAFKA-15188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15188:
--
Description:
There are several Consumer APIs that only touch the {{ConsumerMetadata}} and/or
{{Subscr
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263281176
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743007#comment-17743007
]
Stanislav Kozlovski commented on KAFKA-10345:
-
While the KIP isn't implement
yashmayya commented on code in PR #14003:
URL: https://github.com/apache/kafka/pull/14003#discussion_r1263265359
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##
@@ -2015,6 +2019,33 @@ public void testAlterOffsetsSourceConnectorError()
throw
yashmayya commented on code in PR #14003:
URL: https://github.com/apache/kafka/pull/14003#discussion_r1263263703
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1608,6 +1612,32 @@ void modifySourceConnectorOffsets(String connName,
Connector
mumrah merged PR #14013:
URL: https://github.com/apache/kafka/pull/14013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
github-actions[bot] commented on PR #13580:
URL: https://github.com/apache/kafka/pull/13580#issuecomment-1635219499
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12261:
-
Fix Version/s: 3.6.0
Assignee: Haruki Okada
Resolution: Fixed
> Splitting parti
showuon merged PR #10167:
URL: https://github.com/apache/kafka/pull/10167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1635200263
Especially thanks for your separate reply! @C0urante I have tracked it in
the [Jira ticket](https://issues.apache.org/jira/browse/KAFKA-15172).
Going back to this PR, although it is
[
https://issues.apache.org/jira/browse/KAFKA-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-15185.
---
Resolution: Duplicate
> Consumers using the latest strategy may lose data after the topic adds
> pa
[
https://issues.apache.org/jira/browse/KAFKA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742994#comment-17742994
]
hudeqi commented on KAFKA-15172:
Hi,[~mimaison] [~ChrisEgerton] I am currently doing th
[
https://issues.apache.org/jira/browse/KAFKA-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742990#comment-17742990
]
RivenSun commented on KAFKA-15185:
--
Thanks
> Consumers using the latest strategy may l
[
https://issues.apache.org/jira/browse/KAFKA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hudeqi reassigned KAFKA-15172:
--
Assignee: hudeqi
> Allow exact mirroring of ACLs between clusters
> -
DL1231 commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1263180503
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1159,6 +1161,9 @@ class LogManager(logDirs: Seq[File],
checkpointLogStartOffsetsInDir(logDir, logsTo
DL1231 commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1263173721
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -556,6 +562,46 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
DL1231 commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1263172722
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -556,6 +562,46 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
DL1231 commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1263167540
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -526,14 +532,17 @@ class ReplicaManager(val config: KafkaConfig,
/**
* Stop the given partitions.
DL1231 commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1263161907
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -500,11 +504,13 @@ class ReplicaManager(val config: KafkaConfig,
// Delete log and corresp
ijuma commented on PR #13949:
URL: https://github.com/apache/kafka/pull/13949#issuecomment-1635085148
There are some test failures, they may be flaky - restarted the CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ijuma commented on code in PR #13949:
URL: https://github.com/apache/kafka/pull/13949#discussion_r1263158990
##
core/src/main/scala/kafka/server/DelayedProduce.scala:
##
@@ -58,6 +62,8 @@ class DelayedProduce(delayMs: Long,
lockOpt: Option[Lock] = None)
lihaosky commented on code in PR #13996:
URL: https://github.com/apache/kafka/pull/13996#discussion_r1263147577
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (A
gaurav-narula commented on code in PR #13949:
URL: https://github.com/apache/kafka/pull/13949#discussion_r1263146221
##
core/src/main/scala/kafka/server/DelayedProduce.scala:
##
@@ -58,6 +62,8 @@ class DelayedProduce(delayMs: Long,
lockOpt: Option[Lock] = N
bmscomp commented on PR #14014:
URL: https://github.com/apache/kafka/pull/14014#issuecomment-1635054771
Closed because it's a duplication of this one #14013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bmscomp closed pull request #14014: MINOR: Fix compilation error on
ReplicationControlManagerTest
URL: https://github.com/apache/kafka/pull/14014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bmscomp commented on PR #14013:
URL: https://github.com/apache/kafka/pull/14013#issuecomment-1635053553
Thank you so much, I will close my pull request because it's a duplicate of
this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please
bmscomp opened a new pull request, #14014:
URL: https://github.com/apache/kafka/pull/14014
Compilation fails when trying to make a build or try to run tests on local
machine, and jenkin and testing tool, the default constructor does not exists
see the following error for more details
gharris1727 commented on PR #13977:
URL: https://github.com/apache/kafka/pull/13977#issuecomment-1635037249
The build on trunk is temporarily broken so i'll wait to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
gharris1727 commented on code in PR #13971:
URL: https://github.com/apache/kafka/pull/13971#discussion_r1263122416
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginScannerTest.java:
##
@@ -20,79 +20,114 @@
import org.junit.Rule;
import org.juni
junrao commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1263114168
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -522,7 +525,35 @@ public void subscribe(Collection topics,
Consu
mumrah opened a new pull request, #14013:
URL: https://github.com/apache/kafka/pull/14013
Fix a test compile error introduced in 959f9ca4c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
mumrah commented on code in PR #14009:
URL: https://github.com/apache/kafka/pull/14009#discussion_r1263103383
##
metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java:
##
@@ -44,6 +45,8 @@ public class QuorumControllerMetrics implements AutoClos
[
https://issues.apache.org/jira/browse/KAFKA-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15180:
--
Reviewer: Divij Vaidya
> Generalize integration tests to change use of KafkaConsumer to Consumer
> ---
kirktrue closed pull request #13265: Prototype consumer stubs
URL: https://github.com/apache/kafka/pull/13265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
[
https://issues.apache.org/jira/browse/KAFKA-15188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15188:
--
Labels: kip-945 (was: )
> Implement more of the remaining PrototypeAsyncConsumer APIs
> -
Kirk True created KAFKA-15188:
-
Summary: Implement more of the remaining PrototypeAsyncConsumer
APIs
Key: KAFKA-15188
URL: https://issues.apache.org/jira/browse/KAFKA-15188
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-15188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15188:
--
Description: There are several Consumer APIs that only touch the
{{ConsumerMetadata}} and/or {{Subscri
[
https://issues.apache.org/jira/browse/KAFKA-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15180:
--
Labels: kip-945 (was: )
> Generalize integration tests to change use of KafkaConsumer to Consumer
> -
lihaosky commented on code in PR #13996:
URL: https://github.com/apache/kafka/pull/13996#discussion_r1263076291
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (A
lihaosky commented on code in PR #13996:
URL: https://github.com/apache/kafka/pull/13996#discussion_r1261998987
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java:
##
@@ -0,0 +1,363 @@
+/*
+ * Licensed to the Apache Software Foundation (A
ruslankrivoshein commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1634949921
Well, that's it:
```
$ bin/kafka-get-offsets.sh --broker-list :9092 --topic my-top --time 3
WARNING: The 'broker-list' option is deprecated and will be removed in the
nex
jolshan commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263070668
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundatio
jolshan commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263069869
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Found
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263068420
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263060866
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263059667
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundat
jolshan commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263055145
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundatio
jolshan commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1263052783
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Found
mumrah commented on PR #14008:
URL: https://github.com/apache/kafka/pull/14008#issuecomment-1634910973
Logs from an integration test (TRACE enabled)
```
[2023-07-13 16:56:18,029] INFO [KRaftMigrationDriver id=3000] Starting ZK
migration (org.apache.kafka.metadata.migration.KRaftMig
mumrah closed pull request #13180: MINOR: Add a summary of the metadata
migration
URL: https://github.com/apache/kafka/pull/13180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
mumrah commented on PR #13180:
URL: https://github.com/apache/kafka/pull/13180#issuecomment-1634899885
Closing in favor of #14008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
cmccabe merged PR #13703:
URL: https://github.com/apache/kafka/pull/13703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mjsax commented on code in PR #13860:
URL: https://github.com/apache/kafka/pull/13860#discussion_r1263001020
##
streams/upgrade-system-tests-34/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foun
mjsax commented on code in PR #13996:
URL: https://github.com/apache/kafka/pull/13996#discussion_r1262978439
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
C0urante commented on code in PR #13948:
URL: https://github.com/apache/kafka/pull/13948#discussion_r1262996406
##
connect/api/src/main/java/org/apache/kafka/connect/source/SourceTask.java:
##
@@ -105,9 +105,11 @@ public void initialize(SourceTaskContext context) {
public a
C0urante commented on code in PR #13971:
URL: https://github.com/apache/kafka/pull/13971#discussion_r1262952038
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/ReflectionScanner.java:
##
@@ -62,7 +62,8 @@
*
*
* Note: This scanner has a run
mjsax commented on code in PR #13996:
URL: https://github.com/apache/kafka/pull/13996#discussion_r1262977617
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
C0urante commented on code in PR #13977:
URL: https://github.com/apache/kafka/pull/13977#discussion_r1262939116
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginsTest.java:
##
@@ -500,6 +500,11 @@ private void assertClassLoaderReadsVersionFromRes
cmccabe commented on code in PR #14008:
URL: https://github.com/apache/kafka/pull/14008#discussion_r1262932811
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -158,7 +185,7 @@ private void recoverMigrationStateFromZK() {
privat
fvaleri commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1634715273
Yes, but just use `System.out.println` without adding extra classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
philipnee commented on PR #13997:
URL: https://github.com/apache/kafka/pull/13997#issuecomment-1634701369
looks great, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
C0urante commented on code in PR #14005:
URL: https://github.com/apache/kafka/pull/14005#discussion_r1262913499
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationExactlyOnceTest.java:
##
@@ -46,4 +51,49 @@ public void startClu
C0urante commented on code in PR #14003:
URL: https://github.com/apache/kafka/pull/14003#discussion_r1262733289
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -1608,6 +1612,32 @@ void modifySourceConnectorOffsets(String connName,
Connector
cmccabe commented on PR #13703:
URL: https://github.com/apache/kafka/pull/13703#issuecomment-1634618543
> And all of these builder log contexts do get explicitly set in
QuorumController (including the new ones via this PR), so the default will
never be used. So my guess is the answer is no,
cmccabe commented on code in PR #13703:
URL: https://github.com/apache/kafka/pull/13703#discussion_r1262848304
##
metadata/src/test/java/org/apache/kafka/controller/MockAclControlManager.java:
##
@@ -33,7 +33,7 @@
public class MockAclControlManager extends AclControlManager {
cmccabe commented on code in PR #13703:
URL: https://github.com/apache/kafka/pull/13703#discussion_r1262846403
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -377,7 +377,19 @@ private ReplicationControlManager(
}
public vo
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1262824134
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
ijuma commented on code in PR #13267:
URL: https://github.com/apache/kafka/pull/13267#discussion_r1262822068
##
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala:
##
@@ -123,73 +131,103 @@ class ZkProducerIdManager(brokerId: Int,
}
}
- def gene
ijuma commented on code in PR #14011:
URL: https://github.com/apache/kafka/pull/14011#discussion_r1262751077
##
tests/kafkatest/services/security/minikdc.py:
##
@@ -107,6 +107,12 @@ def start_node(self, node):
cmd = "for file in %s; do CLASSPATH=$CLASSPATH:$file; done;"
ijuma commented on PR #14011:
URL: https://github.com/apache/kafka/pull/14011#issuecomment-1634481728
Thanks @see-quick. Did you verify that the test passes with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jeffkbkim commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1262709064
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundat
C0urante commented on code in PR #13945:
URL: https://github.com/apache/kafka/pull/13945#discussion_r1262708616
##
connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java:
##
@@ -101,4 +105,50 @@ public ExactlyOnceSupport exactlyOnceSupport(Map pr
viktorsomogyi commented on code in PR #13975:
URL: https://github.com/apache/kafka/pull/13975#discussion_r1262674671
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -174,14 +174,25 @@ class KRaftMetadataCache(val brokerId: Int) extends
MetadataCache
[
https://issues.apache.org/jira/browse/KAFKA-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742830#comment-17742830
]
Haruki Okada commented on KAFKA-15185:
--
FYI: maybe duplicated with https://issues.a
cadonna commented on code in PR #13942:
URL: https://github.com/apache/kafka/pull/13942#discussion_r1262545184
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamTableJoinNode.java:
##
@@ -31,17 +32,22 @@ public class StreamTableJoinNode extends Grap
vcrfxia commented on code in PR #13942:
URL: https://github.com/apache/kafka/pull/13942#discussion_r1262600782
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBytesStore.java:
##
@@ -42,7 +46,29 @@ protected KeyValue getIndexKeyValue(f
[
https://issues.apache.org/jira/browse/KAFKA-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana reassigned KAFKA-14481:
--
Assignee: Ismael Juma (was: Satish Duggana)
> Move LogSegment/LogSegments to storage
[
https://issues.apache.org/jira/browse/KAFKA-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742819#comment-17742819
]
Satish Duggana commented on KAFKA-14481:
[~ijuma] Please feel free to take it. L
OmniaGM commented on code in PR #13585:
URL: https://github.com/apache/kafka/pull/13585#discussion_r126256
##
server-common/src/main/java/org/apache/kafka/server/util/json/DecodeJson.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
OmniaGM commented on code in PR #13585:
URL: https://github.com/apache/kafka/pull/13585#discussion_r1261125892
##
server-common/src/main/java/org/apache/kafka/server/util/json/DecodeJson.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
[
https://issues.apache.org/jira/browse/KAFKA-15187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742814#comment-17742814
]
Bruno Cadonna commented on KAFKA-15187:
---
In the PR, I see that you want to change
[
https://issues.apache.org/jira/browse/KAFKA-15187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742812#comment-17742812
]
Bruno Cadonna commented on KAFKA-15187:
---
I added you to the contributor group. Now
jeqo commented on code in PR #13837:
URL: https://github.com/apache/kafka/pull/13837#discussion_r1262555453
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorage.java:
##
@@ -0,0 +1,578 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jeqo commented on code in PR #13837:
URL: https://github.com/apache/kafka/pull/13837#discussion_r1262541127
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageTest.java:
##
@@ -0,0 +1,673 @@
+/*
+ * Licensed to the Apache Software Foundation (A
[
https://issues.apache.org/jira/browse/KAFKA-15187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742805#comment-17742805
]
Jacob Tomy commented on KAFKA-15187:
Can someone help me assign this to me.
These
Jacob Tomy created KAFKA-15187:
--
Summary: Add headers to partition method.
Key: KAFKA-15187
URL: https://issues.apache.org/jira/browse/KAFKA-15187
Project: Kafka
Issue Type: New Feature
jeqo commented on code in PR #13837:
URL: https://github.com/apache/kafka/pull/13837#discussion_r1262507241
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorage.java:
##
@@ -0,0 +1,578 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cadonna merged PR #13957:
URL: https://github.com/apache/kafka/pull/13957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #13957:
URL: https://github.com/apache/kafka/pull/13957#issuecomment-1634163428
Build failures are unrelated:
```
Build / JDK 17 and Scala 2.13 /
integration.kafka.server.FetchFromFollowerIntegrationTest.testFollowerCompleteDelayedFetchesOnReplication(String).qu
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1262475265
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -54,18 +58,92 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
ClusterInstance
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1262474854
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r126246
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1262462756
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/util/SystemTimerReaperTest.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundat
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1262460699
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2360,6 +2360,19 @@ public void testGroupIdsByTopics() {
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1262458373
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13991:
URL: https://github.com/apache/kafka/pull/13991#discussion_r1262456201
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/SystemTimerReaper.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
1 - 100 of 120 matches
Mail list logo
