Nickstery commented on code in PR #14004:
URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java:
##
@@ -100,17 +100,29 @@ void
Nickstery commented on code in PR #14004:
URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java:
##
@@ -100,17 +100,29 @@ void
Nickstery commented on code in PR #14004:
URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java:
##
@@ -100,17 +100,29 @@ void
Nickstery commented on code in PR #14004:
URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java:
##
@@ -100,17 +100,29 @@ void
Nickstery commented on code in PR #14004:
URL: https://github.com/apache/kafka/pull/14004#discussion_r1267954353
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java:
##
@@ -100,17 +100,29 @@ void
viktorsomogyi commented on code in PR #13975:
URL: https://github.com/apache/kafka/pull/13975#discussion_r1267952262
##
core/src/main/scala/kafka/server/MetadataCache.scala:
##
@@ -109,6 +109,8 @@ trait MetadataCache {
def getRandomAliveBrokerId: Option[Int]
def
Nickstery commented on code in PR #14004:
URL: https://github.com/apache/kafka/pull/14004#discussion_r1267948092
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java:
##
@@ -100,17 +100,29 @@ void
viktorsomogyi commented on PR #13975:
URL: https://github.com/apache/kafka/pull/13975#issuecomment-1641908924
@mumrah correct, the problem happens because the broker doesn't have a
populated metadata cache and it tries to auto-create a topic during a topic
metadata request (and it might be
jeqo commented on PR #14012:
URL: https://github.com/apache/kafka/pull/14012#issuecomment-1641902397
Thanks @satishd and @kamalcph, I've moved refactoring changes to
https://github.com/apache/kafka/pull/14045, please take a look.
About the fix, looking forward to take a look to your
jeqo opened a new pull request, #14045:
URL: https://github.com/apache/kafka/pull/14045
Moving refactoring changes from https://github.com/apache/kafka/pull/14012
into a separate PR.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1641878105
@divijvaidya For the internal usage of Jackson, I can say with much
confidence that the limits are far more then what is needed to run Kafka, for
it's usage the `message.max.bytes ` in
clolov commented on code in PR #13999:
URL: https://github.com/apache/kafka/pull/13999#discussion_r1267868782
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -366,7 +370,82 @@ void
testCopyLogSegmentsToRemoteShouldCopyExpectedLogSegment() throws
[
https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield reassigned KAFKA-9800:
---
Assignee: Andrew Schofield (was: Luke Chen)
> [KIP-580] Client Exponential Backoff
mimaison commented on code in PR #13842:
URL: https://github.com/apache/kafka/pull/13842#discussion_r1267865784
##
refresh-collaborators.py:
##
@@ -59,9 +64,20 @@
yaml_content["github"]["collaborators"] = collaborators
# Convert the updated content back to YAML
mimaison commented on code in PR #13842:
URL: https://github.com/apache/kafka/pull/13842#discussion_r1267863457
##
refresh-collaborators.py:
##
@@ -35,7 +36,10 @@
contributors_login_to_commit_volume = {}
end_date = datetime.now()
start_date = end_date - timedelta(days=365)
Luke Chen created KAFKA-15218:
-
Summary: NPE will be thrown while deleting topic and fetch from
follower concurrently
Key: KAFKA-15218
URL: https://issues.apache.org/jira/browse/KAFKA-15218
Project:
mimaison commented on code in PR #13842:
URL: https://github.com/apache/kafka/pull/13842#discussion_r1267858743
##
refresh-collaborators.py:
##
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the
yashmayya opened a new pull request, #14044:
URL: https://github.com/apache/kafka/pull/14044
- https://issues.apache.org/jira/browse/KAFKA-15216
-
divijvaidya commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1641713724
`FileBasedStateStore` and `QuorumState` are not the only place that uses
jackson. Did you check usage of `objectmapper`, `Json.scala` etc. for the
limits question?
--
This is an
[
https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744490#comment-17744490
]
Divij Vaidya commented on KAFKA-15197:
--
[~gharris] [~ChrisEgerton] should we disable this test in
fvaleri commented on PR #13417:
URL: https://github.com/apache/kafka/pull/13417#issuecomment-1641635708
Thanks @muralibasani, let me know when you are ready for another review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
machi1990 commented on PR #13966:
URL: https://github.com/apache/kafka/pull/13966#issuecomment-1641607411
> @machi1990 please check test failures
The CI issue was due to an issue which has been fixed by
https://github.com/apache/kafka/pull/14037
I've rebased on trunk, and hopeful
gaurav-narula commented on PR #13949:
URL: https://github.com/apache/kafka/pull/13949#issuecomment-1641606748
@divijvaidya Apologies for the late reply - I was away on vacation. I've
rebased my changes against trunk. The JDK 17 build still failed though. I
reckon it's due to unrelated
[
https://issues.apache.org/jira/browse/KAFKA-15190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744472#comment-17744472
]
Joe Wreschnig edited comment on KAFKA-15190 at 7/19/23 7:49 AM:
[
https://issues.apache.org/jira/browse/KAFKA-15190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744472#comment-17744472
]
Joe Wreschnig edited comment on KAFKA-15190 at 7/19/23 7:48 AM:
[
https://issues.apache.org/jira/browse/KAFKA-15190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744472#comment-17744472
]
Joe Wreschnig commented on KAFKA-15190:
---
[~mjsax], setting {{client.id}} doesn't seem to be
Divij Vaidya created KAFKA-15217:
Summary: Consider usage of Gradle toolchain to specify Java version
Key: KAFKA-15217
URL: https://issues.apache.org/jira/browse/KAFKA-15217
Project: Kafka
divijvaidya commented on PR #13966:
URL: https://github.com/apache/kafka/pull/13966#issuecomment-1641581680
@machi1990 please check test failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
divijvaidya merged PR #14032:
URL: https://github.com/apache/kafka/pull/14032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya resolved KAFKA-15199.
--
Fix Version/s: 3.6.0
Resolution: Fixed
> remove leading and trailing spaces from user
divijvaidya merged PR #14035:
URL: https://github.com/apache/kafka/pull/14035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #14035:
URL: https://github.com/apache/kafka/pull/14035#issuecomment-1641570516
Unrelated test failures. Merging this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon commented on PR #13999:
URL: https://github.com/apache/kafka/pull/13999#issuecomment-1641564037
This PR is ready for review now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon commented on code in PR #13999:
URL: https://github.com/apache/kafka/pull/13999#discussion_r1267657308
##
core/src/main/java/kafka/log/remote/RemoteLogReader.java:
##
@@ -31,14 +32,18 @@ public class RemoteLogReader implements Callable {
private final Logger
showuon commented on code in PR #13999:
URL: https://github.com/apache/kafka/pull/13999#discussion_r1267655177
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -594,13 +618,15 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long
dajac merged PR #13870:
URL: https://github.com/apache/kafka/pull/13870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Yash Mayya created KAFKA-15216:
--
Summary: InternalSinkRecord::newRecord method ignores the headers
argument
Key: KAFKA-15216
URL: https://issues.apache.org/jira/browse/KAFKA-15216
Project: Kafka
DL1231 commented on PR #14042:
URL: https://github.com/apache/kafka/pull/14042#issuecomment-1641493151
@divijvaidya I apologize for the interruption, but I tried to write unit
tests to cover this scenario, but it failed. Do you have any suggestions?
--
This is an automated message from
hudeqi opened a new pull request, #14043:
URL: https://github.com/apache/kafka/pull/14043
This pr is used to remove the metrics in network package(`SocketServer`,
`RequestChannel`, `Acceptor`) when broker shutdown.
This pr has passed the corresponding unit test, and it is part of
DL1231 opened a new pull request, #14042:
URL: https://github.com/apache/kafka/pull/14042
https://issues.apache.org/jira/browse/KAFKA-15205
Catch InterruptedException when calling ShutDownableThread#awaitShutdown()
### Committer Checklist (excluded from commit message)
- [ ]
101 - 140 of 140 matches
Mail list logo
