[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

2023-07-20 Thread via GitHub
Owen-CH-Leung commented on code in PR #14057: URL: https://github.com/apache/kafka/pull/14057#discussion_r1270242829 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentFileset.java: ## @@ -59,9 +59,9 @@ * the local tiered storage: * * - *

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

2023-07-20 Thread via GitHub
Owen-CH-Leung commented on code in PR #14057: URL: https://github.com/apache/kafka/pull/14057#discussion_r1270242568 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageTest.java: ## @@ -399,20 +403,21 @@ public Verifier(final

[jira] [Commented] (KAFKA-15223) Need more clarity in documentation for upgrade/downgrade procedures and limitations across releases.

2023-07-20 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745419#comment-17745419 ] kaushik srinivas commented on KAFKA-15223: -- [~ijuma] , Can you please help us with this ? >

RE: [GitHub] [kafka] stevenbooke commented on a diff in pull request #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [GitHub] [kafka] stevenbooke commented on a diff in pull request #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [GitHub] [kafka] showuon merged pull request #13999: KAFKA-15176: add tests for tiered storage metrics

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [GitHub] [kafka] showuon commented on pull request #14045: MINOR: refactor(storage): topic-based RLMM consumer-manager/task related improvements

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [jira] [Resolved] (KAFKA-15176) Add missing tests for remote storage metrics

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [GitHub] [kafka] github-actions[bot] commented on pull request #13619: Initial support for OpenJDK CRaC snapshotting

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [jira] [Commented] (KAFKA-14780) Make RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay deterministic

2023-07-20 Thread miltan
Hi Jira, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [jira] [Comment Edited] (KAFKA-14780) Make RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay deterministic

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [GitHub] [kafka] satishd opened a new pull request, #14065: MINOR Fix the build failure.

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

RE: [GitHub] [kafka] satishd commented on pull request #13999: KAFKA-15176: add tests for tiered storage metrics

2023-07-20 Thread miltan
Hi Team, Greetings, We actually reached out to you for Oracle/ IT / SAP / Infor / Microsoft "VOTEC IT SERVICE PARTNERSHIP" "IT SERVICE OUTSOURCING" " "PARTNER SERVICE SUBCONTRACTING" We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA,

[GitHub] [kafka] satishd commented on pull request #13999: KAFKA-15176: add tests for tiered storage metrics

2023-07-20 Thread via GitHub
satishd commented on PR #13999: URL: https://github.com/apache/kafka/pull/13999#issuecomment-1644979117 This commit caused the below build failure. I raised https://github.com/apache/kafka/pull/14065 to fix it. ``` [Error]

[GitHub] [kafka] satishd opened a new pull request, #14065: MINOR Fix the build failure.

2023-07-20 Thread via GitHub
satishd opened a new pull request, #14065: URL: https://github.com/apache/kafka/pull/14065 Fixing the build failure caused by the earlier commit https://github.com/apache/kafka/commit/27ea025e33aab525e96bef24840414f7a4e132f1 ``` [Error]

[jira] [Comment Edited] (KAFKA-14780) Make RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay deterministic

2023-07-20 Thread Fei Xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745366#comment-17745366 ] Fei Xie edited comment on KAFKA-14780 at 7/21/23 4:04 AM: -- Hi [~adupriez], is

[jira] [Commented] (KAFKA-14780) Make RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay deterministic

2023-07-20 Thread Fei Xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745366#comment-17745366 ] Fei Xie commented on KAFKA-14780: - Hello there, is anyone actively working on this ticket? If not, could

[GitHub] [kafka] github-actions[bot] commented on pull request #13619: Initial support for OpenJDK CRaC snapshotting

2023-07-20 Thread via GitHub
github-actions[bot] commented on PR #13619: URL: https://github.com/apache/kafka/pull/13619#issuecomment-1644936041 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[GitHub] [kafka] showuon commented on pull request #14045: MINOR: refactor(storage): topic-based RLMM consumer-manager/task related improvements

2023-07-20 Thread via GitHub
showuon commented on PR #14045: URL: https://github.com/apache/kafka/pull/14045#issuecomment-1644902541 Rerunning CI build: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14045/6/ -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-15176) Add missing tests for remote storage metrics

2023-07-20 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15176. --- Fix Version/s: 3.6.0 Resolution: Fixed > Add missing tests for remote storage metrics >

[GitHub] [kafka] showuon merged pull request #13999: KAFKA-15176: add tests for tiered storage metrics

2023-07-20 Thread via GitHub
showuon merged PR #13999: URL: https://github.com/apache/kafka/pull/13999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] stevenbooke commented on a diff in pull request #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

2023-07-20 Thread via GitHub
stevenbooke commented on code in PR #13842: URL: https://github.com/apache/kafka/pull/13842#discussion_r1270163490 ## refresh-collaborators.py: ## @@ -59,9 +64,20 @@ yaml_content["github"]["collaborators"] = collaborators # Convert the updated content back to YAML

[jira] [Comment Edited] (KAFKA-12946) __consumer_offsets topic with very big partitions

2023-07-20 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611018#comment-17611018 ] zhangzhisheng edited comment on KAFKA-12946 at 7/21/23 2:15 AM: upgrade

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-20 Thread via GitHub
jeffkbkim commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1270140356 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-20 Thread via GitHub
jeffkbkim commented on code in PR #14046: URL: https://github.com/apache/kafka/pull/14046#discussion_r1270133576 ## clients/src/main/resources/common/message/OffsetCommitRequest.json: ## @@ -31,13 +31,19 @@ // version 7 adds a new field called groupInstanceId to indicate

[GitHub] [kafka] stevenbooke commented on a diff in pull request #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

2023-07-20 Thread via GitHub
stevenbooke commented on code in PR #13842: URL: https://github.com/apache/kafka/pull/13842#discussion_r1270124376 ## refresh-collaborators.py: ## @@ -35,7 +36,10 @@ contributors_login_to_commit_volume = {} end_date = datetime.now() start_date = end_date -

[GitHub] [kafka] stevenbooke commented on a diff in pull request #13842: KAFKA-14995: Automate asf.yaml collaborators refresh

2023-07-20 Thread via GitHub
stevenbooke commented on code in PR #13842: URL: https://github.com/apache/kafka/pull/13842#discussion_r1270123123 ## refresh-collaborators.py: ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-07-20 Thread via GitHub
jolshan commented on code in PR #13654: URL: https://github.com/apache/kafka/pull/13654#discussion_r1270114193 ## tests/kafkatest/version.py: ## @@ -249,7 +250,3 @@ def get_version(node=None): # 3.5.x versions V_3_5_0 = KafkaVersion("3.5.0") LATEST_3_5 = V_3_5_0 - -# 3.6.x

[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-07-20 Thread via GitHub
jolshan commented on code in PR #13654: URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505 ## tests/kafkatest/version.py: ## @@ -249,7 +250,3 @@ def get_version(node=None): # 3.5.x versions V_3_5_0 = KafkaVersion("3.5.0") LATEST_3_5 = V_3_5_0 - -# 3.6.x

[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-07-20 Thread via GitHub
jolshan commented on code in PR #13654: URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505 ## tests/kafkatest/version.py: ## @@ -249,7 +250,3 @@ def get_version(node=None): # 3.5.x versions V_3_5_0 = KafkaVersion("3.5.0") LATEST_3_5 = V_3_5_0 - -# 3.6.x

[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-07-20 Thread via GitHub
jolshan commented on code in PR #13654: URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505 ## tests/kafkatest/version.py: ## @@ -249,7 +250,3 @@ def get_version(node=None): # 3.5.x versions V_3_5_0 = KafkaVersion("3.5.0") LATEST_3_5 = V_3_5_0 - -# 3.6.x

[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-07-20 Thread via GitHub
jolshan commented on code in PR #13654: URL: https://github.com/apache/kafka/pull/13654#discussion_r1270112505 ## tests/kafkatest/version.py: ## @@ -249,7 +250,3 @@ def get_version(node=None): # 3.5.x versions V_3_5_0 = KafkaVersion("3.5.0") LATEST_3_5 = V_3_5_0 - -# 3.6.x

[GitHub] [kafka] mjsax commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-07-20 Thread via GitHub
mjsax commented on code in PR #13654: URL: https://github.com/apache/kafka/pull/13654#discussion_r1270108718 ## tests/kafkatest/version.py: ## @@ -249,7 +250,3 @@ def get_version(node=None): # 3.5.x versions V_3_5_0 = KafkaVersion("3.5.0") LATEST_3_5 = V_3_5_0 - -# 3.6.x

[GitHub] [kafka] mjsax commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-20 Thread via GitHub
mjsax commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1270094068 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -38,29 +43,34 @@ public class RackAwareTaskAssignor

[GitHub] [kafka] mjsax commented on a diff in pull request #13996: KAFKA-15022: [2/N] introduce graph to compute min cost

2023-07-20 Thread via GitHub
mjsax commented on code in PR #13996: URL: https://github.com/apache/kafka/pull/13996#discussion_r1265999671 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java: ## @@ -0,0 +1,367 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] philipnee commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-07-20 Thread via GitHub
philipnee commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1644739179 Thanks, @junrao -The failing tests should be fixed in the latest commit: The integration test failed because of missing subscription state dependency, which was added in one of the

[jira] [Commented] (KAFKA-15217) Consider usage of Gradle toolchain to specify Java version

2023-07-20 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745290#comment-17745290 ] Said BOUDJELDA commented on KAFKA-15217: I feel I can take this Jira if it's possible  >

[jira] [Comment Edited] (KAFKA-15217) Consider usage of Gradle toolchain to specify Java version

2023-07-20 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745290#comment-17745290 ] Said BOUDJELDA edited comment on KAFKA-15217 at 7/20/23 10:22 PM: --

[GitHub] [kafka] ahuang98 commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-07-20 Thread via GitHub
ahuang98 commented on code in PR #13654: URL: https://github.com/apache/kafka/pull/13654#discussion_r1270012540 ## tests/kafkatest/version.py: ## @@ -249,7 +250,3 @@ def get_version(node=None): # 3.5.x versions V_3_5_0 = KafkaVersion("3.5.0") LATEST_3_5 = V_3_5_0 - -# 3.6.x

[GitHub] [kafka] jolshan commented on a diff in pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-07-20 Thread via GitHub
jolshan commented on code in PR #13654: URL: https://github.com/apache/kafka/pull/13654#discussion_r1270009709 ## tests/kafkatest/version.py: ## @@ -249,7 +250,3 @@ def get_version(node=None): # 3.5.x versions V_3_5_0 = KafkaVersion("3.5.0") LATEST_3_5 = V_3_5_0 - -# 3.6.x

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270007353 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -40,23 +44,31 @@ public class TopicMetadata { */

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270002911 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -434,22 +437,36 @@ public void setSubscriptionMetadata(

[GitHub] [kafka] gharris1727 commented on pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-07-20 Thread via GitHub
gharris1727 commented on PR #14064: URL: https://github.com/apache/kafka/pull/14064#issuecomment-1644636341 Here's some sample output from the current implementation: ``` $ ./bin/connect-plugin-path.sh list --plugin-path ~/test/plugin-path/ SLF4J: Class path contains multiple SLF4J

[GitHub] [kafka] gharris1727 opened a new pull request, #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-07-20 Thread via GitHub
gharris1727 opened a new pull request, #14064: URL: https://github.com/apache/kafka/pull/14064 This adds only the `list` subcommand, the `sync-manifests` subcommand will be in a follow-up PR. This includes new dependencies to the tools package on connect-runtime and

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269957881 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -87,7 +87,7 @@ private Map> membersPerTopic(final

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269953544 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionMetadata.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269952375 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,27 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269947944 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionMetadata.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269946491 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -36,8 +36,9 @@ public interface PartitionAssignor {

[jira] [Created] (KAFKA-15228) Add sync-manifests subcommand to connect-plugin-path tool

2023-07-20 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15228: --- Summary: Add sync-manifests subcommand to connect-plugin-path tool Key: KAFKA-15228 URL: https://issues.apache.org/jira/browse/KAFKA-15228 Project: Kafka

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269933992 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java: ## @@ -52,33 +42,22 @@ public Map members() { return

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269930044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicMetadata.java: ## @@ -16,44 +16,83 @@ */ package

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269930044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicMetadata.java: ## @@ -16,44 +16,83 @@ */ package

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269927386 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

2023-07-20 Thread via GitHub
C0urante commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1269901272 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -597,7 +596,9 @@ private Set listPartitions(

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

2023-07-20 Thread via GitHub
gharris1727 commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1644520071 Thanks for your help Ismael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] gharris1727 merged pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

2023-07-20 Thread via GitHub
gharris1727 merged PR #13313: URL: https://github.com/apache/kafka/pull/13313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-15227) Use plugin.discovery=SERVICE_LOAD in all plugin test suites

2023-07-20 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15227: --- Summary: Use plugin.discovery=SERVICE_LOAD in all plugin test suites Key: KAFKA-15227 URL: https://issues.apache.org/jira/browse/KAFKA-15227 Project: Kafka

[jira] [Created] (KAFKA-15226) System tests for plugin.discovery worker configuration

2023-07-20 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15226: --- Summary: System tests for plugin.discovery worker configuration Key: KAFKA-15226 URL: https://issues.apache.org/jira/browse/KAFKA-15226 Project: Kafka Issue

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269846580 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269837065 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[jira] [Created] (KAFKA-15225) Define constants for record types

2023-07-20 Thread David Jacot (Jira)
David Jacot created KAFKA-15225: --- Summary: Define constants for record types Key: KAFKA-15225 URL: https://issues.apache.org/jira/browse/KAFKA-15225 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-20 Thread via GitHub
dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269799340 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] rreddy-22 commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

2023-07-20 Thread via GitHub
rreddy-22 commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1644359975 Looks good to me! Thanks @flashmouse for the changes and replies! @dajac is a committer so he'll give the final approval! -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] msn-tldr opened a new pull request, #14063: Kip951 poc

2023-07-20 Thread via GitHub
msn-tldr opened a new pull request, #14063: URL: https://github.com/apache/kafka/pull/14063 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] jolshan commented on pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-20 Thread via GitHub
jolshan commented on PR #14046: URL: https://github.com/apache/kafka/pull/14046#issuecomment-1644292908 Looking at the tests `[Build / JDK 20 and Scala 2.13 /

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-20 Thread via GitHub
dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269744467 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-20 Thread via GitHub
dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269744467 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-20 Thread via GitHub
dajac commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269737507 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] dajac commented on a diff in pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-20 Thread via GitHub
dajac commented on code in PR #14046: URL: https://github.com/apache/kafka/pull/14046#discussion_r1269732280 ## clients/src/main/resources/common/message/OffsetCommitRequest.json: ## @@ -31,13 +31,19 @@ // version 7 adds a new field called groupInstanceId to indicate member

[GitHub] [kafka] jolshan commented on pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-20 Thread via GitHub
jolshan commented on PR #14046: URL: https://github.com/apache/kafka/pull/14046#issuecomment-1644264091 > @jolshan I was actually thinking about the AuthorizerIntegrationTest failures overnight and I found an issue with the latestVersionUnstable flag. Let me try to explain. I was

[GitHub] [kafka] mumrah commented on a diff in pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-20 Thread via GitHub
mumrah commented on code in PR #14047: URL: https://github.com/apache/kafka/pull/14047#discussion_r1269713183 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(

[GitHub] [kafka] jolshan commented on a diff in pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-20 Thread via GitHub
jolshan commented on code in PR #14046: URL: https://github.com/apache/kafka/pull/14046#discussion_r1269711912 ## clients/src/main/resources/common/message/OffsetCommitRequest.json: ## @@ -31,13 +31,19 @@ // version 7 adds a new field called groupInstanceId to indicate

[GitHub] [kafka] mumrah commented on a diff in pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-20 Thread via GitHub
mumrah commented on code in PR #14046: URL: https://github.com/apache/kafka/pull/14046#discussion_r1269710067 ## clients/src/main/java/org/apache/kafka/common/errors/StaleMemberEpochException.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah opened a new pull request, #14062: MINOR: Add a Builder for KRaftMigrationDriver

2023-07-20 Thread via GitHub
mumrah opened a new pull request, #14062: URL: https://github.com/apache/kafka/pull/14062 The number of arguments for KRaftMigrationDriver has grown rather large and there are already two constructors. This PR refactors the class to have a single package-private constructor and a builder

[GitHub] [kafka] junrao commented on pull request #13990: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-07-20 Thread via GitHub
junrao commented on PR #13990: URL: https://github.com/apache/kafka/pull/13990#issuecomment-1644221461 @kirktrue : It seems there were 4 test failures for jdk 11. But the tests for jdk 17 and 20 were aborted. Do you know why? -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] divijvaidya merged pull request #13874: KAFKA-14133: Migrate various mocks in TaskManagerTest to Mockito

2023-07-20 Thread via GitHub
divijvaidya merged PR #13874: URL: https://github.com/apache/kafka/pull/13874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-20 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269665264 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java: ## @@ -52,33 +42,22 @@ public Map members() { return

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

2023-07-20 Thread via GitHub
gharris1727 commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1644153313 @ijuma Could you take another look at this? This is blocking KIP-898 that I'm trying to get landed in time for 3.6.0. Thanks! -- This is an automated message from the Apache Git

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

2023-07-20 Thread via GitHub
divijvaidya commented on code in PR #14057: URL: https://github.com/apache/kafka/pull/14057#discussion_r1269646588 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentFileset.java: ## @@ -59,9 +59,9 @@ * the local tiered storage: * * - * /

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

2023-07-20 Thread via GitHub
gharris1727 commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1644151941 I ran a full system test run: ``` SESSION REPORT (ALL TESTS) ducktape version: 0.11.3

[GitHub] [kafka] bmscomp commented on pull request #14060: KAFKA-15222: Upgrade zinc Scala incremental compiler plugin version to a latests stable fit version (1.9.2)

2023-07-20 Thread via GitHub
bmscomp commented on PR #14060: URL: https://github.com/apache/kafka/pull/14060#issuecomment-1644078470 @It's ok now, things seems more stable, but there is some failure on building kafak with jdk 20 that has no relation with zinc compiler, Notice that for all build the retry_zinc

[GitHub] [kafka] yashmayya commented on pull request #14024: KAFKA-13431: Expose the original pre-transform topic partition and offset in sink records

2023-07-20 Thread via GitHub
yashmayya commented on PR #14024: URL: https://github.com/apache/kafka/pull/14024#issuecomment-1644061803 Thanks Chris, I've rebased this on the latest `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-15216) InternalSinkRecord::newRecord method ignores the headers argument

2023-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15216: -- Fix Version/s: 3.3.3 > InternalSinkRecord::newRecord method ignores the headers argument >

[jira] [Updated] (KAFKA-15216) InternalSinkRecord::newRecord method ignores the headers argument

2023-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15216: -- Fix Version/s: 3.4.2 > InternalSinkRecord::newRecord method ignores the headers argument >

[jira] [Updated] (KAFKA-15216) InternalSinkRecord::newRecord method ignores the headers argument

2023-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15216: -- Fix Version/s: 3.5.2 > InternalSinkRecord::newRecord method ignores the headers argument >

[jira] [Resolved] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14669. --- Resolution: Done > Include MirrorMaker connector configurations in docs >

[jira] [Updated] (KAFKA-14669) Include MirrorMaker connector configurations in docs

2023-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14669: -- Priority: Major (was: Blocker) > Include MirrorMaker connector configurations in docs >

[GitHub] [kafka] C0urante merged pull request #14041: KAFKA-14469: Add MirrorMaker 2 configs to table of contents in docs page

2023-07-20 Thread via GitHub
C0urante merged PR #14041: URL: https://github.com/apache/kafka/pull/14041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante merged pull request #14044: KAFKA-15216: InternalSinkRecord::newRecord should not ignore new headers

2023-07-20 Thread via GitHub
C0urante merged PR #14044: URL: https://github.com/apache/kafka/pull/14044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna merged pull request #13942: KAFKA-14936: Check the versioned table's history retention and compare to grace period (4/N)

2023-07-20 Thread via GitHub
cadonna merged PR #13942: URL: https://github.com/apache/kafka/pull/13942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on pull request #13942: KAFKA-14936: Check the versioned table's history retention and compare to grace period (4/N)

2023-07-20 Thread via GitHub
cadonna commented on PR #13942: URL: https://github.com/apache/kafka/pull/13942#issuecomment-1643982125 Build failures are unrelated: ``` Build / JDK 20 and Scala 2.13 /

[jira] [Updated] (KAFKA-15200) verify pre-requisite at start of release.py

2023-07-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15200: - Description: At the start of release.py, the first thing it should do is verify that

[jira] [Updated] (KAFKA-15224) Automate version change to snapshot

2023-07-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15224: - Description: We require changing to SNAPSHOT version as part of the release process [1]. The

[jira] [Created] (KAFKA-15224) Automate version change to snapshot

2023-07-20 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-15224: Summary: Automate version change to snapshot Key: KAFKA-15224 URL: https://issues.apache.org/jira/browse/KAFKA-15224 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

2023-07-20 Thread via GitHub
Owen-CH-Leung commented on code in PR #14057: URL: https://github.com/apache/kafka/pull/14057#discussion_r1269422337 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageTest.java: ## @@ -399,20 +403,21 @@ public Verifier(final

[GitHub] [kafka] Owen-CH-Leung commented on a diff in pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

2023-07-20 Thread via GitHub
Owen-CH-Leung commented on code in PR #14057: URL: https://github.com/apache/kafka/pull/14057#discussion_r1269422337 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageTest.java: ## @@ -399,20 +403,21 @@ public Verifier(final

[GitHub] [kafka] bmscomp commented on pull request #14060: KAFKA-15222: Upgrade zinc Scala incremental compiler plugin version to a latests stable fit version (1.9.2)

2023-07-20 Thread via GitHub
bmscomp commented on PR #14060: URL: https://github.com/apache/kafka/pull/14060#issuecomment-1643853720 The current pull request CI, the errors related to zinc appeared again in current Jenkins build, rebasing the branch again will run the build again, the strange behaviour is that the

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-20 Thread via GitHub
dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1269401629 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2643,9 +2652,175 @@ private CoordinatorResult

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-20 Thread via GitHub
dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1269398879 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2643,9 +2652,175 @@ private CoordinatorResult

  1   2   >