rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1269957881
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##########
@@ -87,7 +87,7 @@ private Map<Uuid, List<String>> membersPerTopic(final
AssignmentSpec assignmentS
for (Uuid topicId : topics) {
// Only topics that are present in both the subscribed topics
list and the topic metadata should be
// considered for assignment.
- if (assignmentSpec.topics().containsKey(topicId)) {
+ if
(assignmentTopicDescriber.subscribedTopicIds().contains(topicId)) {
Review Comment:
We could do that but I think it's more intuitive to leave the subscribed
topicIds method in the interface for people to implement. We also might need it
in the other assignors and its prolly better to have a way to get all the
available topicIds so I vote to keep it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
