[jira] [Commented] (KAFKA-15402) Performance Regression after Upgrading to 3.5.0

[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758849#comment-17758849 ] Benoit Delbosc commented on KAFKA-15402: Unfortunately the patch provided by KAF

[GitHub] [kafka] kamalcph commented on pull request #14285: KAFKA-15399: Enable OffloadAndConsumeFromLeader test

kamalcph commented on PR #14285: URL: https://github.com/apache/kafka/pull/14285#issuecomment-1692847581 ### Test Report ```scala [SUCCESS] (1) create topic: Topic[name=topicA partition-count=1 replication-factor=1 segment-size=1 assignment=null properties={remote.storage.enab

[GitHub] [kafka] satishd commented on a diff in pull request #14266: KAFKA-15294: Publish remote storage configs

satishd commented on code in PR #14266: URL: https://github.com/apache/kafka/pull/14266#discussion_r1305229020 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -56,28 +56,28 @@ public final class RemoteLogManagerConfig {

[GitHub] [kafka] ocadaruma commented on pull request #14289: KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data

ocadaruma commented on PR #14289: URL: https://github.com/apache/kafka/pull/14289#issuecomment-1692802088 @stanislavkozlovski Hi, could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] ocadaruma opened a new pull request, #14289: KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data

ocadaruma opened a new pull request, #14289: URL: https://github.com/apache/kafka/pull/14289 - JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-7504 - This is a long standing issue in current Kafka architecture that calling `FileChannel.transferTo` (which calls sendfile syscall in

[GitHub] [kafka] showuon commented on pull request #14232: MINOR: Use "add-exports" only when jdk >= 16 in minikdc

showuon commented on PR #14232: URL: https://github.com/apache/kafka/pull/14232#issuecomment-1692718075 > @showuon Are you planning on merging this? I'll merge this tomorrow into trunk and 3.6 if I don't hear back from you. Sorry that I forgot about this PR. Merged into 3.6 and trunk

[GitHub] [kafka] showuon merged pull request #14232: MINOR: Use "add-exports" only when jdk >= 16 in minikdc

showuon merged PR #14232: URL: https://github.com/apache/kafka/pull/14232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] abhijeetk88 commented on pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on PR #14127: URL: https://github.com/apache/kafka/pull/14127#issuecomment-1692713005 Thanks @showuon for your comments. I have addressed them inline/with the latest commits. Please take a look. Also, rebased the changes on top of the latest tunk. -- This is a

[GitHub] [kafka] showuon commented on pull request #14136: KAFKA-15038: Add metadatacache into RemoteLogManager, and refactor all relevant codes

showuon commented on PR #14136: URL: https://github.com/apache/kafka/pull/14136#issuecomment-1692686212 @clolov , thanks for the correction. :) So, I think we need to have some solution for the problem in ZK's mode (which LISR will be sent out first before updateMetadataRequest), or w

[GitHub] [kafka] Taher-Ghaleb commented on pull request #14264: KAFKA-15403: Refactor @Test(expected) annotation with assertThrows

Taher-Ghaleb commented on PR #14264: URL: https://github.com/apache/kafka/pull/14264#issuecomment-1692591866 Thanks @jolshan for your response. `assertThrows` makes the verification of exceptions clearer and more intuitive, thus improving code readability compared to the annotation approach

[GitHub] [kafka] jolshan commented on pull request #14264: KAFKA-15403: Refactor @Test(expected) annotation with assertThrows

jolshan commented on PR #14264: URL: https://github.com/apache/kafka/pull/14264#issuecomment-1692577953 Hey @Taher-Ghaleb -- thanks for contributing. I was curious the rationale for why the annotation should be replaced by assertThrows. I personally don't have a strong opinion, but was wond

[GitHub] [kafka] jolshan commented on pull request #14284: KAFKA-15396:Add a metric indicating the version of the current running kafka server

jolshan commented on PR #14284: URL: https://github.com/apache/kafka/pull/14284#issuecomment-1692575352 Hey @hudeqi Divij asked on the JIRA if there is a KIP associated to this. Metrics changes require one. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (KAFKA-15396) Add a metric indicating the version of the current running kafka server

[ https://issues.apache.org/jira/browse/KAFKA-15396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758780#comment-17758780 ] Justine Olshan commented on KAFKA-15396: +1 Just came here to ask if there was a

[jira] [Created] (KAFKA-15404) Failing Test DynamicBrokerReconfigurationTest#testThreadPoolResize

Justine Olshan created KAFKA-15404: -- Summary: Failing Test DynamicBrokerReconfigurationTest#testThreadPoolResize Key: KAFKA-15404 URL: https://issues.apache.org/jira/browse/KAFKA-15404 Project: Kafka

[jira] [Updated] (KAFKA-15404) Failing Test DynamicBrokerReconfigurationTest#testThreadPoolResize

[ https://issues.apache.org/jira/browse/KAFKA-15404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-15404: --- Affects Version/s: 3.6.0 > Failing Test DynamicBrokerReconfigurationTest#testThreadPoolResiz

[jira] [Created] (KAFKA-15403) Refactor @Test(expected) annotation with assertThrows

Taher Ghaleb created KAFKA-15403: Summary: Refactor @Test(expected) annotation with assertThrows Key: KAFKA-15403 URL: https://issues.apache.org/jira/browse/KAFKA-15403 Project: Kafka Issue T

[GitHub] [kafka] satishd commented on pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on PR #13561: URL: https://github.com/apache/kafka/pull/13561#issuecomment-1692563258 Merging it to 3.6 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] satishd commented on pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on PR #13561: URL: https://github.com/apache/kafka/pull/13561#issuecomment-1692562057 There are a few failures unrelated to this PR, merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Updated] (KAFKA-15211) DistributedConfigTest#shouldFailWithInvalidKeySize fails when run after TestSslUtils#generate

[ https://issues.apache.org/jira/browse/KAFKA-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15211: Fix Version/s: 3.4.2 3.5.2 > DistributedConfigTest#shouldFailWithInvalidKeySize

[jira] [Updated] (KAFKA-15377) GET /connectors/{connector}/tasks-config endpoint exposes externalized secret values

[ https://issues.apache.org/jira/browse/KAFKA-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15377: Fix Version/s: 3.6.0 3.4.2 3.5.2 > GET /connectors/{connecto

[GitHub] [kafka] satishd merged pull request #14286: MINOR Bump trunk to 3.7.0-SNAPSHOT

satishd merged PR #14286: URL: https://github.com/apache/kafka/pull/14286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14286: MINOR Bump trunk to 3.7.0-SNAPSHOT

satishd commented on PR #14286: URL: https://github.com/apache/kafka/pull/14286#issuecomment-1692544878 There are a few unrelated test failures, merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758769#comment-17758769 ] Greg Harris commented on KAFKA-14901: - This flakiness is no longer present on trunk.

[jira] [Resolved] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-14901. - Resolution: Cannot Reproduce > Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfig

[jira] [Commented] (KAFKA-15197) Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()

[ https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758768#comment-17758768 ] Greg Harris commented on KAFKA-15197: - We merged KAFKA-15202 and the flakiness decre

[GitHub] [kafka] gharris1727 commented on pull request #14244: KAFKA-15377: Don't expose externalized secret values in tasks-config API endpoint

gharris1727 commented on PR #14244: URL: https://github.com/apache/kafka/pull/14244#issuecomment-1692508803 Test failures appear unrelated, and the tests pass locally for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] junrao commented on a diff in pull request #14118: KAFKA-14875: Implement wakeup

junrao commented on code in PR #14118: URL: https://github.com/apache/kafka/pull/14118#discussion_r1304862712 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] wcarlson5 closed pull request #13878: MINOR: Move RocksDBTimeOrderedKeyValueBufferTest to use Junit5

wcarlson5 closed pull request #13878: MINOR: Move RocksDBTimeOrderedKeyValueBufferTest to use Junit5 URL: https://github.com/apache/kafka/pull/13878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] wcarlson5 closed pull request #14247: Init store properly

wcarlson5 closed pull request #14247: Init store properly URL: https://github.com/apache/kafka/pull/14247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[jira] [Commented] (KAFKA-15256) Add code reviewers to contributors list in release email

[ https://issues.apache.org/jira/browse/KAFKA-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758714#comment-17758714 ] Arpit Goyal commented on KAFKA-15256: - Hi [~divijvaidya]  Can you please review htt

[GitHub] [kafka] iit2009060 opened a new pull request, #14288: Adding reviewer as part of release announcement email template

iit2009060 opened a new pull request, #14288: URL: https://github.com/apache/kafka/pull/14288 This change adds reviewers (as captured from commit message) to the list of contributors for a release. I will change https://cwiki.apache.org/confluence/display/KAFKA/Release+Process to reflect t

[GitHub] [kafka] gharris1727 merged pull request #14278: KAFKA-15393: Improve shutdown behavior in MM2 integration tests

gharris1727 merged PR #14278: URL: https://github.com/apache/kafka/pull/14278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] gharris1727 commented on pull request #14278: KAFKA-15393: Improve shutdown behavior in MM2 integration tests

gharris1727 commented on PR #14278: URL: https://github.com/apache/kafka/pull/14278#issuecomment-1692280274 Test failures appear unrelated, and the mirror tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] gharris1727 commented on pull request #14232: MINOR: Use "add-exports" only when jdk >= 16 in minikdc

gharris1727 commented on PR #14232: URL: https://github.com/apache/kafka/pull/14232#issuecomment-1692252444 @showuon Are you planning on merging this? I'll merge this tomorrow into trunk and 3.6 if I don't hear back from you. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] eaugene opened a new pull request, #14287: [Minor] Check the existence of AppInfo for the given ID before creating a new mbean of the same name

eaugene opened a new pull request, #14287: URL: https://github.com/apache/kafka/pull/14287 When using kafka consumer in apache pinot , we did see couple of WARN as we are trying to create kafka consumer class with the same name . We currently have to use a added suffix to create a new mBean

[GitHub] [kafka] zhaohaidao commented on pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1692157804 > > @dajac hi, could you pls help me see the check error log. I don't quite understand the root cause and what should be fixed myself. The check error log is as followed > > > coor

[jira] [Updated] (KAFKA-15152) Fix incorrect format specifiers when formatting string

[ https://issues.apache.org/jira/browse/KAFKA-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15152: - Fix Version/s: 3.7.0 > Fix incorrect format specifiers when formatting string >

[GitHub] [kafka] divijvaidya merged pull request #14026: KAFKA-15152: Fix incorrect format specifiers when formatting string

divijvaidya merged PR #14026: URL: https://github.com/apache/kafka/pull/14026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] divijvaidya commented on pull request #14026: KAFKA-15152: Fix incorrect format specifiers when formatting string

divijvaidya commented on PR #14026: URL: https://github.com/apache/kafka/pull/14026#issuecomment-1692145348 Test failures are unrelated to the files: ``` [Build / JDK 20 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft](https://ci-

[GitHub] [kafka] divijvaidya merged pull request #14131: MINOR: Upgrade version of Gradle entreprise to 3.14.1 & custom user data Gradle plugin to 1.11.1

divijvaidya merged PR #14131: URL: https://github.com/apache/kafka/pull/14131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] divijvaidya commented on pull request #14275: MINOR: Missing space in ProducerStateManager LogContext

divijvaidya commented on PR #14275: URL: https://github.com/apache/kafka/pull/14275#issuecomment-1692125151 Please feel free to merge after CI is successful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (KAFKA-15396) Add a metric indicating the version of the current running kafka server

[ https://issues.apache.org/jira/browse/KAFKA-15396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15396: - Labels: kip-required (was: ) > Add a metric indicating the version of the current running kafka

[jira] [Commented] (KAFKA-15396) Add a metric indicating the version of the current running kafka server

[ https://issues.apache.org/jira/browse/KAFKA-15396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758668#comment-17758668 ] Divij Vaidya commented on KAFKA-15396: -- Add a new metric requires a KIP. Do we have

[jira] [Assigned] (KAFKA-15156) Update cipherInformation correctly in DefaultChannelMetadataRegistry

[ https://issues.apache.org/jira/browse/KAFKA-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo reassigned KAFKA-15156: - Assignee: (was: Manyanda Chitimbo) > Update cipherInformation correctly in

[jira] [Updated] (KAFKA-15156) Update cipherInformation correctly in DefaultChannelMetadataRegistry

[ https://issues.apache.org/jira/browse/KAFKA-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo updated KAFKA-15156: -- Labels: newbie (was: ) > Update cipherInformation correctly in DefaultChannelMetadata

[jira] [Assigned] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo reassigned KAFKA-14959: - Assignee: (was: Manyanda Chitimbo) > Remove metrics on ClientQuota Managers

[GitHub] [kafka] machi1990 commented on pull request #13966: KAFKA-15156: Update cipherInformation correctly in DefaultChannelMetadataRegistry

machi1990 commented on PR #13966: URL: https://github.com/apache/kafka/pull/13966#issuecomment-1692115972 I've limited bandwidth thus I won't be able to carry this work forward. I'll happily close this MR and unassign myself from the JIRA for someone else to take it over. -- This is an a

[GitHub] [kafka] machi1990 closed pull request #13966: KAFKA-15156: Update cipherInformation correctly in DefaultChannelMetadataRegistry

machi1990 closed pull request #13966: KAFKA-15156: Update cipherInformation correctly in DefaultChannelMetadataRegistry URL: https://github.com/apache/kafka/pull/13966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] machi1990 commented on pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

machi1990 commented on PR #13700: URL: https://github.com/apache/kafka/pull/13700#issuecomment-1692115498 I've limited bandwidth thus I won't be able to carry this work forward. I'll happily close this MR and unassign myself from the JIRA for someone else to take it over. -- This is an a

[GitHub] [kafka] machi1990 closed pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

machi1990 closed pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown URL: https://github.com/apache/kafka/pull/13700 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] satishd opened a new pull request, #14286: MINOR Bump trunk to 3.7.0-SNAPSHOT

satishd opened a new pull request, #14286: URL: https://github.com/apache/kafka/pull/14286 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes

[GitHub] [kafka] divijvaidya commented on pull request #14228: MINOR: Fix docs for ReplicationBytes(Out|In)PerSec metrics

divijvaidya commented on PR #14228: URL: https://github.com/apache/kafka/pull/14228#issuecomment-1692083582 > @divijvaidya @showuon can you have a look, please? Thanks! Sorry I won't reach to reviewing this PR any time soon. Already have a big list of pending PRs on my plate. --

[jira] [Comment Edited] (KAFKA-15402) Performance Regression after Upgrading to 3.5.0

[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758662#comment-17758662 ] Benoit Delbosc edited comment on KAFKA-15402 at 8/24/23 4:56 PM: -

[jira] [Commented] (KAFKA-15402) Performance Regression after Upgrading to 3.5.0

[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758662#comment-17758662 ] Benoit Delbosc commented on KAFKA-15402: flamegraph are not pointing obvious bot

[jira] [Updated] (KAFKA-15402) Performance Regression after Upgrading to 3.5.0

[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benoit Delbosc updated KAFKA-15402: --- Attachment: image-2023-08-24-18-51-57-435.png > Performance Regression after Upgrading to 3.

[jira] [Updated] (KAFKA-15402) Performance Regression after Upgrading to 3.5.0

[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benoit Delbosc updated KAFKA-15402: --- Attachment: image-2023-08-24-18-51-21-720.png > Performance Regression after Upgrading to 3.

[GitHub] [kafka] kamalcph opened a new pull request, #14285: KAFKA-15399: Enable OffloadAndConsumeFromLeader test

kamalcph opened a new pull request, #14285: URL: https://github.com/apache/kafka/pull/14285 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1304597735 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304596807 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -21,8 +21,8 @@ import kafka.utils.TestUtils import org.apache.kafka.common.security.JaasUtils i

[jira] [Commented] (KAFKA-15401) Segment with corrupted index should not be uploaded to remote storage

[ https://issues.apache.org/jira/browse/KAFKA-15401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758646#comment-17758646 ] Viktor Nikitash commented on KAFKA-15401: - PR: https://github.com/apache/kafka/p

[jira] [Updated] (KAFKA-15401) Segment with corrupted index should not be uploaded to remote storage

[ https://issues.apache.org/jira/browse/KAFKA-15401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Nikitash updated KAFKA-15401: Description: During data disk full event, there could be a situation with index corruption

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304576992 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -870,12 +870,17 @@ class LogManager(logDirs: Seq[File], * Update the configuration of the provided topic.

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304576992 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -870,12 +870,17 @@ class LogManager(logDirs: Seq[File], * Update the configuration of the provided topic.

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304575969 ## clients/src/main/resources/common/message/ListGroupsRequest.json: ## @@ -23,11 +23,15 @@ // Version 3 is the first flexible version. // // Version 4 adds

[GitHub] [kafka] zhaohaidao commented on pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1691992754 > > @dajac hi, could you pls help me see the check error log. I don't quite understand the root cause and what should be fixed myself. The check error log is as followed > > > coor

[jira] [Comment Edited] (KAFKA-15290) Add support to onboard existing topics to tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758643#comment-17758643 ] Kamal Chandraprakash edited comment on KAFKA-15290 at 8/24/23 4:04 PM: ---

[jira] [Commented] (KAFKA-15290) Add support to onboard existing topics to tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758643#comment-17758643 ] Kamal Chandraprakash commented on KAFKA-15290: -- [~divijvaidya]  This below

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304553332 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -870,12 +870,17 @@ class LogManager(logDirs: Seq[File], * Update the configuration of the provided topic.

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304548979 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -301,6 +300,70 @@ class RemoteTopicCrudTest extends IntegrationTestHarness { //

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304540159 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -739,4 +741,15 @@ private static Integer decValue(String key

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304529821 ## clients/src/main/resources/common/message/ListGroupsRequest.json: ## @@ -23,11 +23,15 @@ // Version 3 is the first flexible version. // // Version 4 adds

[GitHub] [kafka] satishd commented on pull request #14238: KAFKA-15290: Handle topic-level dynamic remote storage enable configuration

satishd commented on PR #14238: URL: https://github.com/apache/kafka/pull/14238#issuecomment-1691925632 Merging to 3.6 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [kafka] satishd merged pull request #14238: KAFKA-15290: Handle topic-level dynamic remote storage enable configuration

satishd merged PR #14238: URL: https://github.com/apache/kafka/pull/14238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14238: KAFKA-15290: Handle topic-level dynamic remote storage enable configuration

satishd commented on PR #14238: URL: https://github.com/apache/kafka/pull/14238#issuecomment-1691910971 There are a few unrelated test failures. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304506722 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -739,4 +741,15 @@ private static Integer decValue(String key

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1304505511 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCach

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304504593 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -426,9 +429,43 @@ public CompletableFuture listGroups(

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304488801 ## clients/src/main/resources/common/message/ListGroupsRequest.json: ## @@ -23,11 +23,15 @@ // Version 3 is the first flexible version. // // Version 4 adds

[jira] [Created] (KAFKA-15402) Performance Regression after Upgrading to 3.5.0

Benoit Delbosc created KAFKA-15402: -- Summary: Performance Regression after Upgrading to 3.5.0 Key: KAFKA-15402 URL: https://issues.apache.org/jira/browse/KAFKA-15402 Project: Kafka Issue Typ

[jira] [Created] (KAFKA-15401) Segment with corrupted index should not be uploaded to remote storage

Viktor Nikitash created KAFKA-15401: --- Summary: Segment with corrupted index should not be uploaded to remote storage Key: KAFKA-15401 URL: https://issues.apache.org/jira/browse/KAFKA-15401 Project:

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304474195 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -426,9 +429,43 @@ public CompletableFuture listGroups(

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304456965 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -739,4 +741,15 @@ private static Integer decValue(String key

[GitHub] [kafka] zhaohaidao commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

zhaohaidao commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1304456965 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -739,4 +741,15 @@ private static Integer decValue(String key

[GitHub] [kafka] olalamichelle commented on pull request #14262: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBGenericOptionsToDbOptionsColumF…

olalamichelle commented on PR #14262: URL: https://github.com/apache/kafka/pull/14262#issuecomment-1691806220 Thank you, Christo! On Thu, Aug 24, 2023 at 5:05 AM Christo Lolov ***@***.***> wrote: > Hello! Yup, I have assigned > RocksDBGenericOptionsToDbOptionsColumnFamilyO

[GitHub] [kafka] olalamichelle commented on pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

olalamichelle commented on PR #14078: URL: https://github.com/apache/kafka/pull/14078#issuecomment-1691805536 Thank you, Luke! On Wed, Aug 23, 2023 at 9:59 PM Luke Chen ***@***.***> wrote: > Merged #14078 into trunk. > > — >

[GitHub] [kafka] clolov commented on pull request #14136: KAFKA-15038: Add metadatacache into RemoteLogManager, and refactor all relevant codes

clolov commented on PR #14136: URL: https://github.com/apache/kafka/pull/14136#issuecomment-1691749594 I am possibly wrong, but I think that even though this piece of code sends LISR requests first https://github.com/apache/kafka/blob/88d2c4460a1c8c8cf5dbcc9edb43f42fe898ca00/core/src/ma

[jira] [Commented] (KAFKA-7504) Broker performance degradation caused by call of sendfile reading disk in network thread

[ https://issues.apache.org/jira/browse/KAFKA-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758588#comment-17758588 ] Haruki Okada commented on KAFKA-7504: - I would like to bump this issue up again since

[GitHub] [kafka] showuon commented on pull request #14136: KAFKA-15038: Add metadatacache into RemoteLogManager, and refactor all relevant codes

showuon commented on PR #14136: URL: https://github.com/apache/kafka/pull/14136#issuecomment-1691622348 > I want to ensure that there are no race conditions between LISR and updateMetadata requests from controller i.e. validate that metadata cache is updated during LISR request. Give me a d

[GitHub] [kafka] bachmanity1 commented on pull request #14228: MINOR: Fix docs for ReplicationBytes(Out|In)PerSec metrics

bachmanity1 commented on PR #14228: URL: https://github.com/apache/kafka/pull/14228#issuecomment-1691612191 @divijvaidya @showuon can you have a look, please? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] divijvaidya commented on pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

divijvaidya commented on PR #14083: URL: https://github.com/apache/kafka/pull/14083#issuecomment-1691583678 Hey folks We have `kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest` failing in a flaky manner since this change was merged. I deduced this based on the sudden spike

[GitHub] [kafka] hudeqi closed pull request #13696: KAFKA-14979:Incorrect lag was calculated when markPartitionsForTruncation in ReplicaAlterLogDirsThread

hudeqi closed pull request #13696: KAFKA-14979:Incorrect lag was calculated when markPartitionsForTruncation in ReplicaAlterLogDirsThread URL: https://github.com/apache/kafka/pull/13696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Commented] (KAFKA-4169) Calculation of message size is too conservative for compressed messages

[ https://issues.apache.org/jira/browse/KAFKA-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758545#comment-17758545 ] Pere Urbon-Bayes commented on KAFKA-4169: - Hi,    giving it a bit more thought t

[jira] [Updated] (KAFKA-4169) Calculation of message size is too conservative for compressed messages

[ https://issues.apache.org/jira/browse/KAFKA-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pere Urbon-Bayes updated KAFKA-4169: Attachment: Screenshot 2023-08-24 at 14.06.01.png > Calculation of message size is too cons

[GitHub] [kafka] divijvaidya commented on pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on PR #14135: URL: https://github.com/apache/kafka/pull/14135#issuecomment-1691539374 Merging to 3.6 as the KIP was targeted for 3.6 in release plan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Resolved] (KAFKA-14991) Improving Producer's record timestamp validation

[ https://issues.apache.org/jira/browse/KAFKA-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-14991. -- Resolution: Fixed > Improving Producer's record timestamp validation > ---

[jira] [Updated] (KAFKA-14991) Improving Producer's record timestamp validation

[ https://issues.apache.org/jira/browse/KAFKA-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14991: - Fix Version/s: 3.6.0 > Improving Producer's record timestamp validation > --

[GitHub] [kafka] divijvaidya merged pull request #14283: KAFKA-15400: Use readLock when removing an item from the RemoteIndexCache

divijvaidya merged PR #14283: URL: https://github.com/apache/kafka/pull/14283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[jira] [Resolved] (KAFKA-15400) Fix flaky RemoteIndexCache test

[ https://issues.apache.org/jira/browse/KAFKA-15400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15400. -- Resolution: Fixed > Fix flaky RemoteIndexCache test > --- > >

[jira] [Updated] (KAFKA-15400) Fix flaky RemoteIndexCache test

[ https://issues.apache.org/jira/browse/KAFKA-15400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15400: - Fix Version/s: 3.6.0 > Fix flaky RemoteIndexCache test > --- > >

[GitHub] [kafka] divijvaidya commented on pull request #14283: KAFKA-15400: Use readLock when removing an item from the RemoteIndexCache

divijvaidya commented on PR #14283: URL: https://github.com/apache/kafka/pull/14283#issuecomment-1691520548 Merging to 3.6 branch as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

  1   2   >