showuon commented on PR #14302:
URL: https://github.com/apache/kafka/pull/14302#issuecomment-1698608516
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon merged PR #14302:
URL: https://github.com/apache/kafka/pull/14302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-15412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-15412.
---
Fix Version/s: 3.7.0
Resolution: Fixed
> Reading an unknown version of quorum-state-file shou
mimaison commented on PR #14217:
URL: https://github.com/apache/kafka/pull/14217#issuecomment-1698720236
Thanks. I'm busy with other priorities this week. Feel free to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dajac opened a new pull request, #14310:
URL: https://github.com/apache/kafka/pull/14310
This patch refactors the GroupCoordinator.fetchOffsets and
GroupCoordinator.fetchAllOffsets methods to take an OffsetFetchRequestGroup and
to return an OffsetFetchResponseGroup. It prepares the ground f
showuon commented on PR #14192:
URL: https://github.com/apache/kafka/pull/14192#issuecomment-1698755691
@dajac , could you help take a look for the small PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dajac commented on code in PR #14192:
URL: https://github.com/apache/kafka/pull/14192#discussion_r1309937908
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -501,7 +501,10 @@ boolean joinGroupIfNeeded(final Timer timer) {
showuon commented on code in PR #14192:
URL: https://github.com/apache/kafka/pull/14192#discussion_r1309953193
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -501,7 +501,10 @@ boolean joinGroupIfNeeded(final Timer timer) {
divijvaidya commented on PR #14222:
URL: https://github.com/apache/kafka/pull/14222#issuecomment-1698803492
All test failures unrelated to the tests which are modified in this PR.
```
[Build / JDK 20 and Scala 2.13 /
kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()]
divijvaidya merged PR #14222:
URL: https://github.com/apache/kafka/pull/14222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
showuon commented on code in PR #14192:
URL: https://github.com/apache/kafka/pull/14192#discussion_r1309965911
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -501,7 +501,10 @@ boolean joinGroupIfNeeded(final Timer timer) {
hudeqi commented on PR #14243:
URL: https://github.com/apache/kafka/pull/14243#issuecomment-1698824997
> Continuing discussion on Jira at
https://issues.apache.org/jira/browse/KAFKA-14912?focusedCommentId=17756886&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#commen
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-15267:
--
Fix Version/s: 3.6.0
> Cluster-wide disablement of Tiered Storage
> --
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
yashmayya commented on code in PR #14304:
URL: https://github.com/apache/kafka/pull/14304#discussion_r1309974448
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1090,6 +1090,23 @@ public interface UncheckedCloseable extends
AutoCloseable {
voi
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1310123945
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -125,12 +126,37 @@ public RemoteIndexCache(RemoteStorageManager
remoteStora
hudeqi commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1310125666
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -669,4 +689,10 @@ public static String
remoteTransactionIndexFileName(Remot
hudeqi commented on PR #14284:
URL: https://github.com/apache/kafka/pull/14284#issuecomment-1699113199
>
Hi, I have saw the discussion thread. Maybe I need update the pr title to do
the second thing in PR description. @jolshan
--
This is an automated message from the Apache Git S
[
https://issues.apache.org/jira/browse/KAFKA-14519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-14519:
---
Assignee: Jeff Kim
> Add metrics to the new coordinator
> -
nikramakrishnan opened a new pull request, #14311:
URL: https://github.com/apache/kafka/pull/14311
This PR adds test cases for `RemoteLogManager.read`, including cases to
verify that the behaviour of remote fetch is consistent with that of local
fetch when `RemoteStorageFetchInfo.minOneMess
[
https://issues.apache.org/jira/browse/KAFKA-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-15221:
Priority: Blocker (was: Major)
> Potential race condition between requests from rebooted follower
AndrewJSchofield commented on PR #14111:
URL: https://github.com/apache/kafka/pull/14111#issuecomment-1699383628
@junrao We have done some performance tests with leadership changes and
there does not appear to be any performance degradation.
The testing used `kafka-producer-perf-test.
AndrewJSchofield commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1310454166
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -408,11 +463,13 @@ private Optional
updateLatestMetadata(
log.info("Re
[
https://issues.apache.org/jira/browse/KAFKA-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Wells updated KAFKA-2289:
---
Reporter: Henning Schmiedehausen (was: Henning Schmiedehausen)
> KafkaProducer logs erroneous warnin
cmccabe merged PR #14239:
URL: https://github.com/apache/kafka/pull/14239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on code in PR #14310:
URL: https://github.com/apache/kafka/pull/14310#discussion_r1310545133
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1452,62 +1452,63 @@ class KafkaApis(val requestChannel: RequestChannel,
private def fetchAllOffsetsForG
jolshan commented on code in PR #14310:
URL: https://github.com/apache/kafka/pull/14310#discussion_r1310545133
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1452,62 +1452,63 @@ class KafkaApis(val requestChannel: RequestChannel,
private def fetchAllOffsetsForG
jolshan commented on code in PR #14310:
URL: https://github.com/apache/kafka/pull/14310#discussion_r1310562460
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -183,20 +183,21 @@ public
List fetchOffsets(
l
jolshan commented on code in PR #14310:
URL: https://github.com/apache/kafka/pull/14310#discussion_r1310562460
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -183,20 +183,21 @@ public
List fetchOffsets(
l
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reopened KAFKA-12879:
---
Assignee: (was: Philip Nee)
Reopening due to https://github.com/apache/kafka/pull/1343
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-12879:
--
Affects Version/s: 3.6.0
> Compatibility break in Admin.listOffsets()
> --
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-12879:
--
Priority: Blocker (was: Major)
> Compatibility break in Admin.listOffsets()
> ---
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760531#comment-17760531
]
Chris Egerton commented on KAFKA-12879:
---
Looks like this behavior change has resur
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-12879:
--
Fix Version/s: 3.6.0
> Compatibility break in Admin.listOffsets()
> --
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760532#comment-17760532
]
Ismael Juma commented on KAFKA-12879:
-
Good catch, let's file a new issue perhaps? T
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-12879:
-
Assignee: Chris Egerton
> Compatibility break in Admin.listOffsets()
>
jsancio commented on PR #14239:
URL: https://github.com/apache/kafka/pull/14239#issuecomment-1699559425
Thanks for catching this and fixing it @vincent81jiang . Do you think that
this bug fix should be cherry picked to previous releases?
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-15375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-15375:
---
Affects Version/s: 3.5.1
3.4.1
[
https://issues.apache.org/jira/browse/KAFKA-15375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-15375:
---
Fix Version/s: 3.3.3
3.6.0
3.4.
CalvinConfluent opened a new pull request, #14312:
URL: https://github.com/apache/kafka/pull/14312
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
junrao commented on code in PR #14308:
URL: https://github.com/apache/kafka/pull/14308#discussion_r1309440032
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundation
junrao commented on code in PR #14308:
URL: https://github.com/apache/kafka/pull/14308#discussion_r1310575529
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee commented on code in PR #14308:
URL: https://github.com/apache/kafka/pull/14308#discussion_r1310633377
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundati
C0urante opened a new pull request, #14313:
URL: https://github.com/apache/kafka/pull/14313
[Jira](https://issues.apache.org/jira/browse/KAFKA-15416)
There's some fairly subtle behavior involved here, so apologies in advance
for the wall of text.
# Problem
In the `retryE
C0urante commented on PR #14313:
URL: https://github.com/apache/kafka/pull/14313#issuecomment-1699632378
@philipnee I did my best to research the context here diligently, but I may
be missing something (this is a bit outside my wheelhouse). If you have a
moment, would you be willing to take
kirktrue commented on code in PR #14305:
URL: https://github.com/apache/kafka/pull/14305#discussion_r1310609016
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -66,13 +65,19 @@ public boolean canSendRequest(final long currentTimeMs)
kirktrue closed pull request #14305: KAFKA-14274: [1/7] basic refactoring
URL: https://github.com/apache/kafka/pull/14305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760531#comment-17760531
]
Chris Egerton edited comment on KAFKA-12879 at 8/30/23 7:27 PM:
--
C0urante opened a new pull request, #14314:
URL: https://github.com/apache/kafka/pull/14314
[Jira](https://issues.apache.org/jira/browse/KAFKA-12879)
This restores previous behavior for `Admin::listOffsets`, which was to fail
immediately if topic metadata could not be found, and only
ableegoldman merged PR #14149:
URL: https://github.com/apache/kafka/pull/14149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
philipnee commented on PR #14313:
URL: https://github.com/apache/kafka/pull/14313#issuecomment-1699808838
hey @C0urante - I'm looking into this. I can't seem to reproduce the error
you reported on the jira, and i've tried different JDK versions. I'll follow
up here if i'm able to make som
ethaden commented on PR #14130:
URL: https://github.com/apache/kafka/pull/14130#issuecomment-1699828586
> @ethaden Sorry for the late response. left a comment.
No problem. I highly appreciate that you spend your valuable time on
reviewing my code and providing helpful advice.
> Ca
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310843639
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14294:
---
Affects Version/s: 3.1.0
> Kafka Streams should commit transaction when no r
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760632#comment-17760632
]
A. Sophie Blee-Goldman commented on KAFKA-14294:
I'm not sure that worka
ableegoldman commented on PR #14149:
URL: https://github.com/apache/kafka/pull/14149#issuecomment-1699897638
Thanks! Merged to trunk and cherrypicked to 3.6 & 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jeffkbkim commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310880384
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310892402
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,390 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310897847
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,390 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310903635
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,390 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310906983
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,390 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310919719
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,390 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310920650
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,390 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310923371
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Apache Software Foun
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310930694
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,390 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310941152
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##
@@ -0,0 +1,1070 @@
+/*
+ * Licensed to t
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310948792
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##
@@ -0,0 +1,1070 @@
+/*
+ * Licensed to t
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310952891
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##
@@ -0,0 +1,1070 @@
+/*
+ * Licensed to t
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310953106
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##
@@ -0,0 +1,1070 @@
+/*
+ * Licensed to t
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310953106
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##
@@ -0,0 +1,1070 @@
+/*
+ * Licensed to t
jeffkbkim commented on code in PR #14122:
URL: https://github.com/apache/kafka/pull/14122#discussion_r1310959090
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -9119,4 +8742,257 @@ public void
testHeartbeatDuringRebala
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1310961579
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##
@@ -0,0 +1,1070 @@
+/*
+ * Licensed to t
CalvinConfluent commented on code in PR #14310:
URL: https://github.com/apache/kafka/pull/14310#discussion_r1310966316
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -170,29 +170,27 @@
CompletableFuture delet
* Fetch off
kirktrue commented on code in PR #14305:
URL: https://github.com/apache/kafka/pull/14305#discussion_r1310975600
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -66,13 +65,19 @@ public boolean canSendRequest(final long currentTimeMs)
kirktrue commented on PR #14305:
URL: https://github.com/apache/kafka/pull/14305#issuecomment-1700103001
Test failures are unrelated:
```
kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures()
kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()
o.a.
kirktrue commented on code in PR #14308:
URL: https://github.com/apache/kafka/pull/14308#discussion_r1310978474
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java:
##
@@ -129,6 +132,14 @@ public boolean add(final ApplicationEvent event)
showuon opened a new pull request, #14315:
URL: https://github.com/apache/kafka/pull/14315
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgra
showuon commented on PR #14315:
URL: https://github.com/apache/kafka/pull/14315#issuecomment-1700367639
@satishd @divijvaidya , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vamossagar12 commented on PR #14101:
URL: https://github.com/apache/kafka/pull/14101#issuecomment-1700372474
@akitoshka , Going by all these explanations above, do you think we can
close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
vamossagar12 commented on code in PR #14093:
URL: https://github.com/apache/kafka/pull/14093#discussion_r133838
##
connect/runtime/src/main/java/org/apache/kafka/connect/converters/BooleanConverter.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation
81 matches
Mail list logo
