kamalcph commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1349878452
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -134,7 +134,7 @@ public RemoteIndexCache(int maxSize,
iit2009060 commented on PR #14482:
URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752368980
> @iit2009060 , there are compilation failure, could you fix it?
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14482/10/pipeline/
on it.
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1349871792
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,23 +527,221 @@ class RemoteIndexCacheTest {
}
}
- @Test
- def
kamalcph commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1349871437
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -166,6 +166,11 @@ public Cache internalCache() {
return
showuon commented on PR #14482:
URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752364597
@iit2009060 , there are compilation failure, could you fix it?
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14482/10/pipeline/
--
This is an
kamalcph commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1349857381
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,23 +527,221 @@ class RemoteIndexCacheTest {
}
}
- @Test
- def
iit2009060 commented on PR #14482:
URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752350204
@showuon @kamalcph @divijvaidya I have rebased changes and resolved
conflict on the changes merged by
the PR https://github.com/apache/kafka/pull/14381.
Can you please
iit2009060 commented on PR #14482:
URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752348404
> Since we are adding new tests, can we create a new RemoteIndexCacheTest
under `storage` module and start writing the tests in `java`?
>
> The source code is in Java but the
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1349861220
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -166,6 +166,11 @@ public Cache internalCache() {
return
kamalcph commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1349854436
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -166,6 +166,11 @@ public Cache internalCache() {
return
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773096#comment-17773096
]
Philip Nee commented on KAFKA-15565:
Hey [~sankalpbhatia] thanks for reporting the issue but I'm
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1752310508
@dajac - Not entirely sure what is the best way to fix the jdk11 build. The
rest of the builds seem to be fine with the following failures:
```
Build / JDK 21 and Scala 2.13
github-actions[bot] commented on PR #13980:
URL: https://github.com/apache/kafka/pull/13980#issuecomment-1752300320
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #13873:
URL: https://github.com/apache/kafka/pull/13873#issuecomment-1752300357
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sankalp Bhatia updated KAFKA-15565:
---
Description:
It seems to me there is a bug in this line in the KafkaAdminClient. For the
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sankalp Bhatia updated KAFKA-15565:
---
Description:
It seems to me there is a bug in this line in the KafkaAdminClient. For the
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sankalp Bhatia updated KAFKA-15565:
---
Description:
It seems to me there is a bug in this line in the KafkaAdminClient. For the
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sankalp Bhatia updated KAFKA-15565:
---
Description:
It seems to me there is a bug in this line in the KafkaAdminClient. For the
Sankalp Bhatia created KAFKA-15565:
--
Summary: KafkaAdminClient does not honor request timeout ms
Key: KAFKA-15565
URL: https://issues.apache.org/jira/browse/KAFKA-15565
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sankalp Bhatia updated KAFKA-15565:
---
Description:
It seems to me there is a bug in this line in the KafkaAdminClient. For the
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349811549
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -106,15 +107,29 @@ void validateOffsetFetch(
/**
* Returns true if
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349811501
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -544,6 +573,81 @@ public
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1752128811
Got it @mjsax -
Sharing the code that seems to be causing this bypass. Currently to fetch
any consumer config i.e. `main`, `restore` or `global` we use a common function
[
https://issues.apache.org/jira/browse/KAFKA-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772948#comment-17772948
]
hudeqi commented on KAFKA-15535:
Is this marked as resolved? The doc of
hudeqi opened a new pull request, #14511:
URL: https://github.com/apache/kafka/pull/14511
As described from:
https://github.com/apache/kafka/pull/14243#discussion_r1320630057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349654092
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -106,15 +107,29 @@ void validateOffsetFetch(
/**
* Returns true if the
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349653948
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -544,6 +579,100 @@ public
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349653647
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -544,6 +550,76 @@ public
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349653472
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetExpirationCondition.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349653385
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1763,6 +1803,120 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-15536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hudeqi updated KAFKA-15536:
---
Affects Version/s: 3.7.0
(was: 3.6.0)
> dynamically resize remoteIndexCache
>
satishd merged PR #14381:
URL: https://github.com/apache/kafka/pull/14381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
satishd commented on PR #14381:
URL: https://github.com/apache/kafka/pull/14381#issuecomment-1751951542
There are a few unrelated test failures, merging it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
hudeqi commented on PR #14381:
URL: https://github.com/apache/kafka/pull/14381#issuecomment-1751943708
> Thanks @hudeqi for addressing the review comments. LGTM.
Thanks your review, @satishd please merge it. I have resolved several
conflicts. I see that there seems to be another PR
[
https://issues.apache.org/jira/browse/KAFKA-15502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-15502:
--
Affects Version/s: 3.5.1
3.4.1
> Handle large keystores in SslEngineValidator
[
https://issues.apache.org/jira/browse/KAFKA-15502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar resolved KAFKA-15502.
---
Fix Version/s: 3.4.2
3.5.2
3.7.0
3.6.1
36 matches
Mail list logo
