Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-11-10 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1389047935 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -817,19 +731,11 @@ public void testAccessors() throws E

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-11-10 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1389049719 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -838,39 +733,32 @@ public void testPutConnectorConfig()

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-11-10 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1389050516 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -838,39 +733,32 @@ public void testPutConnectorConfig()

Re: [PR] KAFKA-15552 Fix Producer ID ZK migration [kafka]

2023-11-10 Thread via GitHub
showuon commented on PR #14506: URL: https://github.com/apache/kafka/pull/14506#issuecomment-1805278003 @jolshan , I just created a [PR](https://github.com/apache/kafka/pull/14730) to revert the change in this PR, and the test results also failed `testSingleIP` test. So, let's keep monitori

Re: [PR] KAFKA-15711: KRaft support in LogRecoveryTest [kafka]

2023-11-10 Thread via GitHub
linzihao1999 commented on code in PR #14693: URL: https://github.com/apache/kafka/pull/14693#discussion_r1389074063 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -212,7 +228,7 @@ class LogRecoveryTest extends QuorumTestHarness { server2.startup()

Re: [PR] KAFKA-15711: KRaft support in LogRecoveryTest [kafka]

2023-11-10 Thread via GitHub
linzihao1999 commented on code in PR #14693: URL: https://github.com/apache/kafka/pull/14693#discussion_r1389074063 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -212,7 +228,7 @@ class LogRecoveryTest extends QuorumTestHarness { server2.startup()

[PR] [Draft] KIP-994 [kafka]

2023-11-10 Thread via GitHub
RamanVerma opened a new pull request, #14731: URL: https://github.com/apache/kafka/pull/14731 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

Re: [PR] KAFKA-15360: Include dirs in BrokerRegistration [kafka]

2023-11-10 Thread via GitHub
dajac commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1805313339 This PR has introduces a compilation error (JDK 8 and Scala 2.12): ``` > Task :core:compileScala [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-14392/core/src/main/scala/

Re: [PR] KAFKA-15711: KRaft support in LogRecoveryTest [kafka]

2023-11-10 Thread via GitHub
linzihao1999 commented on code in PR #14693: URL: https://github.com/apache/kafka/pull/14693#discussion_r1389074590 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -212,7 +228,7 @@ class LogRecoveryTest extends QuorumTestHarness { server2.startup()

Re: [PR] KAFKA-15645 ReplicationQuotasTestRig rewritten in java [kafka]

2023-11-10 Thread via GitHub
nizhikov commented on PR #14588: URL: https://github.com/apache/kafka/pull/14588#issuecomment-1805320880 Now only 24 tests failed. And the all seems not related to the tool. @mimaison do you have more comments to the PR? Can we merge it? -- This is an automated message from th

[PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]

2023-11-10 Thread via GitHub
dajac opened a new pull request, #14732: URL: https://github.com/apache/kafka/pull/14732 https://github.com/apache/kafka/pull/14392 has introduces a compilation error (JDK 8 and Scala 2.12): ``` > Task :core:compileScala [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-143

Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]

2023-11-10 Thread via GitHub
dajac commented on PR #14732: URL: https://github.com/apache/kafka/pull/14732#issuecomment-1805328685 cc @soarez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]

2023-11-10 Thread via GitHub
dajac commented on PR #14732: URL: https://github.com/apache/kafka/pull/14732#issuecomment-1805337071 @showuon @mimaison @cadonna @lucasbru If you are around, could you take a quick look at this one? -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]

2023-11-10 Thread via GitHub
dajac commented on PR #14732: URL: https://github.com/apache/kafka/pull/14732#issuecomment-1805372330 The compilation step has passed for all builds and I have verified that `kafka.server.BrokerLifecycleManagerTest` passed locally with both scala versions. Therefore, I will merge this PR wi

Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]

2023-11-10 Thread via GitHub
dajac commented on PR #14732: URL: https://github.com/apache/kafka/pull/14732#issuecomment-1805370594 @showuon Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HOTFIX: Fix compilation error in BrokerLifecycleManager [kafka]

2023-11-10 Thread via GitHub
dajac merged PR #14732: URL: https://github.com/apache/kafka/pull/14732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-11-10 Thread via GitHub
C0urante commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1388621193 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -722,89 +646,68 @@ public void testRestartConnectorAndTas

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2023-11-10 Thread via GitHub
VictorvandenHoven commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1389220068 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -609,17 +842,18 @@ public void testOrdering() {

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-10 Thread via GitHub
dajac commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1389220863 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -96,7 +96,7 @@ public NetworkClientDelegate.PollResult poll(f

Re: [PR] Added topicExists functions in AdminClient [kafka]

2023-11-10 Thread via GitHub
makarushka closed pull request #8340: Added topicExists functions in AdminClient URL: https://github.com/apache/kafka/pull/8340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-11-10 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1389227114 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -656,48 +586,43 @@ public void testRestartConnectorAndT

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-10 Thread via GitHub
soarez commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1389229875 ## core/src/main/java/kafka/server/AssignmentsManager.java: ## @@ -0,0 +1,386 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-11-10 Thread via GitHub
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1389230779 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -722,89 +646,68 @@ public void testRestartConnectorAndT

Re: [PR] KAFKA-15346: add support for 'single key single timestamp' IQs with versioned state stores (KIP-960) [kafka]

2023-11-10 Thread via GitHub
aliehsaeedii commented on PR #14596: URL: https://github.com/apache/kafka/pull/14596#issuecomment-1805669950 @mjsax Cool. Thanks for unblocking me. Maybe now ready to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] KAFKA-15707: KRaft support in TopicBasedRemoteLogMetadataManagerHarness [kafka]

2023-11-10 Thread via GitHub
linzihao1999 opened a new pull request, #14733: URL: https://github.com/apache/kafka/pull/14733 KRaft support in TopicBasedRemoteLogMetadataManagerHarness ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[jira] [Resolved] (KAFKA-15745) KRaft support in RequestQuotaTest

2023-11-10 Thread Zihao Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zihao Lin resolved KAFKA-15745. --- Resolution: Duplicate > KRaft support in RequestQuotaTest > - > >

Re: [PR] KAFKA-15804: Close SocketServer channels when calling shutdown before enableRequestProcessing [kafka]

2023-11-10 Thread via GitHub
ex172000 commented on code in PR #14729: URL: https://github.com/apache/kafka/pull/14729#discussion_r1389423646 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -679,6 +679,9 @@ private[kafka] abstract class Acceptor(val socketServer: SocketServer, def close():

[jira] [Created] (KAFKA-15805) Fetch Remote Indexes at once

2023-11-10 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-15805: Summary: Fetch Remote Indexes at once Key: KAFKA-15805 URL: https://issues.apache.org/jira/browse/KAFKA-15805 Project: Kafka

[jira] [Created] (KAFKA-15806) Signal next segment when remote fetching

2023-11-10 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-15806: Summary: Signal next segment when remote fetching Key: KAFKA-15806 URL: https://issues.apache.org/jira/browse/KAFKA-15806 Project: Kaf

Re: [PR] KAFKA-14133: Migrate ProcessorStateManagerTest and StreamThreadTest to Mockito [kafka]

2023-11-10 Thread via GitHub
clolov commented on PR #13932: URL: https://github.com/apache/kafka/pull/13932#issuecomment-1805861321 This has since been rebased! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

2023-11-10 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[jira] [Updated] (KAFKA-15806) Signal next segment when remote fetching

2023-11-10 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya updated KAFKA-15806: - Description: Improve remote fetching performance when fetching a

[jira] [Updated] (KAFKA-15805) Fetch Remote Indexes at once

2023-11-10 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya updated KAFKA-15805: - Description: Reduce Tiered Storage latency when fetching indexes

[jira] [Assigned] (KAFKA-15426) Process and persist directory assignments

2023-11-10 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-15426: --- Assignee: Igor Soarez > Process and persist directory assignments > ---

[jira] [Assigned] (KAFKA-15361) Process and persist dir info with broker registration

2023-11-10 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-15361: --- Assignee: Igor Soarez > Process and persist dir info with broker registration > ---

[jira] [Assigned] (KAFKA-15364) Handle log directory failure in the Controller

2023-11-10 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-15364: --- Assignee: Igor Soarez > Handle log directory failure in the Controller > --

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-10 Thread via GitHub
soarez commented on PR #14369: URL: https://github.com/apache/kafka/pull/14369#issuecomment-1805892764 Is there a way to trigger the tests again or do I need to push additional changes? All the test pipelines show a Jenkins error: "No space left on device". -- This is an automated mes

Re: [PR] KAFKA-15277: Design & implement support for internal Consumer delegates [kafka]

2023-11-10 Thread via GitHub
kirktrue closed pull request #14670: KAFKA-15277: Design & implement support for internal Consumer delegates URL: https://github.com/apache/kafka/pull/14670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-15277: Design & implement support for internal Consumer delegates [kafka]

2023-11-10 Thread via GitHub
kirktrue commented on PR #14670: URL: https://github.com/apache/kafka/pull/14670#issuecomment-1805940138 Re-triggered a build due to the abundance of seemingly unrelated test failures. For example, the first line of this test in `ClusterConnectionStatesTest` is failing across all bui

[PR] MINOR: Various cleanups in metadata [kafka]

2023-11-10 Thread via GitHub
mimaison opened a new pull request, #14734: URL: https://github.com/apache/kafka/pull/14734 - Remove unused code, suppression - Simplify/fix test assertions - Javadoc cleanups ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[PR] KIP-988 [kafka]

2023-11-10 Thread via GitHub
eduwercamacaro opened a new pull request, #14735: URL: https://github.com/apache/kafka/pull/14735 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[PR] KRaft support in DescribeUserScramCredentialsRequestNotAuthorizedTest [kafka]

2023-11-10 Thread via GitHub
linzihao1999 opened a new pull request, #14736: URL: https://github.com/apache/kafka/pull/14736 KRaft support in DescribeUserScramCredentialsRequestNotAuthorizedTest ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test c

Re: [PR] KAFKA-15800: Prevent DataExceptions from corrupting KafkaOffsetBackingStore [kafka]

2023-11-10 Thread via GitHub
gharris1727 commented on PR #14718: URL: https://github.com/apache/kafka/pull/14718#issuecomment-1806059864 Test failures appear unrelated, and the connect and mirror tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-15800: Prevent DataExceptions from corrupting KafkaOffsetBackingStore [kafka]

2023-11-10 Thread via GitHub
gharris1727 merged PR #14718: URL: https://github.com/apache/kafka/pull/14718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-15804: Close SocketServer channels when calling shutdown before enableRequestProcessing [kafka]

2023-11-10 Thread via GitHub
gharris1727 commented on code in PR #14729: URL: https://github.com/apache/kafka/pull/14729#discussion_r1389645226 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -679,6 +679,9 @@ private[kafka] abstract class Acceptor(val socketServer: SocketServer, def close

Re: [PR] KAFKA-15277: Design & implement support for internal Consumer delegates [kafka]

2023-11-10 Thread via GitHub
kirktrue closed pull request #14670: KAFKA-15277: Design & implement support for internal Consumer delegates URL: https://github.com/apache/kafka/pull/14670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-10 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1389684994 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-10 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1389709078 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public static

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-10 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1389719566 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public static

Re: [PR] KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) [kafka]

2023-11-10 Thread via GitHub
apoorvmittal10 closed pull request #14632: KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) URL: https://github.com/apache/kafka/pull/14632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Created] (KAFKA-15807) Add support for compress/decompress metrics

2023-11-10 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15807: - Summary: Add support for compress/decompress metrics Key: KAFKA-15807 URL: https://issues.apache.org/jira/browse/KAFKA-15807 Project: Kafka Issue Type: Sub

[jira] [Updated] (KAFKA-15807) Add support for compression/decompression of metrics

2023-11-10 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-15807: -- Summary: Add support for compression/decompression of metrics (was: Add support for compress/

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-10 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1389684994 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15277: Design & implement support for internal Consumer delegates [kafka]

2023-11-10 Thread via GitHub
kirktrue closed pull request #14670: KAFKA-15277: Design & implement support for internal Consumer delegates URL: https://github.com/apache/kafka/pull/14670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Assigned] (KAFKA-15341) Enabling TS for a topic during rolling restart causes problems

2023-11-10 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-15341: -- Assignee: Phuc Hong Tran > Enabling TS for a topic during rolling restart causes prob

[PR] KAFKA-15362: Resolve offline replicas in metadata cache [kafka]

2023-11-10 Thread via GitHub
soarez opened a new pull request, #14737: URL: https://github.com/apache/kafka/pull/14737 The metadata cache now considers registered log directories and directory assignments when determining offline replicas. ### Committer Checklist (excluded from commit message) - [ ] Verify

Re: [PR] KAFKA-15362: Resolve offline replicas in metadata cache [kafka]

2023-11-10 Thread via GitHub
soarez commented on PR #14737: URL: https://github.com/apache/kafka/pull/14737#issuecomment-1806580244 @pprovenzano @cmccabe please have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15774: refactor windowed stores to use StoreFactory [kafka]

2023-11-10 Thread via GitHub
agavra commented on PR #14708: URL: https://github.com/apache/kafka/pull/14708#issuecomment-1806629224 @ableegoldman is this good to merge? the failing tests seem unrelated and I've seen them be quite flaky ![image](https://github.com/apache/kafka/assets/3172405/d02560d5-1ffe-443e-8eba-

Re: [PR] KAFKA-15774: refactor windowed stores to use StoreFactory [kafka]

2023-11-10 Thread via GitHub
ableegoldman merged PR #14708: URL: https://github.com/apache/kafka/pull/14708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-11-10 Thread via GitHub
C0urante commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1390087872 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -817,19 +726,14 @@ public void testAccessors() throws Exc

Re: [PR] KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest [kafka]

2023-11-10 Thread via GitHub
C0urante commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1390091434 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -908,75 +799,58 @@ public void testCorruptConfig() throws

Re: [PR] This adds a default implementation to the KafkaProducer interface to … [kafka]

2023-11-10 Thread via GitHub
github-actions[bot] commented on PR #13981: URL: https://github.com/apache/kafka/pull/13981#issuecomment-1806659081 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[jira] [Commented] (KAFKA-15341) Enabling TS for a topic during rolling restart causes problems

2023-11-10 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785136#comment-17785136 ] Phuc Hong Tran commented on KAFKA-15341: [~divijvaidya] controller doesn't know

[jira] [Updated] (KAFKA-15575) Prevent Connectors from exceeding tasks.max configuration

2023-11-10 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15575: -- Description: The Connector::taskConfigs(int maxTasks) function is used by Connectors to enume

[jira] [Commented] (KAFKA-15575) Prevent Connectors from exceeding tasks.max configuration

2023-11-10 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785147#comment-17785147 ] Chris Egerton commented on KAFKA-15575: --- I've published [KIP-1004|https://cwiki.a

[jira] [Created] (KAFKA-15808) kstreams app consumer threads all fenced due to outdated static membership ids during group coordinator migration

2023-11-10 Thread Carrie Hazelton (Jira)
Carrie Hazelton created KAFKA-15808: --- Summary: kstreams app consumer threads all fenced due to outdated static membership ids during group coordinator migration Key: KAFKA-15808 URL: https://issues.apache.org/ji

Re: [PR] KAFKA-15740: KRaft support in DeleteOffsetsConsumerGroupCommandIntegrationTest [kafka]

2023-11-10 Thread via GitHub
linzihao1999 commented on PR #14669: URL: https://github.com/apache/kafka/pull/14669#issuecomment-1806736102 Hi @cmccabe @jsancio The CI-builds finished and I found no failure test report about DeleteOffsetsConsumerGroupCommandIntegrationTest. Is there more I need to do before cod

Re: [PR] KAFKA-12388: Share broker channel between alterIsrManager and lifecycleManager [kafka]

2023-11-10 Thread via GitHub
dengziming closed pull request #10255: KAFKA-12388: Share broker channel between alterIsrManager and lifecycleManager URL: https://github.com/apache/kafka/pull/10255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-6084: Propagate JSON parsing errors in ReassignPartitionsCommand [kafka]

2023-11-10 Thread via GitHub
dengziming closed pull request #10789: KAFKA-6084: Propagate JSON parsing errors in ReassignPartitionsCommand URL: https://github.com/apache/kafka/pull/10789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-15741: KRaft support in DescribeConsumerGroupTest [kafka]

2023-11-10 Thread via GitHub
dengziming commented on PR #14668: URL: https://github.com/apache/kafka/pull/14668#issuecomment-1806737490 There seems some flaky related to this PR here: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14668/2/#showFailuresLink -- This is an automated message from the Apache G