lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1396826235
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +359,592 @@ public void
updateState(ConsumerGroupHeartbe
[
https://issues.apache.org/jira/browse/KAFKA-15839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15839:
---
Description:
It is currently used in the reconciliation path. Could be used more, just
leav
[
https://issues.apache.org/jira/browse/KAFKA-15839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15839:
---
Summary: Improve TopicIdPartition integration in consumer membershipManager
(was: Review to
apoorvmittal10 commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1396823629
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/SinglePointMetricTest.java:
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Fou
dajac commented on PR #14786:
URL: https://github.com/apache/kafka/pull/14786#issuecomment-1815883841
@showuon or @mimaison Could one of you take a quick look if you are around?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dajac opened a new pull request, #14786:
URL: https://github.com/apache/kafka/pull/14786
https://github.com/apache/kafka/pull/14369 introduced a compilation error in
ReplicaManagerConcurrencyTest for Scala 2.12.
### Committer Checklist (excluded from commit message)
- [ ] Verify de
dajac commented on PR #14369:
URL: https://github.com/apache/kafka/pull/14369#issuecomment-1815873092
It seems that a compilation error was introduced by this PR. From the last
"JDK 8 and Scala 2.12" build:
```
[Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-14369/core/src/test/scal
wangliucheng created KAFKA-15851:
Summary: broker under replicated due to error
java.nio.BufferOverflowException
Key: KAFKA-15851
URL: https://issues.apache.org/jira/browse/KAFKA-15851
Project: Kafka
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396803550
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +139,216 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396802119
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java:
##
@@ -195,17 +195,15 @@ public QueryResult query(final Query
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396801743
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +139,216 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396800666
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +139,216 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396796203
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +139,216 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396796203
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +139,216 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396796203
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +139,216 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396794756
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +139,216 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396793814
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -293,7 +285,7 @@ protected QueryResult runRangeQuery(final Query
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396793430
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -247,26 +247,18 @@ public Position getPosition() {
}
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396791842
##
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueToTimestampedKeyValueByteStoreAdapter.java:
##
@@ -127,9 +136,25 @@ public QueryResult qu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396791322
##
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueToTimestampedKeyValueByteStoreAdapter.java:
##
@@ -127,9 +136,25 @@ public QueryResult qu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396789456
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396762731
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +139,216 @@ static class RawAndDeserializedValue {
[
https://issues.apache.org/jira/browse/KAFKA-15831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15831:
--
Component/s: clients
> List Client Metrics Configuration Resources
> -
apoorvmittal10 commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1396756211
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Fou
apoorvmittal10 commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1396755967
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,347 @@
+/*
+ * Licensed to the Apache Software Fou
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396755678
##
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueToTimestampedKeyValueByteStoreAdapter.java:
##
@@ -127,9 +136,25 @@ public QueryResult query(
Apoorv Mittal created KAFKA-15850:
-
Summary: Improve KafkaMetrics APIs to expose Value Provider
information
Key: KAFKA-15850
URL: https://issues.apache.org/jira/browse/KAFKA-15850
Project: Kafka
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1396747100
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1815793979
Thanks for review @AndrewJSchofield, @philipnee. I have addressed the
feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1396738177
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1396737699
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1396737525
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1396736767
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1396723148
##
streams/src/main/java/org/apache/kafka/streams/state/VersionedRecordIterator.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
philipnee commented on PR #14746:
URL: https://github.com/apache/kafka/pull/14746#issuecomment-1815756879
@cadonna - There are some build failures. Can we rerun the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
philipnee commented on PR #14746:
URL: https://github.com/apache/kafka/pull/14746#issuecomment-1815755117
Hi @cadonna - I was about to reply with the same idea you proposed. I think
that would work. I wonder if we could just use a `BlockingQueue` for the
fetchBuffer because fetchBuffer.poll
philipnee commented on PR #14779:
URL: https://github.com/apache/kafka/pull/14779#issuecomment-1815746487
Hey @lucasbru - Thanks for the PR I think it looks good overall. I left a
comment about the inconsistent behavior above, what do you think?
Do we need more tests to ensure the l
philipnee commented on code in PR #14779:
URL: https://github.com/apache/kafka/pull/14779#discussion_r1396702971
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1102,46 +1207,94 @@ public void subscribe(Pattern pattern,
Consu
philipnee commented on code in PR #14779:
URL: https://github.com/apache/kafka/pull/14779#discussion_r1396702415
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1102,46 +1207,94 @@ public void subscribe(Pattern pattern,
Consu
philipnee commented on code in PR #14779:
URL: https://github.com/apache/kafka/pull/14779#discussion_r1396700506
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1102,46 +1207,94 @@ public void subscribe(Pattern pattern,
Consu
philipnee commented on PR #14680:
URL: https://github.com/apache/kafka/pull/14680#issuecomment-1815737836
hi @lucasbru - I think the KafkaConsumerTest failures were caused by some
test we forgot to disabled. The last 2 runs seem to be ok (well, still flaky
but not failing on that specific
kamalcph commented on PR #14136:
URL: https://github.com/apache/kafka/pull/14136#issuecomment-1815724658
@Owen-CH-Leung
Can you please rebase your PR against trunk? I'll review the PR in 2 days.
--
This is an automated message from the Apache Git Service.
To respond to the message,
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396681253
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396679975
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396675130
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396672967
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396671729
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396670969
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396670619
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396669760
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396669104
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396667524
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396667524
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396641719
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundatio
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396641322
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -16,17 +16,21 @@
*/
package org.apache.kafka.streams;
+import java.util.Optional;
Revi
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396641005
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
StreamsConfig glo
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396639777
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396638565
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396638341
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Founda
Dongnuo Lyu created KAFKA-15849:
---
Summary: Fix ListGroups API when runtime partition size is zero
Key: KAFKA-15849
URL: https://issues.apache.org/jira/browse/KAFKA-15849
Project: Kafka
Issue Ty
ableegoldman commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1396625434
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -701,7 +706,15 @@ private StandbyTask convertActiveToStandby(final
S
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396625136
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396624783
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396624092
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
ableegoldman commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1396623185
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##
@@ -1012,6 +1022,8 @@ private void prepareChangelogs(final Map
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396618526
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396617558
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396614486
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396613887
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396612728
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396607932
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396596218
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1396592116
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396590225
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Founda
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396586675
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundatio
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396586675
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundatio
ableegoldman commented on PR #13283:
URL: https://github.com/apache/kafka/pull/13283#issuecomment-1815619664
> do we need this pausing semantics for ReadOnlyTask as well?
Alright so I'm not super familiar with this new code which seems to be
related to the state updater, but IIUC the
CalvinConfluent opened a new pull request, #14784:
URL: https://github.com/apache/kafka/pull/14784
A bug fix where the previous broker epoch should not be set if the version
is smaller than 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396551006
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
StreamsConf
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396507648
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -16,17 +16,21 @@
*/
package org.apache.kafka.streams;
+import java.util.Optional;
cmccabe commented on code in PR #14737:
URL: https://github.com/apache/kafka/pull/14737#discussion_r1396539701
##
metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java:
##
@@ -50,6 +54,7 @@ public static class Builder {
private boolean fenced = false;
cmccabe commented on code in PR #14737:
URL: https://github.com/apache/kafka/pull/14737#discussion_r1396538894
##
metadata/src/test/java/org/apache/kafka/image/node/ClusterImageBrokersNodeTest.java:
##
@@ -66,7 +66,7 @@ public void testNode1Child() {
"rack=Optional.
cmccabe commented on code in PR #14737:
URL: https://github.com/apache/kafka/pull/14737#discussion_r1396536766
##
metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java:
##
@@ -118,6 +124,13 @@ public Builder setIsMigratingZkBroker(boolean
isMigratingZkBroker)
mjsax commented on code in PR #14696:
URL: https://github.com/apache/kafka/pull/14696#discussion_r1396522548
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java:
##
@@ -103,8 +104,21 @@ public String toString() {
}
}
-p
cmccabe commented on PR #14369:
URL: https://github.com/apache/kafka/pull/14369#issuecomment-1815535748
commited, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cmccabe closed pull request #14369: KAFKA-15357: Aggregate and propagate
assignments
URL: https://github.com/apache/kafka/pull/14369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396517053
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
StreamsConfig glo
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Description:
The {{LegacyKafkaConsumer}} and {{AsyncKafkaConsumer}} implementations have a
fundamenta
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1396517053
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -216,12 +232,38 @@ public TopologyConfig(final String topologyName, final
StreamsConfig glo
cmccabe commented on PR #14369:
URL: https://github.com/apache/kafka/pull/14369#issuecomment-1815518652
> @cmccabe I'm confused, I thought that was the whole point of
kafka.utils.Exit
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/utils/Exit.scala#L21-L24
https://git
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Description:
The {{LegacyKafkaConsumer}} and {{AsyncKafkaConsumer}} implementations have a
fundamenta
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Description:
The {{LegacyKafkaConsumer}} and {{AsyncKafkaConsumer}} handle the timeouts
given to the
jolshan merged PR #14747:
URL: https://github.com/apache/kafka/pull/14747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1396501916
##
core/src/test/java/kafka/metrics/ClientMetricsInstanceTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Component/s: unit tests
> Consumer API timeout inconsistent between LegacyKafkaConsumer and
> AsyncKa
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Description: The {{LegacyKafkaConsumer}} and {{AsyncKafkaConsumer}} handle
the timeouts given to the v
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1396500493
##
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##
@@ -60,17 +62,39 @@ public PushTelemetryRequest(PushTelemetryRequestData data,
s
Kirk True created KAFKA-15848:
-
Summary: Consumer API timeout inconsistent between
LegacyKafkaConsumer and AsyncKafkaConsumer
Key: KAFKA-15848
URL: https://issues.apache.org/jira/browse/KAFKA-15848
Projec
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Labels: consumer-threading-refactor kip-848-client-support kip-848-preview
(was: )
> Consumer API ti
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Description: The AsyncKafkaConsumer andÂ
> Consumer API timeout inconsistent between LegacyKafkaConsum
1 - 100 of 271 matches
Mail list logo
