[
https://issues.apache.org/jira/browse/KAFKA-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zihao Lin reassigned KAFKA-14507:
-
Assignee: Zihao Lin
> Add ConsumerGroupPrepareAssignment API
>
lucasbru commented on PR #14680:
URL: https://github.com/apache/kafka/pull/14680#issuecomment-1815926638
Scala compilation in 2.12 is broken on master, which is fixed in
https://github.com/apache/kafka/pull/14786, otherwise this is looking good
--
This is an automated message from the Apa
dajac commented on PR #14786:
URL: https://github.com/apache/kafka/pull/14786#issuecomment-1815931886
Thanks @lucasbru! The compilation step has succeeded for all build and I
have also confirmed that the test passes locally with Scala 2.12 and 2.13.
Therefore, I will go ahead and merge it t
dajac merged PR #14786:
URL: https://github.com/apache/kafka/pull/14786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cadonna commented on PR #14779:
URL: https://github.com/apache/kafka/pull/14779#issuecomment-1815989094
I agree with @philipnee that testing the locking behavior would be great.
However, I also agree with @lucasbru that testing the locking behavior is quite
hard. Given the tight deadline to
cadonna commented on PR #14746:
URL: https://github.com/apache/kafka/pull/14746#issuecomment-1816005251
> I wonder if we could just use a BlockingQueue for the fetchBuffer because
fetchBuffer.poll(time) blocks until non-empty or timeout.
As far as I see from the javadocs of a `Blockin
cadonna commented on PR #14746:
URL: https://github.com/apache/kafka/pull/14746#issuecomment-1816006382
> Do you think it is worth adding a ticket about using the
BackgroundEventQueue for the fetches? Let me know if you have a concrete idea
about how to implement this.
Let me think a
philipnee commented on PR #14710:
URL: https://github.com/apache/kafka/pull/14710#issuecomment-1816006917
Hi @lucasbru @cadonna - If you get a chance, could you take a look at the
PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/KAFKA-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787118#comment-17787118
]
Mickael Maison commented on KAFKA-15836:
This is marked as a blocker for 3.6.1.
mimaison commented on PR #14719:
URL: https://github.com/apache/kafka/pull/14719#issuecomment-1816083065
Can we now close https://issues.apache.org/jira/browse/KAFKA-15799?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
kamalcph opened a new pull request, #14787:
URL: https://github.com/apache/kafka/pull/14787
`findHighestRemoteOffset` does not take into account the leader-epoch end
offset. This can cause log divergence between the local and remote log segments
when there is unclean leader election.
kamalcph commented on code in PR #14787:
URL: https://github.com/apache/kafka/pull/14787#discussion_r1397045499
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -625,9 +626,10 @@ private void maybeUpdateCopiedOffset(UnifiedLog log)
throws RemoteStorageExcepti
clolov commented on PR #14787:
URL: https://github.com/apache/kafka/pull/14787#issuecomment-1816112742
I will aim to provide a review today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash reassigned KAFKA-14877:
Assignee: (was: Kamal Chandraprakash)
> refactor InMemoryLeaderEpochC
[
https://issues.apache.org/jira/browse/KAFKA-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield reassigned KAFKA-15836:
Assignee: Andrew Schofield (was: Kirk True)
> KafkaConsumer subscribes to multip
yashmayya commented on code in PR #14762:
URL: https://github.com/apache/kafka/pull/14762#discussion_r1397042412
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java:
##
@@ -163,6 +163,12 @@ public void initialize(TaskConfig taskConfig) {
[
https://issues.apache.org/jira/browse/KAFKA-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787128#comment-17787128
]
Andrew Schofield commented on KAFKA-15836:
--
Yes, I would say so. I think I'll h
clolov opened a new pull request, #14788:
URL: https://github.com/apache/kafka/pull/14788
With the introduction of tiered storage the ListOffsets API can now return
the earliest local timestamp.
The purpose of this pull request is to enable the Kafka tools to get this
information in
lucasbru commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1397061812
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##
@@ -52,6 +53,8 @@ public class FetchBuffer implements AutoCloseable {
pr
[
https://issues.apache.org/jira/browse/KAFKA-15851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wangliucheng updated KAFKA-15851:
-
Attachment: (was: server.log)
> broker under replicated due to error java.nio.BufferOverflow
lucasbru commented on code in PR #14779:
URL: https://github.com/apache/kafka/pull/14779#discussion_r1397125030
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1068,12 +1168,17 @@ public void onComplete(Map offsets, Exception
lucasbru commented on code in PR #14779:
URL: https://github.com/apache/kafka/pull/14779#discussion_r1397125331
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -112,6 +112,12 @@ public void testInvalidGroupId() {
a
[
https://issues.apache.org/jira/browse/KAFKA-15815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashwin Pankaj reassigned KAFKA-15815:
-
Assignee: Ashwin Pankaj
> JsonRestServer leaks sockets via HttpURLConnection when keep-
lucasbru commented on code in PR #14779:
URL: https://github.com/apache/kafka/pull/14779#discussion_r1397139312
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1102,46 +1207,94 @@ public void subscribe(Pattern pattern,
Consum
cadonna commented on code in PR #13932:
URL: https://github.com/apache/kafka/pull/13932#discussion_r1396975782
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java:
##
@@ -125,11 +122,11 @@ public class ProcessorStateManagerTest {
cadonna commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1397154783
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##
@@ -52,6 +53,8 @@ public class FetchBuffer implements AutoCloseable {
pri
cadonna commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1397156239
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##
@@ -185,6 +188,16 @@ void awaitNotEmpty(Timer timer) {
}
}
+
dajac merged PR #14785:
URL: https://github.com/apache/kafka/pull/14785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-15849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15849.
-
Fix Version/s: 3.7.0
Reviewer: David Jacot
Resolution: Fixed
> Fix ListGroups AP
[
https://issues.apache.org/jira/browse/KAFKA-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787193#comment-17787193
]
Zihao Lin commented on KAFKA-14507:
---
Hi team, If this ticket is open I will pick it up
[
https://issues.apache.org/jira/browse/KAFKA-15799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15799:
-
Fix Version/s: 3.7.0
> ZK brokers incorrectly handle KRaft metadata snapshots
>
Owen-CH-Leung commented on PR #14136:
URL: https://github.com/apache/kafka/pull/14136#issuecomment-1816419916
@kamalcph
Thanks. Just rebased.
Btw when I rebased, I notice that there's a failing test
`kafka.server.AssignmentsManagerTest.testAssignmentAggregation` at trunk. May
mumrah commented on PR #14719:
URL: https://github.com/apache/kafka/pull/14719#issuecomment-1816420476
@mimaison yup, I closed it just now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Owen-CH-Leung commented on PR #14645:
URL: https://github.com/apache/kafka/pull/14645#issuecomment-1816422275
@divijvaidya shall we merge this PR ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/KAFKA-15793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787216#comment-17787216
]
Mickael Maison commented on KAFKA-15793:
Since KAFKA-15799 is now done, marking
[
https://issues.apache.org/jira/browse/KAFKA-15793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-15793.
Resolution: Fixed
> Flaky test ZkMigrationIntegrationTest.testMigrateTopicDeletions
>
[
https://issues.apache.org/jira/browse/KAFKA-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787217#comment-17787217
]
Mickael Maison commented on KAFKA-15836:
Awesome, thanks [~schofielaj]
> Kafka
lucasbru commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1397321134
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -180,6 +180,18 @@ public void maybeAutoCommit(final Map offsets
AndrewJSchofield opened a new pull request, #14789:
URL: https://github.com/apache/kafka/pull/14789
When returning fetched records, the code was not properly honouring
`max.poll.records`.
When it had fetched records for multiple topic-partitions, it was intended
to accumulate records up
soarez commented on PR #14737:
URL: https://github.com/apache/kafka/pull/14737#issuecomment-1816570498
Thanks for the review @cmccabe. I think I have incorporated all your
suggestions. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787243#comment-17787243
]
Andrew Schofield commented on KAFKA-15836:
--
I would say that it's not applicabl
kirktrue commented on code in PR #14789:
URL: https://github.com/apache/kafka/pull/14789#discussion_r1397472048
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -1124,6 +1126,62 @@ public void testFetchMaxPollRecords() {
asser
kirktrue commented on PR #14789:
URL: https://github.com/apache/kafka/pull/14789#issuecomment-1816615350
🤦♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
mimaison commented on PR #14759:
URL: https://github.com/apache/kafka/pull/14759#issuecomment-1816625357
Is the work complete? If so can we close
[KAFKA-15802](https://issues.apache.org/jira/browse/KAFKA-15802)?
--
This is an automated message from the Apache Git Service.
To respond to th
AndrewJSchofield commented on code in PR #14789:
URL: https://github.com/apache/kafka/pull/14789#discussion_r1397505461
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -1124,6 +1126,62 @@ public void testFetchMaxPollRecords() {
pprovenzano commented on code in PR #14737:
URL: https://github.com/apache/kafka/pull/14737#discussion_r1397547750
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -143,21 +143,30 @@ class KRaftMetadataCache(val brokerId: Int) extends
MetadataCache w
dajac commented on PR #14369:
URL: https://github.com/apache/kafka/pull/14369#issuecomment-1816721578
I've also seen `Build / JDK 8 and Scala 2.12 / testAssignmentAggregation() –
kafka.server.AssignmentsManagerTest` failing consistently in a few builds
([example](https://ci-builds.apache.or
soarez commented on code in PR #14737:
URL: https://github.com/apache/kafka/pull/14737#discussion_r1397572189
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -143,21 +143,30 @@ class KRaftMetadataCache(val brokerId: Int) extends
MetadataCache with L
dajac commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1397596576
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for the s
dajac commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1397600750
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for the s
dajac commented on code in PR #14582:
URL: https://github.com/apache/kafka/pull/14582#discussion_r1397610751
##
tests/kafkatest/tests/core/transactions_test.py:
##
@@ -246,8 +246,9 @@ def setup_topics(self):
@matrix(failure_mode=["hard_bounce", "clean_bounce"],
dajac commented on code in PR #14432:
URL: https://github.com/apache/kafka/pull/14432#discussion_r1397287511
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -829,21 +902,50 @@ private
CoordinatorResult consumerGr
OmniaGM opened a new pull request, #14790:
URL: https://github.com/apache/kafka/pull/14790
- Extend the ReplicaAlterLogDirsThread to send an
AssignReplicasToDirsRequestData RPC before promoting the future replica in JBOD
mode with KRAFT.
- Extend AssignmentsManager and DirectoryEventHan
cadonna opened a new pull request, #14791:
URL: https://github.com/apache/kafka/pull/14791
The state updater waits on a condition variable if no tasks exist that need
to be updated. The condition variable is wrapped by a loop to account for
spurious wake-ups. The check whether updating task
[
https://issues.apache.org/jira/browse/KAFKA-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim reassigned KAFKA-15365:
-
Assignee: Omnia Ibrahim
> Broker-side replica management changes
>
mumrah opened a new pull request, #14792:
URL: https://github.com/apache/kafka/pull/14792
We already capture the ZK dual write timings as metrics. This patch includes
those timings in the existing log messages.
--
This is an automated message from the Apache Git Service.
To respond to the
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1397683148
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
gharris1727 commented on PR #14762:
URL: https://github.com/apache/kafka/pull/14762#issuecomment-1816905171
> What was the conclusion here? Is triggering wakeup on a separate thread
(through WorkerSinkTask::stop) before also eventually closing the consumer on a
separate thread (through Work
kehuum opened a new pull request, #14793:
URL: https://github.com/apache/kafka/pull/14793
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
This pr sets registerWat
kehuum closed pull request #14793: [LI-HOTFIX] Enable register watch when
getting children for federated topic namespaces
URL: https://github.com/apache/kafka/pull/14793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
AndrewJSchofield commented on PR #14789:
URL: https://github.com/apache/kafka/pull/14789#issuecomment-1816929338
Test failures reviewed and unrelated to the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397714746
##
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##
@@ -60,17 +62,47 @@ public PushTelemetryRequest(PushTelemetryRequestData data,
s
lihaosky commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1397715022
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -104,20 +103,16 @@ public void init(final ProcessorContext context)
apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397795152
##
core/src/main/java/kafka/metrics/ClientMetricsReceiverPlugin.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397714746
##
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##
@@ -60,17 +62,47 @@ public PushTelemetryRequest(PushTelemetryRequestData data,
s
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397714746
##
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##
@@ -60,17 +62,47 @@ public PushTelemetryRequest(PushTelemetryRequestData data,
s
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397714746
##
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##
@@ -60,17 +62,47 @@ public PushTelemetryRequest(PushTelemetryRequestData data,
s
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1397839267
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
soarez opened a new pull request, #14794:
URL: https://github.com/apache/kafka/pull/14794
Building AssignReplicasToDirsRequestData relies on iteration over Map
entries, which can result in different sorting order. The order does not matter
to the semantics of the request, but it can cause i
soarez commented on PR #14794:
URL: https://github.com/apache/kafka/pull/14794#issuecomment-1817065152
@dajac please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397871398
##
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##
@@ -60,17 +62,47 @@ public PushTelemetryRequest(PushTelemetryRequestData
apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397873419
##
core/src/main/java/kafka/metrics/ClientMetricsReceiverPlugin.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397875576
##
core/src/test/java/kafka/metrics/ClientMetricsInstanceTest.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
apoorvmittal10 commented on PR #14699:
URL: https://github.com/apache/kafka/pull/14699#issuecomment-1817091571
Thanks @junrao for leaving the comments, I have tried to address them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1397895468
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software Foundation (A
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1397895468
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software Foundation (A
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1397751986
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -30,17 +69,376 @@ public class ClientMetricsManager implements Closeable {
private static fina
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1397923196
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software Foundation (A
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1397982732
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreFactory.java:
##
@@ -66,6 +66,10 @@ default void configure(final StreamsConfig config) {
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1397987652
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedStoreFactory.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Fou
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1397992729
##
streams/src/main/java/org/apache/kafka/streams/state/BuiltInDslStoreSuppliers.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398002400
##
streams/src/main/java/org/apache/kafka/streams/state/BuiltInDslStoreSuppliers.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398002738
##
streams/src/main/java/org/apache/kafka/streams/state/DslSessionParams.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398003330
##
streams/src/main/java/org/apache/kafka/streams/state/DslSessionParams.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398003882
##
streams/src/main/java/org/apache/kafka/streams/state/DslStoreSuppliers.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398004582
##
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398005349
##
streams/src/main/java/org/apache/kafka/streams/state/DslWindowParams.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398006947
##
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##
@@ -1038,13 +1038,15 @@ public void
shouldThrowConfigExceptionWhenOptimizationConfigN
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1398012157
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software
gharris1727 opened a new pull request, #14795:
URL: https://github.com/apache/kafka/pull/14795
Jenkins truncates stdout/stderr from tests which exceed 100,000 bytes. This
truncation is computed once per-suite, meaning that each suite gets a 100kb
budget for logs, and suites that log too muc
jolshan commented on code in PR #14789:
URL: https://github.com/apache/kafka/pull/14789#discussion_r1398026217
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -1124,6 +1126,62 @@ public void testFetchMaxPollRecords() {
assert
jolshan commented on code in PR #14789:
URL: https://github.com/apache/kafka/pull/14789#discussion_r1398026217
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -1124,6 +1126,62 @@ public void testFetchMaxPollRecords() {
assert
jolshan commented on code in PR #14789:
URL: https://github.com/apache/kafka/pull/14789#discussion_r1398026217
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -1124,6 +1126,62 @@ public void testFetchMaxPollRecords() {
assert
hanyuzheng7 commented on PR #14570:
URL: https://github.com/apache/kafka/pull/14570#issuecomment-1817349035
@mjsax I have already updated the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
philipnee commented on PR #14680:
URL: https://github.com/apache/kafka/pull/14680#issuecomment-1817393641
Thanks @lucasbru
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
divijvaidya commented on PR #14788:
URL: https://github.com/apache/kafka/pull/14788#issuecomment-1817397316
This is a public facing change. Is this part of a KIP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
96 matches
Mail list logo
