Re: [PR] MINOR: Fix toString method of IsolationLevel [kafka]

2024-01-03 Thread via GitHub
ashwinpankaj commented on code in PR #14782: URL: https://github.com/apache/kafka/pull/14782#discussion_r1441389074 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java: ## @@ -234,7 +233,7 @@ public void start() { throw new ConnectExcep

[jira] [Commented] (KAFKA-16055) Thread unsafe use of HashMap stored in QueryableStoreProvider#storeProviders

2024-01-03 Thread Kohei Nozaki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802401#comment-17802401 ] Kohei Nozaki commented on KAFKA-16055: -- Pull request: [https://github.com/apache/ka

[PR] KAFKA-16055: Thread unsafe use of HashMap stored in QueryableStoreProvider#storeProviders [kafka]

2024-01-03 Thread via GitHub
nuzayats opened a new pull request, #15121: URL: https://github.com/apache/kafka/pull/15121 This PR replaces a HashMap by a ConcurrentHashMap so that the local state store queries can be made from multiple threads. This is based on a discussion in the kafka-users mailing list. See this for

Re: [PR] KAFKA-16072: JUnit 5 extension to detect thread leak [kafka]

2024-01-03 Thread via GitHub
ashwinpankaj commented on code in PR #15101: URL: https://github.com/apache/kafka/pull/15101#discussion_r1441364275 ## core/src/test/java/kafka/test/junit/LeakTestingExtension.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15388: Handling remote segment read in case of log compaction [kafka]

2024-01-03 Thread via GitHub
iit2009060 commented on PR #15060: URL: https://github.com/apache/kafka/pull/15060#issuecomment-1876338999 > Thanks @iit2009060 for the PR. > > Let us say there are two segments in remote storage and subsequents segments in local storage. remote-seg-10[10, 20], remote-seg-21[21, 30] :

[jira] [Comment Edited] (KAFKA-16073) Kafka Tiered Storage Bug: Consumer Fetch Error Due to Delayed localLogStartOffset Update During Segment Deletion

2024-01-03 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802024#comment-17802024 ] Satish Duggana edited comment on KAFKA-16073 at 1/4/24 3:50 AM: --

Re: [PR] MINOR: Fixed typos in docker readme documentation [kafka]

2024-01-03 Thread via GitHub
showuon merged PR #15120: URL: https://github.com/apache/kafka/pull/15120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16074: close leaking threads in replica manager tests [kafka]

2024-01-03 Thread via GitHub
showuon commented on PR #15077: URL: https://github.com/apache/kafka/pull/15077#issuecomment-1876239029 @satishd , please take another look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-15373: fix exception thrown in Admin#describeTopics for unknown ID [kafka]

2024-01-03 Thread via GitHub
jolshan merged PR #14599: URL: https://github.com/apache/kafka/pull/14599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2024-01-03 Thread via GitHub
Phuc-Hong-Tran commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-1876148310 I understand, will get another PR out ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-01-03 Thread via GitHub
tinaselenge commented on code in PR #14995: URL: https://github.com/apache/kafka/pull/14995#discussion_r1441077572 ## clients/src/test/java/org/apache/kafka/common/config/provider/FileConfigProviderTest.java: ## @@ -98,8 +117,91 @@ public void testServiceLoaderDiscovery() {

[jira] [Updated] (KAFKA-15467) Kafka broker returns offset out of range for topic/partitions on restart from unclean shutdown

2024-01-03 Thread Steve Jacobs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Jacobs updated KAFKA-15467: - Component/s: log > Kafka broker returns offset out of range for topic/partitions on restart from

Re: [PR] KAFKA-16067 Refactoring ConsumerGroupListing + add test [kafka]

2024-01-03 Thread via GitHub
hachikuji commented on code in PR #15092: URL: https://github.com/apache/kafka/pull/15092#discussion_r1441070583 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java: ## @@ -104,8 +104,8 @@ public boolean equals(Object obj) { return fals

[jira] [Updated] (KAFKA-15467) Kafka broker returns offset out of range for topic/partitions on restart from unclean shutdown

2024-01-03 Thread Steve Jacobs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Jacobs updated KAFKA-15467: - Component/s: core > Kafka broker returns offset out of range for topic/partitions on restart fro

Re: [PR] KAFKA-16067 Refactoring ConsumerGroupListing + add test [kafka]

2024-01-03 Thread via GitHub
hachikuji commented on code in PR #15092: URL: https://github.com/apache/kafka/pull/15092#discussion_r1441070183 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListingTest.java: ## @@ -0,0 +1,27 @@ +package org.apache.kafka.clients.admin; Review Comment:

[jira] [Closed] (KAFKA-10133) Cannot compress messages in destination cluster with MM2

2024-01-03 Thread Steve Jacobs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Jacobs closed KAFKA-10133. > Cannot compress messages in destination cluster with MM2 > -

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2024-01-03 Thread via GitHub
jolshan commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r1441068240 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -749,9 +749,11 @@ class ReplicaManager(val config: KafkaConfig, * @param responseCallback

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2024-01-03 Thread via GitHub
jolshan commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r1441066328 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -749,9 +749,11 @@ class ReplicaManager(val config: KafkaConfig, * @param responseCallback

Re: [PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2024-01-03 Thread via GitHub
hachikuji commented on code in PR #15087: URL: https://github.com/apache/kafka/pull/15087#discussion_r1441051073 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -749,9 +749,11 @@ class ReplicaManager(val config: KafkaConfig, * @param responseCallback

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-01-03 Thread via GitHub
tinaselenge commented on PR #14995: URL: https://github.com/apache/kafka/pull/14995#issuecomment-1876030053 > Thanks for the PR. I made a second quick pass and left a few more comments. @mimaison Thank you very much for reviewing the PR again. I think I addressed your comments except

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-01-03 Thread via GitHub
tinaselenge commented on PR #14995: URL: https://github.com/apache/kafka/pull/14995#issuecomment-1876028036 > I came up with another path traversal, but this one is less severe. > > If you try to get `/arbitrary/path/../..//dir/dirFile` you can perform "exists" and "isDirectory" check

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-01-03 Thread via GitHub
tinaselenge commented on code in PR #14995: URL: https://github.com/apache/kafka/pull/14995#discussion_r1440996476 ## clients/src/test/java/org/apache/kafka/common/config/provider/FileConfigProviderTest.java: ## @@ -98,8 +117,91 @@ public void testServiceLoaderDiscovery() {

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-01-03 Thread via GitHub
tinaselenge commented on code in PR #14995: URL: https://github.com/apache/kafka/pull/14995#discussion_r1440994447 ## clients/src/main/java/org/apache/kafka/common/config/provider/FileConfigProvider.java: ## @@ -40,7 +44,21 @@ public class FileConfigProvider implements ConfigPro

[PR] MINOR: Fixed typos in docker readme documentation [kafka]

2024-01-03 Thread via GitHub
kumarlokesh opened a new pull request, #15120: URL: https://github.com/apache/kafka/pull/15120 Fixed minor typos in `docker/README` documentation. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a sep

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

2024-01-03 Thread via GitHub
mumrah commented on PR #15118: URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875988796 All production usages now call `latestProduction` and test usages (including benchmark classes) call `latestTesting. One exception is is `QuorumFeatures#defaultFeatureMap(boolean enableUns

Re: [PR] KAFKA-16072: JUnit 5 extension to detect thread leak [kafka]

2024-01-03 Thread via GitHub
gharris1727 commented on code in PR #15101: URL: https://github.com/apache/kafka/pull/15101#discussion_r1440917179 ## core/src/test/java/kafka/test/junit/LeakTestingExtension.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16072: JUnit 5 extension to detect thread leak [kafka]

2024-01-03 Thread via GitHub
divijvaidya commented on code in PR #15101: URL: https://github.com/apache/kafka/pull/15101#discussion_r1440893773 ## core/src/test/java/kafka/test/junit/LeakTestingExtension.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

2024-01-03 Thread via GitHub
cmccabe commented on PR #15118: URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875906638 Alternately, if we wanted to make this literally impossible to invoke from a non-test context, we could move `MetadataVersion.latest` into `MetadataVersionTest.latest`. The downsid

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

2024-01-03 Thread via GitHub
cmccabe commented on PR #15118: URL: https://github.com/apache/kafka/pull/15118#issuecomment-1875904378 I agree with @ijuma that just having a boolean isn't very clear. How about renaming `MetadataVersion.latest()` to `MetadataVersion.latestTesting()`, and then creating a separate fun

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

2024-01-03 Thread via GitHub
ijuma commented on code in PR #15118: URL: https://github.com/apache/kafka/pull/15118#discussion_r1440881725 ## core/src/main/java/kafka/server/builders/LogManagerBuilder.java: ## @@ -48,7 +48,7 @@ public class LogManagerBuilder { private int maxTransactionTimeoutMs = 15 *

[PR] MINOR: Move Raft io thread implementation to Java [kafka]

2024-01-03 Thread via GitHub
hachikuji opened a new pull request, #15119: URL: https://github.com/apache/kafka/pull/15119 This patch moves the `RaftIOThread` implementation into Java. I changed the name to `KafkaRaftClientDriver` since the main thing it does is drive the calls to `poll()`. There shouldn't be any change

[PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

2024-01-03 Thread via GitHub
mumrah opened a new pull request, #15118: URL: https://github.com/apache/kafka/pull/15118 This patch introduces a boolean flag to MetadataVersion#latest which controls whether or not "unstable" MetadataVersions can be returned. For testing purposes, we want to be able to automatically pick

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-03 Thread via GitHub
philipnee commented on PR #15000: URL: https://github.com/apache/kafka/pull/15000#issuecomment-1875876548 hi @lucasbru - i think we might need to loosen the thread access restriction for the interceptor because i think we also need to trigger interceptors during autocommit. There are 2 way

Re: [PR] KAFKA-16025: Fix orphaned locks when rebalancing and store cleanup race on unassigned task directories [kafka]

2024-01-03 Thread via GitHub
sanepal commented on code in PR #15088: URL: https://github.com/apache/kafka/pull/15088#discussion_r1440860832 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1229,10 +1229,21 @@ private void tryToLockAllNonEmptyTaskDirectories() {

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2024-01-03 Thread via GitHub
philipnee commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-1875867893 hi @Phuc-Hong-Tran - yes, the abstractFetch implementation is based on the LegacyKafkaConsumer and therefore requires connection probing. We don't need that in the AsyncKafkaConsumer a

[jira] [Commented] (KAFKA-16078) InterBrokerProtocolVersion defaults to non-production MetadataVersion

2024-01-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802308#comment-17802308 ] Justine Olshan commented on KAFKA-16078: We should really get to writing the KIP

[jira] [Created] (KAFKA-16078) InterBrokerProtocolVersion defaults to non-production MetadataVersion

2024-01-03 Thread David Arthur (Jira)
David Arthur created KAFKA-16078: Summary: InterBrokerProtocolVersion defaults to non-production MetadataVersion Key: KAFKA-16078 URL: https://issues.apache.org/jira/browse/KAFKA-16078 Project: Kafka

[PR] KAFKA-16077: Streams fails to close task after restoration [kafka]

2024-01-03 Thread via GitHub
lucasbru opened a new pull request, #15117: URL: https://github.com/apache/kafka/pull/15117 Streams fails to close task after restoration when input partitions are updated in a new assignment happening at the same time. There is a race condition in the state updater that can cause the

[jira] [Updated] (KAFKA-16077) Streams fails to close task after restoration when input partitions are updated

2024-01-03 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-16077: --- Summary: Streams fails to close task after restoration when input partitions are updated (w

[jira] [Created] (KAFKA-16077) State updater fails to close task when input partitions are updated

2024-01-03 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-16077: -- Summary: State updater fails to close task when input partitions are updated Key: KAFKA-16077 URL: https://issues.apache.org/jira/browse/KAFKA-16077 Project: Kafk

[jira] [Updated] (KAFKA-16077) State updater fails to close task when input partitions are updated

2024-01-03 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-16077: --- Description: There is a race condition in the state updater that can cause the following: #

Re: [PR] KAFKA-16070: Extract the setReadOnly method into Headers [kafka]

2024-01-03 Thread via GitHub
hachikuji commented on PR #15113: URL: https://github.com/apache/kafka/pull/15113#issuecomment-1875758227 Closing as a duplicate of #15097 . Please reopen if mistaken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-16070: Extract the setReadOnly method into Headers [kafka]

2024-01-03 Thread via GitHub
hachikuji closed pull request #15113: KAFKA-16070: Extract the setReadOnly method into Headers URL: https://github.com/apache/kafka/pull/15113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-16070: move setReadOnly to Headers [kafka]

2024-01-03 Thread via GitHub
hachikuji commented on code in PR #15097: URL: https://github.com/apache/kafka/pull/15097#discussion_r1440744523 ## clients/src/main/java/org/apache/kafka/common/header/Headers.java: ## @@ -69,4 +69,10 @@ public interface Headers extends Iterable { */ Header[] toArray

Re: [PR] MINOR: Add reviewers GitHub action [kafka]

2024-01-03 Thread via GitHub
divijvaidya commented on code in PR #15115: URL: https://github.com/apache/kafka/pull/15115#discussion_r1440702318 ## .github/workflows/pr_reviews.yml: ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. S

Re: [PR] MINOR: Bump year to 2024 in NOTICE file [kafka]

2024-01-03 Thread via GitHub
stanislavkozlovski commented on PR #15111: URL: https://github.com/apache/kafka/pull/15111#issuecomment-1875709048 cherry-picked to 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] MINOR: Bump year to 2024 in NOTICE file [kafka]

2024-01-03 Thread via GitHub
stanislavkozlovski merged PR #15111: URL: https://github.com/apache/kafka/pull/15111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@ka

Re: [PR] MINOR: Add reviewers GitHub action [kafka]

2024-01-03 Thread via GitHub
mumrah commented on PR #15115: URL: https://github.com/apache/kafka/pull/15115#issuecomment-1875698491 Thanks @viktorsomogyi, this is a nice little automation. Does this script edit the commit or just the PR body? -- This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (KAFKA-15742) KRaft support in GroupCoordinatorIntegrationTest

2024-01-03 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Werner updated KAFKA-15742: -- Fix Version/s: 3.8.0 > KRaft support in GroupCoordinatorIntegrationTest >

Re: [PR] KAFKA-15742: KRaft support in GroupCoordinatorIntegrationTest [kafka]

2024-01-03 Thread via GitHub
jolshan merged PR #15086: URL: https://github.com/apache/kafka/pull/15086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16072: JUnit 5 extension to detect thread leak [kafka]

2024-01-03 Thread via GitHub
gharris1727 commented on PR #15101: URL: https://github.com/apache/kafka/pull/15101#issuecomment-1875661177 > It might be worth adding more names to the set of expected thread names. I think increasing the scope of this assertion by adding patterns/removing the pattern check/applying

Re: [PR] KAFKA-16072: JUnit 5 extension to detect thread leak [kafka]

2024-01-03 Thread via GitHub
gharris1727 commented on code in PR #15101: URL: https://github.com/apache/kafka/pull/15101#discussion_r1440661862 ## core/src/test/java/kafka/test/junit/LeakTestingExtension.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-16051: Fixed deadlock in StandaloneHerder [kafka]

2024-01-03 Thread via GitHub
gharris1727 commented on PR #15080: URL: https://github.com/apache/kafka/pull/15080#issuecomment-1875639893 > just invoking methods in order is not enough to trigger the deadlock. I believe it is possible to reliably reproduce the deadlock with two countdown latches, one countdown in the Co

[jira] [Commented] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2024-01-03 Thread Hugo Abreu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802246#comment-17802246 ] Hugo Abreu commented on KAFKA-10875: Hello! After some digging around the code it s

[jira] [Updated] (KAFKA-10875) offsetsForTimes returns null for some partitions when it shouldn't?

2024-01-03 Thread Hugo Abreu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hugo Abreu updated KAFKA-10875: --- Attachment: image-2024-01-03-16-14-10-246.png > offsetsForTimes returns null for some partitions whe

Re: [PR] MINOR: Add reviewers GitHub action [kafka]

2024-01-03 Thread via GitHub
viktorsomogyi commented on PR #15115: URL: https://github.com/apache/kafka/pull/15115#issuecomment-1875609641 One more thing is that the current script places the "Reviewers:" section after "Committer checklist" so it's not automatically included in the merge template. I'll see if that can

[jira] [Commented] (KAFKA-15147) Measure pending and outstanding Remote Segment operations

2024-01-03 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802238#comment-17802238 ] Christo Lolov commented on KAFKA-15147: --- Heya [~enether], after a very quick searc

Re: [PR] KAFKA-14133: Migrate storeMetadata mock in StoreChangelogReaderTest to Mockito [kafka]

2024-01-03 Thread via GitHub
clolov commented on code in PR #15116: URL: https://github.com/apache/kafka/pull/15116#discussion_r1440615357 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java: ## @@ -453,17 +456,17 @@ private void shouldPollWithRightTimeout(fin

[PR] KAFKA-14133: Migrate storeMetadata mock in StoreChangelogReaderTest to Mockito [kafka]

2024-01-03 Thread via GitHub
clolov opened a new pull request, #15116: URL: https://github.com/apache/kafka/pull/15116 This pull request takes a similar approach to how TaskManagerTest is being migrated to Mockito mock by mock for easier reviews. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MINOR: Add reviewers GitHub action [kafka]

2024-01-03 Thread via GitHub
viktorsomogyi commented on PR #15115: URL: https://github.com/apache/kafka/pull/15115#issuecomment-1875576165 One caveat with the "Name \" format is that \<\> is markup syntax and means superscript. This doesn't work however in case of emails, so Github will just display "Name name@email",

[PR] MINOR: Add reviewers GitHub action [kafka]

2024-01-03 Thread via GitHub
viktorsomogyi opened a new pull request, #15115: URL: https://github.com/apache/kafka/pull/15115 This PR adds a github action that is triggered when a GitHub review is submitted. The action does the following: - if there is no "Reviewers" line at the end of the description, then appen

Re: [PR] Test2 [kafka]

2024-01-03 Thread via GitHub
viktorsomogyi closed pull request #15114: Test2 URL: https://github.com/apache/kafka/pull/15114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-uns

Re: [PR] Test2 [kafka]

2024-01-03 Thread via GitHub
viktorsomogyi commented on PR #15114: URL: https://github.com/apache/kafka/pull/15114#issuecomment-1875553120 Meant to create this in my repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Test2 [kafka]

2024-01-03 Thread via GitHub
viktorsomogyi opened a new pull request, #15114: URL: https://github.com/apache/kafka/pull/15114 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

Re: [PR] KAFKA-14133: Migrate consumer mock in TaskManagerTest to Mockito [kafka]

2024-01-03 Thread via GitHub
clolov commented on code in PR #15112: URL: https://github.com/apache/kafka/pull/15112#discussion_r1440569384 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -197,6 +196,8 @@ public class TaskManagerTest { @Mock(type = MockT

[PR] KAFKA-16070: extract the setReadOnly method into Headers [kafka]

2024-01-03 Thread via GitHub
Joker-5 opened a new pull request, #15113: URL: https://github.com/apache/kafka/pull/15113 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* TODO unit tests.

[PR] KAFKA-14133: Migrate consumer mock in TaskManagerTest to Mockito [kafka]

2024-01-03 Thread via GitHub
clolov opened a new pull request, #15112: URL: https://github.com/apache/kafka/pull/15112 This pull request migrates the consumer mock in TaskManagerTest test by test for easier reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Prevent java.lang.UnsupportedOperationException in MockAdminClient [kafka]

2024-01-03 Thread via GitHub
jamespfaulkner commented on PR #14955: URL: https://github.com/apache/kafka/pull/14955#issuecomment-1875517539 > Looks good! Out of curiosity, do you happen to know tests which are failing with this UnsupportedOperationException? Ah, sorry I missed this question first time round. I ha

Re: [PR] MINOR: Enable Gradle Remote Build Cache [kafka]

2024-01-03 Thread via GitHub
divijvaidya commented on PR #15109: URL: https://github.com/apache/kafka/pull/15109#issuecomment-1875475685 https://github.com/apache/beam/pull/27015 is not Apache Beam enabled this. Seems like we need to request a build node from Apache Infra and change our jenkins to pick up creds similar

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2024-01-03 Thread via GitHub
Phuc-Hong-Tran commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-1875430964 @philipnee, when you said I should "rethink" about the approach, did you mean I should change the approach or I can just fix the code where you commented? -- This is an automat

Re: [PR] MINOR: Enable Gradle Remote Build Cache [kafka]

2024-01-03 Thread via GitHub
nicktelford commented on PR #15109: URL: https://github.com/apache/kafka/pull/15109#issuecomment-1875405401 Looks like Jenkins doesn't have permission (by default at least) to write entries to the ASF Gradle Enterprise Build Cache: ``` Could not store entry 744bd685bdd1d149ec93934b276b

Re: [PR] MINOR: Enable Gradle Remote Build Cache [kafka]

2024-01-03 Thread via GitHub
nicktelford commented on PR #15109: URL: https://github.com/apache/kafka/pull/15109#issuecomment-1875356669 @ijuma I've temporarily reconfigured it to enable the cache for this branch (`gradle-remote-build-cache`) instead of `trunk`, so we can test that it works as expected using the CI bui

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-03 Thread via GitHub
nicktelford commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1875335559 @lucasbru OK, my bad. It turns out I did a minor refactoring _after_ I ran the test suite yesterday that was so insignificant I didn't think I needed to run the tests again... Turns o

[jira] [Commented] (KAFKA-15867) Should ConsumerNetworkThread wrap the exception and notify the polling thread?

2024-01-03 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802158#comment-17802158 ] Phuc Hong Tran commented on KAFKA-15867: [~pnee] I happened to come across this

Re: [PR] MINOR: Fix toString method of IsolationLevel [kafka]

2024-01-03 Thread via GitHub
PzaThief commented on PR #14782: URL: https://github.com/apache/kafka/pull/14782#issuecomment-1875332142 > Build failed again -- can you maybe rebase this PR on `trunk` to ensure it's on the latest version. Sorry for missed it. Can you please retrigger it? -- This is an automated m

Re: [PR] KAFKA-16051: Fixed deadlock in StandaloneHerder [kafka]

2024-01-03 Thread via GitHub
developster commented on PR #15080: URL: https://github.com/apache/kafka/pull/15080#issuecomment-1875320392 @gharris1727 , sure. I wrote the test but just invoking methods in order is not enough to trigger the deadlock. The requestTaskReconfiguration method is always executed before putConn

Re: [PR] MINOR: Fix toString method of IsolationLevel [kafka]

2024-01-03 Thread via GitHub
mjsax commented on PR #14782: URL: https://github.com/apache/kafka/pull/14782#issuecomment-1875305566 Build failed again -- can you maybe rebase this PR on `trunk` to ensure it's on the latest version. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] MINOR: Prevent java.lang.UnsupportedOperationException in MockAdminClient [kafka]

2024-01-03 Thread via GitHub
vamossagar12 commented on PR #14955: URL: https://github.com/apache/kafka/pull/14955#issuecomment-1875226073 > Looks good! Out of curiosity, do you happen to know tests which are failing with this UnsupportedOperationException? yeah even I was interested to know this. -- This is an

Re: [PR] KAFKA-16016: Add docker wrapper in core and remove docker utility script [kafka]

2024-01-03 Thread via GitHub
viktorsomogyi commented on code in PR #15048: URL: https://github.com/apache/kafka/pull/15048#discussion_r1440302423 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] MINOR: Improve code style about producer [kafka]

2024-01-03 Thread via GitHub
divijvaidya merged PR #15107: URL: https://github.com/apache/kafka/pull/15107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-15816: Fix leaked sockets in trogdor tests [kafka]

2024-01-03 Thread via GitHub
divijvaidya merged PR #14771: URL: https://github.com/apache/kafka/pull/14771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-15816: Fix leaked sockets in trogdor tests [kafka]

2024-01-03 Thread via GitHub
divijvaidya commented on PR #14771: URL: https://github.com/apache/kafka/pull/14771#issuecomment-1875169735 The test modified in this PR is successful - https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14771/4/testReport/org.apache.kafka.trogdor.agent/ -- This is an automated me

Re: [PR] KAFKA-14483 Move/Rewrite of LocalLog to storage module. [kafka]

2024-01-03 Thread via GitHub
satishd commented on code in PR #14034: URL: https://github.com/apache/kafka/pull/14034#discussion_r1440285636 ## storage/src/main/java/org/apache/kafka/storage/internals/log/SegmentDeletionReason.java: ## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14483 Move/Rewrite of LocalLog to storage module. [kafka]

2024-01-03 Thread via GitHub
satishd commented on code in PR #14034: URL: https://github.com/apache/kafka/pull/14034#discussion_r1440207191 ## storage/src/main/java/org/apache/kafka/storage/internals/log/SegmentDeletionReason.java: ## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14483 Move/Rewrite of LocalLog to storage module. [kafka]

2024-01-03 Thread via GitHub
satishd commented on code in PR #14034: URL: https://github.com/apache/kafka/pull/14034#discussion_r1440207191 ## storage/src/main/java/org/apache/kafka/storage/internals/log/SegmentDeletionReason.java: ## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Increase parallelism for Jenkins [kafka]

2024-01-03 Thread via GitHub
divijvaidya commented on PR #15099: URL: https://github.com/apache/kafka/pull/15099#issuecomment-1875126583 > @divijvaidya did you accidentally include the KafkaApisTest change here? Hi @jolshan No, it was intentional since it wasn't merged to trunk at that time. Note that this is

[jira] [Comment Edited] (KAFKA-16073) Kafka Tiered Storage Bug: Consumer Fetch Error Due to Delayed localLogStartOffset Update During Segment Deletion

2024-01-03 Thread hzh0425 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802095#comment-17802095 ] hzh0425 edited comment on KAFKA-16073 at 1/3/24 9:54 AM: - Yes, t

[jira] [Comment Edited] (KAFKA-16073) Kafka Tiered Storage Bug: Consumer Fetch Error Due to Delayed localLogStartOffset Update During Segment Deletion

2024-01-03 Thread hzh0425 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802095#comment-17802095 ] hzh0425 edited comment on KAFKA-16073 at 1/3/24 9:54 AM: - Yes, t

[jira] [Commented] (KAFKA-16073) Kafka Tiered Storage Bug: Consumer Fetch Error Due to Delayed localLogStartOffset Update During Segment Deletion

2024-01-03 Thread hzh0425 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802095#comment-17802095 ] hzh0425 commented on KAFKA-16073: - Yes, this is another good solution, localLogStartOffs

[jira] [Commented] (KAFKA-16046) Stream Stream Joins fail after restoration with deserialization exceptions

2024-01-03 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802093#comment-17802093 ] Stanislav Kozlovski commented on KAFKA-16046: - resolving since it was merged

[jira] [Resolved] (KAFKA-16046) Stream Stream Joins fail after restoration with deserialization exceptions

2024-01-03 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski resolved KAFKA-16046. - Resolution: Fixed > Stream Stream Joins fail after restoration with deserializat

Re: [PR] MINOR: Bump year to 2024 in NOTICE file [kafka]

2024-01-03 Thread via GitHub
stanislavkozlovski commented on code in PR #15111: URL: https://github.com/apache/kafka/pull/15111#discussion_r1440235165 ## NOTICE: ## @@ -20,4 +20,4 @@ clients/src/main/java/org/apache/kafka/common/utils/PureJavaCrc32C.java Some portions of this file Copyright (c) 2004-2006

[PR] MINOR: Bump year to 2024 in NOTICE file [kafka]

2024-01-03 Thread via GitHub
stanislavkozlovski opened a new pull request, #15111: URL: https://github.com/apache/kafka/pull/15111 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-03 Thread via GitHub
lucasbru commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1875033002 @nicktelford I'll rerun it. That being said, the last jobs on trunk have all finished within 3-5 hours, so this must be caused by either infrastructure or the code in this PR. -- This

Re: [PR] KAFKA-15344: Commit leader epoch where possible [kafka]

2024-01-03 Thread via GitHub
lucasbru commented on PR #14454: URL: https://github.com/apache/kafka/pull/14454#issuecomment-1875029211 @mjsax Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-03 Thread via GitHub
lucasbru commented on PR #15000: URL: https://github.com/apache/kafka/pull/15000#issuecomment-1875025923 @philipnee could you take a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-03 Thread via GitHub
nicktelford commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1875025617 @lucasbru I think this is just the CI causing trouble again. The build passes locally. Is there a way to rerun the build without pushing more commits? -- This is an automated messag

Re: [PR] KAFKA-16072: JUnit 5 extension to detect thread leak [kafka]

2024-01-03 Thread via GitHub
wernerdv commented on PR #15101: URL: https://github.com/apache/kafka/pull/15101#issuecomment-1875025332 @gharris1727 @ashwinpankaj I've updated the utility to check for leaked threads relative to threads created before the test. This looks more correct. It might be worth adding

Re: [PR] KAFKA-14412: Decouple RocksDB access from CF [kafka]

2024-01-03 Thread via GitHub
lucasbru commented on PR #15105: URL: https://github.com/apache/kafka/pull/15105#issuecomment-1875023389 @nicktelford Seems like all build jobs timed out. Could you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-14133: Migrate activeStateManager and standbyStateManager mocks in StoreChangelogReaderTest to Mockito [kafka]

2024-01-03 Thread via GitHub
lucasbru merged PR #15106: URL: https://github.com/apache/kafka/pull/15106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

  1   2   >