ppatierno commented on code in PR #15287:
URL: https://github.com/apache/kafka/pull/15287#discussion_r1471546758
##
docs/ops.html:
##
@@ -4045,7 +4045,7 @@ Reverting to ZooKeeper mode During the Migration
On each broker, remove the
apoorvmittal10 commented on code in PR #15281:
URL: https://github.com/apache/kafka/pull/15281#discussion_r1471544504
##
build.gradle:
##
@@ -303,6 +303,20 @@ subprojects {
} else {
apply plugin: 'com.github.johnrengelman.shadow'
artifact
OmniaGM commented on code in PR #15277:
URL: https://github.com/apache/kafka/pull/15277#discussion_r1471541316
##
core/src/test/scala/kafka/security/minikdc/MiniKdc.scala:
##
@@ -118,123 +96,37 @@ class MiniKdc(config: Properties, workDir: File) extends
Logging {
throw
apoorvmittal10 closed pull request #15251: KAFKA-16186: Broker metrics for
client telemetry (KIP-714)
URL: https://github.com/apache/kafka/pull/15251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1917302430
Hi @mimaison the above error was fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ijuma commented on code in PR #15281:
URL: https://github.com/apache/kafka/pull/15281#discussion_r1471437937
##
build.gradle:
##
@@ -303,6 +303,20 @@ subprojects {
} else {
apply plugin: 'com.github.johnrengelman.shadow'
artifact shadowJar
+
ijuma commented on code in PR #15281:
URL: https://github.com/apache/kafka/pull/15281#discussion_r1471436233
##
build.gradle:
##
@@ -303,6 +303,20 @@ subprojects {
} else {
apply plugin: 'com.github.johnrengelman.shadow'
artifact shadowJar
+
cadonna commented on code in PR #15261:
URL: https://github.com/apache/kafka/pull/15261#discussion_r1471396786
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -2332,19 +2335,12 @@ public void
apoorvmittal10 commented on code in PR #15281:
URL: https://github.com/apache/kafka/pull/15281#discussion_r1471432221
##
build.gradle:
##
@@ -303,6 +303,20 @@ subprojects {
} else {
apply plugin: 'com.github.johnrengelman.shadow'
artifact
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471430390
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mimaison commented on PR #15288:
URL: https://github.com/apache/kafka/pull/15288#issuecomment-1917174692
I'm happy to backport to 3.7, but pinging @stanislavkozlovski for approval
before since he's currently running the release
--
This is an automated message from the Apache Git Service.
pprovenzano commented on PR #15288:
URL: https://github.com/apache/kafka/pull/15288#issuecomment-1917157275
Can we merge this into 3.7?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on code in PR #15281:
URL: https://github.com/apache/kafka/pull/15281#discussion_r1471416481
##
build.gradle:
##
@@ -303,6 +303,20 @@ subprojects {
} else {
apply plugin: 'com.github.johnrengelman.shadow'
artifact shadowJar
+
[
https://issues.apache.org/jira/browse/KAFKA-16204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-16204.
Fix Version/s: 3.8.0
Resolution: Fixed
> Stray file
OmniaGM closed pull request #15164: KAFKA-15853: Move PasswordEncoder to server
module
URL: https://github.com/apache/kafka/pull/15164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lucasbru commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1917073495
Thanks, @philipnee. I will not get to it today, but I will review it
tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mimaison merged PR #15288:
URL: https://github.com/apache/kafka/pull/15288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jlprat commented on PR #15289:
URL: https://github.com/apache/kafka/pull/15289#issuecomment-1917022330
I agree with @mimaison, I think we should make sure the tests clean after
themselves. Right now, it seems that data within `core/data/` is deleted but
the directories are still present.
mimaison commented on PR #15289:
URL: https://github.com/apache/kafka/pull/15289#issuecomment-1917005432
Shouldn't we instead update the tests to use temp directories and cleanup
any files they create?
--
This is an automated message from the Apache Git Service.
To respond to the
ehumber opened a new pull request, #15291:
URL: https://github.com/apache/kafka/pull/15291
Similar to https://github.com/apache/kafka/pull/14877 but for 3.6
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage
dajac commented on code in PR #15271:
URL: https://github.com/apache/kafka/pull/15271#discussion_r1471273124
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1350,21 +1321,33 @@ public Map>
currentAssignment() {
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471245590
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471241531
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
OmniaGM commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1471240822
##
.gitignore:
##
@@ -35,6 +35,7 @@ Vagrantfile.local
config/server-*
config/zookeeper-*
core/data/*
+core/data2/*
Review Comment:
can't we just ignore
nizhikov commented on PR #15256:
URL: https://github.com/apache/kafka/pull/15256#issuecomment-1916886726
@showuon Thanks for review. Answered to all your comments. Please, take a
look one more time.
--
This is an automated message from the Apache Git Service.
To respond to the message,
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471235686
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471228675
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471221535
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471221535
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cadonna commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1471044772
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -874,6 +879,12 @@ public class StreamsConfig extends AbstractConfig {
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471202618
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471200818
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471198261
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471191734
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the
nizhikov commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471180248
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache Software Foundation
showuon commented on code in PR #15230:
URL: https://github.com/apache/kafka/pull/15230#discussion_r1471145483
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -563,6 +565,18 @@ class LogManager(logDirs: Seq[File],
startupWithConfigOverrides(defaultConfig,
showuon commented on code in PR #15256:
URL: https://github.com/apache/kafka/pull/15256#discussion_r1471122417
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache
jlprat commented on PR #15272:
URL: https://github.com/apache/kafka/pull/15272#issuecomment-1916746800
Rebased again to contain https://github.com/apache/kafka/pull/15290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jlprat commented on PR #15290:
URL: https://github.com/apache/kafka/pull/15290#issuecomment-1916741727
I confirmed this change fixes the broken build for Scala 2.12, hence I
merged before the CI finished.
--
This is an automated message from the Apache Git Service.
To respond to the
jlprat merged PR #15290:
URL: https://github.com/apache/kafka/pull/15290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #15290:
URL: https://github.com/apache/kafka/pull/15290#issuecomment-1916718062
@jlprat If you've validated the test this changes works, we probably don't
need to wait the few hours for the build to complete to merge.
--
This is an automated message from the
dajac commented on PR #15253:
URL: https://github.com/apache/kafka/pull/15253#issuecomment-1916713439
Hey @mimaison! As you have done some work in this area, I wonder if you
would be interested by reviewing this PR. It would help us with the KIP-848
effort. We need this as soon as possible
dajac commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1471105525
##
clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupDescription.java:
##
@@ -36,6 +37,7 @@ public class ConsumerGroupDescription {
private final
mimaison commented on PR #15230:
URL: https://github.com/apache/kafka/pull/15230#issuecomment-1916707042
When not merging via github we should include the PR number in the commit
message otherwise the PR and commit are not linked. When digging through
history it's often important to find
tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1916691435
Thank you @jlprat for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1471075201
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2759,11 +2761,20 @@ class ReplicaManager(val config: KafkaConfig,
dajac commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1471064233
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -240,10 +240,11 @@ private CompletableFuture maybeAutoCommit(final
mimaison commented on code in PR #15246:
URL: https://github.com/apache/kafka/pull/15246#discussion_r1471061523
##
server-common/src/main/java/org/apache/kafka/security/EncryptingPasswordEncoder.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mimaison commented on code in PR #15246:
URL: https://github.com/apache/kafka/pull/15246#discussion_r1471060922
##
server-common/src/main/java/org/apache/kafka/security/NoOpPasswordEncoder.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jlprat commented on PR #15290:
URL: https://github.com/apache/kafka/pull/15290#issuecomment-1916648931
I'll wait until the build finishes and then I'll merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac commented on code in PR #15285:
URL: https://github.com/apache/kafka/pull/15285#discussion_r1471048806
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1160,7 +1160,7 @@ private CompletableFuture assignPartitions(
jlprat commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1916625862
Fix is here: https://github.com/apache/kafka/pull/15290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jlprat opened a new pull request, #15290:
URL: https://github.com/apache/kafka/pull/15290
Because of lack of implicit conversions, boolean properties need to be
passed as Strings
This is done in other parts of the code already
Fixes broken build introduced in
jlprat commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1916610169
Hi @tinaselenge and @dengziming
I think this change broke the build. Right now Kafka can't be compiled with
Scala 2.12, see the error here:
[
https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812267#comment-17812267
]
Mickael Maison commented on KAFKA-16157:
I assigned the ticket to you since you opened a PR
>
[
https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-16157:
--
Assignee: Gaurav Narula
> Topic recreation with offline disk doesn't update
gaurav-narula opened a new pull request, #15289:
URL: https://github.com/apache/kafka/pull/15289
`ReplicaManagerTest::setupReplicaManagerWithMockedPurgatories` creates two
log dirs, `core/data` and `core/data2` and test `testActiveProducerState`
creates a partition in `core/data2`.
gaurav-narula commented on PR #15288:
URL: https://github.com/apache/kafka/pull/15288#issuecomment-1916595388
CC: @mimaison, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gaurav-narula commented on PR #15289:
URL: https://github.com/apache/kafka/pull/15289#issuecomment-1916597296
CC: @mimaison, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gaurav-narula opened a new pull request, #15288:
URL: https://github.com/apache/kafka/pull/15288
`0001.snapshot` is created by
`ProducerStateManager::takeSnapshot`. Its field `logDir` is the return value
of `UnifiedLog::dir` which was not mocked before. This resulted in
[
https://issues.apache.org/jira/browse/KAFKA-16204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula reassigned KAFKA-16204:
-
Assignee: Gaurav Narula
> Stray file core/0001.snapshot created when
jlprat commented on PR #15272:
URL: https://github.com/apache/kafka/pull/15272#issuecomment-1916544246
Needed to rebase because of merge conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya resolved KAFKA-16210.
--
Resolution: Fixed
> Upgrade jose4j to 0.9.4
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-16210:
-
Fix Version/s: 3.8.0
> Upgrade jose4j to 0.9.4
> ---
>
>
divijvaidya commented on PR #15284:
URL: https://github.com/apache/kafka/pull/15284#issuecomment-1916524273
backported to 3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
divijvaidya merged PR #15284:
URL: https://github.com/apache/kafka/pull/15284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #15284:
URL: https://github.com/apache/kafka/pull/15284#issuecomment-1916513162
the CI tests that are failing are unrelated since they don't use SASL (which
is impacted by this dependency)
--
This is an automated message from the Apache Git Service.
To respond
Divij Vaidya created KAFKA-16210:
Summary: Upgrade jose4j to 0.9.4
Key: KAFKA-16210
URL: https://issues.apache.org/jira/browse/KAFKA-16210
Project: Kafka
Issue Type: Improvement
Phuc-Hong-Tran commented on code in PR #14327:
URL: https://github.com/apache/kafka/pull/14327#discussion_r1470890500
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1040,6 +1051,7 @@ private
CoordinatorResult consumerGr
divijvaidya commented on PR #15281:
URL: https://github.com/apache/kafka/pull/15281#issuecomment-1916468039
How could we have caught this earlier? Is there a gap in our release
validation? I assume that downloading the client module and building it it via
maven could have would have caught
gnarula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1470869032
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2759,11 +2761,20 @@ class ReplicaManager(val config: KafkaConfig,
showuon commented on code in PR #15287:
URL: https://github.com/apache/kafka/pull/15287#discussion_r1470886069
##
docs/ops.html:
##
@@ -4045,7 +4045,7 @@ Reverting to ZooKeeper mode During the Migration
On each broker, remove the
dajac commented on PR #15152:
URL: https://github.com/apache/kafka/pull/15152#issuecomment-1916411947
@rreddy-22 Could you please check the build? It looks like there is a
failure related to checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the
showuon commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1470823280
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -244,6 +244,19 @@ class BrokerLifecycleManager(
eventQueue.append(new
gaurav-narula commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1470842153
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -153,6 +153,16 @@ public static boolean isOnline(Uuid dir, List
sortedOnlineDirs)
Joker-5 commented on PR #14963:
URL: https://github.com/apache/kafka/pull/14963#issuecomment-1916385955
> There is one here:
[1a54c25](https://github.com/apache/kafka/commit/1a54c25fdfff351fd1b35d60dbc95232c550f3a1)
Got it, feel so sorry to trouble you again.
Have a nice day!
--
mimaison commented on code in PR #15246:
URL: https://github.com/apache/kafka/pull/15246#discussion_r1470826862
##
server-common/src/main/java/org/apache/kafka/server/util/Csv.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916373793
@dajac I miss-spelled the email, the correct one is phuctran3...@gmail.com
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rreddy-22 commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1470804235
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -1106,17 +1106,23 @@ private[group] class GroupCoordinator(
}
}
- def
dajac commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1470803293
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -1106,17 +1106,23 @@ private[group] class GroupCoordinator(
}
}
- def
dajac commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916361594
> @dajac Can you invite me to the apache slack as well? The email is
[phuctran3...@gamil.com](mailto:phuctran3...@gamil.com), TIA
@Phuc-Hong-Tran Done. You should receive an
Phuc-Hong-Tran commented on PR #14327:
URL: https://github.com/apache/kafka/pull/14327#issuecomment-1916356809
@dajac Can you invite me to the apache slack as well? The email is
phuctran3...@gamil.com, TIA
--
This is an automated message from the Apache Git Service.
To respond to the
dajac commented on code in PR #15152:
URL: https://github.com/apache/kafka/pull/15152#discussion_r1470785323
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -1106,17 +1106,20 @@ private[group] class GroupCoordinator(
}
}
- def
ppatierno commented on PR #15193:
URL: https://github.com/apache/kafka/pull/15193#issuecomment-1916334577
@cmccabe thanks. I have just opened another PR with a couple of fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ppatierno commented on PR #15287:
URL: https://github.com/apache/kafka/pull/15287#issuecomment-1916333760
@showuon @cmccabe please have a look at this, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ppatierno opened a new pull request, #15287:
URL: https://github.com/apache/kafka/pull/15287
This PR fixes a couple of things related to the #15193 PR.
When you complete "Enter Migration Mode on the brokers", we are actually in
"Enabling the migration on the brokers" referring to the
dajac commented on PR #15237:
URL: https://github.com/apache/kafka/pull/15237#issuecomment-1916330876
@jolshan Thanks for your comments. I have replied to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1470775879
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -3050,6 +3060,53 @@ public void testOffsetDeletionsSensor() {
dajac commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1470774754
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -2056,4 +2059,70 @@ public void
dajac commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1470772994
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -2056,4 +2059,70 @@ public void
dajac commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1470772511
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -903,6 +906,45 @@ public boolean cleanupExpiredOffsets(String
dajac commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1470766511
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1001,8 +1002,26 @@ public void onTransactionCompleted(
dajac commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1470764040
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -589,6 +589,23 @@ private void scheduleGroupMetadataExpiration()
dajac commented on PR #15176:
URL: https://github.com/apache/kafka/pull/15176#issuecomment-1916310489
Thanks @jolshan. I have addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac commented on PR #15196:
URL: https://github.com/apache/kafka/pull/15196#issuecomment-1916306960
Thanks @jolshan. I have addressed the remaining comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1470759188
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -153,6 +153,16 @@ public static boolean isOnline(Uuid dir, List
sortedOnlineDirs) {
lucasbru commented on PR #14963:
URL: https://github.com/apache/kafka/pull/14963#issuecomment-1916278781
There is one here:
https://github.com/apache/kafka/commit/1a54c25fdfff351fd1b35d60dbc95232c550f3a1
--
This is an automated message from the Apache Git Service.
To respond to the
201 - 297 of 297 matches
Mail list logo
