Re: [PR] KAFKA-14589 [1/3] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-02-01 Thread via GitHub
nizhikov commented on PR #15256: URL: https://github.com/apache/kafka/pull/15256#issuecomment-1923260434 Hello @showuon What do you think? `DynamicBrokerReconfigurationTest` failures related to this PR? Or it can be merged as is? -- This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-16218) Partition reassignment can't complete if any target replica is out-of-sync

2024-02-01 Thread Drawxy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813523#comment-17813523 ] Drawxy commented on KAFKA-16218: Hi [~showuon], yes, as long as replica 2001 caught up,

[jira] [Updated] (KAFKA-16218) Partition reassignment can't complete if any target replica is out-of-sync

2024-02-01 Thread Drawxy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Drawxy updated KAFKA-16218: --- Affects Version/s: 3.1.2 > Partition reassignment can't complete if any target replica is out-of-sync >

[jira] [Commented] (KAFKA-16218) Partition reassignment can't complete if any target replica is out-of-sync

2024-02-01 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813516#comment-17813516 ] Luke Chen commented on KAFKA-16218: --- As long as replica 2001 caught up, everything sho

[jira] [Created] (KAFKA-16218) Partition reassignment can't complete if any target replica is out-of-sync

2024-02-01 Thread Drawxy (Jira)
Drawxy created KAFKA-16218: -- Summary: Partition reassignment can't complete if any target replica is out-of-sync Key: KAFKA-16218 URL: https://issues.apache.org/jira/browse/KAFKA-16218 Project: Kafka

Re: [PR] KAFKA-15335: Support custom SSL configuration for Kafka Connect RestServer [kafka]

2024-02-01 Thread via GitHub
github-actions[bot] commented on PR #14203: URL: https://github.com/apache/kafka/pull/14203#issuecomment-1922745265 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-15781: KIP-998, Change the ProducerConfig constructor that allows disabling logging to "protected" [kafka]

2024-02-01 Thread via GitHub
github-actions[bot] commented on PR #14681: URL: https://github.com/apache/kafka/pull/14681#issuecomment-1922745104 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-01 Thread via GitHub
satishd commented on PR #15213: URL: https://github.com/apache/kafka/pull/15213#issuecomment-1922694144 I will take a look at this PR by Monday(5th). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16101: Additional fixes on KRaft migration documentation [kafka]

2024-02-01 Thread via GitHub
showuon commented on PR #15287: URL: https://github.com/apache/kafka/pull/15287#issuecomment-1922643301 And given the above observation, I think it'd be better we also document it about the error logs during rollback, to not surprise other users. @ppatierno @cmccabe , WDYT? -- This is an

Re: [PR] KAFKA-16101: Additional fixes on KRaft migration documentation [kafka]

2024-02-01 Thread via GitHub
showuon commented on PR #15287: URL: https://github.com/apache/kafka/pull/15287#issuecomment-1922641648 @cmccabe , thanks for the comments. Please see my reply below: > running zookeeper-shell.sh does not need to be done "quickly together with rolling at least one broker". You must ha

[jira] [Comment Edited] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813432#comment-17813432 ] Justine Olshan edited comment on KAFKA-16217 at 2/2/24 1:36 AM: --

Re: [PR] KAFKA-13403 Fix KafkaServer crashes when deleting topics due to the race in log deletion [kafka]

2024-02-01 Thread via GitHub
arunmathew88 commented on PR #11438: URL: https://github.com/apache/kafka/pull/11438#issuecomment-1922610191 @showuon @divijvaidya Please take a look into this, as it is long pending. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-16216) Reduce batch size for initial metadata load during ZK migration

2024-02-01 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-16216. -- Fix Version/s: 3.7.0 Reviewer: Colin McCabe Assignee: David Arthur (was: Col

Re: [PR] KAFKA-16101: Additional fixes on KRaft migration documentation [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on PR #15287: URL: https://github.com/apache/kafka/pull/15287#issuecomment-1922552107 I'm sorry but I had to revert this. It's just not correct. * Brokers don't need to be in "pure ZK mode" to become ZK controllers. A broker with `zookeeper.metadata.migration.enable

[jira] [Assigned] (KAFKA-16216) Reduce batch size for initial metadata load during ZK migration

2024-02-01 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-16216: Assignee: Colin McCabe (was: David Arthur) > Reduce batch size for initial metadata load

[jira] [Updated] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16217: -- Fix Version/s: 3.6.2 3.7.1 > Transactional producer stuck in IllegalStateException

[jira] [Updated] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16217: -- Labels: transactions (was: ) > Transactional producer stuck in IllegalStateException during close > -

[jira] [Assigned] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16217: - Assignee: Kirk True > Transactional producer stuck in IllegalStateException during close >

[jira] [Updated] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16217: Component/s: producer > Transactional producer stuck in IllegalStateException during clos

Re: [PR] KAFKA-16216: Reduce batch size for initial metadata load during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on PR #15299: URL: https://github.com/apache/kafka/pull/15299#issuecomment-1922507934 I moved the discussion about KIP-866 metrics to here https://github.com/apache/kafka/pull/15306 -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] MINOR: Add MetadataType metric from KIP-866 #15299 [kafka]

2024-02-01 Thread via GitHub
cmccabe opened a new pull request, #15306: URL: https://github.com/apache/kafka/pull/15306 This patch addresses a few minor observability and operational concerns for ZK to KRaft migrations. The "MetadataType" metric is added to both the brokers and controllers, as defined in KIP-866

Re: [PR] KAFKA-16216: Reduce batch size for initial metadata load during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on PR #15299: URL: https://github.com/apache/kafka/pull/15299#issuecomment-1922503205 lgtm, committed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-16216: Reduce batch size for initial metadata load during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe closed pull request #15299: KAFKA-16216: Reduce batch size for initial metadata load during ZK migration URL: https://github.com/apache/kafka/pull/15299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-16217: --- Affects Version/s: 3.6.1 3.7.0 > Transactional producer stuck in Ille

[jira] [Commented] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813432#comment-17813432 ] Justine Olshan commented on KAFKA-16217: Thanks [~calvinliu] for filing this bug

[jira] [Updated] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-16217: --- Description: The producer is stuck during the close. It keeps retrying to abort the transaction but

[jira] [Created] (KAFKA-16217) Transactional producer stuck in IllegalStateException during close

2024-02-01 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-16217: -- Summary: Transactional producer stuck in IllegalStateException during close Key: KAFKA-16217 URL: https://issues.apache.org/jira/browse/KAFKA-16217 Project: Kafka

[jira] [Updated] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15561: -- Priority: Critical (was: Major) > Client support for new SubscriptionPattern based subscription > ---

[jira] [Updated] (KAFKA-15538) Client support for java regex based subscription

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15538: -- Priority: Critical (was: Major) > Client support for java regex based subscription >

[jira] [Created] (KAFKA-16216) Reduce batch size for initial metadata load during ZK migration

2024-02-01 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-16216: Summary: Reduce batch size for initial metadata load during ZK migration Key: KAFKA-16216 URL: https://issues.apache.org/jira/browse/KAFKA-16216 Project: Kafka

[jira] [Updated] (KAFKA-15284) Implement ConsumerGroupProtocolVersionResolver to determine consumer group protocol

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15284: -- Priority: Major (was: Blocker) > Implement ConsumerGroupProtocolVersionResolver to determine consumer

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1475200369 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String, mutab

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1475198190 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String, mutab

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1475196894 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String, mutab

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
mumrah commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1474508267 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String, mutabl

[jira] [Resolved] (KAFKA-15691) Add new system tests to use new consumer

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-15691. --- Resolution: Duplicate > Add new system tests to use new consumer > -

[jira] [Updated] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16169: -- Labels: kip-848-client-support (was: ) > FencedException in commitAsync not propagated without callba

[jira] [Updated] (KAFKA-16024) SaslPlaintextConsumerTest#testCoordinatorFailover is flaky

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16024: -- Labels: flaky-test integration-tests (was: flaky-test) > SaslPlaintextConsumerTest#testCoordinatorFai

[jira] [Updated] (KAFKA-16024) SaslPlaintextConsumerTest#testCoordinatorFailover is flaky

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16024: -- Component/s: (was: unit tests) > SaslPlaintextConsumerTest#testCoordinatorFailover is flaky >

[jira] [Updated] (KAFKA-15993) Enable max poll integration tests that depend on callback invocation

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15993: -- Labels: consumer-threading-refactor integration-tests timeout (was: consumer-threading-refactor integ

[jira] [Updated] (KAFKA-16112) Review JMX metrics in Async Consumer and determine the missing ones

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16112: -- Issue Type: Task (was: Improvement) > Review JMX metrics in Async Consumer and determine the missing

[jira] [Updated] (KAFKA-16142) Update metrics documentation for errors and new metrics

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16142: -- Issue Type: Improvement (was: Task) Priority: Critical (was: Major) > Update metrics documenta

[jira] [Updated] (KAFKA-16112) Review JMX metrics in Async Consumer and determine the missing ones

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16112: -- Issue Type: Improvement (was: Task) Priority: Critical (was: Major) > Review JMX metrics in As

[jira] [Updated] (KAFKA-16113) AsyncKafkaConsumer: Add missing offset commit metrics

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16113: -- Priority: Critical (was: Major) > AsyncKafkaConsumer: Add missing offset commit metrics > ---

[jira] [Updated] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16116: -- Priority: Critical (was: Major) > AsyncKafkaConsumer: Add missing rebalance metrics > ---

[jira] [Updated] (KAFKA-16115) AsyncKafkaConsumer: Add missing heartbeat metrics

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16115: -- Priority: Critical (was: Major) > AsyncKafkaConsumer: Add missing heartbeat metrics > ---

[jira] [Updated] (KAFKA-16143) New metrics for KIP-848 protocol

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16143: -- Fix Version/s: 4.0.0 (was: 3.8.0) > New metrics for KIP-848 protocol >

[jira] [Updated] (KAFKA-16143) New metrics for KIP-848 protocol

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16143: -- Labels: kip-848-client-support metrics needs-kip (was: kip-848-client-support metrics) > New metrics

[jira] [Updated] (KAFKA-16143) New metrics for KIP-848 protocol

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16143: -- Issue Type: Improvement (was: Task) > New metrics for KIP-848 protocol >

[jira] [Updated] (KAFKA-16143) New metrics for KIP-848 protocol

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16143: -- Description: This task is to consider what _new_ metrics we need from the KIP-848 protocol that aren't

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-02-01 Thread via GitHub
Cerchie commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1475018035 ## docs/streams/developer-guide/config-streams.html: ## @@ -1010,6 +1016,18 @@ topology.optimization + windowed.inner.class.serde + + + +

[jira] [Updated] (KAFKA-16215) Consumer does not rejoin after fenced on delayed revocation

2024-02-01 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16215: --- Affects Version/s: 3.7.0 > Consumer does not rejoin after fenced on delayed revocation > ---

[jira] [Commented] (KAFKA-16215) Consumer does not rejoin after fenced on delayed revocation

2024-02-01 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813389#comment-17813389 ] Lianet Magrans commented on KAFKA-16215: Definitely, added the Fix version. >

[jira] [Updated] (KAFKA-16215) Consumer does not rejoin after fenced on delayed revocation

2024-02-01 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16215: --- Fix Version/s: 3.8.0 > Consumer does not rejoin after fenced on delayed revocation > ---

[jira] [Updated] (KAFKA-16202) Extra dot in error message in producer

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16202: -- Component/s: clients producer > Extra dot in error message in producer > ---

[jira] [Commented] (KAFKA-16215) Consumer does not rejoin after fenced on delayed revocation

2024-02-01 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813382#comment-17813382 ] Kirk True commented on KAFKA-16215: --- [~lianetm] do we want this in 3.8.0? > Consumer

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-01 Thread via GitHub
philipnee commented on code in PR #15216: URL: https://github.com/apache/kafka/pull/15216#discussion_r1474925331 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-01 Thread via GitHub
philipnee commented on code in PR #15216: URL: https://github.com/apache/kafka/pull/15216#discussion_r1474925331 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16181: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh [kafka]

2024-02-01 Thread via GitHub
OmniaGM commented on code in PR #15304: URL: https://github.com/apache/kafka/pull/15304#discussion_r1474743330 ## core/src/main/scala/kafka/admin/ConfigCommand.scala: ## @@ -405,7 +420,7 @@ object ConfigCommand extends Logging { val alterOptions = new AlterConfigsOptio

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1474870992 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String, mutab

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
cmccabe commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1474870992 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String, mutab

Re: [PR] KAFKA-14589 [1/3] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-02-01 Thread via GitHub
nizhikov commented on PR #15256: URL: https://github.com/apache/kafka/pull/15256#issuecomment-1921875382 @showuon Please, wright me, If those failures should be further investigated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-14589 [1/3] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-02-01 Thread via GitHub
nizhikov commented on PR #15256: URL: https://github.com/apache/kafka/pull/15256#issuecomment-1921873375 Other trunk test run contains `DynamicBrokerReconfigurationTest ` fails, also (but only for 1 environment). https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka/d

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-01 Thread via GitHub
lucasbru commented on code in PR #15216: URL: https://github.com/apache/kafka/pull/15216#discussion_r1474777535 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-01 Thread via GitHub
philipnee commented on PR #15216: URL: https://github.com/apache/kafka/pull/15216#issuecomment-1921750518 @lucasbru - Thank you for spending time reviewing the PR. I responded to your comment about resource closing. It is indeed a bit strange why we need to do this. A weird thing I

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-01 Thread via GitHub
philipnee commented on code in PR #15216: URL: https://github.com/apache/kafka/pull/15216#discussion_r1474763839 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-02-01 Thread via GitHub
Vaibhav-Nazare commented on code in PR #13817: URL: https://github.com/apache/kafka/pull/13817#discussion_r1474755853 ## Jenkinsfile: ## @@ -174,6 +183,28 @@ pipeline { echo 'Skipping Kafka Streams archetype test for Java 21' } } + +stage

[jira] [Resolved] (KAFKA-15575) Prevent Connectors from exceeding tasks.max configuration

2024-02-01 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15575. --- Fix Version/s: 3.8.0 Resolution: Fixed > Prevent Connectors from exceeding tasks.max

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-02-01 Thread via GitHub
C0urante merged PR #15180: URL: https://github.com/apache/kafka/pull/15180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-02-01 Thread via GitHub
Vaibhav-Nazare commented on code in PR #13817: URL: https://github.com/apache/kafka/pull/13817#discussion_r1474754259 ## Jenkinsfile: ## @@ -1,3 +1,7 @@ + + + + Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-02-01 Thread via GitHub
Vaibhav-Nazare commented on code in PR #13817: URL: https://github.com/apache/kafka/pull/13817#discussion_r1474755853 ## Jenkinsfile: ## @@ -174,6 +183,28 @@ pipeline { echo 'Skipping Kafka Streams archetype test for Java 21' } } + +stage

Re: [PR] KAFKA-15524, KAFKA-15917: Wait for zombie sink tasks' consumers to commit offsets before trying to modify their offsets in integration tests [kafka]

2024-02-01 Thread via GitHub
C0urante commented on PR #15302: URL: https://github.com/apache/kafka/pull/15302#issuecomment-1921719937 @yashmayya @gharris1727 If either of you have a moment, here's another flaky test fix. Would appreciate a look! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-01 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1474737738 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-01 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1474734641 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16107 [2/N]: Fix inverted args & more tests [kafka]

2024-02-01 Thread via GitHub
dajac merged PR #15285: URL: https://github.com/apache/kafka/pull/15285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-01 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1474695808 ## tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-02-01 Thread via GitHub
mimaison commented on code in PR #13817: URL: https://github.com/apache/kafka/pull/13817#discussion_r1474685305 ## Jenkinsfile: ## @@ -174,6 +183,28 @@ pipeline { echo 'Skipping Kafka Streams archetype test for Java 21' } } + +stage('Powe

Re: [PR] KAFKA-16107 [2/N]: Fix inverted args & more tests [kafka]

2024-02-01 Thread via GitHub
lianetm commented on PR #15285: URL: https://github.com/apache/kafka/pull/15285#issuecomment-1921599500 Hey @dajac seems like we got a good [build](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15285/7/pipeline) now, and test failures are unrelated. -

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-01 Thread via GitHub
lucasbru commented on PR #15216: URL: https://github.com/apache/kafka/pull/15216#issuecomment-1921566239 I have one last comment, otherwise the PR looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-01 Thread via GitHub
lucasbru commented on code in PR #15216: URL: https://github.com/apache/kafka/pull/15216#discussion_r1474644032 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/AbstractConsumerMetricsManager.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache So

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-01 Thread via GitHub
lucasbru commented on code in PR #15216: URL: https://github.com/apache/kafka/pull/15216#discussion_r1474642551 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records [kafka]

2024-02-01 Thread via GitHub
vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-1921517994 Thanks @C0urante for this! Let me review this and get back to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-15296: Allow offsets to be committed for filtered records when Exactly Once support is disabled [kafka]

2024-02-01 Thread via GitHub
vamossagar12 commented on PR #14158: URL: https://github.com/apache/kafka/pull/14158#issuecomment-1921511483 @yashmayya , would you like to re-review this one when you have some time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-02-01 Thread via GitHub
vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1474605205 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +267,18 @@ public String memberId() { r

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-02-01 Thread via GitHub
vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1474598172 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,47 @@ public void testSkippingAssignmen

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-02-01 Thread via GitHub
vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1474595936 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -93,9 +96,9 @@ public class WorkerCoordinatorTest {

[PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-02-01 Thread via GitHub
vamossagar12 opened a new pull request, #15305: URL: https://github.com/apache/kafka/pull/15305 Please refer to the description in [KAFKA-16197](https://issues.apache.org/jira/browse/KAFKA-16197). -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] KAFKA-14589 [1/3] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-02-01 Thread via GitHub
nizhikov commented on PR #15256: URL: https://github.com/apache/kafka/pull/15256#issuecomment-1921473385 @showuon CI results are ready. AFAICS other tests of `DynamicBrokerReconfigurationTest` failed in the latest trunk: https://ci-builds.apache.org/blue/organizations/jenkins/Kaf

Re: [PR] KAFKA-15675: Improve worker liveness check during Connect integration tests [kafka]

2024-02-01 Thread via GitHub
C0urante commented on code in PR #15249: URL: https://github.com/apache/kafka/pull/15249#discussion_r1474555935 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnect.java: ## @@ -963,11 +962,19 @@ public Set activeWorkers() { return wor

Re: [PR] KAFKA-15675: Improve worker liveness check during Connect integration tests [kafka]

2024-02-01 Thread via GitHub
C0urante merged PR #15249: URL: https://github.com/apache/kafka/pull/15249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15675: Improve worker liveness check during Connect integration tests [kafka]

2024-02-01 Thread via GitHub
C0urante commented on PR #15249: URL: https://github.com/apache/kafka/pull/15249#issuecomment-1921447477 The last change was trivial and the build passes locally. Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15675: Improve worker liveness check during Connect integration tests [kafka]

2024-02-01 Thread via GitHub
C0urante commented on PR #15249: URL: https://github.com/apache/kafka/pull/15249#issuecomment-1921446548 Thanks Yash! Regarding adding status code checking in `EmbeddedConnect::restartConnectorAndTasks`, unfortunately this causes the [testFailedConnectorRestartOnlyConnector case](https://g

[jira] [Created] (KAFKA-16215) Consumer does not rejoin after fenced on delayed revocation

2024-02-01 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16215: -- Summary: Consumer does not rejoin after fenced on delayed revocation Key: KAFKA-16215 URL: https://issues.apache.org/jira/browse/KAFKA-16215 Project: Kafka

Re: [PR] KAFKA-15832: Trigger client reconciliation based on manager poll [kafka]

2024-02-01 Thread via GitHub
lucasbru commented on PR #15275: URL: https://github.com/apache/kafka/pull/15275#issuecomment-1921371376 @lianetm Could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15832: Trigger client reconciliation based on manager poll [kafka]

2024-02-01 Thread via GitHub
lucasbru commented on code in PR #15275: URL: https://github.com/apache/kafka/pull/15275#discussion_r1474503361 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1392,4 +1402,16 @@ public void registerStateListener(MemberStat

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-01 Thread via GitHub
mumrah commented on code in PR #15293: URL: https://github.com/apache/kafka/pull/15293#discussion_r1473671017 ## core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala: ## @@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates: mutable.AnyRefMap[String, mutabl

[PR] KAFKA-16181: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh [kafka]

2024-02-01 Thread via GitHub
dengziming opened a new pull request, #15304: URL: https://github.com/apache/kafka/pull/15304 *More detailed description of your change* This PR implement KIP-1011, use incrementalAlterConfigs by default to alter broker configurations instead of the deprecated alterConfigs API, and fall b

Re: [PR] MINOR: log error when initialLoadFuture is not done in authorizer [kafka]

2024-02-01 Thread via GitHub
showuon commented on PR #14953: URL: https://github.com/apache/kafka/pull/14953#issuecomment-1921207947 @cmccabe @jsancio , please take a look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15670: add "inter.broker.listener.name" config in KRaft controller config [kafka]

2024-02-01 Thread via GitHub
showuon commented on PR #14631: URL: https://github.com/apache/kafka/pull/14631#issuecomment-1921207331 @mumrah @cmccabe @mimaison , I think this doc improvement for ZK migrating to KRaft is good to be included in v3.7.0. Please take a look. Thanks. -- This is an automated message from th

Re: [PR] KAFKA-16214: add client info in authentication error log [kafka]

2024-02-01 Thread via GitHub
showuon commented on PR #15280: URL: https://github.com/apache/kafka/pull/15280#issuecomment-1921205131 @ijuma @mimaison , please take a look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   >