[jira] [Commented] (KAFKA-14041) Avoid the keyword var for a variable declaration in ConfigTransformer

2024-02-11 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816389#comment-17816389 ] Andrew Schofield commented on KAFKA-14041: -- While strictly speaking this is not

[jira] [Assigned] (KAFKA-14041) Avoid the keyword var for a variable declaration in ConfigTransformer

2024-02-11 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-14041: Assignee: Andrew Schofield > Avoid the keyword var for a variable declaration in

[jira] [Commented] (KAFKA-8750) Utils#murmur2() method switch case block don't have break

2024-02-11 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816390#comment-17816390 ] Andrew Schofield commented on KAFKA-8750: - I've reviewed the code and also a bunc

[jira] [Commented] (KAFKA-1837) Metadata record future never returns on get call after producer is stopped and messages can't be sent

2024-02-11 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816444#comment-17816444 ] Andrew Schofield commented on KAFKA-1837: - Initial testing seems to show that the

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-11 Thread via GitHub
C0urante commented on code in PR #15349: URL: https://github.com/apache/kafka/pull/15349#discussion_r1485632038 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTransactionsTest.java: ## @@ -31,6 +32,7 @@ * Integration test

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-11 Thread via GitHub
C0urante commented on code in PR #15349: URL: https://github.com/apache/kafka/pull/15349#discussion_r1485632038 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTransactionsTest.java: ## @@ -31,6 +32,7 @@ * Integration test

Re: [PR] KAFKA-15814 Patched the SASL/GSSAPI server construction [kafka]

2024-02-11 Thread via GitHub
github-actions[bot] commented on PR #14748: URL: https://github.com/apache/kafka/pull/14748#issuecomment-1938023853 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-02-11 Thread via GitHub
github-actions[bot] commented on PR #14716: URL: https://github.com/apache/kafka/pull/14716#issuecomment-1938023875 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[PR] KAFKA-16239: Clean up references to non-existent IntegrationTestHelper [kafka]

2024-02-11 Thread via GitHub
ghostspiders opened a new pull request, #15352: URL: https://github.com/apache/kafka/pull/15352 Clean up references to non-existent IntegrationTestHelper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-11 Thread via GitHub
dajac merged PR #15311: URL: https://github.com/apache/kafka/pull/15311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-16178) AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator

2024-02-11 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16178. - Resolution: Fixed > AsyncKafkaConsumer doesn't retry joining the group after rediscovering group

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-11 Thread via GitHub
dajac commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1938170491 > @dajac Maybe I misunderstand, but I don't see how the change you linked is relevant. If you run the tests once (as in locally running `./gradlew unitTest`) then the retries and merging of

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-11 Thread via GitHub
dajac commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1938174110 Ah, I just saw the `Github build queue` thread. I better understand what you're trying to do here. -- This is an automated message from the Apache Git Service. To respond to the message,