[PR] KAFKA-15715: Add Kraft Support to UpgradeFeaturesTest [kafka]

2024-02-23 Thread via GitHub
Owen-CH-Leung opened a new pull request, #15429: URL: https://github.com/apache/kafka/pull/15429 https://issues.apache.org/jira/browse/KAFKA-15715 As per [KAFKA-15715](https://issues.apache.org/jira/browse/KAFKA-15715), this PR adds Kraft support to UpgradeFeaturesTest ###

Re: [PR] KAFKA-15821: Delete active topics after connector deletion in standal… [kafka]

2024-02-23 Thread via GitHub
github-actions[bot] commented on PR #14776: URL: https://github.com/apache/kafka/pull/14776#issuecomment-1962236422 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR: Fix unchecked warning in CredentialCache [kafka]

2024-02-23 Thread via GitHub
github-actions[bot] commented on PR #14808: URL: https://github.com/apache/kafka/pull/14808#issuecomment-1962236411 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] Kafka-14508: ConsumerGroupInstallAssignment API Client [WIP] [kafka]

2024-02-23 Thread via GitHub
github-actions[bot] commented on PR #14834: URL: https://github.com/apache/kafka/pull/14834#issuecomment-1962236395 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[PR] ConfigRegistry [kafka]

2024-02-23 Thread via GitHub
cmccabe opened a new pull request, #15428: URL: https://github.com/apache/kafka/pull/15428 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-16277: AbstractStickyAssignor - Sort owned TopicPartitions by p… [kafka]

2024-02-23 Thread via GitHub
credpath-seek commented on PR #15416: URL: https://github.com/apache/kafka/pull/15416#issuecomment-1962156726 I was going to try to fix the pipeline issue: ``` [Checks API] No suitable checks publisher found. ``` But then I saw it had been attempted and reverted 

Re: [PR] KAFKA-14808: fix leaderless partition issue when controller removes u… [kafka]

2024-02-23 Thread via GitHub
junrao commented on code in PR #13451: URL: https://github.com/apache/kafka/pull/13451#discussion_r1501252737 ## core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala: ## @@ -572,6 +572,48 @@ class ControllerIntegrationTest extends QuorumTestHarness {

Re: [PR] KAFKA-7663: initial commit for reprocessing on user added stores [kafka]

2024-02-23 Thread via GitHub
wcarlson5 commented on PR #15414: URL: https://github.com/apache/kafka/pull/15414#issuecomment-1962002805 I might need to add a couple of unit tests, but I think it could use a review when you got time @mjsax ! -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-7663: initial commit for reprocessing on user added stores [kafka]

2024-02-23 Thread via GitHub
wcarlson5 commented on code in PR #15414: URL: https://github.com/apache/kafka/pull/15414#discussion_r1501173995 ## streams/src/test/java/org/apache/kafka/streams/integration/GlobalThreadShutDownOrderTest.java: ## @@ -120,23 +119,11 @@ public void before(final TestInfo

Re: [PR] KAFKA-16286; Notify listener of latest leader and epoch [kafka]

2024-02-23 Thread via GitHub
jsancio merged PR #15397: URL: https://github.com/apache/kafka/pull/15397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [WIp] Fixes consume bench test.py maybe [kafka]

2024-02-23 Thread via GitHub
kirktrue opened a new pull request, #15427: URL: https://github.com/apache/kafka/pull/15427 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

2024-02-23 Thread via GitHub
artemlivshits commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1501002625 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2129,63 +2167,183 @@ private Map> handleDescribeTopicsByNames(f

[jira] [Comment Edited] (KAFKA-15853) Move KafkaConfig to server module

2024-02-23 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796383#comment-17796383 ] Federico Valeri edited comment on KAFKA-15853 at 2/23/24 5:06 PM: --

Re: [PR] KAFKA-16226 Add test for concurrently updatingMetadata and fetching snapshot/cluster [kafka]

2024-02-23 Thread via GitHub
hachikuji commented on code in PR #15385: URL: https://github.com/apache/kafka/pull/15385#discussion_r1499908727 ## clients/src/test/java/org/apache/kafka/clients/MetadataTest.java: ## @@ -1260,6 +1265,103 @@ else if (partition.equals(internalPart))

Re: [PR] MINOR: Improve test testCommitInRebalanceCallback [kafka]

2024-02-23 Thread via GitHub
lucasbru merged PR #15420: URL: https://github.com/apache/kafka/pull/15420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-02-23 Thread via GitHub
lianetm commented on PR #15188: URL: https://github.com/apache/kafka/pull/15188#issuecomment-1961610927 Regarding the validation of the regex, I lean towards having a new error, like @dajac suggested. Just to clearly tell the user that it is using an invalid regex, without overcomplicating

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-23 Thread via GitHub
jolshan commented on code in PR #15413: URL: https://github.com/apache/kafka/pull/15413#discussion_r1500883045 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {

[jira] [Created] (KAFKA-16304) Disk I/O error does not offline log directory while handling Fetch requests

2024-02-23 Thread Gaurav Narula (Jira)
Gaurav Narula created KAFKA-16304: - Summary: Disk I/O error does not offline log directory while handling Fetch requests Key: KAFKA-16304 URL: https://issues.apache.org/jira/browse/KAFKA-16304

Re: [PR] KAFKA-16152: Fix PlaintextConsumerTest.testStaticConsumerDetectsNewPartitionCreatedAfterRestart [kafka]

2024-02-23 Thread via GitHub
lucasbru merged PR #15419: URL: https://github.com/apache/kafka/pull/15419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-23 Thread via GitHub
lianetm commented on PR #15415: URL: https://github.com/apache/kafka/pull/15415#issuecomment-1961554165 Closing and re-opening PR to trigger build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-23 Thread via GitHub
lianetm closed pull request #15415: KAFKA-16258: callback to release assignment when stale member leaves group URL: https://github.com/apache/kafka/pull/15415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-15302) Stale value returned when using store.all() in punctuation function.

2024-02-23 Thread Jinyong Choi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820083#comment-17820083 ] Jinyong Choi commented on KAFKA-15302: -- [~cervinka]  Hi. It seems like the patch for this issue

Re: [PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-23 Thread via GitHub
lianetm commented on PR #15415: URL: https://github.com/apache/kafka/pull/15415#issuecomment-1961481081 Changes done @lucasbru, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-23 Thread via GitHub
lianetm commented on code in PR #15415: URL: https://github.com/apache/kafka/pull/15415#discussion_r1500782762 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -132,11 +132,20 @@ public enum MemberState {

Re: [PR] KAFKA-14412: Transactional StateStores [kafka]

2024-02-23 Thread via GitHub
nicktelford commented on PR #15137: URL: https://github.com/apache/kafka/pull/15137#issuecomment-1961419902 Closing this PR for now while I break changes out into separate PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-14412: Transactional StateStores [kafka]

2024-02-23 Thread via GitHub
nicktelford closed pull request #15137: KAFKA-14412: Transactional StateStores URL: https://github.com/apache/kafka/pull/15137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

2024-02-23 Thread via GitHub
cadonna opened a new pull request, #15426: URL: https://github.com/apache/kafka/pull/15426 Currently, in the async Kafka consumer updates to the group metadata that are received by the heartbeat are propagated to the application thread in form of an event. Group metadata is updated when a

[jira] [Assigned] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-02-23 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-16169: -- Assignee: Lucas Brutschy (was: Lianet Magrans) > FencedException in commitAsync not

Re: [PR] KAFKA-16152: Fix PlaintextConsumerTest.testStaticConsumerDetectsNewPartitionCreatedAfterRestart [kafka]

2024-02-23 Thread via GitHub
cadonna commented on code in PR #15419: URL: https://github.com/apache/kafka/pull/15419#discussion_r1500644733 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] KAFKA-16152: Fix PlaintextConsumerTest.testStaticConsumerDetectsNewPartitionCreatedAfterRestart [kafka]

2024-02-23 Thread via GitHub
lucasbru commented on code in PR #15419: URL: https://github.com/apache/kafka/pull/15419#discussion_r1500632283 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-23 Thread via GitHub
lucasbru commented on PR #15415: URL: https://github.com/apache/kafka/pull/15415#issuecomment-1961282993 Let me know if you are planning to change something. Otherwise, I think we can merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-23 Thread via GitHub
lucasbru commented on code in PR #15415: URL: https://github.com/apache/kafka/pull/15415#discussion_r1500621907 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -132,11 +132,20 @@ public enum MemberState {

Re: [PR] KAFKA-14808: fix leaderless partition issue when controller removes u… [kafka]

2024-02-23 Thread via GitHub
songnon commented on PR #13451: URL: https://github.com/apache/kafka/pull/13451#issuecomment-1961272891 @junrao Could you help to review this? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16152: Fix PlaintextConsumerTest.testStaticConsumerDetectsNewPartitionCreatedAfterRestart [kafka]

2024-02-23 Thread via GitHub
cadonna commented on code in PR #15419: URL: https://github.com/apache/kafka/pull/15419#discussion_r1500548287 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] KAFKA-16277: AbstractStickyAssignor - Sort owned TopicPartitions by p… [kafka]

2024-02-23 Thread via GitHub
credpath-seek commented on PR #15416: URL: https://github.com/apache/kafka/pull/15416#issuecomment-1961101177 Thanks for the review @ableegoldman - I have incorporated your suggested changes -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-16277: AbstractStickyAssignor - Sort owned TopicPartitions by p… [kafka]

2024-02-23 Thread via GitHub
credpath-seek commented on code in PR #15416: URL: https://github.com/apache/kafka/pull/15416#discussion_r1500481139 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -663,6 +663,7 @@ private void assignOwnedPartitions() {

Re: [PR] KAFKA-16243: Make sure that we do not exceed max poll interval inside poll [kafka]

2024-02-23 Thread via GitHub
lucasbru commented on code in PR #15372: URL: https://github.com/apache/kafka/pull/15372#discussion_r1500478736 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -232,13 +232,22 @@ public MembershipManager

Re: [PR] MINOR: Change config. compressionType to be an enum type instead [kafka]

2024-02-23 Thread via GitHub
divijvaidya commented on PR #15403: URL: https://github.com/apache/kafka/pull/15403#issuecomment-1961076220 The build is failing because we need to modify a few other tests to use enum instead of string. Please tag me here again for review once we have a green build. -- This is an

[jira] [Commented] (KAFKA-9803) Allow producers to recover gracefully from transaction timeouts

2024-02-23 Thread Lenin Joseph (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820006#comment-17820006 ] Lenin Joseph commented on KAFKA-9803: - Do we have any ETA on the availability of the fix ?  > Allow

Re: [PR] KAFKA-16251: Fix for not sending heartbeat while fenced [kafka]

2024-02-23 Thread via GitHub
lucasbru merged PR #15392: URL: https://github.com/apache/kafka/pull/15392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-16111) Implement tests for tricky rebalance callback scenarios

2024-02-23 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819997#comment-17819997 ] Lucas Brutschy commented on KAFKA-16111: https://github.com/apache/kafka/pull/15408 Example test

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-02-23 Thread via GitHub
lucasbru commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-1961025640 I'm keeping this around as an example, but I don't intend to merge this. I think we can merge it together with https://issues.apache.org/jira/browse/KAFKA-16111. Converting to a draft.

[jira] [Assigned] (KAFKA-16301) Review fenced member unsubscribe/subscribe callbacks interaction

2024-02-23 Thread Quoc Phong Dang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Quoc Phong Dang reassigned KAFKA-16301: --- Assignee: Quoc Phong Dang > Review fenced member unsubscribe/subscribe callbacks

[jira] [Commented] (KAFKA-16105) Reassignment of tiered topics is failing due to RemoteStorageException

2024-02-23 Thread Anatolii Popov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819994#comment-17819994 ] Anatolii Popov commented on KAFKA-16105: Hi [~ckamal] unfortunately it is really hard to write

Re: [PR] KAFKA-16152: Fix PlaintextConsumerTest.testStaticConsumerDetectsNewPartitionCreatedAfterRestart [kafka]

2024-02-23 Thread via GitHub
lucasbru commented on code in PR #15419: URL: https://github.com/apache/kafka/pull/15419#discussion_r1500408843 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]

2024-02-23 Thread via GitHub
stanislavkozlovski commented on code in PR #15406: URL: https://github.com/apache/kafka/pull/15406#discussion_r1500387364 ## docs/upgrade.html: ## @@ -36,9 +36,9 @@ Notable changes in 3 -Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading to

[jira] [Comment Edited] (KAFKA-15713) KRaft support in SaslClientsWithInvalidCredentialsTest

2024-02-23 Thread Pavel Pozdeev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818300#comment-17818300 ] Pavel Pozdeev edited comment on KAFKA-15713 at 2/23/24 8:55 AM: Can I

Re: [PR] KAFKA-15761: KRaft support in EpochDrivenReplicationProtocolAcceptanceTest [kafka]

2024-02-23 Thread via GitHub
pasharik commented on PR #15295: URL: https://github.com/apache/kafka/pull/15295#issuecomment-1960924198 Hi, it looks like there is a typo in the ticket number in the title of this pull request. It says KAFKA-15761, but the change is related to KAFKA-15716 - the last two digits are

[jira] [Updated] (KAFKA-16296) Broker shrinks ISR when restarting

2024-02-23 Thread Colin Leroy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Leroy updated KAFKA-16296: Description: We have a rolling-restart problem we don't understand on a 3-node cluster. When

Re: [PR] AKCORE-32: Defined signature for acknowledge functionality and added definition of Share Sessions [kafka]

2024-02-23 Thread via GitHub
adixitconfluent closed pull request #15425: AKCORE-32: Defined signature for acknowledge functionality and added definition of Share Sessions URL: https://github.com/apache/kafka/pull/15425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] AKCORE-32: Defined signature for acknowledge functionality and added definition of Share Sessions [kafka]

2024-02-23 Thread via GitHub
adixitconfluent opened a new pull request, #15425: URL: https://github.com/apache/kafka/pull/15425 AKCORE-32: Defined signature for share acknowledge functionality and added definition of Share Sessions -- This is an automated message from the Apache Git Service. To respond