cadonna commented on PR #15227:
URL: https://github.com/apache/kafka/pull/15227#issuecomment-1968402686
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
philipnee commented on PR #15339:
URL: https://github.com/apache/kafka/pull/15339#issuecomment-1968168522
Hi @lucasbru - Thanks for the review and sorry for the long delay. I went
over your comments and believe have addressed the questions/requests. I hope I
didn't miss anything, please
kirktrue commented on PR #15426:
URL: https://github.com/apache/kafka/pull/15426#issuecomment-1968025786
@cadonna—thanks for the PR!
I'm concerned that `MemberStateListener` mechanism has opened a path for us
to sidestep the thread separation we've intentionally introduced. With this
kirktrue commented on PR #15426:
URL: https://github.com/apache/kafka/pull/15426#issuecomment-1968017311
> Did we take any decision about this architectural change proposed in
[issues.apache.org/jira/browse/KAFKA-16290](https://issues.apache.org/jira/browse/KAFKA-16290)?
Not that I'm
[
https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16290:
-
Assignee: Kirk True
> Investigate propagating subscription state updates via queues
>
kirktrue commented on code in PR #15438:
URL: https://github.com/apache/kafka/pull/15438#discussion_r1505131769
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java:
##
@@ -16,10 +16,14 @@
*/
package
kirktrue commented on PR #15330:
URL: https://github.com/apache/kafka/pull/15330#issuecomment-1967882350
> Could we follow a similar approach as with the integration tests, enable
the ones that are passing, and leave the failing ones disabled, ideally linking
a ticket?
Yes, this is
kirktrue commented on PR #15438:
URL: https://github.com/apache/kafka/pull/15438#issuecomment-1967883771
@cadonna Would you be willing to review this? 99+% is cleaning up
inconsistencies in the events class. There are a few bits that I will call out
that are unrelated.
--
This is an
kirktrue commented on PR #15330:
URL: https://github.com/apache/kafka/pull/15330#issuecomment-1967877265
@lucasbru can you take another look at this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kirktrue opened a new pull request, #15438:
URL: https://github.com/apache/kafka/pull/15438
There are a few minor issues with the event sub-classes in the
`org.apache.kafka.clients.consumer.internals.events` package that should be
cleaned up:
- Update the names of subclasses to
[
https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821435#comment-17821435
]
Cameron Redpath commented on KAFKA-16277:
-
Thanks for the guidance! :)
>
CalvinConfluent commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1505044853
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -994,6 +1002,36 @@ public boolean isInternal() {
}
}
+
CalvinConfluent commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1505044493
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java:
##
@@ -47,8 +49,25 @@ public DescribeTopicsOptions
CalvinConfluent commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1505044242
##
clients/src/main/java/org/apache/kafka/common/TopicPartitionInfo.java:
##
@@ -79,9 +95,24 @@ public List isr() {
return isr;
}
+/**
+
CalvinConfluent commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1505043369
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -558,20 +568,53 @@ public void describeTopic(TopicCommandOptions opts)
throws
CalvinConfluent commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1505039131
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -558,20 +568,53 @@ public void describeTopic(TopicCommandOptions opts)
throws
CalvinConfluent commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1505035988
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java:
##
@@ -36,28 +38,38 @@
public class DescribeTopicsResult {
private
Soby Chacko created KAFKA-16309:
---
Summary: Enabling virtual threads in the Kafka Consumer
Key: KAFKA-16309
URL: https://issues.apache.org/jira/browse/KAFKA-16309
Project: Kafka
Issue Type:
AyoubOm commented on PR #15361:
URL: https://github.com/apache/kafka/pull/15361#issuecomment-1967468968
> Thanks for the PR @AyoubOm !
>
> Here my feedback!
Thanks @cadonna for your review ! For your first comment please check my
reply to it above.
--
This is an automated
AyoubOm commented on code in PR #15361:
URL: https://github.com/apache/kafka/pull/15361#discussion_r1504845463
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateTaskTest.java:
##
@@ -217,21 +215,53 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-15878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821352#comment-17821352
]
Kirk True commented on KAFKA-15878:
---
[~philomathanuj]—are you able to assign this Jira to yourself? I
[
https://issues.apache.org/jira/browse/KAFKA-15878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15878:
-
Assignee: Kirk True
> KIP-768: Extend support for opaque (i.e. non-JWT) tokens in
cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504623635
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1372,4 +1373,8 @@ public PollResult poll(final long
lucasbru commented on PR #15437:
URL: https://github.com/apache/kafka/pull/15437#issuecomment-1966915060
@mjsax Could you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lucasbru commented on code in PR #15437:
URL: https://github.com/apache/kafka/pull/15437#discussion_r1504535154
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -438,7 +438,7 @@ private Throwable
lucasbru commented on code in PR #15437:
URL: https://github.com/apache/kafka/pull/15437#discussion_r1504533449
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetCommitCallbackInvoker.java:
##
@@ -33,7 +32,6 @@
*/
public class
lucasbru commented on code in PR #15437:
URL: https://github.com/apache/kafka/pull/15437#discussion_r1504531700
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -96,7 +95,6 @@ public class CommitRequestManagerTest {
lucasbru opened a new pull request, #15437:
URL: https://github.com/apache/kafka/pull/15437
The javadocs for `commitAsync()` (w/o callback) say:
```
@throws org.apache.kafka.common.errors.FencedInstanceIdException
if this consumer instance gets fenced by broker.
```
If
Phuc-Hong-Tran commented on code in PR #15312:
URL: https://github.com/apache/kafka/pull/15312#discussion_r1504404988
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -87,8 +92,8 @@ public void run() {
try {
[
https://issues.apache.org/jira/browse/KAFKA-16306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16306.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> GroupCoordinatorService logger is not
lucasbru commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504333691
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1372,4 +1373,8 @@ public PollResult poll(final long
dajac commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1504266300
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -53,53 +50,19 @@
@Timeout(value = 60)
dajac commented on code in PR #15430:
URL: https://github.com/apache/kafka/pull/15430#discussion_r1504265561
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/EventAccumulator.java:
##
@@ -137,31 +136,43 @@ public void add(T event) throws
dajac merged PR #15433:
URL: https://github.com/apache/kafka/pull/15433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rykovsi closed pull request #15092: KAFKA-16067 Refactoring
ConsumerGroupListing + add test
URL: https://github.com/apache/kafka/pull/15092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504158556
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1372,4 +1373,8 @@ public PollResult poll(final long
cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504144313
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1372,4 +1373,8 @@ public PollResult poll(final long
cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504156212
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -293,6 +276,23 @@ private void process(final
cadonna commented on PR #15426:
URL: https://github.com/apache/kafka/pull/15426#issuecomment-1966444988
> Thanks for the PR! I left some comments
>
> Architecturally, this is going a bit against
https://issues.apache.org/jira/browse/KAFKA-16290 which proposes propagating
the
dengziming commented on code in PR #15429:
URL: https://github.com/apache/kafka/pull/15429#discussion_r1504147458
##
core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala:
##
@@ -31,13 +34,15 @@ import org.apache.kafka.common.protocol.Errors
import
cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504146104
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1186,8 +1181,7 @@ public OptionalLong currentLag(TopicPartition
cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504145709
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/RequestManagersTest.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation
cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504144313
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1372,4 +1373,8 @@ public PollResult poll(final long
cadonna commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504099715
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -293,6 +276,23 @@ private void process(final
cadonna commented on code in PR #15361:
URL: https://github.com/apache/kafka/pull/15361#discussion_r1504075515
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateTaskTest.java:
##
@@ -217,21 +215,53 @@ public void
lucasbru commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1504029285
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -293,6 +276,23 @@ private void process(final
gaurav-narula commented on code in PR #15434:
URL: https://github.com/apache/kafka/pull/15434#discussion_r1504044580
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -1467,4 +1476,51 @@ int updateAndGet(int actualSize, boolean update) {
rajinisivaram commented on code in PR #15434:
URL: https://github.com/apache/kafka/pull/15434#discussion_r1504009367
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -1467,4 +1476,51 @@ int updateAndGet(int actualSize, boolean update) {
[
https://issues.apache.org/jira/browse/KAFKA-16282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821160#comment-17821160
]
Ahmed Sobeh commented on KAFKA-16282:
-
Thank you both for the feedback! Made some adjustments and
stanislavkozlovski merged PR #15436:
URL: https://github.com/apache/kafka/pull/15436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821066#comment-17821066
]
Bruno Cadonna commented on KAFKA-9062:
--
Closed it.
If we will run again into a similar issue let's
[
https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-9062.
--
Resolution: Won't Fix
> Handle stalled writes to RocksDB
>
>
52 matches
Mail list logo
