Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-09 Thread via GitHub
nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2046644817 > I prefer to don't touch it. This class is all about zk and we can remove it once we remove zk support. So we want to rewrite in java KRaft tests only. Is it correct? I thought

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835595#comment-17835595 ] Chia-Ping Tsai commented on KAFKA-16310: have updated KIP-734 > ListOffsets doe

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
KevinZTW commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1558864630 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,30 +19,30 @@ package kafka.coordinator.transaction impo

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1558858994 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,30 +19,30 @@ package kafka.coordinator.transaction impo

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-09 Thread via GitHub
kamalcph commented on PR #15631: URL: https://github.com/apache/kafka/pull/15631#issuecomment-2046510235 Rebased the PR with trunk, the test failures are unrelated. Ran the 11 failed tests locally, all of them got succeeded: ``` ./gradlew cleanTest core:test --tests kafka.log.LogC

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2046489133 @junrao @showuon thanks for all your reviews and helps! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835583#comment-17835583 ] Chia-Ping Tsai commented on KAFKA-16310: I will update KIP-734 later since the w

[jira] [Resolved] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16310. Resolution: Fixed > ListOffsets doesn't report the offset with maxTimestamp anymore >

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-09 Thread via GitHub
chia7712 merged PR #15621: URL: https://github.com/apache/kafka/pull/15621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15676: URL: https://github.com/apache/kafka/pull/15676#issuecomment-2046467883 @KevinZTW Could you try to use the new function to update this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Resolved] (KAFKA-16487) Support to define server properties by ClusterTestDefaults

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16487. Fix Version/s: 3.8.0 Resolution: Fixed > Support to define server properties by Clu

Re: [PR] KAFKA-16487: Support to define server properties by ClusterTestDefaults [kafka]

2024-04-09 Thread via GitHub
chia7712 merged PR #15687: URL: https://github.com/apache/kafka/pull/15687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-16502) Fix flaky EOSUncleanShutdownIntegrationTest#shouldWorkWithUncleanShutdownWipeOutStateStore

2024-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16502: -- Summary: Fix flaky EOSUncleanShutdownIntegrationTest#shouldWorkWithUncleanShutdownWipeOutStateStore Key: KAFKA-16502 URL: https://issues.apache.org/jira/browse/KAFKA-16502

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2046457414 ``` Build / JDK 21 and Scala 2.13 / testInvalidPasswordSaslScram() – org.apache.kafka.common.security.authenticator.SaslAuthenticatorFailureNoDelayTest ``` https://issues.apache.

[jira] [Created] (KAFKA-16501) Fix flaky DelegationTokenEndToEndAuthorizationWithOwnerTest#testCreateUserWithDelegationToken

2024-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16501: -- Summary: Fix flaky DelegationTokenEndToEndAuthorizationWithOwnerTest#testCreateUserWithDelegationToken Key: KAFKA-16501 URL: https://issues.apache.org/jira/browse/KAFKA-16501

[jira] [Created] (KAFKA-16500) Fix flaky DynamicBrokerReconfigurationTest#testTrustStoreAlter

2024-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16500: -- Summary: Fix flaky DynamicBrokerReconfigurationTest#testTrustStoreAlter Key: KAFKA-16500 URL: https://issues.apache.org/jira/browse/KAFKA-16500 Project: Kafka

[jira] [Updated] (KAFKA-16498) fix flaky OffsetsApiIntegrationTest#testGetSinkConnectorOffsets

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16498: --- Summary: fix flaky OffsetsApiIntegrationTest#testGetSinkConnectorOffsets (was: fix flaky Of

[jira] [Created] (KAFKA-16499) Fix flaky ClientMetricsManagerTest#testCacheEviction

2024-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16499: -- Summary: Fix flaky ClientMetricsManagerTest#testCacheEviction Key: KAFKA-16499 URL: https://issues.apache.org/jira/browse/KAFKA-16499 Project: Kafka Issu

[jira] [Updated] (KAFKA-16497) Fix flaky SaslAuthenticatorFailureNoDelayTest#testInvalidPasswordSaslScram

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16497: --- Summary: Fix flaky SaslAuthenticatorFailureNoDelayTest#testInvalidPasswordSaslScram (was: F

[jira] [Created] (KAFKA-16498) fix flaky OffsetsApiIntegrationTest34s#testGetSinkConnectorOffsets

2024-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16498: -- Summary: fix flaky OffsetsApiIntegrationTest34s#testGetSinkConnectorOffsets Key: KAFKA-16498 URL: https://issues.apache.org/jira/browse/KAFKA-16498 Project: Kafka

[jira] [Created] (KAFKA-16497) Fix flaky SaslAuthenticatorFailureNoDelayTest16s#testInvalidPasswordSaslScram

2024-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16497: -- Summary: Fix flaky SaslAuthenticatorFailureNoDelayTest16s#testInvalidPasswordSaslScram Key: KAFKA-16497 URL: https://issues.apache.org/jira/browse/KAFKA-16497 Pro

[jira] [Resolved] (KAFKA-15160) Message bytes duplication in Kafka headers when compression is enabled

2024-04-09 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran resolved KAFKA-15160. Resolution: Won't Fix > Message bytes duplication in Kafka headers when compression is ena

[jira] [Resolved] (KAFKA-15558) Determine if Timer should be used elsewhere in PrototypeAsyncConsumer.updateFetchPositions()

2024-04-09 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran resolved KAFKA-15558. Resolution: Fixed > Determine if Timer should be used elsewhere in > PrototypeAsyncConsum

[jira] [Created] (KAFKA-16496) Make the default of receive.buffer.bytes -1 instead of 5

2024-04-09 Thread Hechao Li (Jira)
Hechao Li created KAFKA-16496: - Summary: Make the default of receive.buffer.bytes -1 instead of 5 Key: KAFKA-16496 URL: https://issues.apache.org/jira/browse/KAFKA-16496 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-16496) Make the default of receive.buffer.bytes -1 instead of 64k

2024-04-09 Thread Hechao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hechao Li updated KAFKA-16496: -- Summary: Make the default of receive.buffer.bytes -1 instead of 64k (was: Make the default of receive

[jira] [Assigned] (KAFKA-16493) Avoid unneeded subscription regex check if metadata version unchanged

2024-04-09 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-16493: -- Assignee: Phuc Hong Tran > Avoid unneeded subscription regex check if metadata versio

[jira] [Updated] (KAFKA-16493) Avoid unneeded subscription regex check if metadata version unchanged

2024-04-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16493: -- Fix Version/s: 4.0.0 > Avoid unneeded subscription regex check if metadata version unchanged > ---

Re: [PR] KAFKA-9914: Fix replication cycle detection [kafka]

2024-04-09 Thread via GitHub
izmal commented on PR #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-2045923897 Hello! I got some issue. Aslo I tried add **heartbeats** topic in `topics.exclude` and `topics.blacklist` but it isn't help. I have two geo cluster. And need use A as backup for B and

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2045917889 > In the last run, it seem that JDK 21 and Scala 2.13 didn't complete. Could you trigger another build? Typically, this could be done by closing the PR, waiting for 20 secs and opening

[jira] [Comment Edited] (KAFKA-12317) Relax non-null key requirement for left/outer KStream joins

2024-04-09 Thread Florin Akermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835506#comment-17835506 ] Florin Akermann edited comment on KAFKA-12317 at 4/9/24 6:50 PM: -

[jira] [Commented] (KAFKA-12317) Relax non-null key requirement for left/outer KStream joins

2024-04-09 Thread Florin Akermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835506#comment-17835506 ] Florin Akermann commented on KAFKA-12317: - [~mjsax]  https://github.com/apache/k

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-09 Thread via GitHub
junrao commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2045841631 @chia7712 : Thanks for triaging the failed tests. In the last run, it seem that JDK 21 and Scala 2.13 didn't complete. Could you trigger another build? Typically, this could be done by clo

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2045819511 ``` Build / JDK 11 and Scala 2.13 / testLowMaxFetchSizeForRequestAndPartition(String, String).quorum=kraft+kip848.groupProtocol=consumer – kafka.api.PlaintextConsumerFetchTest ```

Re: [PR] [No Review] Kafka-14563 [kafka]

2024-04-09 Thread via GitHub
jolshan commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1558104084 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel, } else if (!authHelper.authorize

[PR] KAFKA-12317: fix documentation [kafka]

2024-04-09 Thread via GitHub
florin-akermann opened a new pull request, #15689: URL: https://github.com/apache/kafka/pull/15689 Fix outdated documentation with regards to KAFKA-12317. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [No Review] Kafka-14563 [kafka]

2024-04-09 Thread via GitHub
CalvinConfluent commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1558097863 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel, } else if (!authHelper.a

Re: [PR] KAFKA-16417:When initializeResources throws an exception in TopicBasedRemoteLogMetadataManager.scala, initializationFailed needs to be set to true [kafka]

2024-04-09 Thread via GitHub
kamalcph commented on PR #15595: URL: https://github.com/apache/kafka/pull/15595#issuecomment-2045793826 @bozhao12 Could you please explain in the summary why this change is needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Created] (KAFKA-16495) Fix flaky TransactionsWithTieredStoreTest#testCommitTransactionTimeout

2024-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16495: -- Summary: Fix flaky TransactionsWithTieredStoreTest#testCommitTransactionTimeout Key: KAFKA-16495 URL: https://issues.apache.org/jira/browse/KAFKA-16495 Project: K

[jira] [Created] (KAFKA-16494) Fix flaky PlaintextConsumerFetchTest#testLowMaxFetchSizeForRequestAndPartition

2024-04-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16494: -- Summary: Fix flaky PlaintextConsumerFetchTest#testLowMaxFetchSizeForRequestAndPartition Key: KAFKA-16494 URL: https://issues.apache.org/jira/browse/KAFKA-16494 Pr

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15621: URL: https://github.com/apache/kafka/pull/15621#issuecomment-2045781013 ``` Build / JDK 11 and Scala 2.13 / testLowMaxFetchSizeForRequestAndPartition(String, String).quorum=kraft+kip848.groupProtocol=consumer – kafka.api.PlaintextConsumerFetchTest --

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
lianetm commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045768269 I created the follow-up task https://issues.apache.org/jira/browse/KAFKA-16493 to address that. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (KAFKA-16493) Avoid unneeded subscription regex check if metadata version unchanged

2024-04-09 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16493: -- Summary: Avoid unneeded subscription regex check if metadata version unchanged Key: KAFKA-16493 URL: https://issues.apache.org/jira/browse/KAFKA-16493 Project: Ka

[PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

2024-04-09 Thread via GitHub
philipnee opened a new pull request, #15688: URL: https://github.com/apache/kafka/pull/15688 beginningOrEndOffset and offsetforTimes should send a ListOffsetEvent and return empty results if the provided timeout is zero. A minor change to the mock timer with zero timeout in AsyncConsu

Re: [PR] MINOR: Add type check to classic group timeout operations [kafka]

2024-04-09 Thread via GitHub
dajac commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1558005191 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2415,6 +2415,22 @@ private CoordinatorResult classicGroupJoinExis

Re: [PR] MINOR: Add type check to classic group timeout operations [kafka]

2024-04-09 Thread via GitHub
jeffkbkim commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1557990553 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2415,6 +2415,22 @@ private CoordinatorResult classicGroupJoin

Re: [PR] MINOR : Replaced the while loop with TestUtils.waitForCondition [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15678: URL: https://github.com/apache/kafka/pull/15678#issuecomment-2045642331 It seems what we want to fix is the infinite waiting, and so maybe we can just add `Timeout` to this class to fix that? -- This is an automated message from the Apache Git Service. To

[jira] [Resolved] (KAFKA-13907) Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-13907. Fix Version/s: 3.8.0 Resolution: Fixed > Fix hanging ServerShutdownTest.testCleanSh

Re: [PR] KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable [kafka]

2024-04-09 Thread via GitHub
chia7712 merged PR #12174: URL: https://github.com/apache/kafka/pull/12174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR : Replaced the while loop with TestUtils.waitForCondition [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15678: URL: https://github.com/apache/kafka/pull/15678#discussion_r1557970841 ## server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java: ## @@ -172,10 +172,11 @@ public void testAssignmentAggregation() throws InterruptedExcept

Re: [PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15686: URL: https://github.com/apache/kafka/pull/15686#issuecomment-2045606629 > Did we decide to completely remove KIP-557 or to just disable it and fix it later? you are right. we didn't do the cleanup for KIP-557. please ignore my comment. -- This is a

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-09 Thread via GitHub
junrao commented on PR #15631: URL: https://github.com/apache/kafka/pull/15631#issuecomment-2045573518 @kamalcph : Thanks for the updated PR. The code looks good to me. Do you know why there were 106 failed tests? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (KAFKA-16485) Fix broker metrics to follow kebab/hyphen case

2024-04-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-16485. - Fix Version/s: 3.8.0 Resolution: Fixed Merged the PR to trunk. > Fix broker metrics to follow ke

Re: [PR] KAFKA-16485: Broker metrics to follow kebab/hyphen case (KIP-714) [kafka]

2024-04-09 Thread via GitHub
junrao merged PR #15680: URL: https://github.com/apache/kafka/pull/15680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
dajac commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045520630 @cadonna Yes, we can merge it and do a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [No Review] Kafka-14563 [kafka]

2024-04-09 Thread via GitHub
CalvinConfluent commented on code in PR #15657: URL: https://github.com/apache/kafka/pull/15657#discussion_r1557881030 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -979,6 +1013,13 @@ void handleCoordinatorReady() {

Re: [PR] KAFKA-16004: auto-commit inflight improved logs, docs and tests [kafka]

2024-04-09 Thread via GitHub
lianetm commented on PR #15669: URL: https://github.com/apache/kafka/pull/15669#issuecomment-2045510642 Thanks @cadonna! fixed it in the entire file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
cadonna commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045503262 Could we merge this PR as it is and then fix the issue @dajac in a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-09 Thread via GitHub
cadonna commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1557865864 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -293,17 +288,12 @@ public void cleanup() throws IOException {

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-09 Thread via GitHub
cadonna commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1557865864 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -293,17 +288,12 @@ public void cleanup() throws IOException {

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
lianetm commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045483420 Good catch @dajac , I missed that. Checking the metadata version in the `maybeUpdateSubscriptionMetadata` before we do the actual pattern update would definitely save some unneeded regex

Re: [PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-09 Thread via GitHub
cadonna commented on PR #15686: URL: https://github.com/apache/kafka/pull/15686#issuecomment-2045462043 > It seems `skippedIdempotentUpdatesSensor` ( > > https://github.com/apache/kafka/blob/f895ab5145077c5efa10a4a898628d901b01e2c2/streams/src/main/java/org/apache/kafka/streams/proces

Re: [PR] MINOR : Replaced the while loop with TestUtils.waitForCondition [kafka]

2024-04-09 Thread via GitHub
chiacyu commented on code in PR #15678: URL: https://github.com/apache/kafka/pull/15678#discussion_r1557842174 ## server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java: ## @@ -172,10 +172,11 @@ public void testAssignmentAggregation() throws InterruptedExcepti

Re: [PR] KAFKA-16004: auto-commit inflight improved logs, docs and tests [kafka]

2024-04-09 Thread via GitHub
cadonna commented on PR #15669: URL: https://github.com/apache/kafka/pull/15669#issuecomment-2045435265 @lianetm I found the same typo throughout the test class. Do you want to fix it in the entire file? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-16004: auto-commit inflight improved logs, docs and tests [kafka]

2024-04-09 Thread via GitHub
cadonna commented on code in PR #15669: URL: https://github.com/apache/kafka/pull/15669#discussion_r1557825632 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java: ## @@ -498,6 +538,40 @@ public void testAutoCommitEmptyDoesNotLeave

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
dajac commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045420088 @lianetm Thanks. So it seems that we call it on every poll. Aren't we concerned about the cost of matching the regex? In the legacy code, I think that we have a mechanism to refresh it only

Re: [PR] KAFKA-16004: auto-commit inflight improved logs, docs and tests [kafka]

2024-04-09 Thread via GitHub
cadonna commented on code in PR #15669: URL: https://github.com/apache/kafka/pull/15669#discussion_r1557815764 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java: ## @@ -498,6 +538,40 @@ public void testAutoCommitEmptyDoesNotLeave

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
lianetm commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045382837 Hey @dajac , we do have the same mechanism, calling `updatePatternSubscription` on a regular basis, as part of the consumer poll loop [here](https://github.com/apache/kafka/blob/4307840f

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
dajac commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045351051 Thanks for working on this one. I have one question regarding the implementation. In the legacy consumer, we have a mechanism to refresh the subscribed topics based on the regex. This is do

Re: [PR] MINOR: fix javadoc warnings [kafka]

2024-04-09 Thread via GitHub
gaurav-narula commented on PR #15527: URL: https://github.com/apache/kafka/pull/15527#issuecomment-2045336022 @gharris1727 I've addressed the feedback. Please have a look when you get some time. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
cadonna commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2045332239 I restarted the build since the Java 11 build crashed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-16487: Support to define server properties by ClusterTestDefaults [kafka]

2024-04-09 Thread via GitHub
FrankYang0529 commented on code in PR #15687: URL: https://github.com/apache/kafka/pull/15687#discussion_r1557742879 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -89,20 +91,24 @@ public void testClusterTemplate() { }), @ClusterTest(nam

Re: [PR] KAFKA-16487: Support to define server properties by ClusterTestDefaults [kafka]

2024-04-09 Thread via GitHub
FrankYang0529 commented on code in PR #15687: URL: https://github.com/apache/kafka/pull/15687#discussion_r1557742410 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -190,6 +190,9 @@ private void processClusterTest(ExtensionContext context, ClusterTest a

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-09 Thread via GitHub
kirktrue commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1557728693 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1750,8 @@ private void subscribeInternal(Pattern pattern,

Re: [PR] KAFKA-16487: Support to define server properties by ClusterTestDefaults [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15687: URL: https://github.com/apache/kafka/pull/15687#discussion_r1557608588 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -89,20 +91,24 @@ public void testClusterTemplate() { }), @ClusterTest(name = "

Re: [PR] KAFKA-16487: Support to define server properties by ClusterTestDefaults [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15687: URL: https://github.com/apache/kafka/pull/15687#discussion_r1557600867 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -190,6 +190,9 @@ private void processClusterTest(ExtensionContext context, ClusterTest annot,

Re: [PR] KAFKA-16487: Support to define server properties by ClusterTestDefaults [kafka]

2024-04-09 Thread via GitHub
FrankYang0529 commented on code in PR #15687: URL: https://github.com/apache/kafka/pull/15687#discussion_r1557588875 ## core/src/test/java/kafka/test/annotation/ClusterTestDefaults.java: ## @@ -39,4 +39,5 @@ int brokers() default 1; int controllers() default 1; bo

Re: [PR] KAFKA-16487: Support to define server properties by ClusterTestDefaults [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15687: URL: https://github.com/apache/kafka/pull/15687#discussion_r1557576225 ## core/src/test/java/kafka/test/annotation/ClusterTestDefaults.java: ## @@ -39,4 +39,5 @@ int brokers() default 1; int controllers() default 1; boolean

Re: [PR] KAFKA-16297: Race condition while promoting future replica [kafka]

2024-04-09 Thread via GitHub
soarez commented on code in PR #15557: URL: https://github.com/apache/kafka/pull/15557#discussion_r1557584496 ## core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala: ## @@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String, } override def removePa

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15676: URL: https://github.com/apache/kafka/pull/15676#issuecomment-2045116605 @KevinZTW Could you take a look at #15687? It offers a graceful way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-04-09 Thread via GitHub
clolov commented on PR #15673: URL: https://github.com/apache/kafka/pull/15673#issuecomment-2045111918 Hello @junrao! Yes, I had missed updating some of the tests - I believe the majority of them should now be fixed, but I will circle back once the latest build passes to check again -- T

Re: [PR] MINOR: Add type check to classic group timeout operations [kafka]

2024-04-09 Thread via GitHub
dajac commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1557570573 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2415,6 +2415,22 @@ private CoordinatorResult classicGroupJoinExis

Re: [PR] MINOR: Add type check to classic group timeout operations [kafka]

2024-04-09 Thread via GitHub
dajac commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1557570573 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2415,6 +2415,22 @@ private CoordinatorResult classicGroupJoinExis

Re: [PR] KAFKA-16294: Add group protocol migration enabling config [kafka]

2024-04-09 Thread via GitHub
dajac commented on code in PR #15411: URL: https://github.com/apache/kafka/pull/15411#discussion_r1557562821 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1046,6 +1054,7 @@ object KafkaConfig { .define(ConsumerGroupMaxHeartbeatIntervalMsProp, INT, Default

[PR] KAFKA-16487: Support to define server properties by ClusterTestDefaults [kafka]

2024-04-09 Thread via GitHub
FrankYang0529 opened a new pull request, #15687: URL: https://github.com/apache/kafka/pull/15687 Sometimes we want to define server properties for all test cases, and using `BeforeEach` to modify the `ClusterConfig` is the only way. The side effect is that the IDE does not like the style si

Re: [PR] MINOR : Replaced the while loop with TestUtils.waitForCondition [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15678: URL: https://github.com/apache/kafka/pull/15678#issuecomment-2045082221 @chiacyu Could you take a look at my comments? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-16483: migrate DeleteOffsetsConsumerGroupCommandIntegrationTest to use ClusterTestExtensions [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15679: URL: https://github.com/apache/kafka/pull/15679#discussion_r1557557116 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -213,4 +234,8 @@ private Consumer createConsu

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1557539944 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,30 +19,30 @@ package kafka.coordinator.transaction impo

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-09 Thread via GitHub
clolov commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1557539618 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -293,17 +288,12 @@ public void cleanup() throws IOException {

Re: [PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15686: URL: https://github.com/apache/kafka/pull/15686#issuecomment-2045021546 It seems `skippedIdempotentUpdatesSensor` (https://github.com/apache/kafka/blob/f895ab5145077c5efa10a4a898628d901b01e2c2/streams/src/main/java/org/apache/kafka/streams/processor/internals

Re: [PR] KAFKA-16467: Add README to docs folder [kafka]

2024-04-09 Thread via GitHub
FrankYang0529 commented on PR #15664: URL: https://github.com/apache/kafka/pull/15664#issuecomment-2045007375 > Maybe we could improve in Kafka-site repo (where we put all the generated documents for all versions), and pointed this guide into [here](https://github.com/apache/kafka-site/blob

[jira] [Commented] (KAFKA-16467) Add README to docs folder

2024-04-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835368#comment-17835368 ] ASF GitHub Bot commented on KAFKA-16467: FrankYang0529 opened a new pull request

Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

2024-04-09 Thread via GitHub
jlprat commented on PR #15553: URL: https://github.com/apache/kafka/pull/15553#issuecomment-2044991965 Closing this one, in favour of whatever comes out of https://issues.apache.org/jira/browse/KAFKA-16490 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

2024-04-09 Thread via GitHub
jlprat closed pull request #15553: MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] URL: https://github.com/apache/kafka/pull/15553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-16485: Broker metrics to follow kebab/hyphen case (KIP-714) [kafka]

2024-04-09 Thread via GitHub
apoorvmittal10 commented on PR #15680: URL: https://github.com/apache/kafka/pull/15680#issuecomment-2044990458 > @apoorvmittal10 : Thanks for the PR. The code looks good to me. Have all the test failures been tracked? @junrao I have checked and triaged the ones which were not tracked.

[jira] [Created] (KAFKA-16492) Flaky test: testAlterSinkConnectorOffsetsDifferentKafkaClusterTargeted – org.apache.kafka.connect.integration.OffsetsApiIntegrationTest

2024-04-09 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16492: - Summary: Flaky test: testAlterSinkConnectorOffsetsDifferentKafkaClusterTargeted – org.apache.kafka.connect.integration.OffsetsApiIntegrationTest Key: KAFKA-16492 URL: https://i

[jira] [Created] (KAFKA-16491) Flaky test: randomClusterPerturbationsShouldConverge[rackAwareStrategy=balance_subtopology] – org.apache.kafka.streams.processor.internals.assignment.TaskAssignorConverg

2024-04-09 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16491: - Summary: Flaky test: randomClusterPerturbationsShouldConverge[rackAwareStrategy=balance_subtopology] – org.apache.kafka.streams.processor.internals.assignment.TaskAssignorConvergenceTest Key:

[jira] [Assigned] (KAFKA-16490) Upgrade gradle from 8.6 to 8.7

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16490: -- Assignee: Chia Chuan Yu (was: Chia-Ping Tsai) > Upgrade gradle from 8.6 to 8.7 > ---

[jira] [Commented] (KAFKA-16490) Upgrade gradle from 8.6 to 8.7

2024-04-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835361#comment-17835361 ] Chia-Ping Tsai commented on KAFKA-16490: [~chiacyu]sure and thanks for you to ta

[jira] [Commented] (KAFKA-16490) Upgrade gradle from 8.6 to 8.7

2024-04-09 Thread Chia Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835357#comment-17835357 ] Chia Chuan Yu commented on KAFKA-16490: --- Hi,I want to take this one, please assign

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15656: URL: https://github.com/apache/kafka/pull/15656#issuecomment-2044920363 @OmniaGM Could you fix the build error? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   >