[PR] Adding Apache Kafka Docker Official Images Directory [kafka]

2024-04-11 Thread via GitHub
KrishVora01 opened a new pull request, #15703: URL: https://github.com/apache/kafka/pull/15703 Adding Apache Kafka Docker Official Images Directory , under docker/docker_official_images, to keep Docker Official Image assets. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16452: Bound high-watermark offset to range between LLSO and LEO [kafka]

2024-04-11 Thread via GitHub
kamalcph commented on PR #15634: URL: https://github.com/apache/kafka/pull/15634#issuecomment-2050934793 @junrao @showuon @divijvaidya Gentle bump to review the diff, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16073: Increment the local-log-start-offset before deleting segments in memory table [kafka]

2024-04-11 Thread via GitHub
kamalcph commented on PR #15631: URL: https://github.com/apache/kafka/pull/15631#issuecomment-2050932821 @junrao Please take another look, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] debug for #15489 [kafka]

2024-04-11 Thread via GitHub
chia7712 closed pull request #15654: debug for #15489 URL: https://github.com/apache/kafka/pull/15654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15945 : Flaky test - testSyncTopicConfigs() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest [kafka]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #14893: URL: https://github.com/apache/kafka/pull/14893#issuecomment-2050904251 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR: Update docs link to deprecated method TimeWindows.grace [kafka]

2024-04-11 Thread via GitHub
chia7712 commented on PR #15700: URL: https://github.com/apache/kafka/pull/15700#issuecomment-2050891467 @AyoubOm thanks for this contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: Update docs link to deprecated method TimeWindows.grace [kafka]

2024-04-11 Thread via GitHub
chia7712 merged PR #15700: URL: https://github.com/apache/kafka/pull/15700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-11 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1561902955 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1388,6 +1393,33 @@ public void commitSync(Map offsets, Duration

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-11 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1561901442 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -616,6 +620,90 @@ public void

Re: [PR] KAFKA-15046: Get rid of unnecessary fsyncs inside UnifiedLog.lock to stabilize performance [kafka]

2024-04-11 Thread via GitHub
ocadaruma commented on code in PR #14242: URL: https://github.com/apache/kafka/pull/14242#discussion_r1561896446 ## server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java: ## @@ -72,18 +72,20 @@ public CheckpointFile(File file, tempPath =

[jira] [Created] (KAFKA-16541) Potential leader epoch checkpoint file corruption on OS crash

2024-04-11 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-16541: Summary: Potential leader epoch checkpoint file corruption on OS crash Key: KAFKA-16541 URL: https://issues.apache.org/jira/browse/KAFKA-16541 Project: Kafka

[PR] Kafka-16540: Update partitions if min isr config is changed. [kafka]

2024-04-11 Thread via GitHub
CalvinConfluent opened a new pull request, #15702: URL: https://github.com/apache/kafka/pull/15702 https://issues.apache.org/jira/browse/KAFKA-16540 If the min isr config is changed, we need to update the partitions with ELR if possible. -- This is an automated message from the Apache

[jira] [Created] (KAFKA-16540) Update partitions when the min isr config is updated.

2024-04-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-16540: -- Summary: Update partitions when the min isr config is updated. Key: KAFKA-16540 URL: https://issues.apache.org/jira/browse/KAFKA-16540 Project: Kafka Issue

[jira] [Resolved] (KAFKA-15586) Clean shutdown detection, server side

2024-04-11 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15586. Resolution: Fixed > Clean shutdown detection, server side > -

Re: [PR] MINOR: remove redundant argument in log [kafka]

2024-04-11 Thread via GitHub
showuon merged PR #15699: URL: https://github.com/apache/kafka/pull/15699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: remove redundant argument in log [kafka]

2024-04-11 Thread via GitHub
showuon commented on PR #15699: URL: https://github.com/apache/kafka/pull/15699#issuecomment-2050767360 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-11 Thread via GitHub
kirktrue commented on PR #15640: URL: https://github.com/apache/kafka/pull/15640#issuecomment-2050761892 @cadonna @lianetm @lucasbru @philipnee—please review this PR if you have some spare time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KIP-848 system tests 2024-04-08 [kafka]

2024-04-11 Thread via GitHub
kirktrue closed pull request #15683: KIP-848 system tests 2024-04-08 URL: https://github.com/apache/kafka/pull/15683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (KAFKA-16539) Can't update specific broker configs in pre-migration mode

2024-04-11 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16539: - Description: In migration mode, ZK brokers will have a forwarding manager configured. This is

[jira] [Updated] (KAFKA-16539) Can't update specific broker configs in pre-migration mode

2024-04-11 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16539: - Description: In migration mode, ZK brokers will have a forwarding manager configured. This is

[jira] [Updated] (KAFKA-16539) Can't update specific broker configs in pre-migration mode

2024-04-11 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16539: - Description: In migration mode, ZK brokers will have a forwarding manager configured. This is

[jira] [Updated] (KAFKA-16539) Can't update specific broker configs in pre-migration mode

2024-04-11 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16539: - Description: In migration mode, ZK brokers will have a forwarding manager configured. This is

[jira] [Created] (KAFKA-16539) Can't update specific broker configs in pre-migration mode

2024-04-11 Thread David Arthur (Jira)
David Arthur created KAFKA-16539: Summary: Can't update specific broker configs in pre-migration mode Key: KAFKA-16539 URL: https://issues.apache.org/jira/browse/KAFKA-16539 Project: Kafka

Re: [PR] MINOR: Update docs link to deprecated method TimeWindows.grace [kafka]

2024-04-11 Thread via GitHub
AyoubOm commented on PR #15700: URL: https://github.com/apache/kafka/pull/15700#issuecomment-2050541433 > @AyoubOm thanks for this contribution. Could you fix

[jira] [Created] (KAFKA-16538) UpdateFeatures for kraft.version

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16538: -- Summary: UpdateFeatures for kraft.version Key: KAFKA-16538 URL: https://issues.apache.org/jira/browse/KAFKA-16538 Project: Kafka

[jira] [Created] (KAFKA-16537) RemoveVoter RPC and request handling

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16537: -- Summary: RemoveVoter RPC and request handling Key: KAFKA-16537 URL: https://issues.apache.org/jira/browse/KAFKA-16537 Project: Kafka

[jira] [Created] (KAFKA-16536) Use BeginQuorumEpoch as the leader's heartbeat

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16536: -- Summary: Use BeginQuorumEpoch as the leader's heartbeat Key: KAFKA-16536 URL: https://issues.apache.org/jira/browse/KAFKA-16536 Project:

[jira] [Created] (KAFKA-16535) AddVoter RPC and request handling

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16535: -- Summary: AddVoter RPC and request handling Key: KAFKA-16535 URL: https://issues.apache.org/jira/browse/KAFKA-16535 Project: Kafka

[jira] [Created] (KAFKA-16534) Sending UpdateVoter request and response handling

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16534: -- Summary: Sending UpdateVoter request and response handling Key: KAFKA-16534 URL: https://issues.apache.org/jira/browse/KAFKA-16534

[jira] [Created] (KAFKA-16533) UpdateVoter RPC and request handling

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16533: -- Summary: UpdateVoter RPC and request handling Key: KAFKA-16533 URL: https://issues.apache.org/jira/browse/KAFKA-16533 Project: Kafka

[jira] [Created] (KAFKA-16532) Support for first leader bootstrapping the voter set

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16532: -- Summary: Support for first leader bootstrapping the voter set Key: KAFKA-16532 URL: https://issues.apache.org/jira/browse/KAFKA-16532

[jira] [Comment Edited] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836339#comment-17836339 ] Francois Visconte edited comment on KAFKA-16511 at 4/11/24 7:56 PM:

[jira] [Comment Edited] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836339#comment-17836339 ] Francois Visconte edited comment on KAFKA-16511 at 4/11/24 7:54 PM:

[jira] [Comment Edited] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836339#comment-17836339 ] Francois Visconte edited comment on KAFKA-16511 at 4/11/24 7:54 PM:

[jira] [Commented] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836339#comment-17836339 ] Francois Visconte commented on KAFKA-16511: --- summarising here the investigation we did with

[jira] [Created] (KAFKA-16531) Fix check-quorum calculation to no assume that the leader is in the voter set

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16531: -- Summary: Fix check-quorum calculation to no assume that the leader is in the voter set Key: KAFKA-16531 URL:

[jira] [Created] (KAFKA-16530) Fix high-watermark calculation to no assume the leader is in the voter set

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16530: -- Summary: Fix high-watermark calculation to no assume the leader is in the voter set Key: KAFKA-16530 URL:

[jira] [Created] (KAFKA-16529) Response handling and request sending for voters RPCs

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16529: -- Summary: Response handling and request sending for voters RPCs Key: KAFKA-16529 URL: https://issues.apache.org/jira/browse/KAFKA-16529

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-11 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2050401151 Hey @cadonna , could you take a look at this small fix when you have a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-16528) Reset member heartbeat interval when request sent

2024-04-11 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16528: -- Summary: Reset member heartbeat interval when request sent Key: KAFKA-16528 URL: https://issues.apache.org/jira/browse/KAFKA-16528 Project: Kafka Issue

[jira] [Created] (KAFKA-16527) RPC changes and request handling

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16527: -- Summary: RPC changes and request handling Key: KAFKA-16527 URL: https://issues.apache.org/jira/browse/KAFKA-16527 Project: Kafka

Re: [PR] MINOR: Update docs link to deprecated method TimeWindows.grace [kafka]

2024-04-11 Thread via GitHub
chia7712 commented on PR #15700: URL: https://github.com/apache/kafka/pull/15700#issuecomment-2050245588 @AyoubOm thanks for this contribution. Could you fix

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-11 Thread via GitHub
fred-ro commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1561429541 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -16,29 +16,38 @@ */ package org.apache.kafka.common.errors;

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-11 Thread via GitHub
fred-ro commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1561426507 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -16,29 +16,38 @@ */ package org.apache.kafka.common.errors;

[jira] [Created] (KAFKA-16526) Change to quorum state for KIP-853

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16526: -- Summary: Change to quorum state for KIP-853 Key: KAFKA-16526 URL: https://issues.apache.org/jira/browse/KAFKA-16526 Project: Kafka

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-11 Thread via GitHub
fred-ro commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1561425249 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -16,29 +16,38 @@ */ package org.apache.kafka.common.errors;

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-04-11 Thread via GitHub
chia7712 commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2050238482 There are build error. please fix it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

2024-04-11 Thread via GitHub
chia7712 commented on code in PR #15575: URL: https://github.com/apache/kafka/pull/15575#discussion_r1561383606 ## server/src/main/java/org/apache/kafka/server/config/ReplicationConfigs.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-11 Thread via GitHub
ilyazr opened a new pull request, #15701: URL: https://github.com/apache/kafka/pull/15701 EventHandlerExceptionInfo#failureMessage() didn't include a message of the propagated exception. But it would be helpful to have them for non-fault exceptions. This PR adds it, so it can be helpful to

Re: [PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-11 Thread via GitHub
ilyazr commented on PR #15701: URL: https://github.com/apache/kafka/pull/15701#issuecomment-2050226155 @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-16473: Use correct cluster ID when formatting log dir. [kafka]

2024-04-11 Thread via GitHub
VedarthConfluent commented on PR #15658: URL: https://github.com/apache/kafka/pull/15658#issuecomment-2050213120 Looks good to me! Thanks for the fix  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (KAFKA-16525) Request manager and raft channel discover node endpoints

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16525: -- Summary: Request manager and raft channel discover node endpoints Key: KAFKA-16525 URL: https://issues.apache.org/jira/browse/KAFKA-16525

Re: [PR] KAFKA-12317: fix documentation [kafka]

2024-04-11 Thread via GitHub
AyoubOm commented on code in PR #15689: URL: https://github.com/apache/kafka/pull/15689#discussion_r1561381861 ## docs/streams/developer-guide/dsl-api.html: ## @@ -1952,11 +1947,6 @@ The join will be triggered under the conditions listed below whenever new input is received.

[jira] [Commented] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836289#comment-17836289 ] Kamal Chandraprakash commented on KAFKA-16511: -- Can you also paste the contents of

[jira] [Created] (KAFKA-16524) Metrics for KIP-853

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16524: -- Summary: Metrics for KIP-853 Key: KAFKA-16524 URL: https://issues.apache.org/jira/browse/KAFKA-16524 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-16207) KRaft internal listener for KRaftVersionRecord and VotersRecord

2024-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16207: --- Summary: KRaft internal listener for KRaftVersionRecord and

[jira] [Created] (KAFKA-16523) kafka-metadata-quorum add voter and remove voter changes

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16523: -- Summary: kafka-metadata-quorum add voter and remove voter changes Key: KAFKA-16523 URL: https://issues.apache.org/jira/browse/KAFKA-16523

[jira] [Updated] (KAFKA-16521) kafka-metadata-quorum describe changes for KIP-853

2024-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16521: --- Summary: kafka-metadata-quorum describe changes for KIP-853 (was:

[jira] [Updated] (KAFKA-16522) Admin client changes for adding and removing voters

2024-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16522: --- Summary: Admin client changes for adding and removing voters (was:

[jira] [Updated] (KAFKA-16518) Storage tool changes for KIP-853

2024-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16518: --- Summary: Storage tool changes for KIP-853 (was: Implement storage

[jira] [Updated] (KAFKA-16520) Changes to DescribeQuorum response

2024-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16520: --- Summary: Changes to DescribeQuorum response (was: Implement changes

[jira] [Created] (KAFKA-16522) Implement Admin client changes for adding and removing votes

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16522: -- Summary: Implement Admin client changes for adding and removing votes Key: KAFKA-16522 URL: https://issues.apache.org/jira/browse/KAFKA-16522

[jira] [Created] (KAFKA-16521) Implement kafka-metadata-quorum describe changes for KIP-853

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16521: -- Summary: Implement kafka-metadata-quorum describe changes for KIP-853 Key: KAFKA-16521 URL: https://issues.apache.org/jira/browse/KAFKA-16521

[jira] [Created] (KAFKA-16520) Implement changes to DescribeQuorum response

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16520: -- Summary: Implement changes to DescribeQuorum response Key: KAFKA-16520 URL: https://issues.apache.org/jira/browse/KAFKA-16520 Project:

[jira] [Comment Edited] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836286#comment-17836286 ] Francois Visconte edited comment on KAFKA-16511 at 4/11/24 5:26 PM:

[jira] [Created] (KAFKA-16519) Expose the supported and finalized kraft.version in ApiVersions response

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16519: -- Summary: Expose the supported and finalized kraft.version in ApiVersions response Key: KAFKA-16519 URL:

[jira] [Comment Edited] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836286#comment-17836286 ] Francois Visconte edited comment on KAFKA-16511 at 4/11/24 5:25 PM:

Re: [PR] KAFKA-16211: Inconsistent config values in CreateTopicsResult and DescribeConfigsResult [kafka]

2024-04-11 Thread via GitHub
infantlikesprogramming commented on PR #15696: URL: https://github.com/apache/kafka/pull/15696#issuecomment-2050163816 @chia7712 Thank you for reviewing my PR. I have updated the branch. Considering describeTopics(), should we note that it should only be used with the resource of type

[jira] [Comment Edited] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836286#comment-17836286 ] Francois Visconte edited comment on KAFKA-16511 at 4/11/24 5:24 PM:

[jira] [Created] (KAFKA-16518) Implement storage tool changes for KIP-853

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16518: -- Summary: Implement storage tool changes for KIP-853 Key: KAFKA-16518 URL: https://issues.apache.org/jira/browse/KAFKA-16518 Project: Kafka

[jira] [Commented] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836286#comment-17836286 ] Francois Visconte commented on KAFKA-16511: --- here is what I have on the leader of partition

[jira] [Created] (KAFKA-16517) Do not decode metadata records in the internal kraft partition listener

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16517: -- Summary: Do not decode metadata records in the internal kraft partition listener Key: KAFKA-16517 URL:

[jira] [Updated] (KAFKA-16207) Implement KRaft internal listener for KRaftVersionRecord and VotersRecord

2024-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16207: --- Fix Version/s: 3.8.0 > Implement KRaft internal listener for

[jira] [Created] (KAFKA-16516) Fix the controller node provider for broker to control channel

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16516: -- Summary: Fix the controller node provider for broker to control channel Key: KAFKA-16516 URL: https://issues.apache.org/jira/browse/KAFKA-16516

[jira] [Updated] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-11 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sal Sorrentino updated KAFKA-16514: --- Affects Version/s: 3.7.0 > Kafka Streams: stream.close(CloseOptions) does not respect

[jira] [Updated] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-11 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sal Sorrentino updated KAFKA-16514: --- Description: Working with Kafka Streams 3.7.0, but may affect earlier versions as well.

[jira] [Created] (KAFKA-16515) Fix the ZK Metadata cache use of voter static configuration

2024-04-11 Thread Jira
José Armando García Sancio created KAFKA-16515: -- Summary: Fix the ZK Metadata cache use of voter static configuration Key: KAFKA-16515 URL: https://issues.apache.org/jira/browse/KAFKA-16515

[jira] [Updated] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-11 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sal Sorrentino updated KAFKA-16514: --- Description: Working with Kafka Streams 3.7.0, but may affect earlier versions as well.  

Re: [PR] KAFKA-15853: Move KafkaConfig log properties and docs out of core [kafka]

2024-04-11 Thread via GitHub
OmniaGM commented on PR #15569: URL: https://github.com/apache/kafka/pull/15569#issuecomment-2050114827 > maybe we should move the constants out of `LogConfig` We can try to do this in a follow up after we merge all PRs for KafkaConfig as am worried about potential circular

[jira] [Commented] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836277#comment-17836277 ] Kamal Chandraprakash commented on KAFKA-16511: -- [~fvisconte] > We can see that despite the

[jira] [Updated] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-11 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sal Sorrentino updated KAFKA-16514: --- Priority: Minor (was: Major) > Kafka Streams: stream.close(CloseOptions) does not respect

[jira] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511 ] Kamal Chandraprakash deleted comment on KAFKA-16511: -- was (Author: ckamal): [~fvisconte]  >From logs, the issue is on partition-765 and segment >`02971163.log` . There

[jira] [Commented] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836276#comment-17836276 ] Kamal Chandraprakash commented on KAFKA-16511: -- [~fvisconte]  >From logs, the issue is on

[jira] [Updated] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-11 Thread Sal Sorrentino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sal Sorrentino updated KAFKA-16514: --- Description: Working with Kafka Streams 3.7.0, but may affect earlier versions as well.  

[jira] [Created] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-11 Thread Sal Sorrentino (Jira)
Sal Sorrentino created KAFKA-16514: -- Summary: Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag. Key: KAFKA-16514 URL: https://issues.apache.org/jira/browse/KAFKA-16514

Re: [PR] KAFKA-16509: CurrentControllerId metric is unreliable in ZK mode [kafka]

2024-04-11 Thread via GitHub
cmccabe commented on PR #15695: URL: https://github.com/apache/kafka/pull/15695#issuecomment-2050092535 > Should we replace all metadataCache.getControllerId by getCurrentControllerIdFromOldController if the former is unstable? The metadata cache is supposed to be used for returning

Re: [PR] KAFKA-16509: CurrentControllerId metric is unreliable in ZK mode [kafka]

2024-04-11 Thread via GitHub
cmccabe merged PR #15695: URL: https://github.com/apache/kafka/pull/15695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-16511) Leaking tiered segments

2024-04-11 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francois Visconte updated KAFKA-16511: -- Description: I have some topics there were not written since a few days (having 12h

Re: [PR] KAFKA-16280: Expose method to determine metric measurability (KIP-1019) [kafka]

2024-04-11 Thread via GitHub
apoorvmittal10 commented on PR #15681: URL: https://github.com/apache/kafka/pull/15681#issuecomment-2050055971 > LGTM -- retriggered Jenkins (failure seems unrelated, but want to sanify check) -- Can merge afterwards. Thanks @mjsax. I can see unrelated tests failures as well and

[PR] MINOR: Update docs link to deprecated method TimeWindows.grace [kafka]

2024-04-11 Thread via GitHub
AyoubOm opened a new pull request, #15700: URL: https://github.com/apache/kafka/pull/15700 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-11 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1561280844 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -902,40 +824,40 @@ object KafkaConfig { .define(ControlledShutdownEnableProp, BOOLEAN,

Re: [PR] KAFKA-15853: Move KafkaConfig Replication properties and docs out of … [kafka]

2024-04-11 Thread via GitHub
OmniaGM commented on PR #15575: URL: https://github.com/apache/kafka/pull/15575#issuecomment-2050037844 Hi @AndrewJSchofield, and @nizhikov Similar to other KafkaConfig PRs, I renamed this to `ReplicationConfigs` to follow the same pattern we adopted in

Re: [PR] KAFKA-16463 Delete metadata log on ZK broker startup [kafka]

2024-04-11 Thread via GitHub
mumrah commented on PR #15648: URL: https://github.com/apache/kafka/pull/15648#issuecomment-2050028734 Thanks for taking a look @chia7712. I've updated the PR with your suggestions and added a few more test cases. cc @soarez and @jsancio in case you'd like to take another pass --

Re: [PR] MINOR: Document JBOD limitation during migration [kafka]

2024-04-11 Thread via GitHub
chia7712 commented on code in PR #15692: URL: https://github.com/apache/kafka/pull/15692#discussion_r1561262953 ## docs/ops.html: ## @@ -3823,6 +3823,7 @@ Limitations version (also known as the inter.broker.protocol.version.) Please do not attempt to do this during

[jira] [Resolved] (KAFKA-16431) Handle log dir failure in hybrid mode

2024-04-11 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16431. Fix Version/s: (was: 3.7.1) Resolution: Duplicate > Handle log dir failure in

Re: [PR] MINOR: Document JBOD limitation during migration [kafka]

2024-04-11 Thread via GitHub
soarez commented on code in PR #15692: URL: https://github.com/apache/kafka/pull/15692#discussion_r1561246886 ## docs/ops.html: ## @@ -3823,6 +3823,7 @@ Limitations version (also known as the inter.broker.protocol.version.) Please do not attempt to do this during

Re: [PR] KAFKA-15853: Move transactions configs out of core [kafka]

2024-04-11 Thread via GitHub
chia7712 commented on PR #15670: URL: https://github.com/apache/kafka/pull/15670#issuecomment-2049994583 `JDK 8 and Scala 2.12` is stopped exceptionally. could you please trigger QA again? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] MINOR: remove redundant argument in log [kafka]

2024-04-11 Thread via GitHub
brandboat opened a new pull request, #15699: URL: https://github.com/apache/kafka/pull/15699 as title ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

[jira] [Created] (KAFKA-16513) Allow WriteTxnMarkers API with Alter Cluster Permission

2024-04-11 Thread Nikhil Ramakrishnan (Jira)
Nikhil Ramakrishnan created KAFKA-16513: --- Summary: Allow WriteTxnMarkers API with Alter Cluster Permission Key: KAFKA-16513 URL: https://issues.apache.org/jira/browse/KAFKA-16513 Project: Kafka

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-11 Thread via GitHub
lianetm commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1561212534 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -984,6 +984,8 @@ public void close(final Timer timer) {

  1   2   >